From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 703F2C47258 for ; Sun, 21 Jan 2024 00:16:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52C426B0072; Sat, 20 Jan 2024 19:16:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DC806B0074; Sat, 20 Jan 2024 19:16:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B9066B0075; Sat, 20 Jan 2024 19:16:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 268176B0072 for ; Sat, 20 Jan 2024 19:16:54 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 9B7FBA0570 for ; Sun, 21 Jan 2024 00:16:53 +0000 (UTC) X-FDA: 81701402706.17.862D244 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by imf08.hostedemail.com (Postfix) with ESMTP id D93DA16000E for ; Sun, 21 Jan 2024 00:16:51 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=DjsVycBd; spf=pass (imf08.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.46 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1705796211; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VGx1uUqBJNwaB067t1zS9OZh+thLjfiev6N5olOliBQ=; b=7xgJ4okN3HfNqdobw/x0ge3UUaOQq03gnpy+KyT/nhuBWmhAyzwVWyPQ+TYT9fcjnsOMl1 VcssMNH46uD0eB/JK9l14SV437UiiQzx4prpGcFC9y0aV0RWWIG0S7FuMrZIp7/Fnkxtho XjSwpeez7p5LpTqWCi3QEiIz642SLKU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1705796211; a=rsa-sha256; cv=none; b=GZ7tfcKLbke/oe3/rnByqSo2g9Y/3VPBkO+87ECQD/moysETcIREkBkj7FJYMS7uWIMnPm rculJL46ai1yPOBoFis+c8Nm5ywdhRcMiIkL5i1ZMBogylLmeuIUDP2jxzHygjcFGnvSkD TyvOFwcM79p/DW0Vn2rSruJ1wPYl1h8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=DjsVycBd; spf=pass (imf08.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.46 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-595ac2b6c59so1356260eaf.2 for ; Sat, 20 Jan 2024 16:16:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1705796211; x=1706401011; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=VGx1uUqBJNwaB067t1zS9OZh+thLjfiev6N5olOliBQ=; b=DjsVycBdEXIqRVG4WDw+6kh8SBDuo55VEPVMuDBsx4cUmSQiPd8vTLuWcsOTRt+KEN 2gDir0U42h00wmPwsgTM+B58xN8ycDfHg9FFUrAuyGRk41nutmUCIqdGoSUrbuEV8GEy lf5Zak7osPtXAbrfozj/voB47PRV3Z1EZWjRU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1705796211; x=1706401011; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VGx1uUqBJNwaB067t1zS9OZh+thLjfiev6N5olOliBQ=; b=E8Bn7rfCKqDPDrTpPsbKQPDp3eBkRiuoRjQuaRNHD7L2ae1mTrTegcLvk1RbQ8Fe49 6ep2MFnFw42wcTMdzorOwFYxbIqIaC3RQIQNt2oqT2ep5HSo+h+zH8GtcfxTiBUYtimd VOgohUUhhGklZ2012aqwmOffLnM7hmPs+PpjnUoKYg65rAKqTtRanBtId8U2GrUDl3Zc VMVGpNJw15WltT2pVcD006jFNNL+GN4fqBtSoeTSScGVlTinL16ysWH9JId9UR92Q+s0 N3K7CXaNAL1dTxQTnzBxMVNsgsCREy2snQwx6iPcFioLypgCBs08ApfvdFBLvokHA/CX jf5A== X-Gm-Message-State: AOJu0Yx3wQAzfCndG69smW+qrcym8Ke0TvmbHKikCgk4jnA2R8DFBxlJ OX7i8nTD9wfsqKlwsv9tpJOuZwf2cnZ+F1CBOInoCAgABtUpQ74oLo49oo9U1c8C7FqQcN+Ibzo yaTv7XBvrr+4S/p4MpvMl9H/2I/AdiC+WBKeJ X-Google-Smtp-Source: AGHT+IFwp+DKXCAKoixsZuns+yTYxxlyPCYBxSpYdd1fXnL6rdiY+k7qeKJU05Nn//cgId/cR/5b/LaiwJxnDuIsufc= X-Received: by 2002:a05:6870:2e06:b0:210:8df6:3b04 with SMTP id oi6-20020a0568702e0600b002108df63b04mr2269701oab.102.1705796210854; Sat, 20 Jan 2024 16:16:50 -0800 (PST) MIME-Version: 1.0 References: <20231212231706.2680890-1-jeffxu@chromium.org> <20231212231706.2680890-12-jeffxu@chromium.org> <78111.1705764224@cvs.openbsd.org> In-Reply-To: From: Jeff Xu Date: Sat, 20 Jan 2024 16:16:39 -0800 Message-ID: Subject: Re: [RFC PATCH v3 11/11] mseal:add documentation To: Linus Torvalds Cc: Theo de Raadt , =?UTF-8?Q?Stephen_R=C3=B6ttger?= , Jeff Xu , akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, willy@infradead.org, gregkh@linuxfoundation.org, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: bsxi7aibujx8ocqwn1cf8a9ije95ymt6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D93DA16000E X-Rspam-User: X-HE-Tag: 1705796211-682782 X-HE-Meta: U2FsdGVkX18GWNk5rDySMGQB0CE6swvA/umskH7xJNuvfUistuJtdQiEV6TfW0vGlBImMKMTQuKPE2ArYltamrLBy1DFVGCNIcE685YRS8lE8n067lPD39KU2RkVYYv8BL/Yg0pUazqoNbaGAFkbRQ7rfzgBaZ4mE7ZsnnL7/8ui3mlWt6Kx09hVk0t5D4rz096J1Do+riCPmCaDHteWm58oU3WwGtLJinfl7dwsEOs1E1PF2sVjO/VoOVZwbzHJ4Ls4c78OxUifY61TOv7wb0M6UUAcCsWO5dak7vSQiEnulXOMVY5dB6OEVK7Nzo00joOSb1U7rlg2BhOttKKPXvvdN6Lbt0s1OM5og4xVNAwaTSaVJ92EHayAMK0iHlJd9LyXRd2eWVGaCYeGbcMtg9WOw0Es62uAulBn09pyF0JVIPuGSXhpJfJIAxGl/XoZGxXl/9vXMOHyv2TpGVlxIv61ATuRcuE6Rutzhw9/ylWkCwtPr/u26+TGsy5J+MwUN2DSYehgJFvjF9P34v7WygbRIzU4JJfrFDxWuem9WXH4HrfCAyJjBcyJtiHWJbkTXAITaDA8KmzpucLLQSU0M5MmXMNfkX1NVo5IttoHM+dJQZThoohWeYO0ZxH/DFlOPTF5aoR7CBqY1hpVojWHnbPKeChsfTmWo+m+0XMJH+m6OzN9B+yh39SNwBrwWV89fugzPIB9zzxGoiZXuuH2Lb1R2OcB5/c86qH8toF+iYF5JFLVPrFsJAIopQYUyAqyp7zEpA0mFnSWYLOpT5gYYbuTI5njVWzsuBYtl2CkJkUyFGAQfuZH/Vf3qyWQhW2tpgA+hO5OG86I9wSuWfV2cnw+09gpJu9OPX7IdOYoC4rgYaB4M7Vu4ZZmkUZgPi/Mzan3JQJfgpCG/wVqZj/dHxTbCWNu+gQYJ4jov19T1hODLggN2R2CymtvLx4VODkRxWEGuIgwsp+R4gn3WQV hnuFvNJW XltINxzkVoNyrftK5ZowcCG3SPuyvcmuhf8oDJNdvgnDjV8hNpxmCarQUkj9TFxBMFGiO65Mujsrw76uiyJFgAVhS97NSMATs7qCJyt3MDmJkOhFKp8/TCll2mZ+kvtx+GuLuIRr4/XExuhFcOSlCm05zdc9+4dFwYlv5FvuH8S1GG0FBBBPR1GQp1yU4t17sNCA+JRQ1sEMMkjCO6l3FviW8J4xIzMfb77FzovNcKJMflouU9w0nQS1acxzXtQbofgawYTdlqOE0Vy+zOmTHuxd1l8fdj7VqbwOnLVUeHXA6i9Aq9J6otVOEj7m2FFe1rw7j0JDEtFb0MOFUNeg08YWN0eD2jrCsXj+Y+NpUb7c98dSnsOxw6hKxBRDxy6syc1Mcw0h8Z4dDKKcK622HUKz/wRHblFaLn9sI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Jan 20, 2024 at 8:40=E2=80=AFAM Linus Torvalds wrote: > > On Sat, 20 Jan 2024 at 07:23, Theo de Raadt wrote: > > > > There is an one large difference remainig between mimmutable() and msea= l(), > > which is how other system calls behave. > > > > We return EPERM for failures in all the system calls that fail upon > > immutable memory (since Oct 2022). > > > > You are returning EACESS. > > > > Before it is too late, do you want to reconsider that return value, or > > do you have a justification for the choice? > > I don't think there's any real reason for the difference. > > Jeff - mind changing the EACESS to EPERM, and we'll have something > that is more-or-less compatible between Linux and OpenBSD? > Sounds Good. I will make the necessary changes in the next version. -Jeff > Linus