From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C330FC4707C for ; Thu, 11 Jan 2024 02:59:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E8F56B0098; Wed, 10 Jan 2024 21:59:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 398AB6B0099; Wed, 10 Jan 2024 21:59:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25F8C6B009A; Wed, 10 Jan 2024 21:59:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 1A2E56B0098 for ; Wed, 10 Jan 2024 21:59:04 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DF1FC1405D9 for ; Thu, 11 Jan 2024 02:59:03 +0000 (UTC) X-FDA: 81665523366.23.7931C66 Received: from mail-oa1-f50.google.com (mail-oa1-f50.google.com [209.85.160.50]) by imf08.hostedemail.com (Postfix) with ESMTP id E899916000E for ; Thu, 11 Jan 2024 02:59:00 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Mb8jMhii; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.50 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1704941941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=iusV3IyQOZs3xOP+4u/FoLP2ed3pvxpbfjuW8JoG9bs=; b=5Cv4wD95wBVMmKF7LKRlbFcoxs6SucOuUGjSv27X36LNbwZMHJ0wNLtJplngFkRPfR/Cpd 3Ppv10g1sQ6sQThfqlj+tDjk9r84AXJC1wVk2lbLcWkKVAFY7058EzBpGAw+5VKyoQyF6Q C/Pml9MGj7Zrk6HP7QtDQFYfrAHlUZc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Mb8jMhii; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.50 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1704941941; a=rsa-sha256; cv=none; b=RWfDUJ3NBAqQtM2VEOLBWnG8Rdzh4keN0XD48bYiqd5YolAdsB9P8YGytbKbhnWZOmmtvU DwIJOlsQsrauQGfZgNihc5g0fVOJgDILu1QDkUu1xyGcrEmCDxBtOc7TeHvTQ6d3E8bG5x pIl2LX7n+u+b6sYeMf60Hy6hTCLHxwI= Received: by mail-oa1-f50.google.com with SMTP id 586e51a60fabf-20503dc09adso3193030fac.2 for ; Wed, 10 Jan 2024 18:59:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1704941940; x=1705546740; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=iusV3IyQOZs3xOP+4u/FoLP2ed3pvxpbfjuW8JoG9bs=; b=Mb8jMhiiaE1uyH9Jxd3ykpIun4/dEXgqZCGjaoK2MwgPjA7x4HiEWySOQwg3sOwuK6 Oez3vlCM4jiX8GdMkJBraCqAyaBxCFB5i/r1F4o2AtUgB5sBb5eV5XJnflUPl5I1o6pg Z4TKt4MfY7XE0I5FPQrrxyQtM65d8cd3IV2xA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704941940; x=1705546740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iusV3IyQOZs3xOP+4u/FoLP2ed3pvxpbfjuW8JoG9bs=; b=j8cx1Jmyq4XK8bFhRqiAdQ/ZZcBDOq07R26SJ7Bz3oD1Ml0MdWWjs6ZuUezfzE+J6I SEyH6mREYu5UmHxyV5XLZSjDQ9fhR/3UdpqRtAiXAA5JlweWeXvajX3gptdhXaGTEMRh Z9Er9Txyg4qRS6IwDSFWRmd0ryp0FpUfxXtb6FdC8jO7nVCd1gLffrWhp9HmjlR7JuLx TH4knoc1qOP/ZuuhzMM/QFYsuwihVMDNFacOV8RBOwJ2ytJktImAYZtE+UNhysx2TmUE hNcCN86XQJZ5aIYUY9j9LiXsJyPFMdjUgY8LGfCn97PgrCMXX1f2Hv6WUbXzNzsYQ8BR 8pSA== X-Gm-Message-State: AOJu0YzElfCX0pOIMuonyRGR0Ojfr9369KXqd2bzm8teHtoAechiZmnF 8lCZ4UIqninFH+51To/hOv1BP6pCt1WQVWaqJ9BoMwbvEOng X-Google-Smtp-Source: AGHT+IEskTSe0nGIcOItqfJ6SepvxiQWh43wQkxn0KPGgUFpEKm7ALUXSUzjdhE2a+LQiKbpeQ6rkBIhe4NhubhRI6U= X-Received: by 2002:a05:6871:4e97:b0:205:e3bd:6920 with SMTP id uk23-20020a0568714e9700b00205e3bd6920mr543948oab.95.1704941939966; Wed, 10 Jan 2024 18:58:59 -0800 (PST) MIME-Version: 1.0 References: <20240109154547.1839886-1-jeffxu@chromium.org> <20240109154547.1839886-3-jeffxu@chromium.org> In-Reply-To: From: Jeff Xu Date: Wed, 10 Jan 2024 18:58:48 -0800 Message-ID: Subject: Re: [RFC PATCH v5 2/4] mseal: add mseal syscall To: Matthew Wilcox Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, sroettger@google.com, gregkh@linuxfoundation.org, torvalds@linux-foundation.org, usama.anjum@collabora.com, jeffxu@google.com, jorgelo@chromium.org, groeck@chromium.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, pedro.falcato@gmail.com, dave.hansen@intel.com, linux-hardening@vger.kernel.org, deraadt@openbsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E899916000E X-Stat-Signature: px65kutphnzqse4hnzgk3aic7udsbtbc X-Rspam-User: X-HE-Tag: 1704941940-160996 X-HE-Meta: U2FsdGVkX1998f0crEBDViilAU0EF4E89NfVNuVMM7zULzTLMt1zqJ1GhK8uLXGKPY9rLn+tDKDn/e/JJtnhsWx2ajsYqrvOECnSuY0fW79OYiLRgUBpqBCFUJ7LWPE1/eTyTThNngWN6j0dUfNWA4sDhxdaLXXEy2x1qpYHkzQDvuxBNhsVchTNoZEMgxW8cqT2fj2aUjhsI5W8q7dmF4HfcKzOrfYRgf7apRIN5oW/y4umidZSHFSsP69QPnaq+ncERpruByMaL8dY18HsJZSeQNF6NkW94a1emXMbbDptl4Ozu8g9HWO1+tkAr0fL4P+H4MTwzrTjCZdIfEs8FFUAapauG9M5ygie4qDyfQ+yd+tjiZAm5PejsY2bHJ5EN/Mq6L3OqKwKDHkhAAd6ryeuXo20aE2y/1cP5wT2Jq4uUUG9MLuKTt7Qw9v+ZpAYd1B+kIM7r6rLeXkvAUX3rFGXPx9QWxDmHEYTJZUQO7LhP2K3Itpe6lTcFVGee1GS+t1HP+41Ol1bg2CgdrCTQmV+deErKTzOVnnLP0c2kwC8FrOJnZn0CnN8+PCzFSI+VBGBW4bDGTjhsD2kbtp0eP2DvCgSUaSEnfc0ae9PxChSHsVhrrAqfvSdYs/Biqovqq+YsqA779RFBW/5auv959GMlP+rMIntQ79CekSfjt5Rt6ajmlra6nayJANWZ8PIEnWw4YfCEb7mlX4Yb5nQLvvX5KwWqpjMSN98ojFjXcPMSICJ0UY2Jka+Zk653Wj6++2GUzPH/rDeUiZbyIocJnKgEPpazdngYskdV4S416oBLos/c7ur5B7G+OYv7iWrtGJ22VypBw64rb9m1kwGaLn5Q28/r6Hg+CRJugrVoebehmFAiCAReoSr8tYfZkzIhUIbx41S5xbfG3mFiqiWmDZACSdFqu/x2H62wy+ABuXCyd+o2cfI0B5Iw42hXN+to+ObERp7DbQipxXVzec X+0LET4m KWdfEcCi9LWdrSTQiDXKvr+TIZ+eqcC/inxjIfYnsNSneD+n0LPMbb6nsDK9HARQggxceyVSbeWhwjrjAOuX5tdKpoI5i7R7EWbS+35hItxh75y9BudIPaXuwVYuNyw8subTN85gQqF4BkQZ+GDnXqUxL4HtNTPfqG8On18/6sSJYfw5cHqG0oc8qKBfISCDXbN+PL3rHZdxua/v+6uogHecwmRSTapTf6MwUiMaPaf0fAKO0+XY5jFq8YrxscB82o5mnEZMU7TY6Jsk9z/1zQVjih3ICJOzTyIIULfys6sflk1D1+E1Pe7qLyMmbLkPovTM3dgyTMCObg5vXlPlp09o7WjDbstsZIN8FWiLjd9OUdX/Hy2L3yTE5szRe3OIFkbPhwCD9N8TFrn9pcIxl2ApRIYpOfexzaO2I X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Jan 9, 2024 at 12:36=E2=80=AFPM Matthew Wilcox wrote: > > On Tue, Jan 09, 2024 at 03:45:40PM +0000, jeffxu@chromium.org wrote: > > +extern bool can_modify_mm(struct mm_struct *mm, unsigned long start, > > + unsigned long end); > > +extern bool can_modify_mm_madv(struct mm_struct *mm, unsigned long sta= rt, > > + unsigned long end, int behavior); > > unnecessary use of extern. > > > +static inline unsigned long get_mmap_seals(unsigned long prot, > > + unsigned long flags) > > needs more than one tab indent so it doesn't look like part of the body. > > > +{ > > + unsigned long vm_seals; > > + > > + if (prot & PROT_SEAL) > > + vm_seals =3D VM_SEALED | VM_SEALABLE; > > + else > > + vm_seals =3D (flags & MAP_SEALABLE) ? VM_SEALABLE:0; > > need spaces around the : > > > +++ b/include/uapi/asm-generic/mman-common.h > > @@ -17,6 +17,11 @@ > > #define PROT_GROWSDOWN 0x01000000 /* mprotect flag: extend = change to start of growsdown vma */ > > #define PROT_GROWSUP 0x02000000 /* mprotect flag: extend change t= o end of growsup vma */ > > > > +/* > > + * The PROT_SEAL defines memory sealing in the prot argument of mmap()= . > > + */ > > +#define PROT_SEAL _BITUL(26) /* 0x04000000 */ > > why not follow the existing style? > > > +static inline void set_vma_sealed(struct vm_area_struct *vma) > > +{ > > + vma->__vm_flags |=3D VM_SEALED; > > +} > > uhh ... vm_flags_set() ? > Thanks. I agree with all the comments above and will update in the next ver= sion. -Jeff