From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3E87D3C526 for ; Thu, 17 Oct 2024 18:14:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39D716B007B; Thu, 17 Oct 2024 14:14:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 326916B0082; Thu, 17 Oct 2024 14:14:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1A0526B0083; Thu, 17 Oct 2024 14:14:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E37BB6B007B for ; Thu, 17 Oct 2024 14:14:34 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F276FA028D for ; Thu, 17 Oct 2024 18:14:13 +0000 (UTC) X-FDA: 82683894006.01.5FBD316 Received: from mail-oa1-f48.google.com (mail-oa1-f48.google.com [209.85.160.48]) by imf01.hostedemail.com (Postfix) with ESMTP id 55C6540025 for ; Thu, 17 Oct 2024 18:14:24 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Qr8vP0DA; spf=pass (imf01.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.48 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729188799; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tuc4W4AtYfN2GY+JESTW7Xxp5b6QqoT46D1gF0g+QEw=; b=6+VgudxGemTD6J37WKvKT9bfHdymWpAYDjDrrbE3xWMT6nF+iAehlPuz7OZIqlIu5tnHaV htMU3I9cDxw6S9fkbqb6fZJrAaj4rco7yYmTLTeW4mDHNPRC/4Tqu9AyAwqMvJb70+07xX JD0wZeFkCW8PPREDQYnXRkvIJspBIxI= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=Qr8vP0DA; spf=pass (imf01.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.48 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729188799; a=rsa-sha256; cv=none; b=HmIWvOrMdojcFHCysJgbBh6wkXSi0Hd0uX+ImqkoKW175RmecbhkKnvaL38pEyAB7SX+aU M9ITC94KEWl0p2BVryoRLMxb5xv+Dn/rl5cGWMqD/ui2XsLcH1Ou4LbPy3Ox6/8RwWo2N1 KLEXDwVTlzwiiul7aJUhbuABM0JROgA= Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-2877ea76040so54737fac.1 for ; Thu, 17 Oct 2024 11:14:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1729188871; x=1729793671; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tuc4W4AtYfN2GY+JESTW7Xxp5b6QqoT46D1gF0g+QEw=; b=Qr8vP0DA83qn14zA46m4Gs3J6oKDnRwVAGLkgBEL1sQZFG3OFdqRMMlaOU9q4urSyI kt2fTGWZw1mfshZcQw9mhWOyIOW8rL1XGG5PMBuPMqPQXVPFNXKrk6OAmHVP2tfFoZeI Cj1Y87MVw+11AOfY8UvRQGsdAH3/rWhkxMSiQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729188871; x=1729793671; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tuc4W4AtYfN2GY+JESTW7Xxp5b6QqoT46D1gF0g+QEw=; b=uAQdOdNsK+MKL9/8ZpF6PYgwJs1VXxx+HRQXwy8iQNofUFdFKzQ3fWuJW7uRjIcyRg JV2vPxB7XrPrmuTlDJsVnThQHAB3kP/1tbVTcWWuNAz4X0Dys131Db/1dTeJHbUtOq3M GPzfeFBkIi6RYNhgN4ePFo2o2rEQn1MEcSI048dsQ4BjZA+8dvIkif1CXrKDOsNKOg6O 7GiOEXg6uuLAKPFGwVqtHeqKjsOTRb2XAxxh8UtiKwXu0T++FJGdmhkWmQHRsA9c+S85 I1AgJwH5BgA1Mxyq8H9m076AcQTfcakkmYS3RHl7H+vsZ7SzCpSuhBf+ww/PNhxO8vS5 pVag== X-Forwarded-Encrypted: i=1; AJvYcCVgG1yEh9qHeRTb5DxQOyI2DREBBMBp6yqKBZ5Sc66y4vzfOr8+E/Dilc72fziLnQhg31eIuHpTHg==@kvack.org X-Gm-Message-State: AOJu0YxOqR3DoRV7Cqtc9btdFEnLtYW1K+ZLBZ1CCHbcnt5f7AtvBTkr J3awv8YwIi8RNlqYqI5G/vxxnmXNZTFP13Gr/rCxnW93xaCnhNj2oa3yDyRv1zuwVGArYEc4qkU x0vxUGBctW33l+w0IvzfiIuLQlXcWF+N/DD3y X-Google-Smtp-Source: AGHT+IEVVY3x9zDyAxMQtSpj1wu+AKPQttF5+Qsw65HIRp9QuQsb3AQbNuaft90UaiRUD5a3DfimZkgaCjLSlrpmkTk= X-Received: by 2002:a05:6870:e414:b0:25e:44b9:b2ee with SMTP id 586e51a60fabf-2890c617250mr1177242fac.2.1729188871620; Thu, 17 Oct 2024 11:14:31 -0700 (PDT) MIME-Version: 1.0 References: <20240830180237.1220027-1-jeffxu@chromium.org> <20240830180237.1220027-5-jeffxu@chromium.org> <4944ce41-9fe1-4e22-8967-f6bd7eafae3f@lucifer.local> In-Reply-To: From: Jeff Xu Date: Thu, 17 Oct 2024 11:14:20 -0700 Message-ID: Subject: Re: [PATCH v3 4/5] selftests/mseal: add more tests for mmap To: Lorenzo Stoakes , Muhammad Usama Anjum Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, pedro.falcato@gmail.com, willy@infradead.org, broonie@kernel.org, vbabka@suse.cz, Liam.Howlett@oracle.com, rientjes@google.com, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 55C6540025 X-Stat-Signature: 7gy7a4mrt11yjz1iziqs8r4e5scj7hrn X-HE-Tag: 1729188864-946882 X-HE-Meta: U2FsdGVkX1+9tuwa3WIi362N+rrTGO+mcsCMyrdS6EmYZnShJft0ZQ1H+FXI9dIfrZa9/IAjdt/YxtPmEypw9HShsoYMaX8gA+RvK4FZfG5n6ZWALozi3DzwPXsRv4u2DWdj/64KYfjkPj22xWXMr3XJ4CQqq19d32HEL4d1MM5vu7Y6Hmdvi0GxUkmZ8P7ElNB9W2jhockWK1OzeBmjA8hjT+F/XKjX7gTydL8pxPHFrTpXoKrhgOef9sgK7/sEgW36VlgQ/4cD6bzqexNebxTTfyUyP3/JgDu+60wRwTVBm4V6jrhvVbADTObcQP3yLNxxrfZnDWhIyRZ74sJvKBbWLf+W+yXosCZMsVj2SZdGD2C2NaawrbvQhJTSuZOGWEApyiHH3zYXa663sRoVajRk2eFvMu3yR0zphCIMgBGyptiJJQ0ARtIa53LqGYv/Dko8V9904z+NTVPx7/n6Jpmz1HYE0aJ48y82223aB3jOjeiKMFE/W6QCaNh3kfSF93hbxLlq+Ah5+A4sJ6g2thTsImJLp7mtx1ZsMCI+GpotiPMZTYNiqxQZ+0e1L6jAhf86EG9vZBSxSkEa6lcjuE/F6Zs1rnMps+Tprj6Wu3GfpD4s9ByN2Ru4fIB8MjYbidd2PJmtc4KahbohTZPy1tHkk0ZgZl9rrItadFyeyNUD7AttaOUp5q9E9sVpTN89B9+ydQ4F/tyMUGrpp6auJWqC0EVBD1MzDw6eaIsytgdhfU2/9gtej9KtxIBTrwV8BcutJeqNL25h8UFGhGB+BiIOnt3eiyeorAnmfcAArvJD3paJ381t92XoVTmJNJ9KVP+VW07mzR8rAfCzugp3KzdZoY1YI9AiGc5ZGlUbVUcl0CGo4wz8vgXCXyQi7U0UI359CYpMQPH4KGATdke/82sGM1QyAq58SaP/FREjHoTb8e5Ma+Vaxt9tb7DMAc1cKupsjv+f2FOKamU6rNe WRaUJWWa 8a6ndBimhlbZuiTElUlhHMDDLIDzBvEsaz2hqrX+19PZF8IDjNv3HYPkSU/osiIfk/MQeuOdL4/1BmHE2J5VqJeUv5aQwlYClP88aoaAyItbAVtSIMKO1ZusUHbuQfQYAQa/pRrcH5/8xNhWmUNvko9pRTp7TCTv2JfhBbZr6l8veazmahB4+PWLFoFk5WIpcwPfsnEp41s5Z/EALlfkIFSY749q6AyLdvL9MphIT3ClUTKtaC3ROGOyUmmHZ7DVdU92e7wYZfTiOCzNQKa7JzUFyrWCt8jwbcl0hJR2JHgsvM7DMQK1WJErHatmEEdEthabJP7WmvOnI95onExFFPj7f9+A/3qrGFNfpsEmvaM1uRE629X7SMazIgoIq6Q0yluL3qKCRTwLANma0s94Ey2kfQQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.196122, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Lorenzo and Muhammad Reviving this thread since the merging window is closed and we have more time to review /work on this code in the next few weeks. On Fri, Sep 13, 2024 at 3:50=E2=80=AFPM Jeff Xu wrote= : > > Hi Lorenzo > > On Sat, Sep 7, 2024 at 12:28=E2=80=AFPM Lorenzo Stoakes > wrote: > > > > > > I also suggest we figure out this FAIL_TEST_IF_FALSE() thing at this po= int > > too - I may be missing something, but I cannot for the life me understa= nd > > why we have to assert negations only, and other self tests do not do th= is. > > > My most test-infra related comments comes from Muhammad Usama Anjum > (added into this email), e.g. assert is not recommended.[1] , > > [1] https://lore.kernel.org/all/148fc789-3c03-4490-a653-6a4e58f336b6@coll= abora.com/ > Specifically regarding Lorenzo's comments about FAIL_TEST_IF_FALSE Muhammad Usama Anjum doesn't want assert being used in selftest (see [1] above), and I quote: "We don't want to terminate the test if one test fails because of assert. W= e want the sub-tests to get executed in-dependent of other tests. ksft_test_result(condition, fmt, ...); ksft_test_result_pass(fmt, ...);" FAIL_TEST_IF_FALSE is a wrapper for ksft_test_result macro, and replacement of assert. Please let me know if you have questions on this and Muhammad might also help to clarify the requirement if needed. Thanks -Jeff