From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D554BE77173 for ; Fri, 6 Dec 2024 20:08:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 33CB96B02E3; Fri, 6 Dec 2024 15:08:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2F67B6B02E4; Fri, 6 Dec 2024 15:08:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B4346B02E5; Fri, 6 Dec 2024 15:08:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id F3DA76B02E3 for ; Fri, 6 Dec 2024 15:08:16 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A11FFC0745 for ; Fri, 6 Dec 2024 20:08:16 +0000 (UTC) X-FDA: 82865620320.06.B3A2060 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf07.hostedemail.com (Postfix) with ESMTP id 1A8A740007 for ; Fri, 6 Dec 2024 20:07:56 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dS4Q+R0g; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf07.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.41 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733515687; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fa40TeoQXNd/EST0klScC6VWGBe0xBrJUCm38PJDQfk=; b=XBskSiRkrET5C/EeS3buc6s7XpKapCUO6MdjdE+D8JmmsNsiDg0aAbbVBZYc1Kn1XZSodj INgzsYfHomVDIAL7jI0zI9hUaRLy9YAskkBLwBbJ4lURAbSY5gIWfHlkVwj7o/ALNBov+O 5vDv9/+Vvg2m75tpD8A1JU/GvJr+UsA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733515687; a=rsa-sha256; cv=none; b=rLsjInd5Ves4n1nZsmsrHZmDCn0nHOdMJPV1hWFKCV2wYkwt0e2Y6Bunkd7LbRhAx9HZ4I TCIqt+soD0o8ZPgLrjintNj1K6MtBr5v29SBgo3CN7BogMmmfnQ1Yti8oVpDwDkYh67iGt cgxh6AUfY/EzjGzafDAZrRgMUou48Js= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dS4Q+R0g; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf07.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.41 as permitted sender) smtp.mailfrom=jeffxu@chromium.org Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-71d4d3738a2so618865a34.0 for ; Fri, 06 Dec 2024 12:08:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733515694; x=1734120494; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Fa40TeoQXNd/EST0klScC6VWGBe0xBrJUCm38PJDQfk=; b=dS4Q+R0g/Dawy0+TwS16dClwTE7IE01450QYr71FgwetaDDMawsVgPV7pvXF5idOEB hd26/gKr2bSf1MfxgI9fJ+WqaPI61YElvxzqUqN9X3LJSY0wshtokuD2VXoA02aT5eUa 0vRU8IUtS8i6dJJEBdHAIcuYw3nYcUcx3Cc0E= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733515694; x=1734120494; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fa40TeoQXNd/EST0klScC6VWGBe0xBrJUCm38PJDQfk=; b=fN00bpV7Tr9q/Yc5XYbOfvoLuoYBSw25zkA2qHiBuCYbYFKvlIGDV5SkHCfH0Os02x s6zI6L1ZG5kdCCXZDc/D+LdOVX40hl5e2WXjBUxwkuV3LoDWpphpPgBkiYboMo2R9JmO AzpABDYI+jkMZWUHAF4OyyqF7irIHFYJpWqo9ICCgTpc2cJ0tg8RLanZEzpd4JEV4vfJ lqzwU0aiBkEZa4BeekJjcJLTiXePs7fPbWZLnoot55dYSoxSit1Wlnht3lBkBpvHJW4W uh9FfyStlot0tOZiwtnwa8pptOyRpficN8dPfDjvZ3GcmzzWZ722yBHJyfzBd3RBhpK4 uu2g== X-Forwarded-Encrypted: i=1; AJvYcCVY/KVUnzC+zDrv10IWvnB/dmYY4rxz3HDmWkYGf5OlgxYFKL2QCjYS4VMRP6eMX75iXT47DbICLQ==@kvack.org X-Gm-Message-State: AOJu0Yyvlw+yqJOcAd58T3Hk2sIXJdzGbJIfFE+RotWvc23c7dtSJqTH C7vbs9qKfVzGQYjpTL8N8JVflN7gkJYiu8aPHkp43wifZ26mLSbDk+vpXH8dBHePL5lBqh5aD9j VQKrz5F2qajgFniYSj//eMnB1N9Zz09wuCBfE X-Gm-Gg: ASbGncs/rL3epqVgpAOa6Sa7qlM/Ar5/0uglZFxh8iEa7czAJ8FoP8drevlaEigJAw1 0w1GNEBbvo/Ru6Q2yPVo0Vhs9JYveQI2KrQNV8JSXK++/xFSXQdjrpEZIuhc= X-Google-Smtp-Source: AGHT+IGnhbchndsxQrpOqmx+L6gEP0mz4KnZxPFnbF3cSlHW3yU9Qu5eUura8Gsl1otfULbbGp1jxsGpXke5kG5WBgg= X-Received: by 2002:a05:6830:3746:b0:718:ff2:c147 with SMTP id 46e09a7af769-71dcf56a5f3mr987845a34.7.1733515693797; Fri, 06 Dec 2024 12:08:13 -0800 (PST) MIME-Version: 1.0 References: <20241206194839.3030596-1-jeffxu@google.com> <20241206194839.3030596-2-jeffxu@google.com> <607a69bb-9b6f-4d0e-83aa-1ec6903c34a5@lucifer.local> In-Reply-To: <607a69bb-9b6f-4d0e-83aa-1ec6903c34a5@lucifer.local> From: Jeff Xu Date: Fri, 6 Dec 2024 12:08:02 -0800 Message-ID: Subject: Re: [PATCH v2 1/1] mseal: remove can_do_mseal() To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, keescook@chromium.org, pedro.falcato@gmail.com, rdunlap@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ipux7aytg7dzdya3yjhqcn8ty41g3rsa X-Rspamd-Queue-Id: 1A8A740007 X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1733515676-525229 X-HE-Meta: U2FsdGVkX18CLbcNpLYnTo+9EA7AU+nOb7TIFIcTx8J9Oaa7UEV6xgL2UzkZcfSeOMfIawll039utC7Yrk9ZWDmFqQnDr00K7rystHgu1nor078X/4Mz5BUk67FaB8qwAyv9j+ebqyzBLbqOGvPNQ4pNtZpZ88JwjAM3aGDddvRFWvSe1Pnhbklk7yeDfhwM+Ts9V5h8t+bxB8WS9qJaSwOQkHugAm2aifGsCHX8TcKYWZeOEPygglLNsvn0OmQPhXn4Onb/HLXv25SWiDig6/KbEo/Mi8YwAP9Z1fqJ3Ca5buYyxkkRmuhlKvlN9KCp7z1iH3KysJYCzQWi+Z1P0/Ea6BTFa37/A5ywCD4QLXY/UlZ4KXG0Wq+hnAn/vrbnLTaJ564JrQvAo/TpXUXBoOmeW4s/CA0HrCLJXDRUaxQsb+QuoR/5jvXnce9cxBWwL66xHGP2p9UhsBr5yAcKKPXhhAkUbfFCw3LqZfyODEfPdug9KQnOlw4m5U+/9Y44a1xKdc0BL8O/kjnr+w4WAwJIDP24NlyF6JZ19p8RFVh4/ifMrFg1nxva3O5jG5ByxIP2D47uVtlzMotM503DbMpkgryi7PW7I0ZPB2SjXPwDHHBbwyHTjvsxTp8rN2uRzIt0v743887mltv3p5gbU6dVkxW1Bj0+lCro7k+ewGrxZ30tiraAA9x8j0LwcP3bzll5lasS1g4DsGhbu6pIe3gewDxyK4OFdtWF5S2LUy2lHdPDKjXnRQzG3WZY2O/e+E8YaAVg35BxZWoZ87H6fIIIxVXy+eyu1/UE4q1hVaeYMqpjpmVI88sCjnncXuXPfo84IvZvTR4U1j5qE2j0HPFEIRlG6Ef/yKNzyG6WXoRUAl8bUXSF/DC/TmX0vLS/f69y5CIVfaHs5+VrwVBgIPKY2crIVOMjfafJpgvt4S5nNU85ITOPmORkLqeaKq9Ply1l8HQU0iSIDHDEXNL KPUYYJWG FHcb+RKUolPNL2ehKbvluaDlUboEQGoAf9XngaV93HvDD4b7MokWOz7be3NZRq5DpQFdX5gqzeuQAKd1I+dKuUNFPJ8yDsaU02L8s2me6qfoFLZn4LpdbHNj7f85/geai8haW1nawY6KNFlEmLYJMkmUn2vqQjbU+ps51CBttYiNVSYu+rTUbUyeaeSC0Ga8u/uI99fGn/RTJqImXbbWob9YiZthW+SFkCbjA7wXSfGwWhO38W+/6Kepdw3R1STbxWK7mL9VeWjQZoJ045Ehy26Ja5+YHe6U4Vx37etsl+bQaxF6pWGTkvwmF7WEwhbD44tpIpc1QErRRo8sv/LrfArGJBWMgWGEBXFZVfTJ+ecOmaCHBl+ShBKCR7PUIIPR2jGp962OEXD7x2fCjBKH4WcCBUIC0zyB4Q6c18IYT7ZQmvy19JxEb7ibAC8bcW0C7bUhjpQ99+JzNd8AS9PPlNwW4WRnY263bM54kNq2ZoEp1HPq903eRZ1VRR8aC5uhIr+aPGvdQq2OrAWK5Ot5bQ4Td1A7BkvYJjTLNg3LG2ff+F6k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 6, 2024 at 11:57=E2=80=AFAM Lorenzo Stoakes wrote: > > On Fri, Dec 06, 2024 at 07:48:39PM +0000, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > No code logic change. > > > > can_do_mseal() is called exclusively by mseal.c, and mseal.c is compile= d > > only when CONFIG_64BIT flag is set in makefile. Therefore, it is > > unnecessary to have 32 bit stub function in the header file, remove > > this function and merge the logic into do_mseal(). > > > > Link: https://lkml.kernel.org/r/20241206013934.2782793-1-jeffxu@google.= com Please remove the link field here when applying. (I pull the mm-unstable and apply my change on top of the existing commit.) > > Signed-off-by: Jeff Xu > > LGTM, > > Reviewed-by: Lorenzo Stoakes > > > Cc: Jorge Lucangeli Obes > > Cc: Kees Cook > > Cc: Liam R. Howlett > > Cc: Lorenzo Stoakes > > Cc: Pedro Falcato > > Cc: Randy Dunlap > > Cc: Vlastimil Babka > > Signed-off-by: Andrew Morton > > Not sure you should be submitting a S-o-b for Andrew :P I'm thinking this > is a copy/paste mistake. > I realized where this is coming from after seeing this response. Thanks for pointing it out > > --- > > mm/internal.h | 16 ---------------- > > mm/mseal.c | 6 +++--- > > 2 files changed, 3 insertions(+), 19 deletions(-) > > > > diff --git a/mm/internal.h b/mm/internal.h > > index 74dc1c48fa31..5e4ef5ce9c0a 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -1457,22 +1457,6 @@ void __meminit __init_single_page(struct page *p= age, unsigned long pfn, > > unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *= memcg, > > int priority); > > > > -#ifdef CONFIG_64BIT > > -static inline int can_do_mseal(unsigned long flags) > > -{ > > - if (flags) > > - return -EINVAL; > > - > > - return 0; > > -} > > - > > -#else > > -static inline int can_do_mseal(unsigned long flags) > > -{ > > - return -EPERM; > > -} > > -#endif > > - > > #ifdef CONFIG_SHRINKER_DEBUG > > static inline __printf(2, 0) int shrinker_debugfs_name_alloc( > > struct shrinker *shrinker, const char *fmt, va_li= st ap) > > diff --git a/mm/mseal.c b/mm/mseal.c > > index 81d6e980e8a9..c27197ac04e8 100644 > > --- a/mm/mseal.c > > +++ b/mm/mseal.c > > @@ -217,9 +217,9 @@ int do_mseal(unsigned long start, size_t len_in, un= signed long flags) > > unsigned long end; > > struct mm_struct *mm =3D current->mm; > > > > - ret =3D can_do_mseal(flags); > > - if (ret) > > - return ret; > > + /* Verify flags not set. */ > > + if (flags) > > + return -EINVAL; > > > > start =3D untagged_addr(start); > > if (!PAGE_ALIGNED(start)) > > -- > > 2.47.0.338.g60cca15819-goog > >