From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDA3DC02198 for ; Fri, 14 Feb 2025 15:19:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23FDB6B0083; Fri, 14 Feb 2025 10:19:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1EFC96B0088; Fri, 14 Feb 2025 10:19:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0905E6B008C; Fri, 14 Feb 2025 10:19:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E1B4F6B0083 for ; Fri, 14 Feb 2025 10:19:05 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9579F45989 for ; Fri, 14 Feb 2025 15:19:05 +0000 (UTC) X-FDA: 83118908250.14.89C32C1 Received: from mail-ot1-f41.google.com (mail-ot1-f41.google.com [209.85.210.41]) by imf25.hostedemail.com (Postfix) with ESMTP id 94006A000A for ; Fri, 14 Feb 2025 15:19:03 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VS08omGI; spf=pass (imf25.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.41 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739546343; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pEgNB+e8X9eCmb5Em4WEq2/1ktgDjteXr7M4CLHP70Y=; b=hfeDIAyf2rGsV0EV9Y//5hcgJQmUBJNsS3YwR7je+bUJOIzaz2IejzWp/mmXyW90nN1dPL K1Ks7eUlR2Lh6EqxQl6MMKhDOeL0dKrSLr+of3DFSFo+816egW09nVV8eziTOHL89uZ7cN LkI0qGG31X1s4ZJFeW6hO9bBGcSe9pM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VS08omGI; spf=pass (imf25.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.210.41 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739546343; a=rsa-sha256; cv=none; b=uudhCoTB4UWh/rMNQy3Lun8eZxYoHSjXsGFlxpf0MdCh5riWE5WsHFvf1UAeYQ2EXDzAqY dQHt1ESh2sdANqijM8f8fdGJlRmyrhrbsT6UpiuQ5MQTAbJrG/Zo23lqcfKAvLWWyoXdpC Hhw6ENEpVnOfiff5UvN1pO35Q4AwFjU= Received: by mail-ot1-f41.google.com with SMTP id 46e09a7af769-724daedf8c3so453640a34.3 for ; Fri, 14 Feb 2025 07:19:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739546342; x=1740151142; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=pEgNB+e8X9eCmb5Em4WEq2/1ktgDjteXr7M4CLHP70Y=; b=VS08omGIl4MHql5CWDjQDXLn460WZvy7+WJt3svBciAQVSvCK+bIq4iqdCrICOgA45 cMo5iqRNxAYdK3VbXu3Ay/3uvT8ifXyHettprBCp1g9Iz0ktbbmQ4ZzafplbFtnh/0AU biOfNz7ihExpOLTtD47krFJQGxolJ8lNn/+Os= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739546342; x=1740151142; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pEgNB+e8X9eCmb5Em4WEq2/1ktgDjteXr7M4CLHP70Y=; b=fged3vA/1inGWlQ5L8+wCk+pUBdo5oSdOdJt0Yr2tjtWVzKliir+evSamryj7g15MG 9mlYHCGrCOOvqPM8VA4Ql8zgJIHlRzaix7dstOe69X9+aK/IFmru8Oj8P3adyEawFOpF TdWtlBo3/Wzltk/ffebl146Do/i/sdb+0Kxxp1cJOeJT+7MLGqVCTh0anuXK2WGHs0QA USONw6Bhsdf/H0JBTOEkMuu1B1WnnbAH9rBoq7s+OPMZ4JPxBgaIcyjc8PdGpTEAIdYD nXBP2rsTgj7wGU4PZ+EkIeGTMKZ77OoCUcLNxifHj2g09CHe6Da0XeaqefA6ewVRESXR jDKg== X-Forwarded-Encrypted: i=1; AJvYcCWQOKu45lvnrJa3ZZi178w0a/C+5ndzZX4ku3uPUVLVDt9k8hLZ7bggLFGf8TX9j1tkBFbPtxtfQg==@kvack.org X-Gm-Message-State: AOJu0YybEa05w3eaDXkOjPDXPD2Wsd5Y9VQq32xaLkb8AWXDftdYKGDb NOBop1YuUBViBd8ymHzL9t+eK9sBWJW9uKqEVRXs2J7uZPJjl/xKX+lSNAJp18MzWSV+hqur7WQ pjisTOWnRlzhZkc9IowMyFZHqE55J1mdN4IyV X-Gm-Gg: ASbGnctBDAxmpUwrL2/iz4HdAqIUl8uWN2yOU6TwidJgLvOMm7QtxvaVwmtSdsAZI0X pI7mMYh4oHYpKgkkShN/GJ+paKsCa3vmsyA+O19WkOdgRD5rTrNG2WkCPSkjZ4IF2EGu+0EU8I1 FgM0Ui9+8Rk+MG586QmFJOZ4vQ8UGXTA== X-Google-Smtp-Source: AGHT+IH3M1MI/ZXrgxBWoTn5XcbnUy6hIbnxuW/lProqCtfwB8xj5L8NYkLoYKwgjWiSVdZWrl3xniim+6Zu173XrLs= X-Received: by 2002:a05:6808:221b:b0:3eb:a61c:4c27 with SMTP id 5614622812f47-3f3e19f2b9emr742458b6e.5.1739546342616; Fri, 14 Feb 2025 07:19:02 -0800 (PST) MIME-Version: 1.0 References: <20250212032155.1276806-2-jeffxu@google.com> <66q7feybn3q2vuam72uwmai322jdx3jtv2m5xmh75l6w6etqiv@knpsyh3o627k> <202502131142.F5EE115C3A@keescook> <8ded890d-f88a-4c59-acbb-8df3418c4a98@lucifer.local> In-Reply-To: <8ded890d-f88a-4c59-acbb-8df3418c4a98@lucifer.local> From: Jeff Xu Date: Fri, 14 Feb 2025 07:18:50 -0800 X-Gm-Features: AWEUYZmbPTbxI-LPUCQ4dfMkA3k9A-wBqOYbs8zt4NFvzvrRV5Zo7S6APKk28jo Message-ID: Subject: Re: [RFC PATCH v5 1/7] mseal, system mappings: kernel config and header change To: Lorenzo Stoakes Cc: "Liam R. Howlett" , Kees Cook , akpm@linux-foundation.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 94006A000A X-Stat-Signature: zj79b6zkrib6scp1duuhcder3m7ropde X-HE-Tag: 1739546343-123001 X-HE-Meta: U2FsdGVkX1+agRl1uY/2weaQg0QrJNCM474lQx4ap4HzJ8dc7ZGHxfmO9xbrv47jQVumWOk7IteNmWr/HQyd++8RxWgAYbC6f1eK827WL0Omtd+iVK+W+9huTj5XeEN67Gbo3Huycdf6g94VJ/aCYT6csjO3de1Ac4WaRI65lVm8NGuzlVJGS6L/qxJkV/mjI0F33jc6O6MPAuZoAVUCqGdapJ1dkCPj7IHILr8kd47u7a4hWioMSkdjdHtxOseL0stB93ekjpLpgt8bryg5x2G6VHO5VLu8PEvN75Yu1nGabZxcQ3cPm25Fv1SOAI8W6WC+sX/pNzxJIVSFTAzokqfgI7hJAOwJaEJIWKOiaMJfb9/ztEC4nQakxUvXbZckKcMHJkY3RTLrt3BK/1YI1caY8ITKdk3jkjnMzaAoyWGrdSz88+hYr5/OQ3i3BgQrSIUBprNURTNBxXYdyAjxax8wLRbYz4ZzO1E6h4rZ+Xlzb54BtKyTLVMkmDLQSbbhAjBI5wb0YrStE/STnukaZlR+GIDiX/k5xh3BHqQs3LL4x5oqEbSfNBIxf9qAsxiL5tDzxT9uF2v89zAFb1euSeYm6SSJLpGwzyhvEptunuEPGgOoq9QifHQAN1slzdyvQ13/7t7kFoAXJo2fuwRI9Z4in5JpgrgKUoC7EeEGMZbo92xaf5PCZR4VDUxlIF5S5ZdjVQf3aH0g3LvbfvDlhQuz4epldkYefONW20dK9t4cXdj5gV5zWwczYPTMh1fsV0QCUOs0JpHs+ea73Ad0i0WfSYgQ4z8Jqb2E+G0+wbX/8NJ4fy1Y59zLfaJvkNlKfNTJWB7h0bZKi/P+nxBS/4THgGcrt+YJ6s3VlUl347MH8jDqzgDkWp/iacKAabDL0z6btrJLxl7py6+tkQ0hF1XqUuit541NA/e/6OH9mkD8lfiWXNIZzUORkeczBZUYJOaLloWbhax4Gjf4zMn MjsN1Vv+ uYvThpgAtCQzsnc0e0re9y2hZ0jGbMIvrBwQ8yXWyLkMrC5D3gx8uz6DKzsWY8aN2H2szwAUd037MSJ0HvdQ2Vx5K7DEOuuzx4dswlyuQ+6VfnGLBve4DgsRnYcQIdgllb/BpFXWK+KSm6SiS4sBd8Z8Ic9ymfbzA1lkr3mRZZ4dANhiGr96gXe7JgYkZNI2ayKvdBWWbLea5bcG+G7PM6kQyzMBgnVnRVMtrIrbT7SXv+qRZ+pwYr6Rjwla2+QQwbsCjPe7mKJSlVeIzn6Mn+49gUvssutZIK+dq X-Bogosity: Ham, tests=bogofilter, spamicity=0.080664, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 14, 2025 at 7:00=E2=80=AFAM Lorenzo Stoakes wrote: > > On Fri, Feb 14, 2025 at 06:39:48AM -0800, Jeff Xu wrote: > > mseal_system_mappings() can be placed in mm.h in this patch, as you > > suggested. But in the near future, it will be moved out of mm.h and fin= d > > a right header. The functionality belongs to exe namespace, because of > > the reasons I put in the commit message and discussions. > > With respect Jeff - and I feel that this might simply be a miscommunciati= on > here - but this doesn't read wonderfully. 'can be placed' 'it will be mov= ed > out', etc. > > Please try to be respectful of experienced maintainers who are taking the= ir > time to review your code, and respond politely and respectfully. I think > what you meant to say is something more like: > > "I'm more than happy to do that, but I feel that it would be more suited = in > a separate header, as this strictly belongs to the kernel functionality > surrounding the execution of code. However we can revisit this at a later > time!" > Thanks! I apologize if my expression appears to be rude. Your revision reflects what I'm trying to say, in better english. > My feeling is that this is exactly what you mean, but you are just > essentially abbreviating this. However it reads rather rudely, which I'm > sure you don't intend. > > Ultimately the fact of the matter is that your series will be merged when > it reaches the standards required of you by the relevant maintainers, as = is > the case will all code submitted to the kernel when we reach consensus. > > In this series you have addressed a great number of concerns which has > brought the merging of it very much closer, so I hope we can continue in > the same vein and reach this consensus soon. > > Let's try to avoid any miscommunication which might delay us reaching thi= s > aim! > Thanks ! -Jeff > Thanks, Lorenzo > > > > > Thanks > > -Jeff > > > > -Jeff