From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1606AE77173 for ; Fri, 6 Dec 2024 16:11:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9A6F26B029C; Fri, 6 Dec 2024 11:11:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 956706B029D; Fri, 6 Dec 2024 11:11:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 81DF86B029E; Fri, 6 Dec 2024 11:11:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 63BB86B029C for ; Fri, 6 Dec 2024 11:11:39 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8AB94C1B54 for ; Fri, 6 Dec 2024 16:11:38 +0000 (UTC) X-FDA: 82865024340.04.CB82847 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by imf12.hostedemail.com (Postfix) with ESMTP id 53B1140013 for ; Fri, 6 Dec 2024 16:11:29 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TzTOtITD; spf=pass (imf12.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.49 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733501479; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XA+yFZiEQVvPrNXcoRRU+QeTGgabAJXB1krFWBWZtOw=; b=qSRaabNw8O9/tlr1Ovmhrmo9jdQhHFjvwYxSbLfK5uWLM/E9sntJnfAud58ThHJNntgmAw y9vczYUej6DCyxtIvK5vWGcsxWjCPQuSZjyTIng/ehvO8XJRB1/hyMcfqr4dqMan52EMAe GROIOVWaNofBX765EW3LXNoH1mlwRfQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733501479; a=rsa-sha256; cv=none; b=S8u3lVHJzHwJ/duTV2oBVRVXFoaNlBVevt79E4Mv1pQnHa3OWEN30f3aSGUne4HgT1bnOg MXJtD+yvG1idN2ClXdQGJslzauT+LNurJz9KT1+McRO9/oEiwbsNoqdd56sZL2MhMRoS3V Vhj4KmjWRpahbShdDHkFjFCFBbNdmMU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TzTOtITD; spf=pass (imf12.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.49 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5f1ee547352so61103eaf.3 for ; Fri, 06 Dec 2024 08:11:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733501496; x=1734106296; darn=kvack.org; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XA+yFZiEQVvPrNXcoRRU+QeTGgabAJXB1krFWBWZtOw=; b=TzTOtITDy1iXGOMEEIWzybaIHjP/4FJTrRxwXFM/tCRYANVqmNfqfZUjim49sCtLOE gsqc+/KX8dZtGb9KPAzpZdL3Y8N5JlSGqR2aK/iq9RIVgtJOnrfBY8Q22H4XJFgHSnHI jojo7CjqrXCl2tOVmz0Wrqz5b5c5VtQrHE7FA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733501496; x=1734106296; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XA+yFZiEQVvPrNXcoRRU+QeTGgabAJXB1krFWBWZtOw=; b=LELyux1EQNBd4rka6EKcD9XPt6UOpqPCIFH7B66ADiO8gbEFLH4GSfbUEpl8FQT/lW K4C+xyqXRIkiXmHKrr/fYLAP4hdwmvJtHk7ijiK58giv9McnsjiKECYHaJyDAjxKguze xWVVtr9Sda58XjPqq7zpHaTnJusJji49cPJddPy1WdkYzNN58LeLtjszgxZURbceWWE9 OENCGwGij0MEJsGnNxU8G1J7xZ+chlQVCkzzOKH2qCeTQy/iqBslBwj6fv1WUBGTo9cL B3o+Z85eNt/8pHfkdr/Lsp8d2bI4+15Z93w90dAo2upXwXBQLM90Df7dKiFLEeE3LZWA q0rA== X-Forwarded-Encrypted: i=1; AJvYcCW8+MRbbWku8Ta1rIeT5ekkOKwbwfmE71w3cbFKEaBN0EoxMNRsjPtlDIqezcQDvkK/bUVi7qJZ8A==@kvack.org X-Gm-Message-State: AOJu0YwcbWbtqlZGK7qBldmd4Dx/MIKC0icQEG8Z5uEzt7x2187sL7+W F+BPTPsxQQfH/l2jketlKsjyz67zqHlf7+3bvAu+krSba7XEROPAxpufb8mkuy5vUEjZPVQTfLr LkMjp0YOGDky2rEJEwn1ORBbqv4rt7Cz8sd5i X-Gm-Gg: ASbGncudpKHrtUpbCB9azmc0LS+VsuX3/F9gebTXPNRIawjYcYL9KTvnY4zEZ2A3vid Ay+g/WxssAThuL1u9sHnzG+yHno901g63xB2JPS+sT4R25gYJwhLUNwXxllfdNFPX X-Google-Smtp-Source: AGHT+IHaYff3JMPT81zyBSEM23QKqUx/UbkJQeJCV7Wp12IwDITkCTMpge+kUaz3qXTSTl0EJTZtDpiCttRvnyLy0H8= X-Received: by 2002:a4a:eb19:0:b0:5e3:b1fe:b1a with SMTP id 006d021491bc7-5f28700e98amr559652eaf.2.1733501495628; Fri, 06 Dec 2024 08:11:35 -0800 (PST) MIME-Version: 1.0 References: <20241206013934.2782793-1-jeffxu@google.com> <2m3zmlehfigs5r7rptwcoft3j4fipfkgfxmdrdttpf76hwhwae@vclfa5ulcmv2> In-Reply-To: <2m3zmlehfigs5r7rptwcoft3j4fipfkgfxmdrdttpf76hwhwae@vclfa5ulcmv2> From: Jeff Xu Date: Fri, 6 Dec 2024 08:11:23 -0800 Message-ID: Subject: Re: [PATCH v1] mseal: move can_do_mseal to mseal.c To: "Liam R. Howlett" , jeffxu@chromium.org, akpm@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, keescook@chromium.org, pedro.falcato@gmail.com, rdunlap@infradead.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 53B1140013 X-Rspam-User: X-Rspamd-Server: rspam07 X-Stat-Signature: 9jrwx6sgpzep3bzf1ss6uxqtumj9ytkb X-HE-Tag: 1733501489-309805 X-HE-Meta: U2FsdGVkX1+XoNxlK1kTKqHWPNjFmja5pjUNOg1zNhpqmNeymxwWLcSpRFKsqnqoIOj82MNJZnokmgKXW0vnSzkn/LevaoZeMXhfnDyQbJOF8S2HdxOTffM8ErRjumUqTCsmz3JtwVnM6F3DNkxIbq+WbWrdXIdkB6Jy92DcoRwMidi9/am4B4tGEuRmQL6xnOt3uPZRGOBJwY7cxs9zPeXIXK1jtwq0E7Qmc01bKd3tvaKQORZx5abqsgEjWgrVGngFZoXZbIEYtK1YTeDJHIQq2Wxmw7r/y7SRe/4TzWCUDts2Xz+2nAn4cJ+6VVS6z9e84FlgsXJ1j7DQJ26DTa9eQxiBGPIpamxySlqy7V+c5RzZJkJ1kQkK5vMRTNOMrGLJrJZ/l6hFURyatZxyd87ulDBgrjaDW33YO7N41jAFVlI9V9V0BV/PHmVabF007Qm9zqKAACuHTt+0/gxSBg4HDhJovhatIcIxQg0SbwGuVzEIO120Ns/jdlyO6nPFsu0CwKPommwC8c831/II2+1qNz0SYagWnRvoX2EpH097SUuzgkG85Eiod9zdXeUEC4XFy0ARxsn5t0xyk7ZGD9o/SKeOaaneww76VFUvfGbDuZIUrmHsRwK2BkTS26grcq702g8BzAmN2sn/+KFcRGu1DqLHMrf4z46ikRaw7J0I830OJJprYtV5TZkkTKwiOdm1Vz4stj70nuROXUe0Ic9tsSW2/bbmzDu6QDmcEHCWL7M81clVhSVMWqFV1ZcF0thWd4Lf+fYivmgqa4NGTPNcF2Ii1lAlfgzjigfdVfLTGBJfjyj9+uMZi3uxhXZ1PT6+LWmIyRRQXMZ8BK9FhX9ZF0RlOgGSYUwQ7r8VlvBwP5MG52kKt80l0pEI3FqabjfDEnTuskpV4pz9EL5wlDNo8Phfg3XMGN+PS1wzlS1FMEgKOgdwaxHzK3X7WSv9yzFaYuE2uVVlKbAKqLh ragxjMC/ SYq4xJoS8qy420WqY8ooytisvK4rQbs0OPjiADnHUQ6w9R1G42uPZqpHmdeJozZrbtJ5CCL9enOqWg5jeIjKQhguafd+b86ksnWA/9zs7ma3nhu/EaOXoeKFI9LjfrU/NL+R4uKRMq2skWLdT0vuJ2fPCyk6FRATFFsufsam+8mY6vbFf1dI+8hKmvo5Chr0u4YPG2Q2qrdqkFV2hDd6V54SsYG3a8bVdtPVxK7IFYM5+9TNtlVwOE4c3CrBP9NIJEDBfbRXRW+Fv91KKhuRHOiOValFzGLbscXSICMVPyEYE3K9v9yCNNoH+zf4ifKnX9XpS8e9xUl/JoFWjh77NwOqKvdbAcQLbmEdehUu28HAYB1A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Dec 5, 2024 at 8:25=E2=80=AFPM Liam R. Howlett wrote: > > * jeffxu@chromium.org [241205 20:39]: > > From: Jeff Xu > > > > No code logic change. > > > > can_do_mseal is called exclusively by mseal.c, > > and mseal.c is compiled only when CONFIG_64BIT flag is > > set in makefile. Therefore, it is unnecessary to have > > 32 bit stub function in the header file. > > There is no reason to keep this function at all; it is used in one > place, and that place uses three lines of code as well. > Sure > In fact, having it separate from the comment about flags being reserved > makes the function very puzzling. > > > > > Signed-off-by: Jeff Xu > > --- > > mm/internal.h | 16 ---------------- > > mm/mseal.c | 8 ++++++++ > > 2 files changed, 8 insertions(+), 16 deletions(-) > > > > diff --git a/mm/internal.h b/mm/internal.h > > index 74dc1c48fa31..5e4ef5ce9c0a 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -1457,22 +1457,6 @@ void __meminit __init_single_page(struct page *p= age, unsigned long pfn, > > unsigned long shrink_slab(gfp_t gfp_mask, int nid, struct mem_cgroup *= memcg, > > int priority); > > > > -#ifdef CONFIG_64BIT > > -static inline int can_do_mseal(unsigned long flags) > > -{ > > - if (flags) > > - return -EINVAL; > > - > > - return 0; > > -} > > - > > -#else > > -static inline int can_do_mseal(unsigned long flags) > > -{ > > - return -EPERM; > > -} > > -#endif > > - > > #ifdef CONFIG_SHRINKER_DEBUG > > static inline __printf(2, 0) int shrinker_debugfs_name_alloc( > > struct shrinker *shrinker, const char *fmt, va_li= st ap) > > diff --git a/mm/mseal.c b/mm/mseal.c > > index 81d6e980e8a9..e167220a0bf0 100644 > > --- a/mm/mseal.c > > +++ b/mm/mseal.c > > @@ -158,6 +158,14 @@ static int apply_mm_seal(unsigned long start, unsi= gned long end) > > return 0; > > } > > > > +static inline int can_do_mseal(unsigned long flags) > > +{ > > + if (flags) > > + return -EINVAL; > > + > > + return 0; > > +} > > + > > /* > > * mseal(2) seals the VM's meta data from > > * selected syscalls. > > -- > > 2.47.0.338.g60cca15819-goog > >