From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7954DCA1007 for ; Fri, 30 Aug 2024 15:53:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D20FE6B0181; Fri, 30 Aug 2024 11:53:22 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD12C6B0185; Fri, 30 Aug 2024 11:53:22 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B98CE6B0186; Fri, 30 Aug 2024 11:53:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 97D0F6B0181 for ; Fri, 30 Aug 2024 11:53:22 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3F2261406D0 for ; Fri, 30 Aug 2024 15:53:22 +0000 (UTC) X-FDA: 82509356244.24.BC3DF64 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by imf27.hostedemail.com (Postfix) with ESMTP id 30A984000D for ; Fri, 30 Aug 2024 15:53:09 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=enIgt+jb; spf=pass (imf27.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.54 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725033118; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w1kleSOg8vL34NiCGn9nqKVN6gqzoun/xCRiElWIius=; b=zIED7L2fOiKjghOySPdcY0nCGsvS63foAdLTMXopmQrr7ochkk8EIbXNO89xqAoVrpaPYQ nyC0tgrq1jMyUgxXV634DtVilPNIsIhjrZqKODytKIxljuCUSo6KWWG3rq60iDAlBkz4gM 9zKZELx3tXWfbj9zUBe9D7EC5CUWuv8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=enIgt+jb; spf=pass (imf27.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.54 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725033118; a=rsa-sha256; cv=none; b=M/HjK/Zy6hOf7Zc3iapv7lJOdhdeLGtv7tUPQuyqUyFPjvm435MUcSr1oI0mPc+e411Wnr LKi93lyDktIJSQ2AxT4Zay7cA6Fz9F4wyFuEW9JzbFjH7yCsUcu0ytQTgSmIIoacEpue3h 1XGklW2Wxz4ZXYxFbwTBfpIp4+C+u34= Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-2610c095ea1so168247fac.3 for ; Fri, 30 Aug 2024 08:53:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1725033189; x=1725637989; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=w1kleSOg8vL34NiCGn9nqKVN6gqzoun/xCRiElWIius=; b=enIgt+jbOugajwgxkw31QfoarYCGbUUD5dme3BojV3hsF818TIaexOZ2xMy3wTy4iN iTeBsoKwobBoyW8f9pjJVDTlJ8sh9Bz0skTykPjd4NgqVyW8ofxNiNA8pJYp3k0VKL5p LQx0H5encIP87R724Pzq74N1ntLf0rKuswfbo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725033189; x=1725637989; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=w1kleSOg8vL34NiCGn9nqKVN6gqzoun/xCRiElWIius=; b=EtvBewOpcCiNVRCaOMuWI9d4VdJuXfoV7bIcyRkuXUjfWI+oJ3NlUb2zaht0kREpAn K8OqI1WhcxzMSbjqEMuGTo/9693CxImkfhdLcUj7qmk0yQE6CdjF8tVTQ/n/kXAAsqoj +l8BIdVJoHDNIgXUk7Iu6mn353H4qaTMt7JnIVvegF3DZ8lgzBTPTj5KKQBvBhS7gNs+ 5ajYnErDVPaKdReks8MGEbNX2yh/8ZrX/R7OoanNGFYcqxIcOvGniMKXpUes7kVV6W5p 2S8UOTOa4VJAjWXOOvt5G3LCHNuRSe3M7SXHYG7kIVpW/dI9RuZKbI4NHbHmfcv83lpA RHbA== X-Forwarded-Encrypted: i=1; AJvYcCX5XoApQtGSgoYEdLnqEwQ4Vz6/7uQiWeHWpxngjOI00RRDC0X3S837Gz13CW7/58wGQHtMxgbkMQ==@kvack.org X-Gm-Message-State: AOJu0Yyr4LC78cbftcLeQjiFvUeNw/DEbd1PZYoyzcdrxPgOam6aaGpO usQxs/c1Yx5KRaRodpw2IsdAFa1QtyFkIqDB8Gpx25AsOdT7BdauUXFMa++98NwAgWAeq6BPUbQ hioPiJg3mHsDMi1gnEDs3w6r4q5jMEGObE4GS X-Google-Smtp-Source: AGHT+IFZoOc4OSRPXPIUfZBqHojHFqN6vZ6Boo4DEXXuYIpSR8r9zMBaustrBst6g13zZa+5yjghU8cVM0qraZJwXqQ= X-Received: by 2002:a05:6870:71c6:b0:254:d417:351f with SMTP id 586e51a60fabf-277b0b79a69mr1381287fac.1.1725033188911; Fri, 30 Aug 2024 08:53:08 -0700 (PDT) MIME-Version: 1.0 References: <20240829214352.963001-1-jeffxu@chromium.org> <20240829214352.963001-4-jeffxu@chromium.org> In-Reply-To: From: Jeff Xu Date: Fri, 30 Aug 2024 08:52:56 -0700 Message-ID: Subject: Re: [PATCH v2 3/4] selftests/mm: mseal_test add more tests for mmap To: Pedro Falcato Cc: akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, willy@infradead.org, lorenzo.stoakes@oracle.com, broonie@kernel.org, vbabka@suse.cz, Liam.Howlett@oracle.com, rientjes@google.com, keescook@chromium.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: aqmepab4yzuiy4pszm75anraijfed9d1 X-Rspam-User: X-Rspamd-Queue-Id: 30A984000D X-Rspamd-Server: rspam02 X-HE-Tag: 1725033189-298702 X-HE-Meta: U2FsdGVkX1+KheuEXKMm2crCSjetfuESOqU7eKvvliBxPpPju6N8FwcHa3uSL+IOuKotY35ASMUYE+M78VVhH/MPiNICygWz8B5+KZwBKUIotwYbHI0HTd3hLP4q6N9lvAJQqdc+5ARzYkMvAPoiejn8/W1rlp39eNjZVnwxRx8/cbdgI7KNNo1ZpKm8bIuzI2B4pKtYRiko79yg7mehTImAbzm+26gaHVT4CNujfpHO3v9Gm6kDRtC2MvnsTyZQhymebSQY3I2B8Kt40eRzU00H+/Sqj7TOEFUC3OTyvBrLVcK/4mq1XfnkNPa96vqwl3ZX8EEjH4j1eNIb7ouayDdgx8D9KPo28MS6zEaDIk0qAXGIJ++uZ0BhIEB9t3EL9CEvgdwt+0A4xSgh/oUz8ibGHXCP7LQHsQAXMgunoDuW2VyO9OviNERFs6VCIlmSDPXJqmB6iiCPTZDdjTofJZ0QNdJpYOvwOiM4kcytezf38Pusnjh+gJos4cSqezWUz1WElMW8KoHBf80K8n/zI47ArScmMGI1DHEtQNbeVsDRjYB+7cUM7AzKvdLz7WXQxj0eXS1AsaPhDiHW+9+xgkIAOo8RaA3HUZ/4ACjCiWf+bjWkIjs7blDQJDHAyhBwvd0x3IJ12VwiP5E2zpw/03J/OlAA+w5vNEFrZBDU+aEYqqLYr7UYYSrsi3So85YC8Dfjc9L3Dg/i6prDIttWzTvr88pgRVW0h8YULEOvmL1sfytPLWHnvj6mcnl7zjXMxI3g+ERjLoeBjfviF1u+2A30KKTRmZYkvaI4TZ50duRtsDmxYiSZzdhh4/qaedfBvNHNYz6uUk3JMpJ8uCe4nWPyh5yINSlOV8YbfUmaf4afqgAqxth23e8R5zDuAIrBBZ5ggNcVSHx+oAAFfffMnD8o8WESLqpzO04RtJR0bPJnlrQ7+AYUVrMdjyFZ1zk9A4v8RwS89JqEzeCvDD2 3n9Sn3tY DUgsI5Va5blsoh8bW2ATnZKAORHDZw9DXcMjMOQyF9lql59QMMMCt8TUrUK74NkllMaq1gLun26+yOs5wv7N3Ec1OD4AhMhaz17x+yx4A9leFFbMnP5nVsOxMCxjbMawxhrT9Eg5szTn9t/62g+aAUDKXH5Py2OkZVHrAMXSz+nc6YDtFnV7nBJ9Gw0xnnalqy85Zd/r2OFX+kG+802+N4FiwQycymO5SAjWrcCUiGXLKmWahFY6QedqwBMhlnKAXvumuFcerbO6uGpYbSOJBjyUyGXN6QrDHtTFBBUS95ZP/tpFny64RkT3LjtIlbwTXFBJUu+w8+csXG26+ImYcc9R63zgxOLM8T73HKzaensXGvJU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Pedro On Fri, Aug 30, 2024 at 5:57=E2=80=AFAM Pedro Falcato wrote: > > On Thu, Aug 29, 2024 at 09:43:51PM GMT, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > Add sealing test to cover mmap for > > Expand/shrink across vmas. > > Reuse the same address in !MAP_FIXED case. > > > > Signed-off-by: Jeff Xu > > --- > > tools/testing/selftests/mm/mseal_test.c | 125 +++++++++++++++++++++++- > > 1 file changed, 124 insertions(+), 1 deletion(-) > > > > diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/testing/se= lftests/mm/mseal_test.c > > index ae06c354220d..d83538039e76 100644 > > --- a/tools/testing/selftests/mm/mseal_test.c > > +++ b/tools/testing/selftests/mm/mseal_test.c > > @@ -2222,6 +2222,122 @@ static void test_munmap_free_multiple_ranges(bo= ol seal) > > REPORT_TEST_PASS(); > > } > > > > +static void test_seal_mmap_expand_seal_middle(bool seal) > > +{ > > + void *ptr; > > + unsigned long page_size =3D getpagesize(); > > + unsigned long size =3D 12 * page_size; > > + int ret; > > + void *ret2; > > + int prot; > > + > > + setup_single_address(size, &ptr); > > + FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); > > + /* ummap last 4 pages. */ > > + ret =3D sys_munmap(ptr + 8 * page_size, 4 * page_size); > > + FAIL_TEST_IF_FALSE(!ret); > > + > > + size =3D get_vma_size(ptr, &prot); > > + FAIL_TEST_IF_FALSE(size =3D=3D 8 * page_size); > > + FAIL_TEST_IF_FALSE(prot =3D=3D 0x4); > > + > > + if (seal) { > > + ret =3D sys_mseal(ptr + 4 * page_size, 4 * page_size); > > + FAIL_TEST_IF_FALSE(!ret); > > + } > > + > > + /* use mmap to expand. */ > > + ret2 =3D mmap(ptr, 12 * page_size, PROT_READ, > > + MAP_ANONYMOUS | MAP_PRIVATE | MAP_FIXED, -1, 0); > > This is not expansion, but overwriting. Expansion is allowed through an a= djacent mmap + mseal (which will merge the two VMAs). The mmap is trying to expand the address range beginning from ptr (size 8 * page_size) to 12 * page_size. This is overwrite + expansion. > > > + if (seal) { > > + FAIL_TEST_IF_FALSE(ret2 =3D=3D MAP_FAILED); > > + FAIL_TEST_IF_FALSE(errno =3D=3D EPERM); > > + > > + size =3D get_vma_size(ptr, &prot); > > + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); > > + FAIL_TEST_IF_FALSE(prot =3D=3D 0x4); > > + > > + size =3D get_vma_size(ptr + 4 * page_size, &prot); > > + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); > > + FAIL_TEST_IF_FALSE(prot =3D=3D 0x4); > > + } else > > + FAIL_TEST_IF_FALSE(ret2 =3D=3D ptr); > > + > > + REPORT_TEST_PASS(); > > +} > > + > > +static void test_seal_mmap_shrink_seal_middle(bool seal) > > +{ > > + void *ptr; > > + unsigned long page_size =3D getpagesize(); > > + unsigned long size =3D 12 * page_size; > > + int ret; > > + void *ret2; > > + int prot; > > + > > + setup_single_address(size, &ptr); > > + FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); > > + > > + if (seal) { > > + ret =3D sys_mseal(ptr + 4 * page_size, 4 * page_size); > > + FAIL_TEST_IF_FALSE(!ret); > > + } > > + > > + /* use mmap to shrink. */ > > + ret2 =3D mmap(ptr, 7 * page_size, PROT_READ, > > + MAP_ANONYMOUS | MAP_PRIVATE | MAP_FIXED, -1, 0); > > This is also a partial overwrite. The mmap is trying to shrink the address range beginning from ptr (size 12 * page_size) to 8 * page_size. This is overwrite + shrink. > > > + if (seal) { > > + FAIL_TEST_IF_FALSE(ret2 =3D=3D MAP_FAILED); > > + FAIL_TEST_IF_FALSE(errno =3D=3D EPERM); > > + > > + size =3D get_vma_size(ptr, &prot); > > + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); > > + FAIL_TEST_IF_FALSE(prot =3D=3D 0x4); > > + > > + size =3D get_vma_size(ptr + 4 * page_size, &prot); > > + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); > > + FAIL_TEST_IF_FALSE(prot =3D=3D 0x4); > > + > > + size =3D get_vma_size(ptr + 4 * page_size, &prot); > > + FAIL_TEST_IF_FALSE(size =3D=3D 4 * page_size); > > + FAIL_TEST_IF_FALSE(prot =3D=3D 0x4); > > + } else > > + FAIL_TEST_IF_FALSE(ret2 =3D=3D ptr); > > + > > + REPORT_TEST_PASS(); > > +} > > + > > +static void test_seal_mmap_reuse_addr(bool seal) > > +{ > > + void *ptr; > > + unsigned long page_size =3D getpagesize(); > > + unsigned long size =3D page_size; > > + int ret; > > + void *ret2; > > + int prot; > > + > > + setup_single_address(size, &ptr); > > + FAIL_TEST_IF_FALSE(ptr !=3D (void *)-1); > > + > > + if (seal) { > > + ret =3D sys_mseal(ptr, size); > > + FAIL_TEST_IF_FALSE(!ret); > > + } > > + > > + /* use mmap to change protection. */ > > + ret2 =3D mmap(ptr, size, PROT_NONE, > > + MAP_ANONYMOUS | MAP_PRIVATE, -1, 0); > > + > > This is also an overwrite. You're semantically testing the same thing, an= d testing the same regions of code. This is not overwriting. MAP_FIXED is not used. -Jeff > These 3 tests are all kind of the same thing. > > -- > Pedro