From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240F0C19F32 for ; Thu, 27 Feb 2025 23:39:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 94CBE6B0083; Thu, 27 Feb 2025 18:39:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D6BF6B0085; Thu, 27 Feb 2025 18:39:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 777EF280001; Thu, 27 Feb 2025 18:39:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 589506B0083 for ; Thu, 27 Feb 2025 18:39:02 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 05B44A4233 for ; Thu, 27 Feb 2025 23:39:02 +0000 (UTC) X-FDA: 83167342524.24.B8B62EE Received: from mail-oo1-f53.google.com (mail-oo1-f53.google.com [209.85.161.53]) by imf11.hostedemail.com (Postfix) with ESMTP id 1B2F340010 for ; Thu, 27 Feb 2025 23:38:59 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RHtLdmQw; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.53 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740699540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BtvOHIMuelDkAYqCBYw4pmTE6kjO3Q01OuRJQEoDcUw=; b=XuBwoeeLEBi0z9VSQxD65H1VcYUChSUy4Qq5Y01zAJm+qTZgc7bfO50wkW9P67PjCyySii KvbekL0e2GQWKm+vHu80cyUwhcAHvQqtx1a/HGFT5SBNI9e+7/s38c86KT/NxMPr/2gjqh BsROY7UhNNneb6l62pplGhie9UR0ckc= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=RHtLdmQw; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf11.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.53 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740699540; a=rsa-sha256; cv=none; b=lTNVge5yFs2mj3yegq8OyUjhQNnxIIwEzg51DbOkxDVTUNeqA/uipxi5yK7LT/d5/Zu7so 50fvCdF8YG6+yhaaf5DSwoVj2YtZsZlQaHfG0v7aPVweIzbL3FB/OxSBNj5a9dhA5XOHfL n+OHZ6btiqNXfzrm2L05Pivu1OVoJno= Received: by mail-oo1-f53.google.com with SMTP id 006d021491bc7-5fc6f75aa8aso77674eaf.1 for ; Thu, 27 Feb 2025 15:38:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740699539; x=1741304339; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=BtvOHIMuelDkAYqCBYw4pmTE6kjO3Q01OuRJQEoDcUw=; b=RHtLdmQwjXIK/cjThJbUN8/CFE0Gan3hbPXMna6my6NUc41jSTg/16YH1jVYjoRYFM LyLKncl2QBjiRzNS4EX9aI1+C+kb51VTKhKGWnla3LBQGft+39UPw+eisd0rCSxs5EKq VIFnBXHrsNCZiE9w/gS3BHEQ5rzLzTSR+N9uU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740699539; x=1741304339; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BtvOHIMuelDkAYqCBYw4pmTE6kjO3Q01OuRJQEoDcUw=; b=H6tzvhjFoPI15BPHq9nDzmJyyqLteNBwAUd9+LxyHd1h2xjQXPRSxi59OlfHajV1BV vTgBGvJXASX7ibtx6Mu7HvvPul+48r2+RvpS4Mib1I9EtFkW2Ad+c/uZvjxKOYHV4tW6 057hF7iOhhfqnp+RB7qnPv7zKuQ9HbzcTWrdo6iMW9hYosdnVpuk3wSB7F3ffYFay3WP tplPD3Vn4LaKLmXiah8NYq8XfaLqj35TausUm1r5ZePEVT86ArbMvAQ6SodPwfMh/961 ivgB8xi7/rtlnk9zdnTc0NMLfgM6C8gAONj4PCD0BROBCJyxO//umd8DzDZjLNgtMy6A MjOw== X-Forwarded-Encrypted: i=1; AJvYcCVo6Gg3skvoP+ydgmNYrg8FciZoMljL3BvQ6ia1HXlapgA0Hp/GI0nOHfQlmEfqTAPpMJrIim5OeQ==@kvack.org X-Gm-Message-State: AOJu0YzFqBMuMd/HDNXZ/3Lsv7OeKlo2Qfd8MJFm0kXvXbfYwTunwcmf asb2sLNDAot3s9mYV6Y6xQBUNi7s/HFbT1eaFD/TKy+wWx2aJbM0sHO7bdLkZGoT3SpOP/jTLm8 37Y230leMIAnM41PZxwyIS1dVI6NmfAKEVGa2 X-Gm-Gg: ASbGncv+AbuqUQQIEep0m3AIArIM+52lsOHyU7ktx7tx3X495umZ2aq/d12HWLwzrwm cActNQbohbGaciN/ULRFgyeH8g9kKBedH1tiQ6BuDa/nEJNAnpOJ3yxW+cGiwKnD/aQv5qMN1c/ jw4CV78tftpQ/H96crCT8510/Vu1DQ2cfWfRsvWVPo X-Google-Smtp-Source: AGHT+IGa5qWw6mWS9FqBki1tFln20XRNh8F87XAQ33WnPErm38DCBjPn+ns0NBr5sJsRp+DHD4erKnV1oUgv1UGVsr8= X-Received: by 2002:a05:6820:a110:b0:5fc:e9dd:45ed with SMTP id 006d021491bc7-5feb352ea7bmr202854eaf.1.1740699539040; Thu, 27 Feb 2025 15:38:59 -0800 (PST) MIME-Version: 1.0 References: <20250224225246.3712295-1-jeffxu@google.com> <20250224225246.3712295-7-jeffxu@google.com> <20250226162604.GA17833@redhat.com> <20250226180135.GI8995@redhat.com> <20250226182050.GK8995@redhat.com> In-Reply-To: From: Jeff Xu Date: Thu, 27 Feb 2025 15:38:47 -0800 X-Gm-Features: AQ5f1JpI4wTwciE-lKyx_Ev93hW3Fh_Xe8B3FCHbhfxf4AGtcraQIrvmSgrDIxs Message-ID: Subject: Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping To: Lorenzo Stoakes Cc: Oleg Nesterov , akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1B2F340010 X-Rspam-User: X-Stat-Signature: x33nkbm8ked1rfecnnwx8ipbh1bcfjmx X-HE-Tag: 1740699539-936485 X-HE-Meta: U2FsdGVkX18fQWfYOOo4IoolU/mEhht/S/AvdC8qIuEOLWLhjc8/cP6FpBCxbaDaxUR0uDjIKubuqZ1g162E0jebRkXMdNOvdO2CYjXMu+15KCbEQgErTX0nWUrN2Kiw1/fBE4Qk3HxWkp3sOb1sU0PaFOpCA9YR5shd50C7pjEp7ujYWw8XHXYDCDIwovd0RtmL6nuzF9BE1u8xTxWG8XY+OkXEOb0G9ztHy/k3D8hV61/Gg+DvQT5ldbLBm+c+JyNhm3hqv2nK/5VGeu+7lSyBZp5sEuHI0t5uS0sMX3TQwXE0IIwT/2wSEwnywaDYS8v1bdjhn2MPmBEpL6bEKcHmBYWan7f2Hibn6sWhyTQyKwDFwtry99CiGDpCPvWjhOXKeVl6HQalYh2REJV6TgiSC7x6XdCmsbAeWesq/NicNMQo9yJwRFwcR5y3jBqY8Z5O6pOJ1fthlUSoGiBnq3ACFB7OkeP2KQRS27kRQ/V9371PN8u86xT0eyEWcCfasXG7L2Xqwg/SUDTsAUGT2b+jRVTyBhJsAdhOpv5TAOYzzTo9S7zhFee3LE2+8eSQcMQA3Xhc49cl5AMe9kqJsbi7Zbu0+dSjdka81WUXZY55WiEC713zcxya9Fq7UOdlDcvis7wAWVjMqZJVkCx6RpZWkruNr3FRxCI5wn10ASYIE9gVBVuTFfSPaqObmgqe7X19q7JN7smFXWePNUE1tBNtEkmnTlY14EhwCeNsao7gAk5zTrVbT3ciNP+VAlazDm09zFPk4vN3E8y/JHU86bFF0xHlT/UtLWg/RtvV1sOAX9P4hpy39QVU+duKfqh5l6MMQs4VEryxjwE/hNYvopQZDvCcNskI7l+K9NN/spMtM1tyQjtR9VoY5faY8CI7FTC7NgfbLzbpJquN2LSFqJ9jDw8KbweVexI2gXO+mPgwOdwM3wvq8FOAYfInXQwsqSKyp7WqLWBsDirzy+d q9ekutOz qBFf8oNG4Jh0OpvFe5Bkn1P1/KexlJgdM/+WfPOXTWskkyml6SODfmh5Ec9o7VwqGvwTLBDg5qibV2keIfg58Rollrm7bJOfbHh3/rKsi34vFVyMH0e4ISm26mpBQhDSTpFdWf8dEt5T/kmgOF4JdC0tjuv4NIMHntqg2oSqQmKNdztT3OYVmods03A7ZVxHIYggtR59pYXMZWz4bz9v832z8+72mKD56wtHePJQzw/yFnTJZmvubul7U88UZJHbo2afIatIYRC3Ez/pTpLb+5Z5RrzK55tYGk7vZ X-Bogosity: Ham, tests=bogofilter, spamicity=0.148246, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 26, 2025 at 10:25=E2=80=AFAM Lorenzo Stoakes wrote: > > On Wed, Feb 26, 2025 at 07:20:50PM +0100, Oleg Nesterov wrote: > > On 02/26, Lorenzo Stoakes wrote: > > > > > > Like I said, Jeff opposes the change. I disagree with him, and agree = with you, > > > because this is very silly. > > > > > > But I don't want to hold up this series with that discussion (this is= for his > > > sake...) > > > > Neither me, so lets go with VM_SEALED_SYSMAP. > > > > My only objection is that > > > > vm_flags =3D VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO; > > vm_flags |=3D VM_SEALED_SYSMAP; > > > > looks unnecessarily confusing to me, > > > > vm_flags =3D VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_SEALED_SYSMA= P; > > > > or just > > > > vma =3D _install_special_mapping(..., > > VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_S= EALED_SYSMAP, > > ... > > > > looks more readable. But this is cosmetic/subjective, so I won't argue/= insist. > > Agreed. This would be good. > > > > > > Jeff - perhaps drop this and let's return to it in a follow up so thi= s series > > > isn't held up? > > > > Up to you and Jeff. > > > > But this patch looks "natural" to me in this series. > > OK, I mean in that case I'm ok with it as-is, as you confirms there's no > issue, I've looked at the code and there's no issue. > > It was only if we wanted to try the VM_SEALED thing, i.e. _always_ seal > then it'd do better outside of the series as there'd be a discussion abou= t > maybe changing this CONFIG_64BIT thing yada yada. > > > > > Oleg. > > > > Jeff - in that case, do NOT drop this one :P but do please look at the > above style nit. > Ok. > Let's keep things moving... :)