From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E22E9C7EE23 for ; Tue, 16 May 2023 01:41:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F313900003; Mon, 15 May 2023 21:41:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A34A900002; Mon, 15 May 2023 21:41:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16A50900003; Mon, 15 May 2023 21:41:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 07A09900002 for ; Mon, 15 May 2023 21:41:50 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id BF6491A0DB2 for ; Tue, 16 May 2023 01:41:49 +0000 (UTC) X-FDA: 80794416738.08.BF93A3D Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) by imf12.hostedemail.com (Postfix) with ESMTP id F399F40002 for ; Tue, 16 May 2023 01:41:47 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aUHNG7WI; spf=pass (imf12.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.54 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684201308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vOedSJ17V8iHt8KHOe3xnYUuoXUkebVLJNVs3KstdqI=; b=VKNuACX1jedvAkXxd5mzE8OJrGvLGOVOdCLEqLF15v1VghCEfj0T2RRXOh4CKIQnzqfqsQ /6Sgxm5cbVC1RBiBWkj9+xi/O2IKRYE6qg07xD7iCwjzneX9xxbGUTEibwlA+/+y6BSXsp VUkY1EpfPn0CQYPivFE7eAJyqsjRP/k= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684201308; a=rsa-sha256; cv=none; b=WOPtFd55KVTLMWtyyG4Hr9iOMbEB7oBPaEsiW977V0Ix7xm5+KKuXwA2z1eA1HIvk0DR2X dFlec41IN1Kaa48fkRKdN6Ec/OTj4aUZmEOgwL3jGAyw4hWFC23AqwPZPx9Wuc1DyNC9NC DexZ08ZxAagr/iWehargnzxWAIcZZGQ= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=aUHNG7WI; spf=pass (imf12.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.54 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1924fa9620aso5630155fac.0 for ; Mon, 15 May 2023 18:41:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1684201307; x=1686793307; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=vOedSJ17V8iHt8KHOe3xnYUuoXUkebVLJNVs3KstdqI=; b=aUHNG7WIgh65aeOq/mwYfz+62LGweoGA/GHSVSaepQsF8GDMGY5iN4EV+lDiTkP6Gy UGEVeUcU8hw6rh9Sg2yz0hySRiFvwpx4o19DT9lRfptAnEOo0IzYBnrqHN5w6hTXv8jw Xk4owUbp1ktPr+cFzASk8e8UJl+jWZO2bkRWk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684201307; x=1686793307; h=content-transfer-encoding:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vOedSJ17V8iHt8KHOe3xnYUuoXUkebVLJNVs3KstdqI=; b=WB9Y4nbcHVKqbrN4VzWWbwJAMhNYvZDqVwLBZ1dDe4Go43zkv217QKtNTLRw/RVeru wKdN/5H8/1dEafTUq7Z9ljg+heNyNBdxCQihNQLGWMuqoIhMtgMP8FsH5qFDsi+CrpAr 6MzEgpJ/xyJtwcJgKjuupazxhPrqXMztjDrY7Mv+V+PMDiLAASEOu1R0fZhKVakEopZE uRzm79AWLjfpypxyIbiZgxniZJ10G0mez03KNwVImGFiuWE7FBea4Wx1Wj4U2fRpvvjl 4hydtswy6E7UlMDNB+vbpv6sMXqZ+r1LB+qlWScaewZN87yjWJG5mYtgzwXgPBPJUHqR juyQ== X-Gm-Message-State: AC+VfDxr91pSObYEegPvfOiHmym8+7SZikZoiHjO8S+vE/0+o3cP5qwe T4Mtdfo/2+daQaNxZG+GDyKvj2ZK20vZgnzp83zhx8WtxNQgtTI2wkQ= X-Google-Smtp-Source: ACHHUZ6rcT//gO0BfDl+K3mf6a3mSdpI7F1kSMtj1wRAbxCuSDTjM4Co5wJy7waK4krsWK3J03Yy/z+tGlWnJZuPMCs= X-Received: by 2002:a05:6870:e14e:b0:196:8dc3:4e16 with SMTP id z14-20020a056870e14e00b001968dc34e16mr5220391oaa.39.1684201306869; Mon, 15 May 2023 18:41:46 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jeff Xu Date: Mon, 15 May 2023 18:41:35 -0700 Message-ID: Subject: Re: mprotect outbound check. To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, linux-hardening@vger.kernel.org, Jorge Lucangeli Obes , lstoakes@gmail.com, Liam.Howlett@oracle.com, peterx@redhat.com, zhangpeng.00@bytedance.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: F399F40002 X-Stat-Signature: c6383d7rfp619ox9dc9zqgzo6bzehnsc X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1684201307-773985 X-HE-Meta: U2FsdGVkX19pUBRbCRj1eDPjRQuXY5rzzCs2yk8YWzDT2Hx+dOiKoHGqGVX7KYDJ6sb23QKbCuKSo4eK3yp/j9CpFj8WDBTo8AsXr/vZYRFYeuQghVJEguxiur1j2EOLipUqTghny8yDEKYD3mehp5couhXL8AVZRqk4D/0i54v1TKgRPJf4sIhQEnUAbvReHhfWykGGsr9elP7CkuB2aig3komAsVNKmp9CrhHoQPsDRxwiHWC2t48Eu8F3XrjJxEzcrmGnJlNjLS39BCplBHbHrSclQJQuRSIgQIujmXn7NLGDIBfMr5y71rJM868J4mQeMgr8oIT0LDitNDn2v+f/X1K3rvi31QoQMFkH3oBHnKNrBpW+sjVZWsB5OziKpRtkwK0huVfibMnTshUzhiUTa9DzTriCcnzbCHcj18GcNUyr7YS2QMTQ/wL45H4w1pWYsrF/kQHC38CL8376NEP7R3gmDfl+nffV5KjtT1xpgMyBfc5yU7oRQZitXpivB+3g/tP4MjXfm+Aqlip5Hr4qXplIP3UmDKVpNf5+u28THS7Qea2uL2Zw2sqg9mB5uf1ycBBuwXCQuufEZyUtn41Q1Es0ZnhKU2ltazRwXN3JzBxJvV+1HRo+nAO7/96Ghy0OwWHXBY4bLz0/JVUrkXh/O+7tXvakJE15dDUyfIwTb1dU+KfiSEvHxdByH+AgtL4Po9H5QrGWErINmcTLicHTTS5FpLiF03SRT4gLfTVAIlVGu21+QO0CgkRRz4Um7ePzuhi+iXDA/apupzJ4cXvonEnaj6ydUPPxctC8/KLTtvMvbMn/2xgrJQadOwO7bIQt1S3Aq+ktbQcLKKD1nKEK7Hx5AxAElg/Nx9sXkJXvQGWCyp2lB56Cu++Z2lRFtWFRMtzrIXsDSJDwgyBtg4/bifJ8rkX4IQATjbJhS9nyv+8WR6g2uFK0HAWxypMAsSoSYvnR5VF1dbpgCR1 wnxfUuBC awitkR98J34FC9GnSgmq9aGJvcrAwBIy/qighqV9Dz+fOP66LW7Qf+v2n9j1g7U/VxNzV/k3z2bCQ0CfQPjhjHv3DL3IieQYfKZbDeyxLeLXT+zEJYfpOeluayrIPvznhGnUzke/zgMWY7drwp0QIiIjnK/gsAhIujhMn7xnbvv0OGZrvp7bbO74Az6JupukBf8TxSlZT5Etl8mKewNXohmeIQoBfGIlby5Oh5JqCHQakkdJBAty4fNO/FBTVgVoKfa84ittBYG/in5+TKZ7Ew+v98DxZKKtFAdCM X-Bogosity: Ham, tests=bogofilter, spamicity=0.072894, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: + Peter, Lian, Lorenzo Is this related to this hotfix ? mm/mprotect: fix do_mprotect_pkey() return on error Thanks! -Jeff On Mon, May 15, 2023 at 11:00=E2=80=AFAM Jeff Xu wrot= e: > > Noticed there is a slight change for mprotect between 6.1 and 6.4 RC1 > > For example: > Consider the case below: > 1 mmap(0x5000000, PAGE_SIZE, ...) > 2 mprotect(0x5000000, PAGE_SIZE*4, ...) > > in 6.1 and before, 2 will fail, and in 6.4 RC1, it will pass. > > I know that munmap will accept out-of-bound cases like this (because > memory is freed anyway). > > Is this change intentional ? > > Thanks! > Best regards, > -Jeff