From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88F6BCA0EC3 for ; Thu, 29 Aug 2024 21:34:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F14046B0082; Thu, 29 Aug 2024 17:34:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EC4226B0083; Thu, 29 Aug 2024 17:34:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D8BC86B0085; Thu, 29 Aug 2024 17:34:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id BE2A96B0082 for ; Thu, 29 Aug 2024 17:34:55 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5577F141275 for ; Thu, 29 Aug 2024 21:34:55 +0000 (UTC) X-FDA: 82506588150.16.187D56A Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by imf15.hostedemail.com (Postfix) with ESMTP id 79E2AA0019 for ; Thu, 29 Aug 2024 21:34:53 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dnvB6x1X; spf=pass (imf15.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.174 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724967205; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0JtBxizp2xk+cb6j8tpy+Jh/K4VTYG9aTNZKmyMd4xs=; b=nClNRwGHgtIhEKxFK42mb/qC2+qK74AoPZwhYinb2EVoaHeR72jV4SEseVbb4fGvRjxX88 A0KY9dDZ5NyEXNc6OryCgIALcC5+2/AykyFghRzCYI5s7z3q8M1ycuGOEIx27ymnUftCte aHCQJgaJ85PPTeoRdSrvQVhv7UsrkWo= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724967205; a=rsa-sha256; cv=none; b=BCz9cxhMyXQm3vNtEA81BF6bkw+s57zkfkEs2X7+aOkeozjXsfSNZPM4Y372pspOVzUDno wYDWQLpmAbdNtJMk+58uQnB+bSOti4c9MQvcB5PD7Edu7vdROlCzrPxbltoJh4kR2dzaGT 9cb5OHuKRtwB2DFJmujpD4dc1GmYuBc= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dnvB6x1X; spf=pass (imf15.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.174 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-3df0d7734fbso72890b6e.3 for ; Thu, 29 Aug 2024 14:34:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1724967292; x=1725572092; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0JtBxizp2xk+cb6j8tpy+Jh/K4VTYG9aTNZKmyMd4xs=; b=dnvB6x1X62PlXOrGPWEVEJlg5maY1SPGcq9Z+tcTBHZ5czCmf8PbbxElHivpUkcI6U Vl+T2SZGhGLZyv05hV+rwzz7P2FYTkK97YiS63IeWCHdph5vzsY2TAN1MsqvpgEmm8dX 6WJNU0RFtz/4YVpN0nWUHSi2/cl58qI4EHPxQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724967292; x=1725572092; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0JtBxizp2xk+cb6j8tpy+Jh/K4VTYG9aTNZKmyMd4xs=; b=qiM0RXmhbyYZQivRqwHlwnaI+oyDyabXvk2iWvrgoEC1oCUSC5mzwDy2yk+MVb5wKl gnJjtcGHOkf0TvWqCnO4Ke3FNaUVKj8HF4DrDPB/fr6/yB2WiFm57SjbkPAiiC3/lxNQ J57DZizE8uFSu1ub0F2d1XbgxqKETSG0cgKcFYQgnZlS712Yu3GBY8Vpi6EWsNL82Oax IoxAekgF4m5mQRwwzQBpACO2LF8d8fsoVcOEPWywSIr8UwbEuvRpE/nRyTYaLi2+oNhE Auo2Xd2qlP+tYifemcat2dtvcpECgDMs4hGOtOvOgPYKBM9XKVN0S8Om/Cgw86lWI/Ww xuaw== X-Forwarded-Encrypted: i=1; AJvYcCWX8VRsq1f/M9kqkidWW7pfFT9/JQBYJtSmSS9eobNllG931jltvgJ882DQe7Z89jWxg9Kc/VZcLQ==@kvack.org X-Gm-Message-State: AOJu0YypZDvbczipFc7Fg0UgP8VB00UE0yFnGT4y8Yj2kolZaQTz1142 2TnT7WpiDR3DjpVOWoVNE2UMc3OkvaZw7bpNXgPnuzybUSj+gUtszZKef3hBGydW19i/QUQ1sx8 s8gmZmFEDrYMifQ6vhzlUiez3vgwbtFEbJEpZ X-Google-Smtp-Source: AGHT+IF8S+GO7dEufmTmvxbO4vM2RK3AOgSOXWQtC8IWIc2+VslrOR7pjLdfmxtOCWGYxQmolXhTV6/tS12h6+WLD3s= X-Received: by 2002:a05:6870:c186:b0:268:99df:437c with SMTP id 586e51a60fabf-2779008e247mr2378244fac.2.1724967292019; Thu, 29 Aug 2024 14:34:52 -0700 (PDT) MIME-Version: 1.0 References: <20240828225522.684774-1-jeffxu@chromium.org> <20240828225522.684774-2-jeffxu@chromium.org> <097a3458-0126-48e3-ba0d-d7dc7b9069d2@lucifer.local> <5a312d38-4591-47b1-9a6c-4a7242dbe20d@lucifer.local> In-Reply-To: From: Jeff Xu Date: Thu, 29 Aug 2024 14:34:40 -0700 Message-ID: Subject: Re: [PATCH v1 2/2] selftests/mm: mseal_test add more tests To: Matthew Wilcox Cc: Lorenzo Stoakes , akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, pedro.falcato@gmail.com, rientjes@google.com, keescook@chromium.org, "Liam R. Howlett" , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 79E2AA0019 X-Stat-Signature: 9pwb5afihzkfy9bhahhmi5986xtoiytt X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724967293-37590 X-HE-Meta: U2FsdGVkX1+820J6mOmmqBaeIYz4cap1pbgZz5acYyM06ui/cEH694vJ5notry4r8ofHfO1sSC4ow8BrjbIG9eQ+rcYD7tgHj7YaYsUKbKrsfGa9l8ySzcUQqq1wky7kKzbXzZybJQxeatYe6/EQT+RLFZbYSUeDco0LrVy2EaJNudDbIKj3BX/KkDC7gXqlx7C+Ftz7bhBXG/XTkmc/n/FZ8PHYcSPwgYJZKXLmO+6nAIHmROqe/7IevCYxGcldWUAlROtd1ha089WfdfFfIteEQ6UQkG/EcAwup7UcI5QNUzX0/qG3iLXkeonco4Bq4UbZkGmEyiWsDpcSqFe5gxcXEhLM7CNrMlSfQ6qU3XFz81QLoBlllmzrG2pYgRcQ4vKYdG0rMCYFCgAYJZ9jLCPt6XZPlQtO7c3FhUcoCAOgl6KFZFwpu7hMAj7dB+W1LRmDHO+duxBoTpG3qQSkQbe/InilqlAx2SJ2RfxyzVSQtI19NDkwr/8tYKER95mzUv74Uxh9VUouxD9bOSVPAio4EbAa8Wqfuwm51DsBKdHtGk5cabz+ShoylXd+aXz8DNptGNm44poUFI5SH9XUw3UMvrJNHo6rLwn9FWZmmayniERQTWXAfDR+dsvVbO43D/Zuvn3CLozMccarFTnF2ntmyvyFr6O2IHzXr9rOt7VsZ0KRP1gop/SRPMnQya9Mbbr752SMiXAuHmyTv0fJXhFN5GiuUX5dUExmVRiW3u+05HnhMmWA+UtzqHZ3YtVDzo/aCagBGoUH615Xc/pFUsPjnqtWAGi5u9yQ5fxcLXywsNVcwUyoUVAvmC0c/gCxuDOeUH2AkDeGXzoObbEZxE9Fy06pG/9pabSC+pQWt3qWqZnsp3nHNXFvqsVl024RJTm5OMbzq34a7JOfzrzWLlGZhTyRirdt6SigfOErRqCbZASERtNCdjCnPLWjcZBImcMIva2NBB11KDs6UsK h/W27pwX 8C0rMYDMSN21C1z19MdNYN2PoCf57YcsXKyoNVLX1u8ioAEnMhaMFcB7AN5AbzI7bKn18bPkUsYYq5GzRrl2RdF35J/NITs6c+wJAOsd9M0b4KwGwYPgrb1kpxzSDltGOFT3tU4y9lC0hGArwSEnZw0UHMOB4NieE3bTELOkyzB3XUONjNG0J74yC2nMOpjHvCNGrAUzZoWfP4cHgbpz7aTp7DzrAivDGvL1TT2Lc9jzn5aCs9u283ou85Ay5t+LA8muY44HGdcudzrvDifdC1FkBh7OdVIzG04rdAAxF9mWMTaCUY5sRlDTo6vM83mBTVjgyJDCNfTG/vIWa3R9E9dzzE9dr6Dph7kD6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.001879, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Matthew On Thu, Aug 29, 2024 at 12:58=E2=80=AFPM Matthew Wilcox wrote: > > > > > Can you send this as a separate patch, preferably as an RFC so we= can > > > > > ensure that we all agree on how mseal() should behave? > > > > > > > It is not an RFC because it doesn't change any semanic to mseal. The > > updated test will pass on linux main as well as 6.10. The increased > > coverage will help to prevent future regression, i.e. during > > refactoring. > > You seem to not understand that there is disagreement on the semantics > of mseal(). I mean, ther's been a lot of arguing about that over the > last week. There's understanable reluctance to accept a large pile of > tests saying "this just ensures that mseal behaves the way I think it > should", when there is substantial disagreement that the way you think > it should behave is in fact the way it should behave. Be prepared to > argue for each semantic that you think it should have. > If this is about in-loop discussion, this patch also passes the latest mm-unstable branch which has in-loop change (pending Liam's fix on mmap). The increased test coverage also helps to ensure the in-loop change's correctness on sealing. I'm not aware there are other semantic changes on mseal, we can continue this discussion on V2 patch, if necessary. Thanks -Jeff