From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE361E77173 for ; Fri, 6 Dec 2024 19:53:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3F0B66B02DD; Fri, 6 Dec 2024 14:53:30 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 39FFA8D000B; Fri, 6 Dec 2024 14:53:30 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 267356B02DF; Fri, 6 Dec 2024 14:53:30 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0803D6B02DD for ; Fri, 6 Dec 2024 14:53:30 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id AF6BD80244 for ; Fri, 6 Dec 2024 19:53:29 +0000 (UTC) X-FDA: 82865583192.30.581BD49 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by imf04.hostedemail.com (Postfix) with ESMTP id 3F54C40015 for ; Fri, 6 Dec 2024 19:53:09 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TVylK5yW; spf=pass (imf04.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1733514791; a=rsa-sha256; cv=none; b=1syrgb136NpMy58PpvT+CNgjBOVJNGdZrV/L//gyr26TurxvET583bK9DFWOsvdaVkVjTm Uv0Qt0CtX5/Ro8n+u0fRnmGCVUdjUPFceflttY0xg5XJrv5ah3iZvRo+yabLXg3eBm6V56 wkH1OrYeClQNsSb5GaelCopucqT2gaI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=TVylK5yW; spf=pass (imf04.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1733514791; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kD0PG/Son46c2udECUUzy+txrtNMIZH1gjXmstMo4Js=; b=CknYpntIpvYk52V6QZPEn57b0/y50h/Cm6bV2P48PHUP57mpygYior+jRsejh3eGRsHm8x DCY6hfkHcw/0fQHgmQa+sHJrXLhml9aHUhRpeQCubApHfkj0O8JxpBdG5G/YKqYDTUwCH8 NJ/EPYbB4G8aQNX7vXH21xlChH/HdJg= Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-29e1a8afb6cso324647fac.1 for ; Fri, 06 Dec 2024 11:53:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1733514805; x=1734119605; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kD0PG/Son46c2udECUUzy+txrtNMIZH1gjXmstMo4Js=; b=TVylK5yWlCPSoseJffVCuo6Bf6pqqlbNXTI2LQ6+LShlogzYcvEUVrVfxMvBYcMPCv Aj99Q4rHYMrwNSsRLWiwAGBZVPYVVBaTveemasczf2FmiWKEM35BXX7vrWjctyvRQkK4 NychmTFsTUCk6qa/APweZEmuhMdBjsnfC9xtA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1733514805; x=1734119605; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kD0PG/Son46c2udECUUzy+txrtNMIZH1gjXmstMo4Js=; b=wQ5U4QIDEKvRZzbM2KXnrmhhnRAPtbnmjtc+6bO047rSfiiNm1Nkn6XpfmaQ8HNyc+ yfvUtCfB1railXsJfenWnJwMC9Y1QE5UpT3+EDRVMnH26a0gYOn6eDc53CkYhr1bwTzG NhfVLSkS1Q/aSy1B+vcO+tvbnZdzHnN4uROVm8Xj7ktRqW7L6IvohLuut1EJxQxPrwTm AOxAQlQENpy2GQJqYI262QxCU/hgS77lBJVWfavpWYRJcUSFeJC4R6Y1ZBmSGA2FiteV p9TA0fdcGdvZVOAKi2YAmErSSBTiw2agVygaekb5u2jY8OzNs6rKULtlGmpHlFJiilXP FdmA== X-Forwarded-Encrypted: i=1; AJvYcCU4A8/dnxw5eG2Q6lLpdHlMx6V4kZ74KrWnRD3P4C9CfVmJiTzf2uThikciPUbnZIXvAS7pqyjTMA==@kvack.org X-Gm-Message-State: AOJu0YzWTAbGPun9JcKHWrOXz4SrdomQyRIZdjNyx3x2TYzfJXH1Q5Uf 5jqCoWDJp9Z4zIJbGrN2XNH/FopBAQEvgH3eXSKQNf0VGCLZZaj4N6W2NlwOia9oDG8zVU/HwrW Pqf55MAETNKDjFXHQCiMxXzHLYPFkbioAUxoc X-Gm-Gg: ASbGnctOxKiL+01D93YIOdyy2hRytVNASfFl+hmIh37UfrAr9EIIWdcefQzEjQ8p62r 0wJljJTkINsl0Mu/MwsjZNFwNkw6MK3+GxZpPqR9HfHhShzUvodMAqm5ncZg= X-Google-Smtp-Source: AGHT+IFSeXugZN7WIOwQr8YQLq8LU3bDv7Zj73/Xx2iLMaJeWot5Rr5Xvi0Wz4axw+70GUka05MUK/Yl5vgeFS0FbSQ= X-Received: by 2002:a05:6830:6586:b0:715:7a24:32c6 with SMTP id 46e09a7af769-71dcf6c2979mr910230a34.6.1733514804898; Fri, 06 Dec 2024 11:53:24 -0800 (PST) MIME-Version: 1.0 References: <20241206193309.3026213-1-jeffxu@google.com> <456abc34-9071-46f0-8c70-62377484dbf0@lucifer.local> In-Reply-To: <456abc34-9071-46f0-8c70-62377484dbf0@lucifer.local> From: Jeff Xu Date: Fri, 6 Dec 2024 11:53:13 -0800 Message-ID: Subject: Re: [PATCH] mseal: remove can_do_mseal To: Lorenzo Stoakes Cc: akpm@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, keescook@chromium.org, pedro.falcato@gmail.com, rdunlap@infradead.org, Jeff Xu Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3F54C40015 X-Stat-Signature: pg4gsbkt7eekgyk3rppf15ygqnib46jc X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1733514789-657814 X-HE-Meta: U2FsdGVkX1/SJw18G9AmOlMvJpItg8rna4KGC+2G5p3bumLIzk9E8KiNASGGh6kep9kC9Ba4Y1fm2Ll2YOhcPS8O+uSj1140/XEEFzy0Lzak5zeeYxDPdBlTaomBoJKJkuwAzSuZiU9wtyqpEKMPiiRuJc5Isw3OYqwmk9avPpXC6aIgMuOcfV0u0agtq6rqz/sSEmEtyuzSdcBnT6O8FcvD4x6YxSbrVzqEDTKx/9UgDc/8sQ49BQKjTQBCIXFxQUHhHAiC+2KwmK2Uyhc7UjrVL0211vmzEl+gKYpvq/xQmnfNjMhWfEflOr49dZoE1zMrzWcXrOxAIO1auSzE4gWAjLAy7y3knv5u6v8PrswTSuDQsXzge0+NO/07C43gRXsZ7Kc4eq8BxVyq8yOQlFCMMRb8wASqJZ6hVl+xze1XxrCRDXvpR4PRw4WsKAUqVvy88zYEEWVDsXfFo4VQRG4bJnFB1JgfCOOnMBUZjS1ceD7p3UIn69GrfNuPUcRiQk8FyW5CqNjTrKOGABT8P40SeeOC5dPBjbNZ89j0RDlBl7XMaCT4GtmqnJEizHBhs3sGzpcE0D/dhj6cs01QhJ0vwUhxGoUXeafZFcV7c8oc1ep7e7Vmm2w1mjS39m3narV35iXCB+6Nvlh0gHOUKb0XEFic75dO7wFImntxSdNeSRE4fsfpcTWNDlggzXSG04OLU0Kef9GQqBAhjBXnnPusgWnY28HtDP7Exo5CLqwtUFpBG8HB3f0vdFIDjDCWKT7dCKmQBm4MrMZkuglKsf3lt+/ZzISHkAuE+gc6RHeOrjQ4/5ISDOQkMV8Zo4g4GMXMffqgPuv04q1TyHIJ0QsHr304CXqYfFhEtPhp9m9NNYduMC5xqiVstkHLEmFQi51ncyT6ogoEEG5AU121uR/VRiWa4ORFrwrAA5mWsGq2uYR2XRZgYUGIah2Tjp80wbOWpH3OVPrcudew1s2 Kf1KYs3z DUOIyHBJOzmH9XRwsSeNiZdrlRGuJy/+4sQp+Y220g9uxYrnNUkZgTDMzlS19YEP7GU5edvj/owWSxbatgCmkJAR1rzVrSYu5Wbav4AaosV9m0OaxzNivmjbDd5WSrseEGQmp1wlpme9xwA7GjyIRq0eboPkyPYISJuuh1TRom8gitKZgYTYykCieOq6kp5BJXPo2qM2Hn9tVwx7T3f8fJaLnLxOEvhwpUlGOWQPLjedN4eWti8FP8SY0Eebod6X/vHtJ5z0KLzzlRROP4AUUZAHWP30ESWD9bV39HTKrZ4vtL+cKYTMugoFeBFBs04hrTbgSaJ6jyn7PiTpyAZX1HcZmEdDUH+NaHzDGZpeolxnTldk13FOjMWTkm/+0kK1fP2b/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000252, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Dec 6, 2024 at 11:39=E2=80=AFAM Lorenzo Stoakes wrote: > > On Fri, Dec 06, 2024 at 07:33:09PM +0000, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > Hi Andrew, > > > > Is that possible to squash this change on top of > > "mseal: move can_do_mseal to mseal.c" on the mm-unstable ? > > > > This is the first time I m doing this, because I saw dev did this befor= e, > > and saying this is the prefered approach. > > > > I could also send v2 which is what I usually do. > > > > Thanks > > -Jeff > > > > Signed-off-by: Jeff Xu > > Hi Jeff, > > Fix-patches and the like are usually for stuff that's been taken and this= , I > don't believe has (I might be wrong actually). > sure. > But anyway, as a reviewer it's easier for me to deal with a v2 in this ca= se, I > am not going to give tags to the original version of this and want to mak= e it > explicit I am only giving them to the corrected version. > > So from my perspective could you do a favour and send as a v2 as it makes= my > life easier anyway? :) > sure. > Thanks, Lorenzo > > > --- > > mm/mseal.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > > > diff --git a/mm/mseal.c b/mm/mseal.c > > index e167220a0bf0..08e6f328d9c7 100644 > > --- a/mm/mseal.c > > +++ b/mm/mseal.c > > @@ -225,9 +225,9 @@ int do_mseal(unsigned long start, size_t len_in, un= signed long flags) > > unsigned long end; > > struct mm_struct *mm =3D current->mm; > > > > - ret =3D can_do_mseal(flags); > > - if (ret) > > - return ret; > > + /* Verify flags not set. */ > > + if (flags) > > + return -EINVAL; > > > > start =3D untagged_addr(start); > > if (!PAGE_ALIGNED(start)) > > -- > > 2.47.0.338.g60cca15819-goog > >