From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D8CCC28B2E for ; Tue, 11 Mar 2025 21:54:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8FADF280002; Tue, 11 Mar 2025 17:54:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A8F1280001; Tue, 11 Mar 2025 17:54:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 74A8F280002; Tue, 11 Mar 2025 17:54:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 56256280001 for ; Tue, 11 Mar 2025 17:54:51 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 055A71406A3 for ; Tue, 11 Mar 2025 21:54:52 +0000 (UTC) X-FDA: 83210625624.09.00A8FC0 Received: from mail-oo1-f54.google.com (mail-oo1-f54.google.com [209.85.161.54]) by imf30.hostedemail.com (Postfix) with ESMTP id 20EC080005 for ; Tue, 11 Mar 2025 21:54:49 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=STiLF2K5; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf30.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.54 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1741730090; a=rsa-sha256; cv=none; b=a3nrvfucLXytoInnlXIREZtEAdUKjNeoQo088b60X19bQdZCLPa9L+PhE5bCmGx/0QIGl/ Hn6l9bT8Y2pfMdmX4q/2sxg8JJl4xSyC7YCceZ7XElzP/+PGD46S6anOhNCaieOh29AtSC AC+OXwPjeAGdd8v8M+NHtA5K2ghLPW4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=STiLF2K5; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf30.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.161.54 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1741730090; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZqtLjg1DzXxI0seit2K5+J+AUgYKo7ZSLSErJeqONSA=; b=aUaHRNJtNcdzTWtHn3KtXTSTHG09u+V5NpLoVuaLOx0m8XH47mHQM/3RMsVHRolxuTAfoY qMO9ZlYGl3PtsfRQ352bBFBzX29E63Nx4R6ecqdpCtJre/IpYW5AF2kP4DIIJgtmPXiPUO pK3qOXWXiZ+fLFLB3DT0tcKOZElQYPY= Received: by mail-oo1-f54.google.com with SMTP id 006d021491bc7-601c848abfbso102367eaf.1 for ; Tue, 11 Mar 2025 14:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1741730089; x=1742334889; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZqtLjg1DzXxI0seit2K5+J+AUgYKo7ZSLSErJeqONSA=; b=STiLF2K5kDdIgcH04qDMWBKArpXQhw1PLyN7ijsxwUqggC8an/Zt+q0CT+IwU075eq 2c+jg78RpwcdYK+iuYp8ZIuX1P266DCmj9vz8Qz77sDNZhy4PPLpyebQeX/RWRqV+zjf 9YHypQdc60r234wBiHaxi90Ows+ELBGsGs09w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741730089; x=1742334889; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZqtLjg1DzXxI0seit2K5+J+AUgYKo7ZSLSErJeqONSA=; b=Xm7GPRYIlOHTCDfIlD0rk3e6SZfzCTboK1/k+u1KO0shIx1lsaQdQSPLXioeDjjAWS AIxLUIV7ZXh18G9lAXYE/qIcvAbImmyJ/ODu02qZPmJjTuq4IqjZoQ3FEPAOqO4PocgU yqFe8aEWtETIjJswUsWhx0L3FzhY2+ktq7uzxWw1Kaxh8dZdtcItdCCuoA8F/aRlwAOv EG4f1c2RSgvPSdYj5BcxSODwA6kX4MtujEIwn945GKFTu9QZvxcyagJhLX34LfMY1A5+ vtwrXB/XVVQpDzLVYVJBZeJjn8ecHTbfqESpit2s3ISTWTB3Y8AHkpB0CKLNfIJAMsdF EHHg== X-Forwarded-Encrypted: i=1; AJvYcCWoZE4e0ZOLiWiCksEo2Lna4z0fAWU+KLTieXIAcqgIHWf1N4jDx4hlNEBreRKkkaEUK/WeommN7g==@kvack.org X-Gm-Message-State: AOJu0YzFIXD/qmmLYtoDO9XyzkCRXe085vvrgM60Q+M2d7xLISHT6J4b L+YpH66WvDfWtX93vKaqpNdrXNK+s6sUXkWZPvZSktbTzN77dY9tjo60lJJgSdgBS0ofI3NAVHi 5917fDdWhvTm1Atr8NuDXpjUNLwMLfb/+0TCj X-Gm-Gg: ASbGnctb0RF9eJadanSOzoG1lqxOXJ7GF31Ie420UIP2WxVBBcv2Xr1yUfh85do8NX7 S/N3CxuC4qo5CTbmhB7xLxD99E8v/FSx0C9y8SbsceIfuH4W++5ar0ibm7POZo3fs3XE5dVM0VJ tk9JLfggqHA7wcgubd2Tns9Hzj X-Google-Smtp-Source: AGHT+IH2IPSslGXs3S6U3SZyEjhufps+FOgJ4MI5DY7Uu+/0+4vI/knID5uO2tWz7qPzGa2aOnkdzTN2mj4h7r9KJSs= X-Received: by 2002:a05:6808:228a:b0:3f4:1be4:b1d4 with SMTP id 5614622812f47-3f6a2b39ca2mr2959328b6e.2.1741730088963; Tue, 11 Mar 2025 14:54:48 -0700 (PDT) MIME-Version: 1.0 References: <20250311123326.2686682-1-hca@linux.ibm.com> <20250311123326.2686682-2-hca@linux.ibm.com> In-Reply-To: <20250311123326.2686682-2-hca@linux.ibm.com> From: Jeff Xu Date: Tue, 11 Mar 2025 14:54:37 -0700 X-Gm-Features: AQ5f1JoHdL7fy9WOBHHtsPNXX2PhdRPHU3FfnSh5XG6auVNGW-V5IoHWDbRycD8 Message-ID: Subject: Re: [PATCH mm-unstable 1/2] mseal sysmap: generic vdso vvar mapping To: Heiko Carstens Cc: Andrew Morton , Lorenzo Stoakes , "Liam R . Howlett" , Kees Cook , =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= , Alexander Gordeev , Sven Schnelle , Vasily Gorbik , Christian Borntraeger , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 20EC080005 X-Rspamd-Server: rspam05 X-Stat-Signature: o1e4ctikk6zzsbjjnqeyfwishecq1tfn X-HE-Tag: 1741730089-905023 X-HE-Meta: U2FsdGVkX1+WWw6EsU44pC1NJMnPGqoZFqCGfNzyMyLnHXJzx8QciM72z6BpKGcZC9b9pzKHKL7SkLFpuB0hFqgviEw+YT4kuHn7aooeoabB/xjXDepqEWQXafEQb9wxhp2m72U1HKt7Z9iUbTAjeRu7F6a+TOVS+PsCCxVqofPWK91e0x0jMTBMWIaVLs3EgsD4ZvFYoYnJbcRiJS9Qkgnte9XpGf2YGu7bhEE8IMbAtk3wU+/i1egdCQNy2OOIQUQ3oKC5zHkxpyh1yeGbJ2tEShetbZikzLMYLKKkFZQByvlKFWk7GGZCAuPhBeQxqr1CnfuJFtSyXPvo0Szq6ZXKC8e8Hd8Xov4B2ywuzWBmWc7Qx008QlIhwOUHbNU8MSJE7mQdulsEovDbvDiLAoGuhouf1HJU00BtXgExHjXswqkqsF28HwzxqajfE0E8xjuGcMhFp3t5lSLuJrRl2tqKO5X6RVJvnaWLtldqXsHm7HrsJVRovbrMkT9a7yUg+UOLQJ4eLTwWUu6VRYoi8OUE8IY2UW0QGQknfGifc0SztycxUCoaWapd5bYBQGRsXF42z7qcUa2pHh1n84j4zk7em26JaLi2In8fBDiKryl70bNh/LfbGQ+xazmdpaX8R2qucmgL08S4uD5qaeEQv6KFsXDb+ovmaPpKCW25lVkATe1WBO1iDMDYsW7IWfXkZ62wk1+R/3LIdgzTh7TBlsVdGrtmGiBSRFoC9ICKB7LEyTdNfcpomxZcfa+fFJddetcblf97EnUbWZtM5u1rt15HtyXa0UAdoIXDY+GdVwlgBGuIGkyz2cT/77EqizPmfMIVvbJ0gpITGdN3fdqtPM5oYR3CJl7ed8dXH88Az+T3O9mWYCIVIkisS/JgnGE8VPPq69y5J4tco75Ri47fqIpDB8qeMPpLofhgBqUayTJZlp0f1yyUqSPYOXE+6505xeUnDK6ePcttMYAfJkf sxI/QRBQ vGC5tpjaEMMk4A0PFaSsu9Q7KdaGZxdrNms1xeo+6nHcfQLe1/8jyFgW8NN3AQsvc/4ngX5Q5nFdFI220kxb+oalJffhj6uER4FY6qsHtzwTlsatqB8MI/jLN+9hspVNlQGQ/tI8tPvSEubu4jOc1rdxcKJpD/kVgC3kCJ1q/rZfQWPR1RsaKo63XdfW/DxIpPZOf48k4Von1ewOFtfM/xhwkt7fzQG90wWki2gj6/BZRwwfC1VDrhP2c8/WkaB3HXCzkftTkDwxdukF3aHQquMxjLMfwDQxejoHH X-Bogosity: Ham, tests=bogofilter, spamicity=0.005521, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Mar 11, 2025 at 5:33=E2=80=AFAM Heiko Carstens = wrote: > > With the introduction of the generic vdso data storage the VM_SEALED_SYSM= AP > vm flag must be moved from the architecture specific > _install_special_mapping() call [1] [2] which maps the vvar mapping to > generic code. > Thanks for fixing this merging problem. The new selftest in mseal_system_mappings should catch this :-) Hi Andrew, when you apply this to mm-unstable, could you please insert this between: commit 5bda54a4f304a7c3d65a40c9c3f015901caa2ce6 selftests: x86: test_mremap_vdso: skip if vdso is msealed and commit 884323e928c6938923e5dfcb8a601b3363e1130b mseal sysmap: enable x86-64 That will make the series complete. > [1] https://lkml.kernel.org/r/20250305021711.3867874-4-jeffxu@google.com > [2] https://lkml.kernel.org/r/20250305021711.3867874-5-jeffxu@google.com > > Signed-off-by: Heiko Carstens > --- > lib/vdso/datastore.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/lib/vdso/datastore.c b/lib/vdso/datastore.c > index e227fbbcb796..b7c7386c98a9 100644 > --- a/lib/vdso/datastore.c > +++ b/lib/vdso/datastore.c > @@ -99,7 +99,8 @@ const struct vm_special_mapping vdso_vvar_mapping =3D { > struct vm_area_struct *vdso_install_vvar_mapping(struct mm_struct *mm, u= nsigned long addr) > { > return _install_special_mapping(mm, addr, VDSO_NR_PAGES * PAGE_SI= ZE, > - VM_READ | VM_MAYREAD | VM_IO | VM= _DONTDUMP | VM_PFNMAP, > + VM_READ | VM_MAYREAD | VM_IO | VM= _DONTDUMP | > + VM_PFNMAP | VM_SEALED_SYSMAP, > &vdso_vvar_mapping); > } > > -- > 2.45.2 > Reviewed-by: Jeff Xu