From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 763FCC0219D for ; Thu, 13 Feb 2025 14:14:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCB066B007B; Thu, 13 Feb 2025 09:14:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D54AC6B0082; Thu, 13 Feb 2025 09:14:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF57C6B0085; Thu, 13 Feb 2025 09:14:39 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A552B6B007B for ; Thu, 13 Feb 2025 09:14:39 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 13EBB161066 for ; Thu, 13 Feb 2025 14:14:39 +0000 (UTC) X-FDA: 83115117078.09.A31635F Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by imf26.hostedemail.com (Postfix) with ESMTP id 271CD140008 for ; Thu, 13 Feb 2025 14:14:36 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gxSRkaux; spf=pass (imf26.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.170 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739456077; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KwgMpUGpPt83uP2kmDr1SGqVNltXn8RoI5FSgDbOZyI=; b=xG7fk54c26h3eBB/6sEnILi/e69rYFXcCzyiv8V0R9tj/tFcPPS5qJzyr/PprKhNuOGWRi hQHZ3PJwmdD0su9KZYyjW/UkcW5bbGMFMayl9hPyfOLgSSJUy2kBF5QpMcVDKeumSpYUEE 43UvvkBDVu60SsX/+NcjdBv0RCwLku0= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=gxSRkaux; spf=pass (imf26.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.167.170 as permitted sender) smtp.mailfrom=jeffxu@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739456077; a=rsa-sha256; cv=none; b=E8Xj2IAIYxe1B7mGZHQB/KJvC7TAUuTxjz7mqmU4q90W8h85LIz2WYOBhtmbx8bWpuhDHi DRUWUqNNYEhFQl//aBS+iKCYHbihhC37pt+J7JWRXwmJCoVVlNJuqN6dmygXn33P3JmzX9 NYW0nyn8MkzKdlbn+m7ASmjGo/7Y0Pk= Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3f3c9c1edbbso18865b6e.2 for ; Thu, 13 Feb 2025 06:14:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1739456076; x=1740060876; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KwgMpUGpPt83uP2kmDr1SGqVNltXn8RoI5FSgDbOZyI=; b=gxSRkaux6/DdVl7n5F97AbKfk9RhWiiWqzA4Fc1g+KiRMRNgeaY62bEl9qYnmQknHD MMrcvAsuwrczBlyIF1MnLDG4QR7SvU6yfZhSZNbHVJsTuTZvxw5gpRY7SlGJUS/+qiNR 72oBWRu48b6N5d5u7pj0yCL6iH5WnN/TEUTF8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739456076; x=1740060876; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KwgMpUGpPt83uP2kmDr1SGqVNltXn8RoI5FSgDbOZyI=; b=XS4jG9unUQWCtimCw4hL9LUb4TYzOafV+mbtjRo2sOyLdak8q1XjAHUnrlUMXMTfdM O+J5EXRbc8iVD8Ht+uH5kT+9v3FCr7PEJ3TmYwFXokK0CyJm3WS7+yx+/VzmDtKyDnpt jIEyTkw9Fk+POzBAPe6zH0zAJKTj8NI6vJiV8gWuqcjGHAS/8CQW/NQo+PkxvlLXloHj ySBObSnsnbpBRKjijzm11By++Ukm6DwJn/zUAQMY0YltBpdWnSeyG0Qx/qvmOv40dy/T ohiXH9sxkmA+OpARqhM2POeupeyQTH2ikf31Udkt7ICuxEpc4mqLssxs0CP56S9/ObiK O4vA== X-Forwarded-Encrypted: i=1; AJvYcCWWPLhqGtImG3dGhsQMNdzLcrVUihxGZKfTE43G/FAARIU+IAIPmsqchWkuwJ9PgpCPpRWceWx2hQ==@kvack.org X-Gm-Message-State: AOJu0YyGaPnoJAIDT1nvWfSU20hxGENbBp6b7KKW68hyMGD6Q275vdz7 BSqEQXnw+CB99KsV3b3lX52P+XqG5Yox/ioXJo+HEpwfoCz5n3pAipZX7UOO+SGXhptnFYA/+Zd /w9Rj+j0cDWG6qUpAkGaZrw/hdkZbktihL0Kf X-Gm-Gg: ASbGncuEZro60bSwzXcxP7r/geaLPKZPi2/s2K0NtYYMmTL3U4ZIGRroVP/k8Or1++0 tt9cmmkA0Pn0VhC6Y/pzLDl/AhLL3qs1F9INzHoap1pv9xaCJOlkWWgkaDGelV1f4bWNCtjwd X-Google-Smtp-Source: AGHT+IEtNnqaFNM3IFYkaevRL1voz6bW7MV+eHfloPEq3p2jBFOfznRwaq9+4MhkBWZc8DES3xDKYRxboQlSxD5GRww= X-Received: by 2002:a05:6808:189f:b0:3eb:6849:e89 with SMTP id 5614622812f47-3f3cd5d31a2mr1761716b6e.3.1739456076093; Thu, 13 Feb 2025 06:14:36 -0800 (PST) MIME-Version: 1.0 References: <20250212032155.1276806-1-jeffxu@google.com> <20250212032155.1276806-3-jeffxu@google.com> <20250212135000-861e6353-6e0a-43c3-9b28-649ae4dfc607@linutronix.de> In-Reply-To: <20250212135000-861e6353-6e0a-43c3-9b28-649ae4dfc607@linutronix.de> From: Jeff Xu Date: Thu, 13 Feb 2025 06:14:00 -0800 X-Gm-Features: AWEUYZn6agI683FCVewtEvJCU-TMhKcDzUvXDlTokG6FIGxk-prLy1E5md-55vU Message-ID: Subject: Re: [RFC PATCH v5 2/7] selftests: x86: test_mremap_vdso: skip if vdso is msealed To: =?UTF-8?Q?Thomas_Wei=C3=9Fschuh?= Cc: akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, lorenzo.stoakes@oracle.com, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, oleg@redhat.com, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 271CD140008 X-Stat-Signature: b5wkywow1p9g9ce3c34pkx6isgkcz3su X-Rspam-User: X-HE-Tag: 1739456076-872962 X-HE-Meta: U2FsdGVkX1/GctFL41hfYnVB3u652yFdg1wBcrc3U9hiyZOoVtUK1aS6JDFrcBcoLiZt1OkJPDifXJhHBklAq4OJ5o2GqErgQmR9B1C3BE7mpFSc1JLqmFJmSgxTEnl8B0jeXlj47s/LGkd7ka4TaL+fm/8mUHIbJFnVyVP0ij+Y5aYTW1Mo9BpXwKKpMzkZh4V5Z4k0qP041oxplRLON6YliltSmVm/Gi9LmUoEVotzM16USNoQRmmSiEqoFofOxdrUVI+Co8sw4iUcuq9yxAcvx+kEYs+0yvb4TvxNkyMHrotBRV/1htth//9UvkMueNx0wVk3LPzcBeNJbiUFXyA2IjQ+p2ub+Vjmwa+Nb2+Wydji7KU1KuJngTg8AoQTGvLZnj/8oxuFad0ZN4MQ7DBQC07AM/M033md46WeVcLL+T9/McSveltZaTAEWId4viIepTbVTzFE2v9eqn1CoomLtK2PMN3GXJrg3xFj+uDumkrl5t00qR2vdInl7LDPhaz4In0EuIexSrHt8vx9HUPVcaToryBQcQP1gdK9dXj2hSMtNcGPUzHw5eHQqrerZilmtS83Y3h9UXUUE+Yk7w/h5K9s4xqC9Kor3hD1nG2gG/kHvZN+EUKZIYqD3HtFw0BOWZ7nQ7DBWGj79ILGpLC8D5FmitFSkis+655Hggpq2SfZQzXyixTpyD6ZxrRkjSXe2Gmtzp6VpzwCgJzawk7fuCEplbzQduEL+b0uJK4ZgNffm8+sko2McaWx+tfRsSfrgwP/TpmxqhHFePI1G/lqVp126lJpLw8xmtHX//SBa8g4spMDVQIUW/pPk1Ta9bHjYSQZ03GoCCz2ZGaIuWwsGN+l0zwPtkBr7aliuGLXQnQz4+9yokzeM1+z4pqy8j2vBGOGEvQnd48+D9nYY4khgod8abZ6rfUrDlQaY8dTBqMjpqBnhjRYV/Y6ZuzTxbdOc3Ab+ACN4K3IOZP ntT2cUok om0H5iH5QctIgh5bJSh672X/kTxtJJvyIL4B5WZyVOTFNY5CWF6qSQ6UVd1YIaWCe1NMUe2g0bcNjR3mMx5CYZ1ETGfyHTyXtZ/y8jVGksQpH4y6ih7SjlWfCcNwfqJ3pSwCpg/t83kfDEXuiKocs/OwIKdEqxR1GwU5YjJiPHRtenYaP8ij6+k6ORSq0jIoE0uVemG2z3GhH1vuXCsU30dc1vTyQaCS4CMiNntSauhIGDzJ7hefV5h63uweYgbCI0bHdGHYUm6KVVe3boT+4Tao9QvFSuKI74Q/YbJOVd2SbGaO40ddRWdpfe4m1fVU8qb64eyvi1MadnyEa2Ege9/frGjhr8flBdFkKCxeChBe3DFZ9sbgHwuoPYw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Feb 12, 2025 at 5:04=E2=80=AFAM Thomas Wei=C3=9Fschuh wrote: > > On Wed, Feb 12, 2025 at 03:21:50AM +0000, jeffxu@chromium.org wrote: > > From: Jeff Xu > > > > Add code to detect if the vdso is memory sealed, skip the test > > if it is. > > > > Signed-off-by: Jeff Xu > > --- > > .../testing/selftests/x86/test_mremap_vdso.c | 38 +++++++++++++++++++ > > 1 file changed, 38 insertions(+) > > > > diff --git a/tools/testing/selftests/x86/test_mremap_vdso.c b/tools/tes= ting/selftests/x86/test_mremap_vdso.c > > index d53959e03593..c68077c56b22 100644 > > --- a/tools/testing/selftests/x86/test_mremap_vdso.c > > +++ b/tools/testing/selftests/x86/test_mremap_vdso.c > > @@ -14,6 +14,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > #include > > @@ -55,13 +56,50 @@ static int try_to_remap(void *vdso_addr, unsigned l= ong size) > > > > } > > > > +#define VDSO_NAME "[vdso]" > > +#define VMFLAGS "VmFlags:" > > +#define MSEAL_FLAGS "sl" > > +#define MAX_LINE_LEN 512 > > + > > +bool vdso_sealed(FILE *maps) > > +{ > > + char line[MAX_LINE_LEN]; > > + bool has_vdso =3D false; > > + > > + while (fgets(line, sizeof(line), maps)) { > > + if (strstr(line, VDSO_NAME)) > > + has_vdso =3D true; > > + > > + if (has_vdso && !strncmp(line, VMFLAGS, strlen(VMFLAGS)))= { > > + if (strstr(line, MSEAL_FLAGS)) > > + return true; > > + > > + return false; > > This only tests that any mapping after the vdso is sealed. The code above begins by searching for the "[vdso]" string, then looks for the first line that starts with "VmFlags:", and looks for the "sl" substring within that line. We're assuming the format of smaps won't change from release to release. > There is a real parser for /proc/self/smaps in > tools/testing/selftests/mm/vm_util.[ch], see check_vmflag_io(). > This test is in selftest/x86, which makes it hard to include the vm_util from selftest/mm, if that's what you're asking. If you are asking reusing the code logic from vm_util, the check_vmflag_io() calls __get_smap_entry(addr, "VmFlags:", ...), which begins by searching for address, then looks for the first line that started with "VmFlags:", then check for the "io" within that line. This is the same logic as my code, if I read the code correctly. Thanks -Jeff > > + } > > + } > > + > > + return false; > > +} > >