From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1811EC197BF for ; Thu, 27 Feb 2025 21:49:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74D4F6B007B; Thu, 27 Feb 2025 16:49:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6FD946B0082; Thu, 27 Feb 2025 16:49:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C5E56B0083; Thu, 27 Feb 2025 16:49:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 409A66B007B for ; Thu, 27 Feb 2025 16:49:03 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id E32D881DE2 for ; Thu, 27 Feb 2025 21:49:02 +0000 (UTC) X-FDA: 83167065324.24.703C9C3 Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by imf23.hostedemail.com (Postfix) with ESMTP id ECC9B14001A for ; Thu, 27 Feb 2025 21:49:00 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=O56JAIpv; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1740692941; a=rsa-sha256; cv=none; b=ZZwyhsNkTMmTnMbomqpNgGL7sHwuBW+duPA+EwkEtKSjW++DNrb62p0RIuwrlgeMOEc4eT VHMx9jC+2mxRDPrAjWifoEdfTsQd2/+JsbSe47z5+60xZ2j3dtzeKJamGEbY0JltY/zO3x BvMhagbmIZ1/O56PXQwn7unoMtRTFcg= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=O56JAIpv; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf23.hostedemail.com: domain of jeffxu@chromium.org designates 209.85.160.45 as permitted sender) smtp.mailfrom=jeffxu@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1740692941; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=S20fxq1ry7p9hh50mjUI/MxMWC0bw2bNpdDweaT8JpQ=; b=LDRNzkdaQBe9CAxJN0wz8m1JpHeOpb7YabNRwT2hnwX8xdnpEag7HVOLJ6T+da1w7G7ltQ ACZIVyhiOV9vOKGCImXXGWn6jzJICYCh8pr3ZFrguWm93+EKWXP5hZdkY0R9egHZlz1XB2 M9NazWiaWsePpqaI9vn3HYec/lLp7/I= Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-2b1aedfa604so54052fac.0 for ; Thu, 27 Feb 2025 13:49:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1740692940; x=1741297740; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=S20fxq1ry7p9hh50mjUI/MxMWC0bw2bNpdDweaT8JpQ=; b=O56JAIpvD3RYmb5NghS4EBNWLfys7GyRgpnJZNhzcZ+xDl87h6wE8CrOor03nAHIXr bz06w8jDRmfDYnz9ldnUyW6cODFgM+WuOjjSLQfHphYK36bHwdmz4ajlircWyOONeQWa IR72UZ3huon1QLdvkuwB/8H+eoOuS4ry1alkM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740692940; x=1741297740; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=S20fxq1ry7p9hh50mjUI/MxMWC0bw2bNpdDweaT8JpQ=; b=c1xkmNnqBrS6TfEti8nJPVwz3nk7waivnrWuVxgj54Bw3MloKO+eTu1ooS7n2wLBJX zYmQm/wS9S8r9DgIedkkgKu3Dx45dOxpwbwQwMXmXBk9sIgF9e1kZwx4WBq9++yLhan3 dLTqAXOiZFFhfySY4FgAASvoAgABluINACHG09NMhScqdIsDCFawRDjHwhXnMFfzyfN8 U59j6jZn9Vo5JseSCrAxuXzhHiCn3gAwrponjqu0gsGKHcZ7f9y+KMZ/IaZX5khZc6Xy rDdQJ2i1HYw01ynN+0nC7rI1TJhDB/lzsOyd6K7jSXbDJMsoIW9/lvi0w7iwq1391kem aJrA== X-Forwarded-Encrypted: i=1; AJvYcCU1VvYCe5/aCFft5dms+y3f1YodQG10PgK6WbPMB8U3+3IAEJDSgqb84c+Q4LoaP6JV35QUvD7U3w==@kvack.org X-Gm-Message-State: AOJu0YxoT/BSQokNQQhVoeWgAKoaBb5wwBsDOUHEsPD41//TaQ3k409r jZJ7eGtNQS0U76S98iHJvZ6f1RuwgKJQbjQ8E6Qwy+spQGdaBX0Spnoq6JgXTOnk1d3ItqBA1uB ++iAZuutRDjUovymZMxx3DAJeeywhOT+Ut/xO X-Gm-Gg: ASbGnctU+sM30HGGUNELKQaAq88fyakQr+uLO9XM4Vq5nLOThv2fuDzVvkgAuEyG4Q6 9nFY9KAJeSGgLpFD7pvW6TNwKAbmSxCMjW3l8f8qUIO/2GHU8C5XWh1GhjrmV0G+dxE4rIm5FRk kM5f6RieC8cQlWDUz+OulyEsfqlZC2S6yG9yLG X-Google-Smtp-Source: AGHT+IHyEdounA70KkXSh23Nmd4f4aE5ui8o/HbAvGXPGW/uNecoMbNRDyQAff5aD7Br5h1XJp/sjnk6PehGLfqhLtY= X-Received: by 2002:a05:6808:3097:b0:3f4:a27:f74d with SMTP id 5614622812f47-3f55862f435mr194102b6e.9.1740692939817; Thu, 27 Feb 2025 13:48:59 -0800 (PST) MIME-Version: 1.0 References: <20250224225246.3712295-1-jeffxu@google.com> <20250224225246.3712295-7-jeffxu@google.com> <20250226162604.GA17833@redhat.com> <20250226180135.GI8995@redhat.com> <20250226182050.GK8995@redhat.com> In-Reply-To: <20250226182050.GK8995@redhat.com> From: Jeff Xu Date: Thu, 27 Feb 2025 13:48:46 -0800 X-Gm-Features: AQ5f1Jo2mnzwZQraAqqQiHYSY4itEhI58lkCEMcdRw_QRoxgrmRrD4sF7HgEYxE Message-ID: Subject: Re: [PATCH v7 6/7] mseal, system mappings: uprobe mapping To: Oleg Nesterov Cc: Lorenzo Stoakes , akpm@linux-foundation.org, keescook@chromium.org, jannh@google.com, torvalds@linux-foundation.org, vbabka@suse.cz, Liam.Howlett@oracle.com, adhemerval.zanella@linaro.org, avagin@gmail.com, benjamin@sipsolutions.net, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org, linux-mm@kvack.org, jorgelo@chromium.org, sroettger@google.com, hch@lst.de, ojeda@kernel.org, thomas.weissschuh@linutronix.de, adobriyan@gmail.com, johannes@sipsolutions.net, pedro.falcato@gmail.com, hca@linux.ibm.com, willy@infradead.org, anna-maria@linutronix.de, mark.rutland@arm.com, linus.walleij@linaro.org, Jason@zx2c4.com, deller@gmx.de, rdunlap@infradead.org, davem@davemloft.net, peterx@redhat.com, f.fainelli@gmail.com, gerg@kernel.org, dave.hansen@linux.intel.com, mingo@kernel.org, ardb@kernel.org, mhocko@suse.com, 42.hyeyoo@gmail.com, peterz@infradead.org, ardb@google.com, enh@google.com, rientjes@google.com, groeck@chromium.org, mpe@ellerman.id.au, aleksandr.mikhalitsyn@canonical.com, mike.rapoport@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: ECC9B14001A X-Stat-Signature: 9stf1da73ew1np55cue7ccqafdnyk9fr X-Rspam-User: X-HE-Tag: 1740692940-933658 X-HE-Meta: U2FsdGVkX1+0SliNO/CJ8dWNs2sOwQD6po4ECADELpNMsMEtdxrEgwlm3YERIrqpOvzYzNlMUlfBzOKSng8gN2lBIvtJQFzCdTYMRJRonIkpazRNcuq8bcpmBFMYSF8yQiD16a2Kw3ivgQll/faj9R6kYI8CiEEZHq7C486pzgCi8H7D1IDJkECXVnsqNM2sU5xH6Ou+MAg9xo65N64xytLX2c7PH0eS4JvGhBDp3FYAQVkuPxtDM94wO9EnDEzQhNIPlWwI0+0JT5iTWiQzSC2ibd0rXB8EYbwccmLcdEOmXa5fMUGyH16Cb5ZZN9zeyiosOzSiacKvmKgBepOiafmQCR8iLaiRmZyyqn0Pi+0rwjFrVOHgQ3eHgf80uud/U0prDrWplkjt0gBMEhgCMN7zJRheomRcepV67AK722t8RLG71/2BWvzif7y3/3BedPAd/t617TQq0fGYbZEhDHulCP+x875G/DauklIFsN5sTcDWYbwlv52Cw2RSCSRyyKZATAjwS2J3H8vVcUE9297QBvOdGpnBX93GGhjKtnceXPurebeo5ng9nMPnrp8DiynJA1Lfe2uYDCrQ3i4pcVxcKMoCzalwfcUiK2ku6GsIp3Fk+fkN9DZYXCZyBwePHzdnyalY3CMcQODDbjIwcg4Tgm+lSZG7Frh32iMOzRogqg2mkDlEH9spEKNi6/jF4ie/w4SsBmsb8I7snaQ9M63UCeBl3TNQsz+SkPCL1A9ewfMtUPJ38L/Nu7Ur7ZDfmavpRt4MnyYFd3pvfzCBNLw1DbY9975R1D/TM9az2yXrHV4y36/5D196Fo4FLrGeKBXdW/Im9vk2bizNyalcT02YkL71fprMA/KVo+/VEhPka6guOM0A6WNfWyxEatGP5mbqy5xg1u251UwQXHayxIVO+JIZ8OT2DNEDp3MP2R5L2ubAlJdm+C0O8rIvz2y3Er4J2dTr+xqJjDPmSNq Balg5t78 mn09RHOKIRaaRAMyrvtLMNxLzuM3Kih0NxUQRd5S3M3oj1O6IQm3ff2bfsMl0E6uXYm9Jyl1TtsKvJfPe7VaVCKSlBCQP50FytlCNNI5kPmzk3HG4Lh/p9l5HjOCeOxFuM8yo64rjpI0HbYwNT9hRdzX1i/TCSkos9q5qxPF70QbwdIxAf1KjDsmCeSaW8UyIxxWpbQpDCmZPbBi6grAPth+4nD2BTWcIrdvp42+OQo5SgMqw3VG0Ogi2QUz4BvgXN6rR1RCbuWry2Kh6BORO0BST8IInYTLHfmJz X-Bogosity: Ham, tests=bogofilter, spamicity=0.007216, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Oleg On Wed, Feb 26, 2025 at 10:21=E2=80=AFAM Oleg Nesterov wr= ote: > > On 02/26, Lorenzo Stoakes wrote: > > > > Like I said, Jeff opposes the change. I disagree with him, and agree wi= th you, > > because this is very silly. > > > > But I don't want to hold up this series with that discussion (this is f= or his > > sake...) > > Neither me, so lets go with VM_SEALED_SYSMAP. > > My only objection is that > > vm_flags =3D VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO; > vm_flags |=3D VM_SEALED_SYSMAP; > > looks unnecessarily confusing to me, > > vm_flags =3D VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_SEALED_SYSMA= P; > > or just > > vma =3D _install_special_mapping(..., > VM_EXEC|VM_MAYEXEC|VM_DONTCOPY|VM_IO|VM_S= EALED_SYSMAP, > Sure ... > > looks more readable. But this is cosmetic/subjective, so I won't argue/in= sist. > > > Jeff - perhaps drop this and let's return to it in a follow up so this = series > > isn't held up? > > Up to you and Jeff. > > But this patch looks "natural" to me in this series. > Thanks for sharing your insights on uprobe! Your expertise is invaluable. -Jeff > Oleg. >