From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BE93C04FF6 for ; Fri, 19 Apr 2024 16:13:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B9C4C6B0098; Fri, 19 Apr 2024 12:13:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B4CD66B009A; Fri, 19 Apr 2024 12:13:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A3B786B009B; Fri, 19 Apr 2024 12:13:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 833AB6B0098 for ; Fri, 19 Apr 2024 12:13:50 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A8EA74153D for ; Fri, 19 Apr 2024 16:13:49 +0000 (UTC) X-FDA: 82026777378.09.14FFB9C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf23.hostedemail.com (Postfix) with ESMTP id B248614001C for ; Fri, 19 Apr 2024 16:13:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FDY9XkKm; spf=pass (imf23.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713543227; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; b=2G1bOZGY6OVtffnLz8nFgUVberN29dlyswDKNpWyV0hdX/F6r8ORXOAqOI/CfF1UKq6lDB 2y7z+l8OQ46kNDRvbeHper56QEWQY9yGXBs5JSQcbrU037LxCAIc7lwTENeaibL5mnyqWC 4rqHlk8gpBRWJ2ivtmRYo2mlxA9g54w= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=FDY9XkKm; spf=pass (imf23.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713543227; a=rsa-sha256; cv=none; b=gypu/m0tk4km4bDcOJ+c5rHRJmAXIi0N66A+CgbZNeeJYXFTdyOzq33fx55j3FtswSC0uS HTqOpuMJ5pe+8/K+oiCfAkcstOhSJw7suwIvh+zOcby6TEfg2r+eyCTum4Nwxb3JUhAcqH Pjep1J8TSatC6rSbX+Mask3YcppTBVQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713543227; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; b=FDY9XkKmbAQX4cUwDRUq93P7oJB3Ts/vdNPb3CiH3viJzxa1N81vUSoRgzvBMYAcINmTrJ PuG84WAmhoyez4dkkYXz0qV5kmK7QiAy/DV8kNnRqjRm1XJ3SHm3o6o5cPowrGnmkq73Tp V5T6SXCE4b6DDQwlKSmnQY+g1TfGdtE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-384-YoAsWh9kMbm29FaiVaCqaw-1; Fri, 19 Apr 2024 12:13:42 -0400 X-MC-Unique: YoAsWh9kMbm29FaiVaCqaw-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-415591b1500so11366415e9.3 for ; Fri, 19 Apr 2024 09:13:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713543221; x=1714148021; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nLxECB9bMpQI6z8V9G04dNBlY46x4K0VVLSohnbBzYs=; b=Eotq1W73jlcgq5e8AMT7k2pl13vBfUiOkCMXCM8iKiVTVS3OERjNKw1EaJOHX7gyl7 /JaXaMvyAkExAxeDBcob6JPTzOoKtU+Gxh34VL4dWdDgYYBossZK3/MSRK9vV1Smajav cc8Dk/fw3v1HzcVxrVVjmGZMK/RVFGrlp3Gx7tJ5UvaCYMlDe0G6Rn51tTtMMp+n0I/x HJftHVNOz88HHEzUpEk4jnc2jzzeqxkAW9tBRXxfozSvs9dwv54eGMTjh8Tgk6KYRwE9 xA5/1PO7KPr1pF1ATLmhIRnh49CCUMg5GO5JbPgfUxiaxLeGb1zH7ruZc6xFmTkVPjJh fnBg== X-Forwarded-Encrypted: i=1; AJvYcCXMOQo9+uOaTbQeabqF4Zh14UmoZIxQUtW9y+gn0/ouN5XTt+4DAtkpVYL9Tk0Z6PLhAj9ZylzwAxACXEHYn7g/q3k= X-Gm-Message-State: AOJu0YyEkI1ai/L9iOxs5a4Cs6GjJNRmO76Ey76SYGlVPnMwPzkJT0tT ZOep0+2af6QgJOkIS9mLiIT7q5Hf06msfStjOrYsTQdi5ksXELhWRSpV8PLQoSCT1a21MiQtn03 cUi2O57b9m69ZyITFOAY7FELcWqXqa9x1g1gL1qKLaT+74cmhTPmnXz2KFKuwq/uNAq4dyeolCT ALyoNoWKrhujzvQ/ySaiV5bjo= X-Received: by 2002:a5d:5265:0:b0:345:66a1:d949 with SMTP id l5-20020a5d5265000000b0034566a1d949mr1596274wrc.0.1713543221703; Fri, 19 Apr 2024 09:13:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFnajPMHcMdpRY04h+TNXdbRj7g/tI02Iw0JIqVHCpyfHEB4naUbmsOShyxFazrDJ7rYEXw5oIH9VgniqhruMA= X-Received: by 2002:a5d:5265:0:b0:345:66a1:d949 with SMTP id l5-20020a5d5265000000b0034566a1d949mr1596246wrc.0.1713543221365; Fri, 19 Apr 2024 09:13:41 -0700 (PDT) MIME-Version: 1.0 References: <20240418194133.1452059-1-michael.roth@amd.com> <20240418194133.1452059-10-michael.roth@amd.com> <20240419141920.2djcy6ag3peiiufn@amd.com> In-Reply-To: <20240419141920.2djcy6ag3peiiufn@amd.com> From: Paolo Bonzini Date: Fri, 19 Apr 2024 18:13:30 +0200 Message-ID: Subject: Re: [PATCH v13 09/26] KVM: SEV: Add KVM_SEV_SNP_LAUNCH_START command To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: wr3r8wfkwdqwyky61puh3nochqsf3fqn X-Rspamd-Queue-Id: B248614001C X-Rspamd-Server: rspam10 X-Rspam-User: X-HE-Tag: 1713543227-959812 X-HE-Meta: U2FsdGVkX1934t6AVw3Z5s249cpZjp8hMXVuh/veANhQwUILFQCfLLdcamlsB76YVL8VxEHylF76aOlKkAOejIjsnIvNxKqlr21Udrx5McPPyZXwA4RYqjAnObE1Si3e765R1PFBH1BDH5BxFepO/DCjC0FSI3bZv2nfpa5NHbu4mLWMSWCFmFU3DGGQ2Xjw6YCw3cNHC843oHajqjR1s3XOLRpQGss3J1/E3/7yqt+jsjfuVE1W0HkNeMkeYgWue08AmL3tkMdF2zLgzqR47DkvOsj+1kqaJ2upXZJrw/utKxFaNg2rY+UDbGXYQcKyYLG+/WlNWM7/OE/VXjyJzk3R6z83TqQYv84W+np9+ekECoEw0JOWi6l7kGHqrx25fF4IEjHWvRZA+nSMP1kHOn64IEHJi1K61TINeX75sh0jsj+wNKamSA+8BCE8QYrgE+Y3gnmOnXRAZllxhwciC0G727cxkdK8HrRj76JyIgLeqtnJZyO+/r1fF4UgFSzvGBIoyLSvoL4S9Z7OUfO8+xTKVp+YPYzZkiuFuAidxzhB7FodLa0MgkTK+P/51JBYbe9brikUacmrvRSobFzCwPVegVU7ejbJNJEEDKhdcCE0IRW1F3l3kg1ZHzqWTuw+V/gsJ6RhkM/ayHzJVXEm/9aBoN6KEQD2yMCoKCO2AJt+33hZaUQJqaRD049Xgv8R2qGgZ3YZMNqaS4hnR3wx3EBbBegr86mq4uWRshJCPiVgpJzZvl1FiRET8dbJ8Af/TAV3bXptSvPJ5MSoHW9dpYc9yjZGY43Sz1hSmJu4tmqPEX1zBj38OCLDw0Ao/1eNJFhGWD0rLXWdYUANIK0wg7EYXt1fQEtbZlnyHkDzEi9SScWzjnFt9axaw+x5pNRCRiK5Lb6AnMFbK0vyY6YNtWRRxLB/hUwLq/yhzgrWpDGttTbSMO95pLxtwCLY88PzuX7RsY60awKkRV2eVui 2nQgi8C5 7VIKNLaOAMeszfi+tSjbfhCv2uD/kwCQPKZUS1dh6q9NAz4NZ4Pr9GehaaXKs9MPmgaFfIsvGcdKOu3sBnQCR39BnQgvMBBc/VN+NYVEJpdUHUhWJpceqXOa48sVvpYw6kRUhfWcpVSFoAgWWc6yLybx+zxHt3QAW21W72IrPpOEcx+MlfjFTgCviKKHuJ22dCop6YQIF330WaxBIsjl6jWjg6+6KbQd86Js5GRnGR7KVK+fZK+E7xpmfo5moJYyxdAV8Cvk6HD3i2lw8SMiZE+gzXmfqUemXekt7rz+rMUAIPW0pV7smLGz7kQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000020, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Apr 19, 2024 at 4:19=E2=80=AFPM Michael Roth = wrote: > So my current leaning is to send a v14 that backs out the major/minor > policy enforcement and let firmware handle that aspect. (and also > address your other comments). Sounds good to me! In the meanwhile I guess you can also update to have PFERR_PRIVATE_ACCESS. Paolo