From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7612CC4345F for ; Wed, 24 Apr 2024 16:52:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB7246B02C8; Wed, 24 Apr 2024 12:52:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D66528D001F; Wed, 24 Apr 2024 12:52:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2DFB6B02CA; Wed, 24 Apr 2024 12:52:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AC5866B02C8 for ; Wed, 24 Apr 2024 12:52:15 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id E15FD40228 for ; Wed, 24 Apr 2024 16:52:14 +0000 (UTC) X-FDA: 82045018230.21.CEB9CE1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf29.hostedemail.com (Postfix) with ESMTP id 58B98120016 for ; Wed, 24 Apr 2024 16:52:13 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A3TEbl8n; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713977533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=id9ycaUBE8n/nnS15W/vGnLyEDK1wrwv0iZjSLUyk1Y=; b=DuBSN2xXAwMY7BOpDaK0QbBGJt7JXQS2nHS7IaBo4OhtH1hT8Z01g0pPakfzz7lCWFfTFF d2JDXQzwezHz41JdQoCEqvjrKLTliOn2zBGoMxfqECVIF7t04lEqRAl8Q2J9qdwFhiL8uf mp8dhOQvIoCIUxBXwRlQk/6onaWfwAM= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=A3TEbl8n; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf29.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713977533; a=rsa-sha256; cv=none; b=KJPDX6RD4B8+kVM4o/l5UltfMp22pCPooUVQ6vfvnpq3wCu7p69S00VbWR3W7gb1s09hnO E+dEro2v1ccJujZoE9Q3ET0L4nzbQLfl1iiOoExTAh0KztdKWws1BNNU0M3m5YVvTb9Sa3 Au4xnH7MrD2KQq4hGpqznd0+DC4KEgo= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713977532; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=id9ycaUBE8n/nnS15W/vGnLyEDK1wrwv0iZjSLUyk1Y=; b=A3TEbl8nPoVQ6slzkU5TYnzNuvN0ALGIKlZg5ouUeNIxeTW6wk4QwO7P8ymoS1MeoJrU8X QKSNbAxS5R5ChwJBIkq0CxDPS/2U7APl6po4abCI91zdfNhwYmA7CShiNE5mJ3kuIHaGTw R1i9xd4V/hF+1Mu3yGkk0EkocvFqyuQ= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-656-yYzBO4khPtS7k7JI2WTWAg-1; Wed, 24 Apr 2024 12:52:10 -0400 X-MC-Unique: yYzBO4khPtS7k7JI2WTWAg-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-349c63ea688so11737f8f.0 for ; Wed, 24 Apr 2024 09:52:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713977529; x=1714582329; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=id9ycaUBE8n/nnS15W/vGnLyEDK1wrwv0iZjSLUyk1Y=; b=gf6/5xm/NhqkF3bNrbRE2NRzGKFdzfjoGsCu31Zgc325a6qM3DbOYweOilkkXOumSb HkFauiUygM3KurOsB+J29mQca56X8M2O4vEPl2QyImuueYwNU8QzdUml3N/zIAcofv59 0MGyX5CuBHyS6s5voeQzw9+a/OEQjdAfqWBJBUHmh0XmfJ5hr4jfXNdBKUU/uDZxjgL9 36A3dqSuPdw6H8v6fdzAfifYy/r6dcu8duipmzNg4Nc/R6Vuoj+1bbnuUbI2rc9td/Xd sV7KfOcHhuGtGYU7xsvYxOBZmReFqNx0FipcTug0oOm8ACcXOjU8nmUQjYzI7M2dMc5f Ifrg== X-Forwarded-Encrypted: i=1; AJvYcCUIiyisHZ0KX31voQXLj0KdUjEpADaesESP2NBDu1tpLA16/ehqKZ2v+7lKcYUnz3FXMkcDSXVDcSdKUJmVMR7A70g= X-Gm-Message-State: AOJu0YzqWTjuHKr+mZI1FHYQLi50klyWwFPPDxhGJk9TAqug47wfbdR+ BrfHGSIRxEl1A+2vYDbhTtqh0iB4NB+bWlx2hNe5EFP3Dvi5weKkUqXXOwtxuxH1gf60LDEA3z2 wUrMkG9WEwjLOMl71X7z5unyzBmran844loC8s7OenbuvcIUNgMt9/uan9f5TnnQhiVxcpRaoQs OrQWtfdZN25C6ipya+YAt+2sk= X-Received: by 2002:adf:a2d5:0:b0:34a:ef9b:b6d3 with SMTP id t21-20020adfa2d5000000b0034aef9bb6d3mr1894659wra.33.1713977529042; Wed, 24 Apr 2024 09:52:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFR+Q8XeU6R6xECmEQz4NqbdTNaO1G1EnGJfcOAEAL7aKaYxgGlsEHUag2BDkifl8iK/Ykj8pEtfMPkXRl3N6s= X-Received: by 2002:adf:a2d5:0:b0:34a:ef9b:b6d3 with SMTP id t21-20020adfa2d5000000b0034aef9bb6d3mr1894619wra.33.1713977528725; Wed, 24 Apr 2024 09:52:08 -0700 (PDT) MIME-Version: 1.0 References: <20240421180122.1650812-1-michael.roth@amd.com> <171388991368.1780702.14461882076074410508@amd.com> In-Reply-To: <171388991368.1780702.14461882076074410508@amd.com> From: Paolo Bonzini Date: Wed, 24 Apr 2024 18:51:56 +0200 Message-ID: Subject: Re: [PATCH v14 00/22] Add AMD Secure Nested Paging (SEV-SNP) Hypervisor Support To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 58B98120016 X-Stat-Signature: yop5ybtbfbhgg7t6mj96kqubr4ok771z X-HE-Tag: 1713977533-969079 X-HE-Meta: U2FsdGVkX1/d475tnpWFjUQ6b9paTI1JfKXz7rj91v+YlrfccWoQLC1ekEqdQR4XKtB4x8919th9us2IQISpQCJfShMRUqb1Kla5DaiL1FhZl8TZIi27/JG+lK8YNUb/rs96lLpXDvBItuvh8QP46yfnfsOlo78dzwczc3F20PGKkzYG91ra0/tEfkTt5y0rz2T6w7dLe0X/AMZOFBKNQ1WAhL2TSZ+7vBU2PfsCAPnM7HLxWALTsKDO0Gcw7yRhJGJqFXf2UlZM1nN5H94Wg79WejVyBJFTLSzK2zSPwUDnsBm+B8mPtouPnRos0kQp8DHX+dsCFe//YhjddiygHF6t45NbBDD/EhPje7UWf5m0s8OnOm3CFzhQhEk6ZMQybqTgFye02MbMk1R6QUkF5IzrDhTp4ENT+d2DJENU1O/xpkbr3GG7zhWOD9NxqsTQIga0uRVXLWz5oLLhmMSLW7IsrY6pJEA1QyuoYf550TV53Gqzcr7FdEWSHNOfhDlMZmmz8HvnSf6NquK9e6gh9Jyrm5n+ouGQGdd1SybrSciYynWcQZXtaxHBGS3wRmEUh518B777Vehy3TfFr0OPednfsyjfx7INkiSulAOfDfShyez+VuOBDFwnECYPNDqkpPbbYlLCqWi6fe5nP7gV1AmlKVH2C0+T+pZ2Rh9ltxU5jBttSCZTdHEuK2/FuWdu32qWMyHqIhOz+aECDknub4xsGlrIpJfnH9xTF7uWZ5XG85NmtybE3ZxAb23RrzArzEZcTeWA5LOOnRjrR/W67LytoPl/h9+z7CCu/gdVzcwCltwBDjnLt/P1jYq66pJLzqkagzAcvkNtQfnea2AWUHFgtuQPeGW/g8hn6IOX0LQgcI4B1iZtXHXaZ4bvQVwrhqRrCP4NPRvKyC91Tv+gOZ6rgxBm0JIcl4ALRc0cTe9yyZuBGbN2Pmh8SX2M3bAonPyH2h4IawC+Mc8AYXU cDxsMncq btsDmqwng301DOlW2+i9T8IkEAFPQ1mjvlj9z1H5cfH+DFaOAUy4AJIdOho9Q/GXyBp/brs9+mlzLWHXTvOA5OSE+3LkfGxyq7ox577HilHEa6CumPUrCHqUMFzsIv9fi9NAJQ5tKnth2EtP5npOtO9YHYrgwOIM8dnpVTknmi2mTG+81M7w48CF7huHx7qhX03jUsemaPD8Z0AVKZbQEPvXRoVOPoJJ6aE8pD7jX46hJ5JLmIhAdKB9swdJcqbewhB9aerqVHsSefByAQl3DB8LSScNytP5+9deC0OJ34d02zpMofqIWRGtUSobmhHeuH96xyt4fUbXosEgyhgHzPEaSyt+V5aYr41hw X-Bogosity: Ham, tests=bogofilter, spamicity=0.011340, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Apr 23, 2024 at 6:32=E2=80=AFPM Michael Roth = wrote: > I just sent an additional set of fixups, patches 23-29. These add some > additional input validation on GHCB requests, mainly ensuring that > SNP-specific requests from non-SNP guests result in an error as soon as > they are received rather than reaching an error state indirectly further > into the call stack. > > It's a small diff (included below), but a bit of a pain to squash in > patch by patch due to close proximity with each other, so I've pushed an > updated branch here that already has them squashed in: > > https://github.com/amdese/linux/commits/snp-host-v14b Thanks, I pushed that to kvm-coco-queue. There was a missing signoff - I just added it since you actually added it in the past[1] and the patch only differs in context. Now off to getting those mm acks. Paolo [1] https://patchew.org/linux/20231230172351.574091-1-michael.roth@amd.com/= 20231230172351.574091-33-michael.roth@amd.com/