From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2BA3C61D85 for ; Tue, 21 Nov 2023 17:01:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B9046B04B8; Tue, 21 Nov 2023 12:01:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 441776B04B9; Tue, 21 Nov 2023 12:01:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2BCF76B04BA; Tue, 21 Nov 2023 12:01:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 1707C6B04B8 for ; Tue, 21 Nov 2023 12:01:20 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D3B01A0A6C for ; Tue, 21 Nov 2023 17:01:19 +0000 (UTC) X-FDA: 81482577078.07.15A1609 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 2842F160068 for ; Tue, 21 Nov 2023 17:01:13 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L3koYayg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700586074; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v93FwVXoTzkwCTHloTDbAyzgq12DcyzYpNvU8V0mZJE=; b=N/2sarntQCzNohI4WuDy1ekzvvkKWhbEvCHdBoExiQ0AzBYZitDC+0mUYA3z1P52VirfwX 50XrmfnF+Pasn9l2txTTOHL7UL4Ocw10+CHQqJ/FcJIY3qcr3ohczoSCJjukfebGW6SlnL qgUCVCu89IqTNrHFOqJRXaT8YTxIfV4= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=L3koYayg; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf08.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700586074; a=rsa-sha256; cv=none; b=3UKAKX4b/nKLKPqLCtbMfbwSbo57pnaRenciyw/KzVd9jiPM2mzkIXhH7APBJ5eo5P1unh sWYBEaU3PnDV6mKTtVKP9hAKmB4fddHiiApEmCAYQ8twXX9KvktyrgD1+Vwb0PU65ti3TG cX3KJL2VrS0hE7CSzQv/h+56fpJSOdc= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700586073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v93FwVXoTzkwCTHloTDbAyzgq12DcyzYpNvU8V0mZJE=; b=L3koYaygbkvTx1tYh7/t+xhgOmEV4PBdKQM0/OZqbx6AIy4WuQT2D37iZD3l0CTBPd/xkk VnqU9PkyGkhB1Bh99DEko7Vpx8/HVGYrcV4nBCfVtFPcfy3pRGBjcuC4FA941J6l/+ll2/ NKN3LGMBb31ay8Wks7k5PG8qI+/6eDE= Received: from mail-oo1-f71.google.com (mail-oo1-f71.google.com [209.85.161.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-27-CmP9VvXTMVaqW9e4rq94rw-1; Tue, 21 Nov 2023 12:01:09 -0500 X-MC-Unique: CmP9VvXTMVaqW9e4rq94rw-1 Received: by mail-oo1-f71.google.com with SMTP id 006d021491bc7-58794776af4so6063394eaf.2 for ; Tue, 21 Nov 2023 09:01:09 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700586069; x=1701190869; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v93FwVXoTzkwCTHloTDbAyzgq12DcyzYpNvU8V0mZJE=; b=X+eToYS8PghqTuqrl8UqIcKRhpJQk9LrAqQyjVfv5GD1txE2PY8XNEo9bLjkFk7U3j QrGiVQiikkg7FEqTJ/7ucQWy+L8ysnHw/+tZvLthlaM13KPe5Z7maloMsPXE5V0W15Nd OhQEzajuRmutNInJCmL592aFMv9bSVJZ0kRWlJrsXMlaPs1oplMWrQ98aXISecn2Un/X NTCgNSaYdkveyqBJrzOYlHwKk149frfQ+AlYwt4jdQjqVsIzZWIBG+Fdgd8bPEHFTcfH FGjfC7cDB2G7GNScBO4VLOJbppRb8IaJFOqj4/jLMPoF/W41Mpn6atoLgRKONPVgW0yF i54Q== X-Gm-Message-State: AOJu0YxEVAg9FUdl0+58Be1ZhxqjgXyL+qfAZcw4Ys2Nj9qVW5TsJzKl zYAMikmgcrB3fhC1gwA4JvKMoVMHEPjQX8VvTwT3Yrz9xV23vtHPMtjxVZXzmr0CtnV9JJIcf4/ 0T1tw9QdlIJRsx1j+/l6IgZ46Lok= X-Received: by 2002:a05:6358:7e47:b0:169:a9d4:3faf with SMTP id p7-20020a0563587e4700b00169a9d43fafmr12581516rwm.11.1700586069075; Tue, 21 Nov 2023 09:01:09 -0800 (PST) X-Google-Smtp-Source: AGHT+IHzwqwXTcQOMVq6+W/ToO1AFQnqdGCzNKV3DK3CezCKFyIOZTTVBddsfYxnVHAme/q2N84DW6rxhPtI5xPi31c= X-Received: by 2002:a05:6358:7e47:b0:169:a9d4:3faf with SMTP id p7-20020a0563587e4700b00169a9d43fafmr12581454rwm.11.1700586068588; Tue, 21 Nov 2023 09:01:08 -0800 (PST) MIME-Version: 1.0 References: <20231105163040.14904-1-pbonzini@redhat.com> <20231105163040.14904-35-pbonzini@redhat.com> <13677ced-e464-4cdb-82ae-4236536e169c@sirena.org.uk> In-Reply-To: <13677ced-e464-4cdb-82ae-4236536e169c@sirena.org.uk> From: Paolo Bonzini Date: Tue, 21 Nov 2023 18:00:56 +0100 Message-ID: Subject: Re: [PATCH 34/34] KVM: selftests: Add a memory region subtest to validate invalid flags To: Mark Brown Cc: Anish Moorthy , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Sean Christopherson , Alexander Viro , Christian Brauner , "Matthew Wilcox (Oracle)" , Andrew Morton , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Xiaoyao Li , Xu Yilun , Chao Peng , Fuad Tabba , Jarkko Sakkinen , David Matlack , Yu Zhang , Isaku Yamahata , =?UTF-8?B?TWlja2HDq2wgU2FsYcO8bg==?= , Vlastimil Babka , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A. Shutemov" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 2842F160068 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fcfeqnoiabpar6wyoww9jqqtwu65b8r5 X-HE-Tag: 1700586073-408701 X-HE-Meta: U2FsdGVkX1/ebOFiSv01Ug13CTMTQP8HcJQaMtuwbu5sF39caI71R6EaawA2IEQThlUaZzymPdC6WOYjMeiOs7MY5rfAlAV0onnYnyy/ry3I91LxnJAkU8l7/X8ebR4AXh1uHIg1nwzFSdAWToXft75TpWhP4ReIcUWJgdXvPIGbBzSlpt+BvLTv/RpROzq2SIRpaB2HvSQ4DNNo5xZteEWJbwB/av2r7UnmsrPGWiIDyqSO2hPA1/W2BJdD3BKN8IMAOUIH0cQFE20dFOot3Erm6z3bX73bURuM4YgvvpWybz25hRHlGLzrb1Wzl7qxzcmHOus0Zzy3hfbz2Um4NbZc/FQOgbjk65GGozo0qi9B3k+6vSIhE5RJEl3mB5JkmuHy9bsFpihAKoa7LYm6KxPeFT5qp5Xe/4JKWmYp3mZNpWq0rU5frYNAviNhvi32zcifgcIwOSE3XxUQvBGqDIf0OMvWuIP2dOeonsrGiMcNXvRuiGwpSWk4/qCSoxtT1cXB0vlc0NSw879/dWvZiRDnX39gomkrEfTStAzsed2Qb+6B7SQiQc2i1iKLcITbHgnGfcR2vnBBXhcSp/ElUE23tULENO/lmh8NvgxxYxo1PWpzXQkJjzZVwJfiDKdGZG7Fh40ppipLuXPI0fVRnFESznkfBY8prqzDn4Xpdk3iTJ5pp/n1ZDQZAkbQoLpAni00I72HfjKqfPnDMK9d2Uz4nhxqM4bsLttnXvNPRAOaTMbjDJv911Cezysqi78/qE1dy4fNZhFN17gImaTY3yyqNP6iYqe9f4xkUbNomx30Oyf8o4awgNdHLbVmj8AVO3ylVVej68yxyDfoqUHGxR5JC7YQy7Q0nRKy9cEgUtBJRE5wQzywSNfPpNbr0Xmt7hLvnUy0mg1+v98HoQZiWeLsW5mLCJpv8VjBh7Lv/LWWKYrBVuogIo59PueJr/hg8QNGi9gMhSh5MbualvA 5RIq88Tu xQwS53rGdL8uLWIIOKvr2Djfk+2cT5q1iIvbCibK9vbsu+i4VgbgtT/bnY0UFn2BgIiClwJzDSBT1cp7vHfUjQICCzkZfvKkkD8XTN19cujXferdQtFOGVb5WSmCDCAWWgUSJVVwmKPZyVSZowtslaRIfLKL8lt48KPnb/t42J6yd+EWs3MF4v78vsDbBeliT/kr5zuA/UZt2KkKCvb8CNAEChKsE1+Yjnl9weBpdH9fspdcDBzkCfRpFv37JOg0oraBSrLMqZiS6WsGKa4JStzkucSpHnOKV+tmydo3ZIf3VpFehGQ4tFCJN/iVwAxUktehh9QEZljqMEfXy2M8VLJpd+ZgSvLk5lJBh5ngUK7mTM68OIk+cTF5wpfAObcsw1GX8cuCoO+SSvPc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 20, 2023 at 3:09=E2=80=AFPM Mark Brown wro= te: > > On Wed, Nov 08, 2023 at 05:08:01PM -0800, Anish Moorthy wrote: > > Applying [1] and [2] reveals that this also breaks non-x86 builds- the > > MEM_REGION_GPA/SLOT definitions are guarded behind an #ifdef > > __x86_64__, while the usages introduced here aren't. > > > > Should > > > > On Sun, Nov 5, 2023 at 8:35=E2=80=AFAM Paolo Bonzini wrote: > > > > > > + test_invalid_memory_region_flags(); > > > > be #ifdef'd, perhaps? I'm not quite sure what the intent is. > > This has been broken in -next for a week now, do we have any progress > on a fix or should we just revert the patch? Sorry, I was away last week. I have now posted a patch. Paolo