From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF67BC4345F for ; Fri, 19 Apr 2024 12:01:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 786BD6B007B; Fri, 19 Apr 2024 08:01:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 70E7D6B0087; Fri, 19 Apr 2024 08:01:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5877E6B0096; Fri, 19 Apr 2024 08:01:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 372A66B007B for ; Fri, 19 Apr 2024 08:01:49 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BE05D1C1A5E for ; Fri, 19 Apr 2024 12:01:48 +0000 (UTC) X-FDA: 82026142296.03.737CF6C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf30.hostedemail.com (Postfix) with ESMTP id B62728001C for ; Fri, 19 Apr 2024 12:01:46 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VZwfwel9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713528106; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Vahs511qBysOkO0uiEmPvdJfNTUFHsURAvS7DcBv8xY=; b=oRijabT7xk8WoQYHBQj+FQWTmz/29eNUsZP1qgzAzRlR+fewlhph7brzKAbRAudqW65iDT ZdowrJpokM/aSbWnt/5J4/AZXTs4Qtfh60WGfgxCFsNlNqD/XGpt/VXGHWBVHNvUlTB3M/ i4dYgi18QzY1RD9DcQ7KK2hLwBecHTQ= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VZwfwel9; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf30.hostedemail.com: domain of pbonzini@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=pbonzini@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713528106; a=rsa-sha256; cv=none; b=Wr7+dvrdrBclznsk4Qkbdvs2rqAI0YxabUntwbxV3tIgX8Y4MiL/qyTo0/alwUgI+/rCwk mXs6dAHBvGwKUQTY/GFmzvVSPxbcsH2eL27bQiHBhZ60qqWVw5zTzYRtw+H2UTOT6mwpzf dNtqT0udc9e/mbnroB5pA+xlOZ6qB3E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1713528106; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Vahs511qBysOkO0uiEmPvdJfNTUFHsURAvS7DcBv8xY=; b=VZwfwel9YBivSdyE7uLPg8aS7qFFLDuEKmtQOqlv8SApKARwMAlmEh9OpiVO+AHhlmEnMY UJMlN3s4NdSuzVBQkPhOHCiSx3Ps5VTggssrjkj31F6/d9am44sUzFiq5WE+UrzNlfcZsD etB90ZLL8yuQqh9xDGPfQTLcSYYPdSI= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-172-hFi7-N8LNqCzjOqqAnjEpA-1; Fri, 19 Apr 2024 08:01:42 -0400 X-MC-Unique: hFi7-N8LNqCzjOqqAnjEpA-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-41828dd7c29so10044615e9.3 for ; Fri, 19 Apr 2024 05:01:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713528102; x=1714132902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vahs511qBysOkO0uiEmPvdJfNTUFHsURAvS7DcBv8xY=; b=k75sIoOnu6ZPLLI+sPftM9Q6tzSWWa0ekXuziADqLdOyS/4ZZ8PiUdXw/SId2Jyel6 sS1wA+kHLYR0YTigGrJ33keLpEvznlIq76xQc5l+RnBITgey+0cr24oC15c9pVIUNLQq 7r8lJY+Nno8guqMHm3MWKzEazr07FBBeSs0xJqlTiz/3P25qVNsQVy82gc1YXfX3o1bq GxCer5QTZLSQcWpNzVCmP6WRb0hP2LKntwd2hO23W5NILCUwhTXqqAJbffWuu3CqmWyO JDO/6aybfZpvA1dpHji/P95kdjiG2yWNA2B9rI0uxG5gBdbdtpAR7H+ta92wdR+cQSTe scSQ== X-Forwarded-Encrypted: i=1; AJvYcCVfl/88sK8GxjwMw/7jEDmwnqGIulD49a6wxBW29+lL//vRYUyOs+zqbXl4hWw9/3V9+eBA3DwCZ79cjUzMufy8lac= X-Gm-Message-State: AOJu0Yy2TPOAC+V88HYgIFeJjwOQNZTQxigIaW709ZoV4X7v2DUv1FzV 4DNsrI4qnMK3HPcgJbjLTJ9SO3JJjTY8etcBaSOuq9RFAsm694XBm38kn/h9lvPomFUnW8SC6Au 2iK4dp6atQyR14z+6rcEVuUbRArTEavPrbrKDfHmgApeae9MEX2E5QWruBCqaNwQmqIa4y7WCQv vQusm+gUhtHkF0mXKBx7GtuUA= X-Received: by 2002:a05:600c:45cd:b0:418:9ba3:ee76 with SMTP id s13-20020a05600c45cd00b004189ba3ee76mr1378054wmo.4.1713528101551; Fri, 19 Apr 2024 05:01:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEaFUZhMFYFAs3ZhsYYcBoV+2/MzoyjDzM+1t4+goj9WAVZ/2QAmnhBwnZ/PquJCML4YzG+HJVNxiJvWhvW6sY= X-Received: by 2002:a05:600c:45cd:b0:418:9ba3:ee76 with SMTP id s13-20020a05600c45cd00b004189ba3ee76mr1378024wmo.4.1713528101121; Fri, 19 Apr 2024 05:01:41 -0700 (PDT) MIME-Version: 1.0 References: <20240418194133.1452059-1-michael.roth@amd.com> <20240418194133.1452059-17-michael.roth@amd.com> In-Reply-To: <20240418194133.1452059-17-michael.roth@amd.com> From: Paolo Bonzini Date: Fri, 19 Apr 2024 14:01:29 +0200 Message-ID: Subject: Re: [PATCH v13 16/26] KVM: SEV: Support SEV-SNP AP Creation NAE event To: Michael Roth Cc: kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, bp@alien8.de, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, Brijesh Singh X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: B62728001C X-Stat-Signature: 3ejcnshtnhd3rbc1sg39hp6pcnojrtwh X-HE-Tag: 1713528106-730336 X-HE-Meta: U2FsdGVkX19xjd0oEeCQtPMoer17UqMt618MNGpmMBz8WjcpRQLTpdgeBgR8spSwUQm0+l6+nBnoG9I2KaDcBGhg9O14+bc55PVeNT5DG1svfDJoh/owTy8kTX8Uc+drdkdDwTWDHepUUOFdrem7vcYVjXvWTj1rtumSP5c8JkOprlQ7bGdYHZ0GwqENHU58T/qUrQl46H0gpu0V22NLkwXG3yUREl78j+uvthz3ewXpouSii6Or1vJkA8VN6F7IGiVpNihE67tMhSFAzwMSV7k34hrHih9EpIjG4arrHbuOMkS6qPu0QFfgPy0AXAs8drNEMEVOmOP+egomgkiPGd0ymu51W0aeQjK5UgoZD90vx8PHiEHnOPFqo4O2dXTvoYzRjZf51+WjgRP9UKzV3XeN7kK9jEAOZWCXlq1G4FvB5VodfVK10f3UVJu5QFomvv8FdgJZjD+XAvEGxL7fad6clYyiLts0CAsNCWdypcj84QWU6e5JafsLdgD24t5xSVfpJjvgHyA+lzbBUIecbpELgutu1mpwV+QDLMIlLUXTVCAjGaBzDcGvLgBRwmhoPbBrHNz4bv1pOVZse709dr6Hj1Dz7QFtI+pobRce1CqL85cQmnO+U64Qhgl+ZFO6zI5N37HnCXyivakvWUEZfoLIz3cS4OhhyneCBZ6c4cLHxEqBvcgCOw0KVFDqmOdnV/t74PF8JcuFcgN3Gy7OR9VOpZbsOPxF1aSf7XmPf8b5r5lwx3FyNzwjQSpDVyCXexX1MGsJP7dCFAMwgDM5WFZ71Cs+NK5pPE08S/dZy2XAF/Xk9t3+uYU4q/gTzo8NsUo4qgMyplUwKpsTwoXAX8Z9/TVXjnEIgF/xiwuThGoGz/yurH+KlV4Dh68R0xSLNp0Tw3APXrurefBRWtHJuV55PsGDZwlORcDaCOgH0lfYI6YyAWhwaNTQqQrGLuyVWegXtsaR+ddxIdDyMli d3DUnJnu L6+2FV96fla7M+8zubB2+l2AHK7uu5UkycMO6oaNvszOc0mDHx5aovjDDR8anuVjeZu3+KAkLGrianDMnYjTqKTcZvLpL2vUuWB9Y1+jGoOwiAM1sLcQjwFuB6ihamfkpVhMijRq3YmRyuwd+Yp3JdaC0nFZzarVUKcYAKM8twIJdb0VNm5ppqH0vTzFzmyQNdadi8WtTfGR6SIy8dayQgcql5srnGAp7MAJp0PBDtVPwS9Q58IJQUi9SFzMXj7IkGKG756JWm4+COgVp8grxy/XwfItdi1JxUGXh X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Apr 18, 2024 at 9:45=E2=80=AFPM Michael Roth = wrote: > * the VMSA will be NULL if this vCPU is the destination for intr= ahost > * migration, and will be copied later. > */ > - if (svm->sev_es.vmsa) > + if (!svm->sev_es.snp_has_guest_vmsa) > svm->vmcb->control.vmsa_pa =3D __pa(svm->sev_es.vmsa); > > /* Can't intercept CR register access, HV can't modify CR registe= rs */ This needs to be svm->sev_es.vmsa && ... (see existing comment above the "i= f"). Paolo