From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F16B6C4828F for ; Fri, 2 Feb 2024 21:43:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 626448D0002; Fri, 2 Feb 2024 16:43:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AEF08D0001; Fri, 2 Feb 2024 16:43:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49DEF8D0002; Fri, 2 Feb 2024 16:43:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 398B78D0001 for ; Fri, 2 Feb 2024 16:43:01 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 03EE61A02C9 for ; Fri, 2 Feb 2024 21:43:00 +0000 (UTC) X-FDA: 81748189362.04.0505BC4 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf02.hostedemail.com (Postfix) with ESMTP id 45A7A80010 for ; Fri, 2 Feb 2024 21:42:59 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1Q1FBsQD; spf=pass (imf02.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706910179; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=JMTAKCnlm+qRofrbzQT0twQWPmdB7rbVAIRwYv4C2eY=; b=i1E/JFe/M7gliEO7POmUGlX09Dyop7rYAU2mz0P/HFcgY5zP0QDEpF1u+FrTFMtNcW/Dai 4dH3E6cGNeYmyUyL+sRPoWTpbN4gWCb31dNdeSejtlAwT4h8NvpL4Zuxe2+UasH/BMq5W8 /ha6qYqqDLjmknY8pAw+H7MN9AfT0UA= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=1Q1FBsQD; spf=pass (imf02.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706910179; a=rsa-sha256; cv=none; b=VXB0CfH0R1/AvtnjTkjt8vBczPHJrxeeJfAILZAzv2eIU2/Onc4puTjQDc3u0UJkRJuKaL AdIv4GR3jlm10QfTlg8Ff17jQCni2wSay/HYgR7pKisaq/RLhRkaHNstCqkkWbFD2RAO7W 3NEZ/GpW2yW1lmnOGBdq4uTPex6jQsQ= Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-604255f581cso15923367b3.3 for ; Fri, 02 Feb 2024 13:42:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706910178; x=1707514978; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JMTAKCnlm+qRofrbzQT0twQWPmdB7rbVAIRwYv4C2eY=; b=1Q1FBsQD/CYKs+CDhZ2+TUnSbrXbmhZNn7V1eJTZGYpyUZ1DJspQ2PJsZDKwPFWXOY vJGkapuOwMDdmhHEiewl2t84ImKurIvDd3WCz3uMPORkYnJG8GdakgvnvXfIk5BhuF+t Zwa2DCBH3NdE31yTddn24Gq5vzubWaKnkFTkYTuQ+K9W0e28FgVGfZMC8+VFPrIoOg/5 fhHnl4w4vXuzF2B3wNt1/8/PruA/bTXL8F8BgIdtxd+nAxFAEJtAz4bMhPTsfe9ALOdW s/QnQRDg5kEgLGRj32GIHNoeq3CTBmS6qx3BKT4uOldF/0uTvXl/5zrkK6/V5EWgjdM7 uPMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706910178; x=1707514978; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JMTAKCnlm+qRofrbzQT0twQWPmdB7rbVAIRwYv4C2eY=; b=aREYR5vYhznTd0/JUkVO+uPylpW8MaR34yYxOfNGCJ6ROdIigS2tgOI4eK+OvWNWdn xyVeeIMxoBRUysRY3iHhna4sUKkYlt1T2XybIsz/8geZY7w3c1MB3gaIPBkYOLwNc8DJ WhseEl7YVp/Hj1oS7Hs7MfSldfmada5lBIbE1HWv0TsQcBg9XIgwVzBXiN/mtLWjB/GA 4j+A9DqVcC/GN+0T9xesBlY/yFT2prZhl8DsBVronmSwh8KUQHDhbyBXCivCHLOG2jto BuGO0DRo/xwPT0dK3nNYhweuCVNrW0baYT9XXGHyxOvhGvF3L/LIULrCCAEQ5zba93Tq MZJA== X-Gm-Message-State: AOJu0Yynez+sl9G6+XgLz0IMNNOuxu4cyxUqn7AZuo/pqpeHdtB8GPMb LcaDHxWzD4C2vI/xshLL9Z58C2s4ZWvRZQchR+znqg7+rT8qLr/ILIMD8y04pnnnFMmNZfgJhUa TduuXOW03UVTYt9Cqp+uP4e+9+MlIsMtN7zGg X-Google-Smtp-Source: AGHT+IHCXjtFXHPMmcjKAuZloPxLqvRZDzLRsio77BcVGOg3RTtHzUSiPVrgFhG7UEsNkzW/caKJn5/hzaqDvapj1VY= X-Received: by 2002:a0d:d495:0:b0:5eb:3851:2bba with SMTP id w143-20020a0dd495000000b005eb38512bbamr9522889ywd.41.1706910178189; Fri, 02 Feb 2024 13:42:58 -0800 (PST) MIME-Version: 1.0 References: <20240201153428.GA307226@cmpxchg.org> <20240202050247.45167-1-yangyifei03@kuaishou.com> In-Reply-To: From: "T.J. Mercier" Date: Fri, 2 Feb 2024 13:42:46 -0800 Message-ID: Subject: Re: Re: Re: [PATCH] mm: memcg: Use larger chunks for proactive reclaim To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Efly Young , hannes@cmpxchg.org, akpm@linux-foundation.org, android-mm@google.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mhocko@kernel.org, muchun.song@linux.dev, roman.gushchin@linux.dev, shakeelb@google.com, yuzhao@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 45A7A80010 X-Rspam-User: X-Stat-Signature: ga9kaqo51mw1shy3ygnze5n57jd49nsz X-Rspamd-Server: rspam01 X-HE-Tag: 1706910179-896789 X-HE-Meta: U2FsdGVkX18yKW9EvqnhwxSoPGjmDn23O/R4oQGzadhAquL2ATmsGIzRIEq89AGjHDWNnoXEVZldaQhUQ3WF8Cms7ExrbL6gjbKq8oQMayl518dcuTEBtAD7dRzgmmaeY4w1Sa2k3h+keNkVXcjGa+ycm8O6vht6wedhQBm7PysfABe8k/19kQnenWICSqq7lbFeP3lI0TEUPZ3kVEUYKR9v+IJLOHzHNTDG1LdUjrp3iGgQde9U7gWB0lUdX6WctL4vg8q/SXNYemJNvXd0fhSxWRPj3WjcN3/n+7dUTjD2SiHoSbjtIZPEsSHGng5tMKEjj2KdQzuiEeA7zEMmh1ikfw74SXZUyDADD0KR30FZSjmKckLBqlqAH2qfxCLUR5/hkX/sFzEXMTQa94AQrmfPwiLEiX9Un2A8kv1X4tfIy4vsZOo49X3M5w/w/PiyLoLNaoRKaL4uRqSNYfGukztePbNfwiCuS4Ets6N3UxQXoAMmHy0eG0ysOI5/alVOvuMOAsmyCAI3psyoYDDGajJ/1/m81fzrg0YXcbGpRAdB6gZqK7csKg3EanwIa8nNBpufjcH79VJ3ZNDt2U+9lIy2ZKbS9xNkeBjrHV25nnEUDSW5FeOWbZ+/jx80GN6yhZrQYsOSmvypNaFh9NMBAbCe2qf9QcBMbfaVUte4mZyZsASDYVEsGMPRx7C/TPVMqudN6Z3u+lmdrMsNrUGis1zhNjomh4RWJ+NG+L5VbEEFAHieB8J9XF8urzBUuYe6B9fk/hPMisZBryjB9xCbFXUAED4y92q9yIEW9N3bwWxi7JEI+oxt4p/LDzNxlrDN4PQy2nIpBNKKSLV2GXLgiVlkFIP0v2S3JR1czYs5udtMhfCRJL9Gjgy7K8wW9DnIAi/V6BhM0uVz4Y9oaBQAqqat4QIgdk0s82n9bNcu5j4TmSD6UfyIvDy8FOZQXcT5fGNuYEGfviZkAM4mdsc /9tWwNUh v0kQLlah+8Vf4Mi+hlI6Pr46FzYIkyr7vO/qYmSKWA9MLSVJYHBzelvYQEp+c0AQ/KNSaJh24vrGXx0to13yMZZ+pPqqrX/KBVcngWWQ0QXNLw7aLa03WF7I806YFuzOYHQvhyQzIPkF0cyLc3PD8YWaPOIU7LKR3/Z6EboVIne48WgZMkZcfavkhS5Q3SiIWD91NAQ6UEltCjPGM1+lJWkdhioG5oxKz0H9BYaxnHud3kG6MxwtjEnz7EqxKGM/nV4FoaWkPOa8MRNXZF/MGGvUuAQnjJoNskTvQNQejsPXP+GSxOshQSzwa4Vavi/Uvj1u/Y8ckVs4e4Mo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.189730, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Feb 2, 2024 at 11:46=E2=80=AFAM Michal Koutn=C3=BD wrote: > > On Fri, Feb 02, 2024 at 10:22:34AM -0800, "T.J. Mercier" wrote: > > So all of these should be more or less equivalent: > > delta <=3D SWAP_CLUSTER_MAX ? delta : (delta + 3*SWAP_CLUSTER_MAX) / 4 > > max((nr_to_reclaim - nr_reclaimed) / 4, (nr_to_reclaim - nr_reclaimed) = % 4) > > (nr_to_reclaim - nr_reclaimed) / 4 + 4 > > (nr_to_reclaim - nr_reclaimed) / 4 > > > > I was just trying to avoid putting in a 0 for the request size with the= mod. > > The third variant would be simpler then. Modulo looks weird. > > Oh, and I just realized that try_to_free_mem_cgroup_pages() does > max(nr_pages, SWAP_CLUSTER_MAX). Then I'd vote for the fourth variant + > possible comment about harmless 0. > (I'm sorry if this was discussed before.) > > Michal Ok great, let's do that. Thanks for your input.