From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04A7DCE7A88 for ; Sat, 23 Sep 2023 15:26:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26DAE6B024B; Sat, 23 Sep 2023 11:26:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1F7366B024F; Sat, 23 Sep 2023 11:26:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 070F86B0251; Sat, 23 Sep 2023 11:26:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E77AF6B024B for ; Sat, 23 Sep 2023 11:26:15 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B9161A0284 for ; Sat, 23 Sep 2023 15:26:15 +0000 (UTC) X-FDA: 81268238310.09.2D1B735 Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by imf25.hostedemail.com (Postfix) with ESMTP id EC5BEA0021 for ; Sat, 23 Sep 2023 15:26:13 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tp7w5y6W; spf=pass (imf25.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695482774; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=x+h/az42itE2oKI662KLx1KdcIMxc2RkjNaC45gpe54=; b=xN9y0E2bOujZYiCJUfWVufHXMaq1A1UuHlpt1f3K0QzI90VZasjZH2TgOD9YIS/pw7bF+b RIKs5aO1EtWeWKCh4fnF3aFluePRQ7eLVN3z9tXVGD206SiGfbkW8MHcJ0gT4Co2CtpOdb NikLiCnHLZzy3oObJSmUn1ui003dumY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695482774; a=rsa-sha256; cv=none; b=W4GTomznGu2nlcx5b0Z7BRR9ibPoapDznw6e5M/k63j45yGwJk93B0xDAVA74O5F4x4zLl wn7eQu5TF3fXVw1LN8sqZBKpvndGp/tA4anySTc1piqGtNQmp9gi1cjuK0TqebxVsyJ31e Z9sK52lampIvvtDYQmLd0ZHjR1GEcvg= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=tp7w5y6W; spf=pass (imf25.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.177 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-d8198ca891fso4193003276.1 for ; Sat, 23 Sep 2023 08:26:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1695482773; x=1696087573; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=x+h/az42itE2oKI662KLx1KdcIMxc2RkjNaC45gpe54=; b=tp7w5y6WATI5A/eq1I8MW9A/Jhu6GgEgE4NvoXJzP4aHiNkQvGq8LzHNod0o6ywRLX xOUrZH4Rg/wHohiNBZEZuiWsB9gDhcy7sjtUZ6jslvmtzLPvpD/xn0xvx4QpQbm6DOkd DfFXaeWKgccfSKyc3nuvIkncyZLvrVmXqpJm3huAEexVJUn+Ya3hj169tzAoD6WTb5LY ONBXjAz8pp4z+jkztXn+2Cv/d7HSTwKonanGTiRbox2tUScc9FSTAEg/0yyefwbBTb3B Aos0oVnUIZlynFJdLVMWIqs6ku7881SQWUjb3FsuTd6xfmuc+W2vI7HwlpLuiHTfpfU5 v/yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695482773; x=1696087573; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=x+h/az42itE2oKI662KLx1KdcIMxc2RkjNaC45gpe54=; b=UIJUlu8Vlf40D8fsV51ig59DO3VrVAj5tgHSHu07CplDBY9vkx17/quylgJZrloZTy qb9ml/l0wryulTWtGPM1kpPUubkBFkKXjCZ8LFCPamKKFQn0q0XZbLZZZwdZbHMZB451 jNwBu9vGjJvBV8lqN1/WTRQbdl1NtPo2Eiw4eiNhh55WH2JP79dBtvP3nXzuHkcRPHBp aCiXuR/tSQnrGOkV57ee6WuePG7AAZDy7spY1oGO3lWfbRKs+FS0k/iKTAYURtIbyx3E KLbARIKhhSje8IdQ6MTGjv4FJHJbxFHVKjPRWZgd9P9Si9iipQGY0qB6WvwzqD8JxyoK p8TA== X-Gm-Message-State: AOJu0Yz5Tncxdv/7YrJAy6YY9FXnHVKMuETUd1BQ1by5GLR5z8NWyWSp iw1JXBBgbcdvwepfQcJI4wggk/rJdCEKkAHVKV5XwA== X-Google-Smtp-Source: AGHT+IEGmpdHWqw4w2snpe2G+qFtVOKWkEX4IPfs05uJV+CjCM2jUsVwu81JYX1gUtN3ZD/+ldATGpVopRS2goYjIbQ= X-Received: by 2002:a25:b94f:0:b0:d84:d709:7966 with SMTP id s15-20020a25b94f000000b00d84d7097966mr2743218ybm.0.1695482772915; Sat, 23 Sep 2023 08:26:12 -0700 (PDT) MIME-Version: 1.0 References: <20230921062206.14429-1-jaewon31.kim@samsung.com> <20230921122244.1cbf2d57@gandalf.local.home> <20230922022746epcms1p323c50015241eb01311e7e10579fd4c6c@epcms1p3> In-Reply-To: <20230922022746epcms1p323c50015241eb01311e7e10579fd4c6c@epcms1p3> From: "T.J. Mercier" Date: Sat, 23 Sep 2023 08:26:01 -0700 Message-ID: Subject: Re: [PATCH v2] vmscan: add trace events for lru_gen To: jaewon31.kim@samsung.com Cc: Steven Rostedt , "yuzhao@google.com" , "kaleshsingh@google.com" , "akpm@linux-foundation.org" , "vbabka@suse.cz" , "hannes@cmpxchg.org" , "linux-kernel@vger.kernel.org" , "linux-trace-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "jaewon31.kim@gmail.com" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: EC5BEA0021 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: cfs8p63gbory8oanxe35ihjr911hdb9r X-HE-Tag: 1695482773-853262 X-HE-Meta: U2FsdGVkX18W+wozWOAmDER0w5O6Sycp8tRLHJjvZB0TTntITnSabfkzvZ33akUu7842kAYeQIzss2YQPOdtBl2A0PdVWEUsmWkyGFBK/xbsQsEW9E2hPC/0hSWvkGgvb1Px9jprgFHDa1OJLTBbzh1JX+YH/s7OdeZ6veJbfybY/ol2CMAOyUc0xB3jMdLe2cM7/KatK18JRCmuSlmkfjkkPGR3Zdxv7F/MyzXUsGE35sTqESwF269X1+hWj3RQQ3NfeaOB4zOr4wAYdxOOx55/ALdn0EjiLbLKNdmWfNU3+4JysOG4+nX+2OUXJAmdTiK/y8tNrMLqygsbyCNOpIiorSnS5t70OM2LiQgQwfbP+6+8gDhWUdQMuSPDs8x3+2OGE7wmU5HQKVmJIrcgYbCrAiVeN89k/1eTLRsSahXNLHIr9XLF+DtQpkCEvfTTaGz8UdknwvWCzeM0bRAj1QpmKJ2jGQREhQscuocnctZFmkNltaJTLBuMSTaa9AE8OivJ6Ny1eNFeUsbMXqqVaxOQvSR19Ge3Ajq02unRqSI4dQr8xQHetBMxwB5iLRBYOV7Q9CHh/rV/Ny5BhQYAp5FRaruvQCaCOiFmSmp4FL56o5SUWlCBoHZbzDB7lZvzJ/0fpZxmSvGJo7Du6d1PrJr75gAk84naoe0A+KlV9m5CtjblxV+FO1DbhXmTNGozhQqyKKvDR8IqEHxHJLk9nR19NrnhWdvuLrL08LO31pR4VypATN1maE2D9bZ/VApsvPbDQN6kfDWvLGb5u1ox9Sxib2KonkHPiVnsg+s1Q298qBmfBBQIhqqZa7NKrrD/qf7pskRu9QBUvf0nX7NFo35rK5ySxUdXl6b3t+/y37AMb0J53+RCmBbPCdL9dMMX100cT7LCh9xP945nVb0xeOOfJ5lvd0BVANF4vcwaiI64uRLRoXI6xqScKagCfJXNepFgRqhWy04CCbx9PbQ 1Hyppfun qbsEfxodAQ0bkYSiELwKcbHEw3tUFvg51ZYeBVTySrrFLCg4kHeJxGlPAKYCjb9D9Jlz8uc5VvhYW/cLSnNEyB4ZOcbDKVbdOlatRqeUsf4r4qaXRJwyNJ+0oeEFAuwXRD6MPO06fbIwO3URVJnhkEMfhnmtAgfCOEoB+mAsRBaouJsiKdamCOtZ0HgvfkjwJbBtrNJCbCOk8rQy+UC3MxvwPKUt4tmlYJP9vWmB2ZD3/e9382gRglvld8Rv4mFhK6amHGG4KAytLfp3R4hcuRK94NKD5OIPO6v9lbaNstmF+nIgoSkzzYuUMFxFxhwVQjSmhQRHscO8KXtt6Z15MALSc7wylBH3Kc3/iEzOq/9FHEvVTIS5XuER/6UqMDPEWRfXCVZ3xtsW0ZbVEKEud3YPo+Yqy1VFZqr/L937Xk1bEDS3RbbkhpiKosQP2SOGGxbtC5fLN3fEHLAB9N8a96OJt/UCKWDxpfn10uNI827n5HCM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000137, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Sep 21, 2023 at 7:27=E2=80=AFPM =EA=B9=80=EC=9E=AC=EC=9B=90 wrote: > > >On Thu, 21 Sep 2023 09:12:30 -0700 > >"T.J. Mercier" wrote: > > > >> > + TP_fast_assign( > >> > + __entry->nid =3D nid; > >> > + __entry->nr_reclaimed =3D nr_reclaimed; > >> > + __entry->nr_dirty =3D stat->nr_dirty; > >> > + __entry->nr_writeback =3D stat->nr_writeback; > >> > + __entry->nr_congested =3D stat->nr_congested; > >> > + __entry->nr_immediate =3D stat->nr_immediate; > >> > + __entry->nr_activate0 =3D stat->nr_activate[0]; > >> > + __entry->nr_activate1 =3D stat->nr_activate[1]; > >> > + __entry->nr_ref_keep =3D stat->nr_ref_keep; > >> > + __entry->nr_unmap_fail =3D stat->nr_unmap_fail; > >> > + __entry->priority =3D priority; > >> > + __entry->reclaim_flags =3D trace_reclaim_flags(file)= ; > >> > + ), > >> > + > >> > + TP_printk("nid=3D%d nr_reclaimed=3D%ld nr_dirty=3D%ld nr_wri= teback=3D%ld nr_congested=3D%ld nr_immediate=3D%ld nr_activate_anon=3D%d nr= _activate_file=3D%d nr_ref_keep=3D%ld nr_unmap_fail=3D%ld priority=3D%d fla= gs=3D%s", > >> > >> Many of these values are unsigned so I think many of these format > >> specifiers should be %lu instead of %ld. > > Hello T.J. > Thank you for your comment > As you expected I got this from the legacy lru trace. > I've changed as you recommended. > Actually I changed isolate_mode, too. Please let me know if this is not a= ctually needed. > Great, looks good to me. Reviewed-by: T.J. Mercier > --- a/include/trace/events/vmscan.h > +++ b/include/trace/events/vmscan.h > @@ -367,7 +367,7 @@ TRACE_EVENT_CONDITION(mm_vmscan_lru_gen_scan, > * classzone is previous name of the highest_zoneidx. > * Reason not to change it is the ABI requirement of the tracepoi= nt. > */ > - TP_printk("isolate_mode=3D%d classzone=3D%d order=3D%d nr_request= ed=3D%lu nr_scanned=3D%lu nr_skipped=3D%lu nr_taken=3D%lu lru=3D%s", > + TP_printk("isolate_mode=3D%u classzone=3D%d order=3D%d nr_request= ed=3D%lu nr_scanned=3D%lu nr_skipped=3D%lu nr_taken=3D%lu lru=3D%s", > __entry->isolate_mode, > __entry->highest_zoneidx, > __entry->order, > @@ -525,7 +525,7 @@ TRACE_EVENT(mm_vmscan_lru_gen_evict, > __entry->reclaim_flags =3D trace_reclaim_flags(file); > ), > > - TP_printk("nid=3D%d nr_reclaimed=3D%ld nr_dirty=3D%ld nr_writebac= k=3D%ld nr_congested=3D%ld nr_immediate=3D%ld nr_activate_anon=3D%d nr_acti= vate_file=3D%d nr_ref_keep=3D%ld nr_unmap_fail=3D%ld priority=3D%d flags=3D= %s", > + TP_printk("nid=3D%d nr_reclaimed=3D%lu nr_dirty=3D%lu nr_writebac= k=3D%lu nr_congested=3D%lu nr_immediate=3D%lu nr_activate_anon=3D%u nr_acti= vate_file=3D%u nr_ref_keep=3D%lu nr_unmap_fail=3D%lu priority=3D%d flags=3D= %s", > __entry->nid, __entry->nr_reclaimed, > __entry->nr_dirty, __entry->nr_writeback, > __entry->nr_congested, __entry->nr_immediate, > > > > >Other than this, from the tracing POV: > > > >Reviewed-by: Steven Rostedt (Google) > > > Hello Steven > I've appreciated your Reviewed-by, let me take this on my next v3 patch. > > > > >-- Steve