From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B522C4345F for ; Tue, 30 Apr 2024 17:31:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A01F56B00B4; Tue, 30 Apr 2024 13:31:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B2056B00B5; Tue, 30 Apr 2024 13:31:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8529B6B00B6; Tue, 30 Apr 2024 13:31:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 674886B00B4 for ; Tue, 30 Apr 2024 13:31:23 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 29D8680987 for ; Tue, 30 Apr 2024 17:31:23 +0000 (UTC) X-FDA: 82066889646.07.208F2AA Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf20.hostedemail.com (Postfix) with ESMTP id E3AD41C000C for ; Tue, 30 Apr 2024 17:31:20 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EovKXXGN; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=tjmercier@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714498280; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6JwxAddIORoDjZb7vE3h0utwtl3KaibdVVn/7aWOhkk=; b=oVlXvvgZICX8gDOg8KJB+0vR/xa2lX+zIjOUs367IznIsJ6y1HieGS4K2JqHbuhg4XUdpP pnxbpXtFPmIm4+n7XlfqR97bYbSovsrPxjCsd/HBpfFOTCYtSqh5TM8Fv0unEMIrku5cUa JgJQF27sWe94R1oTuVwxqCTYZmiXVHQ= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EovKXXGN; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=tjmercier@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714498280; a=rsa-sha256; cv=none; b=kp30NCzSN3jG6vWkl7GaesSM4yn0IVYnSzrWhUw4FwVJkmjGMGLqdzfxxGvKRo1P6UspI7 48a9j17czlw+a0gIIgf79zCHjOQIPBOtl4i4FBu0iCy0NjflKbhwGEdmThiU7tEskkkwES k6KNsR5SPoL7lQFRZrx9ct1OtKI+knM= Received: by mail-yb1-f181.google.com with SMTP id 3f1490d57ef6-de59daab3f3so5453988276.3 for ; Tue, 30 Apr 2024 10:31:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714498280; x=1715103080; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=6JwxAddIORoDjZb7vE3h0utwtl3KaibdVVn/7aWOhkk=; b=EovKXXGN5W2GW7uTL/r3oWdUu5CklCxDZcyXfRP45SW2zuxgOohbrESW1W3oP8JMuF vrx04nsHQa7JEuYNZzEvJmLY1xflcZznZcUmGV1DbjjiqGulVd98FntZZdPn0IdxwrRk AUjs/uMksNxovTfj8daAsFyc2slEsZgK8nQbh3rLwGI8FARQsW7V7PTbkxP7agAYvMOL WzrqOgqdVrpuQq9JoaqD+ZodbG3rqciuDrpTu/q/5QS8pyMNvK/H3jL7E9b1CmGE1BgB St7OW+oL0/pR2OA2womIooMP7sGpr/cN3dFRXy4N2YstquNo8M3yIh+ipWPrhEVUNbIn pWZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714498280; x=1715103080; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=6JwxAddIORoDjZb7vE3h0utwtl3KaibdVVn/7aWOhkk=; b=xJPuUpA0zD4E/RNuFKj0mS+CDwOtDq6jiHk5l5SYwGcYVIEpchIW6t4/ffEbr/q7rL tE0rfw1wJA/lBuaHU3FMm3VxAvA55nUhfOZHEXsIGKO/fjgOz9u7AWYR5FM5rw8HEvCI i/lv4Xn36ERw2Cso0baJhYj3Mj7fZD6bfv+X2y+R6WakEvVZJTRu1ECUl031Rcl2yKqU 7OvIXghxeYX23omIjIJpQMRWe1j83BzhsCrhbKkVHDUDZcCyPGLRRXta7kIayPynNuf2 WL7orApfrVAdznOZT4GmkbkgEppinOcWnjVjBFJwUmqMFmDYeCGKO+F/Nm9nDK57eNyQ onbQ== X-Forwarded-Encrypted: i=1; AJvYcCXeF56X4qwzQh7trktqU3hTy1ldt1mYFa60yoL/iU8sSwWorxJwdRnKQoY4lrw8fLKgZmi3QZiF9LAzE/Mp27454ss= X-Gm-Message-State: AOJu0YzbYPc1d0SjPb4GPhcpw0qeMwlSDbCk+dzydC0jDf0TKglMgX/W a/vFJqKb4KzepWkwcfeDRs1mznIcIZwzMnnXtUZZJawBon2WUfYZsgT1JN6GveXnfu0FcmSdetw f0OBPiiafH02+ppCDKAtcHxuUbN71lt/ycdM8 X-Google-Smtp-Source: AGHT+IH2ACVPK5qhzjkvkzWZ+/A/LHh7HwsvSaGNnO5heFlYlzrgW2SD/J0T7ULwesjC0XZnvnmzP0ce7Okt0fZZF+I= X-Received: by 2002:a05:6902:2491:b0:de6:d7f:2a37 with SMTP id ds17-20020a056902249100b00de60d7f2a37mr262373ybb.6.1714498279865; Tue, 30 Apr 2024 10:31:19 -0700 (PDT) MIME-Version: 1.0 References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-6-shakeel.butt@linux.dev> In-Reply-To: <20240430060612.2171650-6-shakeel.butt@linux.dev> From: "T.J. Mercier" Date: Tue, 30 Apr 2024 10:31:07 -0700 Message-ID: Subject: Re: [PATCH v3 5/8] memcg: cleanup __mod_memcg_lruvec_state To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: E3AD41C000C X-Stat-Signature: xc8d1kng4kjkbgq81ptwtck8zigy8bbm X-HE-Tag: 1714498280-875665 X-HE-Meta: U2FsdGVkX19+HA0G8BQhf+pU59Di1cUwUMBAoQfSzN9VYk4JAOQ56JppnLCLco6xq2EWBIK4Uk4NrguktqVqFkNLDajgzwB5Fvo7gY/mZqoX8VqnPK3K8qdUz8lH61o+CsF/xb1kNN94AsuzCWPxbOYUU4sF8NCkb6g6n4uwabiRqkwNAJE0nLQkl5rG/twabDANcWVdJib6DpUNQzH/CqMmdCzi45wM4do1trmBHxy5U6RyG8kXKAF2z3iUSo0X42p6pw9mbU5QyJkRcjfJqyxdtIu/aH9YXH6dggt/+HcMWP0WSH6AS3jJF/P8og2lWuRSBOT07lA3nngyqi67XeN860KE5ZD9KRFcEoV597tIat72VbSb/mMJ1dIuIAOD+eGAC8k1sADrrToXatdrK4x3RLKdzEr8/d7WFrCho/MFvcxIfxbL6wOyXvOs3WlPJw9PxsRGGBVKV+TzzP//y5LmXZ2IKoL4T1wgcvTGrVPPcyxyXroFENGHHR4foRUTKJd+u8K1yx5c0dZVoy4EHKpXMmQcDEW3XOk7yJzZBVuDv7tZFDyRzqrNmIeqfi9loAl6tWdfMfSJKRMiD9jBXgq6SayoDC5KrSaRbWiI5N4SBykdPCp+z8Xxjj2IVO5wu8odWAjtfSM9C72CGxtrCCRO1Z8IT9T+ZhI0Z9xfWFJ9rX5veYvwcMKwejQPDvDQt43XunpRb7Gb11L1Kw0fqapG4/b8RIWMbpEozJsGWWEM51a7ZN6QWD6avmMMy8k8xBVjf6/dUtGYejvF5PaxF7kwW4OcSScIF8ICoo8E0vDvp2U3qu5O94HV5Kp8kkRM3PnQ76YQ6LzD9Sm49R0moB3OjTOu8mTsAuYzzvNDuyFAliIYtCDYKJEhkQ22AYXW75T2KkITZBq4VpwbP2OMkFDPAjKFIVi8l1NmfsJRbEL9Yuei0XqFtu9+5Ft1tCFoeF5Ic6983vJywFY521v phMRObGE Cm3mXh8rA7T9nZnnbHPyCsDuxC9mmRfFQdj8y0XcnecySAarl+QJdG6gq/n1nm+9vsoKPX5ile66hSl3UMbUWxxNC3wzF6IDtYAeW3ygfRItvEAipAQIunck3bA2doO23DnrwwYmJMY2FUH5M2QqOIRAIVCcVstbm6JHP9ISAJOJZfu2TbiDwpxcdKajqND4Rvwmrfrpw2OYzq+jhmXCHW++gXkzpou8NcqboHuuiJ1R9eo3Gb29n2vqXZ9q5Mi0sVmZTMWussl2Ku0Io/92pgz6tQsvp/Dg8Oeuybe+cXIa/BPTYfNEFGgi/0k429+qNRZD9j6E45wKyRqg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.185027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 11:06=E2=80=AFPM Shakeel Butt wrote: > > There are no memcg specific stats for NR_SHMEM_PMDMAPPED and > NR_FILE_PMDMAPPED. Let's remove them. > > Signed-off-by: Shakeel Butt > Reviewed-by: Yosry Ahmed > Reviewed-by: Roman Gushchin Reviewed-by: T.J. Mercier > --- > Changes since v2: > - N/A > > mm/memcontrol.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index f424c5b2ba9b..df94abc0088f 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -1008,8 +1008,6 @@ static void __mod_memcg_lruvec_state(struct lruvec = *lruvec, > case NR_ANON_MAPPED: > case NR_FILE_MAPPED: > case NR_ANON_THPS: > - case NR_SHMEM_PMDMAPPED: > - case NR_FILE_PMDMAPPED: > if (WARN_ON_ONCE(!in_task())) > pr_warn("stat item index: %d\n", idx); > break; > -- > 2.43.0 >