From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 319D6C47422 for ; Fri, 26 Jan 2024 21:21:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BD4C36B008A; Fri, 26 Jan 2024 16:21:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B84EC6B008C; Fri, 26 Jan 2024 16:21:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4CD36B0092; Fri, 26 Jan 2024 16:21:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 93CA26B008A for ; Fri, 26 Jan 2024 16:21:03 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 60B27160185 for ; Fri, 26 Jan 2024 21:21:03 +0000 (UTC) X-FDA: 81722732406.14.28CDF67 Received: from mail-yw1-f180.google.com (mail-yw1-f180.google.com [209.85.128.180]) by imf26.hostedemail.com (Postfix) with ESMTP id BB766140012 for ; Fri, 26 Jan 2024 21:21:01 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zM0JOzG7; spf=pass (imf26.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706304061; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jqSQ6/JqtbJ7/Z4GvmSnpd6osmjgOZaJXviYh+bhU2c=; b=W0q6scbaBf+TofbewfBl0WpnrtZgMZK4SZ4Pp0dq6qf5Bns+3PMEVXSnYTbUxJjCfHc1tZ tWg8x/H7cj5OO7/O4YAThw5M1bZmEoDaaNtVM5G21yqUk+o249wWFuxTWhUqyoi7nV2iJf 8OwiuIrMYd4MjDvAACDXxUzMW34Of7s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706304061; a=rsa-sha256; cv=none; b=bjiTAF5IATBQk0vKK7kFXaGxRWRJ/oWM5lM8opcCRCDxnSmO/ewJh3YIp4BrZ05qN6Y8hZ anZaVhPpudYYRGj8PFd/wS/Ku8jo4lAD5swd/wOQlDFT8Q9KKTGVvatnrfm578ozyhkMDH zKw3bL94AKpFzetr1TVXcIAdgz3TxmM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=zM0JOzG7; spf=pass (imf26.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.180 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f180.google.com with SMTP id 00721157ae682-602d2e67217so7314907b3.2 for ; Fri, 26 Jan 2024 13:21:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1706304061; x=1706908861; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jqSQ6/JqtbJ7/Z4GvmSnpd6osmjgOZaJXviYh+bhU2c=; b=zM0JOzG7tff0JF0mgmt96JaiSkITn0A8soIc8jcE/9/l6nmhTrVhCMPXIPWLaQKA/s x4A5GGOGCfRkPO9f3Dxyui0wI87Opz2oOcKf8bdOyrmepNUzL7DdCbJ9oagzmYj47Krq yQuX/+VJKQU3Uln4tC1m8qb6ZEQAffRXbdW/kpIRLia/PG0izXisilUUZ36RDkFYqHRB lb02iwisg2kykXMyyXUo5e3TzVuDRjuV33x5hSfREW1e82YmtzaIuoj9+4bwgHDiCyIZ kAzzT3payAWNUtjZxE2xD+ra3u1BWrYzatx7yVDjfkAI6rt2sZBY/Y9QueIVqCJ3Krl2 o3gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706304061; x=1706908861; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jqSQ6/JqtbJ7/Z4GvmSnpd6osmjgOZaJXviYh+bhU2c=; b=KIP/yd3A/1ctmi+4UKLO4sKmsf/dJXB7KU6J9znn9pm/CYtyr9UfHfniCVw2tyI6s2 bumRoBA08ISVUr22CR8t9OIhNlUzg48Bak+cfkDWzRMVJ/f2jRstzte7kFQSMSlPvz+G gYbTEndVfJZ8i9CMONZs4J7Oj8O+AmEoeB99he8Ix0ym1AfwEuBwpPjLIgUAuRJn28P6 dRXB8yASCHP0R0Y9RmLuIIS20gUARWooaF53k+2JBkCueaz/Nw1y0bD+mjvv/Ipg+0aD 9Vv8CaQiVVaw+aRspDXBOXVP/h33DI/OM0k3yCWX749DMAZ7zV4KaELXLZLlUpu4D0SG dN5g== X-Gm-Message-State: AOJu0Yy+KrarMsekYftg7Jim3Y10csVKYlk+Xs+qvH/K9OdOVI/djWmN JT/DtoV9YRoFRmzY5UZo0IEuBgSH2+HPV48XtD55khZiLB+k5JMvPQiHfara0/tuLACqBQDGSGp akml9hzvIHoCJYEfXuEDB7e3xSyHUshctukiS X-Google-Smtp-Source: AGHT+IEInO9IEFlzJRr6meAiSq4E2PgTyFNhUdgistQTybmuwE3VxXUiMiP/g5jRNnh4t1nO1wKJjTxi1oFnyckHOss= X-Received: by 2002:a05:690c:f8d:b0:5eb:3851:2bba with SMTP id df13-20020a05690c0f8d00b005eb38512bbamr522536ywb.41.1706304059761; Fri, 26 Jan 2024 13:20:59 -0800 (PST) MIME-Version: 1.0 References: <20240126203353.1163059-1-tjmercier@google.com> <20240126210642.GK1567330@cmpxchg.org> In-Reply-To: <20240126210642.GK1567330@cmpxchg.org> From: "T.J. Mercier" Date: Fri, 26 Jan 2024 13:20:48 -0800 Message-ID: Subject: Re: [PATCH] mm: memcg: Don't periodically flush stats when memcg is disabled To: Johannes Weiner Cc: Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , android-mm@google.com, Minchan Kim , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: BB766140012 X-Rspam-User: X-Stat-Signature: 9n1u4fu94w69sykzzd56xzb37ge3jon5 X-Rspamd-Server: rspam03 X-HE-Tag: 1706304061-970549 X-HE-Meta: U2FsdGVkX188QcayDjYlUwT2xJtzjbF2sW6IAHbT5O5Suv9Dd2Arf33xcwrEMBr+kbiqRyk4j4/5uqn39ngFMFrt9QBTdFceAC2WB+b/7rTsXvNrYWZF0XyNlPQxJ7eLo1OgLbFmqRfSqvyJhx1PDD8e5P8RWPVqcvGJXDcM8slj0uK9DLOr8QHA9VC/QoE3tniw9FapLdXG3uH971PZeutTiK13YVulleKwMZDWw8awLr/i+LEgHDoYT4At8DfW0mGWAf67+Kjyt/5XziiaLf0r7wzRbSd5orEENklU0XGpcBZS9nCg9eLhiT4OV9pDtrAgieXB4bDs1LJPV2t4sNXFx7dC0+zG7QfZhA2HW2ZN0mcpXvtVPtFefoIrAXmeahjGUwH87WE5yZy0B7M53ZT4YmIqKXGIIs/jKdh+d+QMT58eJS082+e9FSpbL28YAXVIQ/fPdsm+rROlNAZk9TdXijljvb1TOeIZ5IJO5NM/+PVImQwH8CdK5uV+xgd3VS620tux3qmB+shCOvoeDhZCMr7V1EDbNVkt6Ns4BWZXhX1ozeBw4QSJNk4JCwI3qOYoB1F4UzOQP6YpeEEwcskeKlp79Qua7fWXjTa5XhNlvDJJkrP47O+hiuHqAczXGYrL/T2YLo19WXZYEoaof56QmlK+76sqE990jsZLlW8XMT3hWKqC44IucwJ7Z+6EBAPmZbgZidyq3U9KYzdetUyd+mc9HMC0FpBoe3xPG9cM0IwlaETjalnRMONnSbhpai0e7hAJ1nT5nz6N0oyv5ng8MjaTvL3aPRjlx3tjKIk9/8NKSqDw5JP5cHKxXGJ+ntuk0T7q01J4FzPW6xjVyJMEQO/UziBhxpVUtX1qv345d0GaIGwJwBpPAzOmnMmXDO1ctlHtRKv4yxjP4WCX5LZJb1X1Ezkmb7HhOI044Gyi1v1xDHsZR3mysciq3Zb+XItAK7M1Le/sToXX6VU 2HA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Jan 26, 2024 at 1:06=E2=80=AFPM Johannes Weiner wrote: > > On Fri, Jan 26, 2024 at 08:33:52PM +0000, T.J. Mercier wrote: > > The root memcg is onlined even when memcg is disabled. When it's online= d > > a 2 second periodic stat flush is started, but no stat flushing is > > required when memcg is disabled because there can be no child memcgs. > > Most calls to flush memcg stats are avoided when memcg is disabled as a > > result of the mem_cgroup_disabled check [1] added in [2], but the > > periodic flushing started in mem_cgroup_css_online is not. Skip it. > > > > [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/= tree/mm/memcontrol.c?h=3Dv6.8-rc1#n753 > > [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/= commit/?id=3D7d7ef0a4686abe43cd76a141b340a348f45ecdf2 > > > > Fixes: aa48e47e3906 ("memcg: infrastructure to flush memcg stats") > > Reported-by: Minchan Kim > > Signed-off-by: T.J. Mercier > > With what Shakeel pointed out resolved: > > Acked-by: Johannes Weiner Thanks Shakeel and Johannes. v2 is here, hopefully fixed up correctly: https://lore.kernel.org/all/20240126211927.1171338-1-tjmercier@google.com/