From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A1D7C3DA4A for ; Wed, 14 Aug 2024 21:00:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B53166B00A2; Wed, 14 Aug 2024 17:00:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ADD3E6B00C4; Wed, 14 Aug 2024 17:00:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 956F06B00C5; Wed, 14 Aug 2024 17:00:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 768CA6B00A2 for ; Wed, 14 Aug 2024 17:00:19 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E74E4C11C2 for ; Wed, 14 Aug 2024 21:00:18 +0000 (UTC) X-FDA: 82452068916.24.9E0F05F Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com [209.85.219.174]) by imf28.hostedemail.com (Postfix) with ESMTP id 1FC19C0030 for ; Wed, 14 Aug 2024 21:00:16 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=A4JqxygA; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=tjmercier@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723669163; a=rsa-sha256; cv=none; b=jsnXb8Qz6pw37MRIHHYrvYvqGSeFbc+gfsupQFwXrVWmDoINp9IVDkcqbw+fb/SaTrZHmN P7X4zK7+eQXqr2w9Pb/yIMSD7Db25CzfW4KLJecWfFO4ZcYnNuGCKfCFbt2T9pHgbrmlJW W0wWau8glirPiQv01QTxDkhwwQysh/w= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=A4JqxygA; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf28.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.174 as permitted sender) smtp.mailfrom=tjmercier@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723669163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=HBRix1wwOMh4arF0zGt6se8WJ5OdxF7B5CsJBNLT4jw=; b=XQy4bLlOSsQ6sCY7f3MSCW2quLJnZx3q4n+11lhZ8qkAqRog0WyVLsBf90E+ms+wMlcNjD GdJn6Jj9skaywJLRTW/EHgr9N0JiexaT4PS+S7ftq9OWUl7eJXujND0xXnikqR8qVzzeh7 AlafNJHqYPRzNRbsNJDakC18KgP9oxc= Received: by mail-yb1-f174.google.com with SMTP id 3f1490d57ef6-e0b9589a72dso330307276.3 for ; Wed, 14 Aug 2024 14:00:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723669216; x=1724274016; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HBRix1wwOMh4arF0zGt6se8WJ5OdxF7B5CsJBNLT4jw=; b=A4JqxygAkSEuVf8E0IMdZ1SkxKgRgO0dC2YJAQaGevshkACQYtyxKMu+Za+AtX5XAS z6+SPgSmBYOFKp+ZCLgvJ7tPwz7f1x2ipx+Y2LJuH1faxaM5f1r1lh7brUmp+2In0aoH TeZ7wIknv70P20Dj4sRfzc91eo1nKETyumhjSN8ZK4XZal7lIuLteuRFLvBUGGqeKsr8 fp3QtSbh1AtppiCnTUXX34BNY7UFNSpMLPbchXZhtk++0X2rD6yPu5HLVn8LH8ArnFSv yPc2BZdMTNaecqiHmMBnPRa999yirJIG+iMAvkaBMB3bqWIOOZTGGXe7T9Zh1kD0SQou YNgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723669216; x=1724274016; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HBRix1wwOMh4arF0zGt6se8WJ5OdxF7B5CsJBNLT4jw=; b=QzYXJm8MNyRuoIW2Uig69pldCTYd2HO/nlJWCAy5LrzykiQJ5Gq8mBVaJyvchhO99L 8bbsf1kB4rsT4MOuJDDOEpfPkcDgL2HiLDS1YaiQuPj06uIv1GyXp7vghHD5bvkyz+Q6 VGI7W/59sKhZW6CpRGhW9V+JhlXXaJVnRqLkoSTd8mt4JfnimNyLgMNqCT4Z+Kq1vXoh 3EHRw8K+b91Y0bvUwkwFxKBVIgwVPzhoKD+3pmta+gKupsbVtVnCLrT+gpPeKCYOrV9S p+bk71wasj51YVHRguzK7jh6PBjneXGRHsJmBy8GvU99LnFMx0iMWhKyLHnrAH1hqHdx CrxQ== X-Forwarded-Encrypted: i=1; AJvYcCWAITTTfytm6nNi/O6yJ66kJfzF7JsnexZnX4gyjcm9R5uJCYVC2zWoYq2UvILmdiuhyitTVO2YWA22NMu2XJMP6g4= X-Gm-Message-State: AOJu0Yxx5bFppdgzkwuO9fwGkHIH6gpdEr6gFqLKuInyC00g1/UyJ80s QPaIgwOlhne8rM5GA/YYAm8M76TsQCRVPXdAI02QNoGBDLsLfGX7z0UqtYpz7vtbT9Zuv8fuF6U b0AFvfGrRJriifBT39T8Pp3u69wk61NOWF0ie X-Google-Smtp-Source: AGHT+IEL2neSDQmMRmgI8aTlzUOZ/xklZeylZk3AG6/Zf9u+kVpogZQGc56kVsahQZFWMpFciwzX7ON3q+IoZZDvYxw= X-Received: by 2002:a05:6902:188c:b0:e0b:d2da:2422 with SMTP id 3f1490d57ef6-e1155adf686mr4709547276.25.1723669215863; Wed, 14 Aug 2024 14:00:15 -0700 (PDT) MIME-Version: 1.0 References: <20240814202825.2694077-1-shakeel.butt@linux.dev> <20240814202825.2694077-4-shakeel.butt@linux.dev> In-Reply-To: <20240814202825.2694077-4-shakeel.butt@linux.dev> From: "T.J. Mercier" Date: Wed, 14 Aug 2024 14:00:03 -0700 Message-ID: Subject: Re: [PATCH 3/4] memcg: initiate deprecation of oom_control To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 1FC19C0030 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: aezz53xom94gm7f8xf44mu6b4n6mxrun X-HE-Tag: 1723669216-717719 X-HE-Meta: U2FsdGVkX19MJwtp9oCB8JpV84h3ueUhvGyWCosLsQfeNm44tfrX+ae/kYPjnVu4NC4nJzUDUxOAaOilckKpGLoGvt518Y4R+DJ/d7ODMwplyoRpI8YSiOMG9r8vdJE5y+iJ6EOq4xUisfIQ+ArzQQ7fw9lM13hpzGBonE12E2ab2ycvZDcKt5eJ4D9LQIsyYE+WRxS10GZVnLUjtv764NBy6T6G7sQjuEVSsJyJpKklQBmz8OQQyN02fxSEaOiJ9jURSjloDkwuyXD9tMZFM8/hHbcTgD662B0oqIhTivJMyyl5euSIvfZ3xlpUDuuNMRs94BmnTrzEDNrYlmbwlWnyt6PURysgzN9973Wc8B28uNhM8plsHDmXSdKz7ZzBpCO4C9YyXHw+cPcZL9TxoDTbiEDdR+vugpLJVAB1HJeOrMeyJ0mTIDRl8jG20CGAgxudIz2r+/q9jaZ3AtHt48g8SLBpHj5D5Lne5YyTl21S8KTK9K0BZgBMHZ0QvQWZsiTy9/5X5DqoMW9X3JNhoJolpu+eS++moqzNlrtrBFOp9wtWnwc0JG5QQEo21Vx82R8kZDghB4tTuh59OxFyUnjyinP1R+pCOacK7zVFpqiVrn0ixBYPrRXjJWM6zQqh71cF9hyiD0D7lpA5EmNG5n6f732/cUKMhH/nEHys9fAvYhsL61HhkpmjtBwQOv3zhY1w1f/KbmjpWiKFTSzLrHMY4h82i4zPN4CSsfYA3LyClR75cJg/Xf9BMgUxYG38IF2Fp3McS9Zd1PJs1tW1jMMHCC0rmu6zr7H7xIiIUSgMFgFzDp1RiNoadudVzrM/F7qSFNNzgNWpWD/ayKZmnsKPGi90SMLf8UX36xsXcawciM08ItywqSR+UdJxdABMcuPlujrB3BPmd9lr0FsVvHbGZIjB94r8HHdDOJ8x/eZzh1dg5UiKMW/CYR1XOeYS1l9wDBpoNH9zsoJl59i SZuf+RTQ Hx2lDnoFfS0rkS2n//gYyh7TLN9jFa5+HAOyubaY5sH8yYEr/cT2iiXEoNky/Y4nMGE+DzGlfQ3osU5R2k/IB3efy+sBNb9BXjsoCLW9ueS/N23gcKSz8UNILh+rkChQldLUeaBB/coofklGAGSxe2qSN0vWLIbe6J/e1XSO7Ng1A8t/x3GoI+ltHBt4B9bsHSLjfuJX6/MlBgQPolTuqH29NDx7oDg+mbZQGMvRVoMYz+CN27j8f8t4UYX3i0cv9DmPqQt5fGA5lk8MboqHqBUrgHg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 1:29=E2=80=AFPM Shakeel Butt wrote: > > The oom_control provides functionality to disable memcg oom-killer, > notifications on oom-kill and reading the stats regarding oom-kills. > This interface was mainly introduced to provide functionality for > userspace oom-killers. However it is not robust enough and only supports > OOM handling in the page fault path. > > For v2, the users can use the combination of memory.events notifications > and memory.high interface to provide userspace OOM-killing functionality. > Let's start the deprecation process for v1 and gather the info on how > the current users are using this interface and work on providing a more > robust functionality in v2. > > Signed-off-by: Shakeel Butt > --- > Documentation/admin-guide/cgroup-v1/memory.rst | 8 ++++++-- > mm/memcontrol-v1.c | 7 +++++++ > 2 files changed, 13 insertions(+), 2 deletions(-) > > diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentati= on/admin-guide/cgroup-v1/memory.rst > index afe5e95e9f7b..74cea6712d06 100644 > --- a/Documentation/admin-guide/cgroup-v1/memory.rst > +++ b/Documentation/admin-guide/cgroup-v1/memory.rst > @@ -92,6 +92,8 @@ Brief summary of control files. > This knob is deprecated and shouldn= 't be > used. > memory.oom_control set/show oom controls. > + This knob is deprecated and shouldn= 't be > + used. > memory.numa_stat show the number of memory usage per = numa > node > memory.kmem.limit_in_bytes Deprecated knob to set and read the= kernel > @@ -846,8 +848,10 @@ It's applicable for root and non-root cgroup. > > .. _cgroup-v1-memory-oom-control: > > -10. OOM Control > -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > +10. OOM Control (DEPRECATED) > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > + > +THIS IS DEPRECATED! > > memory.oom_control file is for OOM notification and other controls. > > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > index e0bb54e42011..07343e338e4e 100644 > --- a/mm/memcontrol-v1.c > +++ b/mm/memcontrol-v1.c > @@ -1907,6 +1907,9 @@ static ssize_t memcg_write_event_control(struct ker= nfs_open_file *of, > event->register_event =3D mem_cgroup_usage_register_event= ; > event->unregister_event =3D mem_cgroup_usage_unregister_e= vent; > } else if (!strcmp(name, "memory.oom_control")) { > + pr_warn_once("oom_control is deprecated and will be remov= ed. " > + "Please report your usecase to linux-mm-@kva= ck.org" > + " if you depend on this functionality. \n"; Missing close paren? > event->register_event =3D mem_cgroup_oom_register_event; > event->unregister_event =3D mem_cgroup_oom_unregister_eve= nt; > } else if (!strcmp(name, "memory.pressure_level")) { > @@ -2754,6 +2757,10 @@ static int mem_cgroup_oom_control_write(struct cgr= oup_subsys_state *css, > { > struct mem_cgroup *memcg =3D mem_cgroup_from_css(css); > > + pr_warn_once("oom_control is deprecated and will be removed. " > + "Please report your usecase to linux-mm-@kvack.org i= f you " > + "depend on this functionality. \n"; > + Missing close paren? > /* cannot set to root cgroup and only 0 and 1 are allowed */ > if (mem_cgroup_is_root(memcg) || !((val =3D=3D 0) || (val =3D=3D = 1))) > return -EINVAL; > -- > 2.43.5 > >