From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 62670C4345F for ; Tue, 30 Apr 2024 17:32:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5F6D6B0087; Tue, 30 Apr 2024 13:32:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0F4D6B00B7; Tue, 30 Apr 2024 13:32:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB0436B00B8; Tue, 30 Apr 2024 13:32:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7A4636B0087 for ; Tue, 30 Apr 2024 13:32:21 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2835916057E for ; Tue, 30 Apr 2024 17:32:21 +0000 (UTC) X-FDA: 82066892082.06.B27AB59 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf20.hostedemail.com (Postfix) with ESMTP id 530951C0005 for ; Tue, 30 Apr 2024 17:32:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SkhLlEl9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=tjmercier@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714498339; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=yW/DKRBIS4ATn0WcLDg63sbAJpcKsatVFeaBysHTbx4=; b=JkS0XjVQ1XJgP16Xz1fzEbKWXilJpsi69g/XZogxAGeTM+b+Jn2431fSvy3YkamfRIMRfw WIzYko/LSYCGGoAqSFPZBQ/JxncJhVfgRNMicNWSqvZGsOOwaqFbVs2R2/vdoxCUhlYrHZ 4JeOkZ1VmciuDXNUgJqavjHv0yyhvrY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=SkhLlEl9; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf20.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=tjmercier@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714498339; a=rsa-sha256; cv=none; b=mBf6+4tqxR03j2SzxBe//R6odVrczzHTrzGYxCdOXVcGCFr56OTf0c0JBpvjOk1eXGPYlS 6cdBacLc/LGA8qRfWD7+bCsPWfUQuDzwrTObXWgNYqP4t8l4HOVGp0X8ZG+Tqnf/2RU7fL HNDS8eaLZt0LeqpQ/E3iY7+Fnu3emTE= Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-de596c078c2so5881680276.0 for ; Tue, 30 Apr 2024 10:32:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714498338; x=1715103138; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=yW/DKRBIS4ATn0WcLDg63sbAJpcKsatVFeaBysHTbx4=; b=SkhLlEl9K4dTktlbU5tqYDrQFZBOaOor3dmon4mI9QRoZUhmxc+f8ievsl42DpOXAE dgThL1CTvvTIdgBlcvKBDJAMVYLRaJo0yhT7KepvTi+wWRBxXjuNkSltYuIfjTyupXOx OHd5ylBvGv/Zor9GE2NrSb3suy351LRns3W2rLd/El3088us9ztG9S9y8++eNUJ8UlDO jx6KB2723o11wqpLQ7+zYxz+pizM3cYaUPuCGm/Z+ML+rpnc6rcmnFdE3h/QLk+GfaDr EH9JklrDXIJcE4LQx4WGQdXMPIffqkhQKPT5fUcXegihr62XHDmjkTtxhJhbm6+C4tVY p59A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714498338; x=1715103138; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yW/DKRBIS4ATn0WcLDg63sbAJpcKsatVFeaBysHTbx4=; b=Zr6iB1kuqcV+NdX4A8On5DHQsM+fsz3LTnE7ipeQju6gWfZ2H+snWpr3cXRMCJK/ar Adb/Hl7ADmt+VAk6yJ2lpnPiwMmZ7U98pi0WUZcxGdD3VSvI0yApBLKcvKTJAscRytV4 mXJKuNYnQ9Juk115V74vWp/v8JhPi/8+kZwedi6hNhI1OUupwlMMXRXUjIESCGom5ONz 7Uce02QP30ub7SWby+vwjFiQxzy72ei0UkJBf29g9kkNgEcKw1RVWnRXE6xXljADAHRE TbmyXe59hetT+GQSE/jywa2cSaFFppd7sild/lKpMTQawuGp07vCd84Lfb7+B1kog5eh 4TJw== X-Forwarded-Encrypted: i=1; AJvYcCXXCqe2ls969PyvXi5apFTlUElACuJet4eaTn3nHM4eMD8JxJWVIR9lTHfQDg/Jeju11fSnTshfDDWBI3lLOpT+Xzs= X-Gm-Message-State: AOJu0YzBK3PV1Gq1n/UyTNS0rhsNLR8LPvW/G33U2ul2O5z24yDUv4P6 fl1F9d9QN9vktgZ/yRjCGH1YX8CTHVycBuL4stkMNhscv2JL1T+ECh1TE9dUrmQv41nELuRwt0Y 895wDG4wGHgDBGINNa1GRLcdnyPebs/AIe7A8 X-Google-Smtp-Source: AGHT+IGGj2j629aGObH5Im8Bk3IRYjZLXCZc3eAvdRTbmkI73mygaiDZqMZuoLjAKsy7A7OQwr72htT4re5sSltDfIc= X-Received: by 2002:a5b:609:0:b0:de5:5a39:2cb0 with SMTP id d9-20020a5b0609000000b00de55a392cb0mr184524ybq.31.1714498338252; Tue, 30 Apr 2024 10:32:18 -0700 (PDT) MIME-Version: 1.0 References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-7-shakeel.butt@linux.dev> In-Reply-To: <20240430060612.2171650-7-shakeel.butt@linux.dev> From: "T.J. Mercier" Date: Tue, 30 Apr 2024 10:32:05 -0700 Message-ID: Subject: Re: [PATCH v3 6/8] mm: cleanup WORKINGSET_NODES in workingset To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: 4ngrh3xzpox19meuxm6hfa3pw3b4icqk X-Rspamd-Queue-Id: 530951C0005 X-Rspam-User: X-Rspamd-Server: rspam12 X-HE-Tag: 1714498339-886111 X-HE-Meta: U2FsdGVkX1/ZMVI1ZfuayfWyBij9BXG6SXQK8afK0HV7Bi6wSnB5JTsgjr4/ZL3mGx1pGeP85kKeFCz3aw79ZEoyzxkq7LUFZ0qUSSPYiDOTVfSvPNKbx/uLvy7avKHSQpNAS7Z/E4jp5HSBjzRobgAlQoxR4RkKOhO2dzn4Wetj6Kr8xvcoO3dF7Zkv4M2df1UaFTnFtQXJvTOJhTDtbMGG4kCx+mYO1j3+96wnbaRmjGaWrsRErn3GvpDQUUALftwJzCNlNIoEqZagGFY7KEaY24pDReYZtqDEQmju6TZ/20QJyQGIk1W8CZBKClR10T0EUDoemkArcAPui4e5GN+U2W78SUPyYFyC1K0l1H97leRWRgUQbZK3At6MZBmIaUkgBxzuGD+By42+JhMzsn4/MG172+gbZLmuzA2c+fnvt9nQ8vg4H3xeov3ilhyQIOYfXc4YNNHKIagacGU2nrwaG0XDxYnV6REwrNS6o+6vCg0ARYjPU4KDHWu7ij9SFY5XB1/COGV0SuXWOBaEzzvPtx31JKJmxdxYjLrQuuJQOb6AJhNaV4N+ZBJyKE8kewVviGqKfUn7foY0D++qk33IBBU/ldq0wNKqxdpsrt+f4w1UyCudDELZZs5k9Zg3YsPGPr5N+XVK8EthqFd+ilxweyWCCkcsvDa7cj+/idL+eLDfxXLwgm/IFQ5e+rO3FXQppPoMggBVQjStUNkr5uc/4vGeCdjnjjMTt45jDSWIUvvOuvgxoJFVaO1fcbRvvZpZYMh+TYtvHVf8Ixiq0UbWInoTFB4B+q13ZqVVWcsmmMF1AcVdzfejjTA/qxK+k5YiG4rUwVlkMiskOviHQykaLuIaxa+MZQQ2lttWC9ZDE8vpe1mspmamSfSDKCfflMxLGRvHoQHYKSe1Jxf3N7uO1OqIZYeG7oDCEBHWGvANzSOEek69U+9aCsmFQodVRO+XAHEQnnPQXg8vNop yayKCDau SmMdHgRZo+bS6P3rjXkqepIMfheAdcxpv1lUlytqurWw2IXQFa3/1I9xiUaRPAgnsJGVuc8YWxPT5UaxvHhuVz3NyuD0V+kV+hxkWrjTPYQ5l2LpxzfaaYjui//T+j1eQrYoR/lS4WHQeDcSpyW5pe0Hk43IkIWaWnnJI6pZ25i3vF1KWlWUns12gsa64W2JFKBe3b/xDyzacqMkwDl9pM6ocCp6zOrhvHcuacdxy+PcVt/9e2kyWAZ5NPeBW70qSepCC7oIX6ZsNElc3tAVM/tWOTsJFfIyH7ubK6ElKz3uUK30zbTAKEbNN9hHB7xvJ9EcP+iOAsOj2qC0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 11:06=E2=80=AFPM Shakeel Butt wrote: > > WORKINGSET_NODES is not exposed in the memcg stats and thus there is no > need to use the memcg specific stat update functions for it. In future > if we decide to expose WORKINGSET_NODES in the memcg stats, we can > revert this patch. > > Signed-off-by: Shakeel Butt > Reviewed-by: Roman Gushchin Reviewed-by: T.J. Mercier > --- > > Changes since v2: > - N/A > > mm/workingset.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/mm/workingset.c b/mm/workingset.c > index f2a0ecaf708d..c22adb93622a 100644 > --- a/mm/workingset.c > +++ b/mm/workingset.c > @@ -618,6 +618,7 @@ struct list_lru shadow_nodes; > void workingset_update_node(struct xa_node *node) > { > struct address_space *mapping; > + struct page *page =3D virt_to_page(node); > > /* > * Track non-empty nodes that contain only shadow entries; > @@ -633,12 +634,12 @@ void workingset_update_node(struct xa_node *node) > if (node->count && node->count =3D=3D node->nr_values) { > if (list_empty(&node->private_list)) { > list_lru_add_obj(&shadow_nodes, &node->private_li= st); > - __inc_lruvec_kmem_state(node, WORKINGSET_NODES); > + __inc_node_page_state(page, WORKINGSET_NODES); > } > } else { > if (!list_empty(&node->private_list)) { > list_lru_del_obj(&shadow_nodes, &node->private_li= st); > - __dec_lruvec_kmem_state(node, WORKINGSET_NODES); > + __dec_node_page_state(page, WORKINGSET_NODES); > } > } > } > @@ -742,7 +743,7 @@ static enum lru_status shadow_lru_isolate(struct list= _head *item, > } > > list_lru_isolate(lru, item); > - __dec_lruvec_kmem_state(node, WORKINGSET_NODES); > + __dec_node_page_state(virt_to_page(node), WORKINGSET_NODES); > > spin_unlock(lru_lock); > > -- > 2.43.0 >