From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33F42C10F16 for ; Tue, 30 Apr 2024 17:30:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9B2076B00AE; Tue, 30 Apr 2024 13:30:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 962896B00AF; Tue, 30 Apr 2024 13:30:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 82C5C6B00B0; Tue, 30 Apr 2024 13:30:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 64DA86B00AE for ; Tue, 30 Apr 2024 13:30:08 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 11430140A1A for ; Tue, 30 Apr 2024 17:30:08 +0000 (UTC) X-FDA: 82066886496.29.82F9C01 Received: from mail-yb1-f173.google.com (mail-yb1-f173.google.com [209.85.219.173]) by imf08.hostedemail.com (Postfix) with ESMTP id 4BAEB16001D for ; Tue, 30 Apr 2024 17:30:06 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KEOuDY+7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=tjmercier@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714498206; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lm5P6IOa3RMwDfuQvPxY3o2hNKAu49zNJupUAM6VZ+I=; b=HbOzy0NRmNx5ogh5J32S+buxKxBC2egRBAMGvnOSCJs7DvBXubLEd9aIi9GQ7RGXgzKs7f n8VF5IR2UEeULorqLU+RFsPasMAzmBbwBCrHIrNQPRNAZMohW+UtqW66O0SzjEqZvFNTQl RjyEb3R6lcETFhsg/2402eU8ICIbphk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714498206; a=rsa-sha256; cv=none; b=KmqxLEvq/Jc6KMC5JsvGUNV7eIURQbBjPSuMCdTf/6ot0RjOIFxtRXMBoKUq2/e1+ke96I ujS+kPCTSBrwFgoffUJeqNCLefAzlKkM/yQAJDLf+EkiVspBXF1DQWjXuUZcnWMJChguwt oOQ+ZIvSih2SQSyXYab66olF5WCJMm8= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=KEOuDY+7; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf08.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.173 as permitted sender) smtp.mailfrom=tjmercier@google.com Received: by mail-yb1-f173.google.com with SMTP id 3f1490d57ef6-dbed0710c74so5666378276.1 for ; Tue, 30 Apr 2024 10:30:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714498205; x=1715103005; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=lm5P6IOa3RMwDfuQvPxY3o2hNKAu49zNJupUAM6VZ+I=; b=KEOuDY+79zzaXGWkw9IN+fHHwj7v5sYXZ/ufOpyFNYqeHT0hEmZwOTSPMlRN5kInBD XyXsHRgj0VhRhIrvzMjQFn0mqFjVz5RWFfd6F7XafZF9HH3geEFc+H4VT/N8k+fqzvNI /ydT/k+vkL+gdE0xN4TlGedu4MiupW8IfQeCYBE6Fke7ERz3mbEvsUupaRHrW8y3X9vc EViYH9YxxqE+Byq6lGiQQq+7kn8EtVjluLr3t/ZljZBSvGUrF1gF22I6TyW6zh5HqnkS ZJZ5CTU9zi1CbLWYYwCxwIsBzEIk/zBftzPpVAja18WLwHLTkHMdI2LmxJCRlnxkt3d1 f4nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714498205; x=1715103005; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=lm5P6IOa3RMwDfuQvPxY3o2hNKAu49zNJupUAM6VZ+I=; b=fal8MbmBYgFsdqFZ3Di7aTn01r5eaVtZn47q3tybH5w+f/88XxBen+UH/TpVM312hR nn7TIe0E03DMWLrhxA6yloZ/DBefyQkdmzBDPpr1+sYhkDTrzS9JPsWVsCE04fzygaBQ pi/HK6UDD588I0w6TfCms92nzvSt8qKNY30WaOWvtXyZPAKcXLCte2IxQRq/VfShvH1V ccIXhbYz7jfL6OcdGS4naXeu9epD+lZZXiVrG9Jkm5nftsrRtR+Bk+aacYCzpqHNonjy 9IHR+6qIgF1xoRgfdT4YmignKWTH28WF7dJdB0FakidjK8MnjDl6voLcEQMhX9VAMNHs cbkA== X-Forwarded-Encrypted: i=1; AJvYcCWsUmUmrZHML2WGryCG6CsxeHpk6/TWMojvsLjXyc4P2qR53dJAIzXAbnVrIi+31fAS5a+hyKT5chDg3YYP1M284aM= X-Gm-Message-State: AOJu0YyXHT96DBAVll+CADmalFQ4b4sq0cfYHvKLac0jIWF9jJwaJFCX 3bmiPMrND3r6H/FldGJ9to0vL3mtR788IBPe4RUWWxZyDNy4SWUfLMgxQdbLd6sviBrieyyKJn2 tE0o4Huzg1SnaUs66BVzG2A4VD9eUKmxEuFVg X-Google-Smtp-Source: AGHT+IGLCMJMaJ8vivYqAqjYqyClXYQKm02ht9XqedwsjAbByqHfmkONanDJ93jtdsZ7VdK7yIACdV6MuXJx8gG8bIY= X-Received: by 2002:a05:6902:2491:b0:de4:7816:e7b9 with SMTP id ds17-20020a056902249100b00de47816e7b9mr288420ybb.17.1714498205222; Tue, 30 Apr 2024 10:30:05 -0700 (PDT) MIME-Version: 1.0 References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-3-shakeel.butt@linux.dev> In-Reply-To: <20240430060612.2171650-3-shakeel.butt@linux.dev> From: "T.J. Mercier" Date: Tue, 30 Apr 2024 10:29:52 -0700 Message-ID: Subject: Re: [PATCH v3 2/8] memcg: dynamically allocate lruvec_stats To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 4BAEB16001D X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ozcjphr6fqeq4zzxqnqm8wtje6pb5bq9 X-HE-Tag: 1714498206-655919 X-HE-Meta: U2FsdGVkX18NcMVcygaLLwZpzAxMgVvJ3SgfONYkDv+gqcpWMxXzhZmCMGH6Y8Ec3vMN6pOVkDUCgMq1Qw3IfNKa0vHtH0K2irz9qI2kyZAUknxT1X819ad4zQBK1fdT0dVeTaFeNrWpJt/w7mDCUc2UQd3xFkVyFCxip4BqG1Ox53fKlr5Jy7P4zLqyeJ62jEPamHRKG172+FHEoywC4Lqy4zx6AUEPzCl/0RuqtWbfKze3dQxk0Z3J8Jwfoiqufka4q4rHk0/btcFVCmCPB/3aoZ/DzZ5pOA+lRCYmmWqjVznawAXQm6NIdUJCdSIfJS1Wib6kuDop2bqt40Kzhi0KVdOt8mGN8GEWpRF/3fbQ0RI9BDvKx9E2jj5uA0zdgygwogSPbESzU3FMtqK9Or0ox0SI4IQgGFLRxgSl0EVfAOeTJt+o8PVsIeGj1gD3oMNIx0l4CBZMp7xChVCuENjATknqzWh154rdLypUG9ARgJxX/5z6nDFEfXTW6TDuG1GGSuST2F88TNnlxbFCXSqQ4ZZiRB85QGXsc5eSt41//hYgoVQfS9oNR6+I901KptTyvH2oJqFJj9J7OqH3I2gbtLoTnMYDEidu7ACFR2w+mmxuvLLTgixfj7+uyOZOfu0ZdMgbac236/iDSYoLyMMk9ig5BLv21kQzG6yHsmkIQuHpoIMGPxnep//TSs1ustGTqhW1faja+vTOwvLouOsQYFz4h4OrBK7Y3oedERufJTkn5CsQRna1Jy4yilH6DO1UDsuq53LeErmEOIhI/xz3SCPbRGlNdKQimhcbM1s3/Nw5V36lCdWobVVNjZeeVVxbfuRF+qIHyYTzt6HHtQdPy8Mq5mgyUBCnGGCiNCrkQBPDWvD+VGaAlqTOdyKsZWQDT9RWRj67Ei6EOSF1VSxN6n9cLnTMmQgCgbN3BXwwL4aQsMpH6ykBTQtUr70famewAro9WA4W01g/eFf hQkxFpg8 5Ow/WtHNwiS5BSUvE9cXa2Jjn9yFsgJYMIWR1SlEOP4Af3Yfpx/Kl9t287VpHY44GoPRIK8bzJqBgEzKHm2/PwUt4LnBz3cr4p8JCo0h+pavMeP78g7qI5apX0oP5ZiVFmGqvjy4mX86zd/soFm3rQ+n3GWB6TxCf1ndvsYIof9UCaq4UfN6qBh3cYvqqRWkqMmQ7Nf2oLjO9ISRcFfpdFMz9glAYvpf+1RsZrPatALzGc8H3hVgyk5gGQNBtzamU81sg3mAMTtWymuCGBdwZevLmKJB2J2jqmES3XWhhPwY+39Mibe/oCBdLOv8BpC4AanCebFxXMBPrFNM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.024450, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 11:06=E2=80=AFPM Shakeel Butt wrote: > > To decouple the dependency of lruvec_stats on NR_VM_NODE_STAT_ITEMS, we > need to dynamically allocate lruvec_stats in the mem_cgroup_per_node > structure. Also move the definition of lruvec_stats_percpu and > lruvec_stats and related functions to the memcontrol.c to facilitate > later patches. No functional changes in the patch. > > Signed-off-by: Shakeel Butt > Reviewed-by: Yosry Ahmed Reviewed-by: T.J. Mercier