From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88CBDC369A2 for ; Wed, 9 Apr 2025 22:11:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6F38B280058; Wed, 9 Apr 2025 18:11:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6A3C56B0174; Wed, 9 Apr 2025 18:11:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 569ED280058; Wed, 9 Apr 2025 18:11:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 38BD76B0173 for ; Wed, 9 Apr 2025 18:11:07 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6EAC6C144E for ; Wed, 9 Apr 2025 22:11:08 +0000 (UTC) X-FDA: 83315901816.03.F50011F Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) by imf09.hostedemail.com (Postfix) with ESMTP id 6B6D614000C for ; Wed, 9 Apr 2025 22:11:06 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hJMKleh8; spf=pass (imf09.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744236666; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1WeMoI07MGM7m41ZJQjcw0OZDaYzBhtEXKaYLAMP5Fc=; b=mGRdfY7a8awZRGRnZIWdv1qpBPQZyPQtxaMEmvMWm0guowzRXALb1385sSUv+Gc0Po3A06 LYgFCBz3reeRzDkR+JSajf42faDtX+uZ3pONn4kRv4/Te0Q/LrhjPspsqK/nwFM0lO1h4X +fI6v48qIytEcXxJyvw0ccObSUbe5bw= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hJMKleh8; spf=pass (imf09.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.43 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744236666; a=rsa-sha256; cv=none; b=5BmfMt/Ikw17HQ6EBBEMgoNPPdDdXUwzDO6uLIDb13m6keA/VnBpIAWq7OTCxjt6EdE0IN WYG3NoA8F7aUmtzsqCEINMscxiaQHO9a8htxbhWeCWYdxEs3l0e3Laa/bDD0kSKD8Chm2U 8sbHu30Pu7KxqW6v4NGVRkbBKIgAua0= Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-43d5f10e1aaso23635e9.0 for ; Wed, 09 Apr 2025 15:11:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744236665; x=1744841465; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=1WeMoI07MGM7m41ZJQjcw0OZDaYzBhtEXKaYLAMP5Fc=; b=hJMKleh8Qr+DhS2BhulhusoOfh0UH8kt1Ng/TfdFHiKWEkKKzQC0T8FijJtrG0PX1n As1jEdhlIiRFzin/TdP/gX3gvAEI95lKvRjdH3P8ZzwgetE9Q408kNiMtoNQOiHHDSaO W3Bi7Kr7fxDVVFDkd1SVXcg47I4ldmtpp/TbSSuHwGNeUO1MOdez6M+u12epp26iQyLR RPtzNv4LSttRXDVJIa5ca8y/28018K0j654R+KzSdz2T5+KiuLPdocEemZfkFDj0xq1F omjSaWppPCwJVzYsBjZhCgRzDkPJxWAE5amt9TB7te6XBzzXep/U0/EIEXWxu8DhTYCw HOiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744236665; x=1744841465; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1WeMoI07MGM7m41ZJQjcw0OZDaYzBhtEXKaYLAMP5Fc=; b=EB3fNgym6YMTLT5haY0b5pl0ObLeiJ27RVZEzu67lc4HP79ms4qOiiFuC905DSvRts MkkqfYW4aBQXP6L7LBdjMZFKIVgTm/tkde69L16ZRbjaZ2PRXRBFJy7y1ee7VMZyctNY Zd7nL2Vg6mPuaC4+Z3hpwZux9CBrxK7uamoCfG37VQ8pfcPidNtq9r1ySvrvxptazEhZ R1+tyq+XkyK6d6AXwY7KjNENjbjVXmJdVXXYASveJurrdwLTPnEMOl2w3WeaLJdLojZZ TpOAr/AHzPcJREYEJt7HSg0X+NxBvo0g0w+e9ez8KSDGsjwWzGzwArKZ7Jw0erxuvsS5 MlBA== X-Forwarded-Encrypted: i=1; AJvYcCV3YK+c9qVweFOdVzJQPLILuI7GpGFpViNetiBZktrU2wPpD9P47hnQtwDQ9mavZOgN51+4MKN37g==@kvack.org X-Gm-Message-State: AOJu0YwZgSSwbwcKdrV9Z6fTeoSDpufTsnwGj+XueGYhYozRzea2eNC9 iIwxRSxB+fuuatkXXtBwxPqrUwR0I/Qvmf2GkpJWNx8Imk8AAfPMSxQhfxnKdLljLc6VUfplHWv 6MirjAiAuTu4U/wFag2tM7s5MlqCmHsPSQLt9 X-Gm-Gg: ASbGnctX3UBCWiEo9Fv7/WwebfAVL5cQcZ5+DlHKg9vZGevF863MoT9gBzrMW7hL/HC mJQVAYFZumCBFPZ3uyCIT1itt+LvoJkU38GupywfmwDCMAcmq71PoUmXCq1XuYLDLyo0ShXYznI oQMf4kQcAs/kIjZdTYV/gibDIkor4ORwWtWMk78XVL4DYvC+zP0dI= X-Google-Smtp-Source: AGHT+IEsJ8CCoy1fpsu/63E7U9CaB6UWoIs5FAuxTzGAsoy+kQFfpjcbCaX9O4ryUbCd712o+KPaQMApElvTdzca8rA= X-Received: by 2002:a05:600c:3d8d:b0:43b:bfe9:8b43 with SMTP id 5b1f17b1804b1-43f2df42953mr309915e9.4.1744236664648; Wed, 09 Apr 2025 15:11:04 -0700 (PDT) MIME-Version: 1.0 References: <20250409195448.3697351-1-tjmercier@google.com> <20250409140848.da67768ac1f5e79d7296de4d@linux-foundation.org> <20250409141131.bd67f6b19ea7e770dce40ac7@linux-foundation.org> In-Reply-To: From: "T.J. Mercier" Date: Wed, 9 Apr 2025 15:10:51 -0700 X-Gm-Features: ATxdqUGQ4NDgYljRmh8RkqWTri1UizwS_iIrkWzRlXDyd4XZqN2xYBpQHGLQ3Qw Message-ID: Subject: Re: [PATCH] alloc_tag: Handle incomplete bulk allocations in vm_module_tags_populate To: Kent Overstreet Cc: Andrew Morton , Suren Baghdasaryan , Janghyuck Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6B6D614000C X-Rspamd-Server: rspam05 X-Rspam-User: X-Stat-Signature: obop9fazj61gc1ccyaobkj35wcg8yd84 X-HE-Tag: 1744236666-290141 X-HE-Meta: U2FsdGVkX19ZoQcAX9oIVrD1ANNHKUY6vaL/OETlpNtNlES8zlfRh52b0nxcigvqugp2D27tCMJGZnZUtkiL6Ou8YCQ71oJGZlOmGKXY+tm1Kf5nRswkgdGsjcDTbtKZzmvekRJ1kQPZ9RjzG/uO+XYQSKZN/NM/egXYNqK4P6waT5ixnvVe+fdWkgchLjgsDTHPF7+4xC7MVcY07biWiGD9PBZCmaMC8cRhjR2sVgG4oYqzLQdDAjQnedjKtnF+cXCF+gsaAWpMaSsK0sm0wQJ1BNsB9IfVSjCw49jzLz0b2hoP7P09Q3fwU8xmcqPcRwsNyHuNrOKRdNVjs+LS3CZjzz5X2R2fxKYIRbTbEuapnJqiNRkCXUQzAGGQj/naXsyT/N+iF3EtFNb5omOlCGU9glB5m1J7pzJyQ8N6OQFQP/i37YPmrR6XAAgyLf0ULX0YbkGutxS9PZC0SefDMEXQ+p1iiq3llr//CnvvNP+WIZy7AIzEekItjNh+FNaGzeQdrQJswXXqfo2sAJ+eaEl6qhYgXNNzJhfzo+AaqoFWrfzG0ojsYifZHawiNXgMdGjG1AGleTMNXyXZtvPwzauhfv8TpOqwc86e1m6PekKEy4S/eNORgEXGy2xEye+kiGNjEEKLnjP956LrM9wOtSdUY2HpwPG3j7syqOh3skWSy2Z5nZiKzcpdSgyulpfX9dT/Uxnqk3+1NbK2p9H8zqUlgiM65qRn4G5NbTNbNgGwsWglzJcPj+hmg/v6h5A0qHWIKVaAeiCf9YXFobGNpa0ttOTJuVkRc9wD6KscyTBpunnGP335kXy3PcbFUYtZBHZc3BlU4vN+NSAwjvSIm+UbKlRNMsi/87q67T3cc+RF7vhVRwN+aNybsyrgb4lhf4ZiznD8a1r5tSbgdReZL7cB32Bx0h2yDzijAblVfTQ+jy97frxUMRHv1Ru1n1hQtwRx5ano31XRJmVig0i xvSmiQFd hLaS9pSLT9n+R2Ox9U1lqYpmuZFnomUQ/sF33Ezq97McjrigRrIeOSNWzzFeACBvV/fybJ5xJ5UPR+bd4iVLQdjZW52+CK7CoJ5taHrQ3Qyc7HXvN9ErH0Xgv9ooNSX1Z+oJf0fQVxHl4b8CzV36DurhKnN0tda9jYoWvTguaYvdHNZDs5lQU15ZaJKIkXAHgLipGzfwa2bdm2dyAOJ9uYnnV8IACfcJXJClRz8NRo6J4/wTKrdEL0HvDv+DLXf58xjUtjh/WkgWadEZBqU77oyuW4587Np9RqkBuoPuhi1kcnJ4Sv6Afz6bT8JLIHYDBqYUyJYeFYl8EKTGkSxIIySZpIQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.031664, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 9, 2025 at 2:57=E2=80=AFPM Kent Overstreet wrote: > > On Wed, Apr 09, 2025 at 02:51:18PM -0700, T.J. Mercier wrote: > > On Wed, Apr 9, 2025 at 2:11=E2=80=AFPM Andrew Morton wrote: > > > > > > On Wed, 9 Apr 2025 14:08:48 -0700 Andrew Morton wrote: > > > > > > > On Wed, 9 Apr 2025 19:54:47 +0000 "T.J. Mercier" wrote: > > > > > > > > > alloc_pages_bulk_node may partially succeed and allocate fewer th= an the > > > > > requested nr_pages. There are several conditions under which this= can > > > > > occur, but we have encountered the case where CONFIG_PAGE_OWNER i= s > > > > > enabled causing all bulk allocations to always fallback to single= page > > > > > allocations due to commit 187ad460b841 ("mm/page_alloc: avoid pag= e > > > > > allocator recursion with pagesets.lock held"). > > > > > > > > > > Currently vm_module_tags_populate immediately fails when > > > > > alloc_pages_bulk_node returns fewer than the requested number of = pages. > > > > > This patch causes vm_module_tags_populate to retry bulk allocatio= ns for > > > > > the remaining memory instead. > > > > > > > > Please describe the userspace-visible runtime effects of this chang= e. In a way > > > > which permits a user who is experiencing some problem can recognize= that this > > > > patch will address that problem. > > > > > > > > ... > > > > > > > > Reported-by: Janghyuck Kim > > > > > > A Closes: link will presumably help with the above info. checkpatch > > > now warns about the absence of a Closes: > > > > Hi Andrew, This was reported on our internal bug tracker so there is > > no public link I can provide here. If it's better not to add a > > Reported-by in this case, then I will do that in the future. > > In that case perhaps cut and paste the info from your internal bug > tracker? > > Commit messages can include quite a bit more than just a short > description of the commit, when it's relevant - e.g. I try to include > the literal log of the oops being fixed when appropriate. > > It really helps when looking at things weeks or months later and trying > to remember "ok, exactly what was that code path I need to watch out > for?" Agreed, it would have been better to include this. I think the modprobe errors I followed up with would be good to append to the commit message. Shall I send a v2?