From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFD8DC4345F for ; Tue, 30 Apr 2024 18:09:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2074A6B00B3; Tue, 30 Apr 2024 14:09:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B5C56B00B5; Tue, 30 Apr 2024 14:09:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 056D96B00C2; Tue, 30 Apr 2024 14:09:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id CBE0F6B00BB for ; Tue, 30 Apr 2024 14:09:25 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 741251A050C for ; Tue, 30 Apr 2024 18:09:25 +0000 (UTC) X-FDA: 82066985490.27.C22B42C Received: from mail-yb1-f176.google.com (mail-yb1-f176.google.com [209.85.219.176]) by imf02.hostedemail.com (Postfix) with ESMTP id B48FF80010 for ; Tue, 30 Apr 2024 18:09:23 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hDtfTqXB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=tjmercier@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1714500563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=WMNTCdm5svpxXWjpVt60+t7ZBqUkllAdM5ompQ7ypY8=; b=SNdj+P6ijM51Imgu4B2ypmt8nq54TO56N+jxP/JefDvalymVQk2tEXIAj9rtIlbhI+ZgiA AghSG8Rt9P8XRKvqR/wXcecYCp9PSB3pEhs1sfDLg5lAERP0J6d0pJJFMq0mXs9TvgNGtO N/k1t8HRcsoGncEgiFpZmz7JhIrzZog= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=hDtfTqXB; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf02.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.176 as permitted sender) smtp.mailfrom=tjmercier@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1714500563; a=rsa-sha256; cv=none; b=sQm8uyKmFOED8132wEN469pU8lnyBgGNF84wvL+wu388oINoO1WV5TbJ88ZsfGIb/dbdUy mhdajLm0fLK5kWoK+BOMGXFGd3pzC641RIFpSJveUT4iALcI+44apSLKx4cElt0wh8QuhV FLrsstv76zmgoc+eGATwoKa1nCtOqCc= Received: by mail-yb1-f176.google.com with SMTP id 3f1490d57ef6-de5b1e6beceso5219531276.0 for ; Tue, 30 Apr 2024 11:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1714500563; x=1715105363; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WMNTCdm5svpxXWjpVt60+t7ZBqUkllAdM5ompQ7ypY8=; b=hDtfTqXBb+UrijPLGrsiDdo87nWY8U8OQg6vjt7flIv+1NmD9jf9GSCCMWaXiRK4Av 5sN0TTqhlRduXm8DlrSBx3GHbmBpANZNWgitP1qswYK75N3EWNUCp9PLebd0jtHSftvu T+zKNzsWNGGVg53IAtiriVDOIqwPnNtPx62UsMKPS7lpQlVElD1PFySLWMDPDAusO0eB 6gAPbbYgCXg7C8MwLTi+oh/9G4S+37X5fW/q+kOHO6mZHn2h5mSvMOAVTDGbd50EXtpC aT5eS7DZsu059ApJK4PDCzFb+hSL4dvSsUuT8ELslEustSQh+8b1tY31p//EPb3oeJO6 1XYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714500563; x=1715105363; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WMNTCdm5svpxXWjpVt60+t7ZBqUkllAdM5ompQ7ypY8=; b=N7mclDnhJf6WPg/j7GZv09Gbn6lZg8LOsm/kBdKNAVgFGxCNvjmNkh0cLeyU+1anQ0 Xg27Ur2+Muc61OZI3kxL/h05UYORqG38d7jX3jUipgcHTbcNPHmL1DYXL1D8Q6j9ivU0 Y0Mx2x6wk//YD+t/1xFwWeRKJHmO9kL4jRI+OygnW+NEcLSKbliejyDand0i2+KEt10A olbLGaagYDdGTz//CHh6vT0DQ9sJ6EwgEYQZQfqOBntKPimRUvsXxo+xbf7w3CE01NLq BOENs28zEwFdfrpnxwsPhH/6sAIG0fRZoDxLFp4hnitlWXSiR0w2UhJ8jai1mE3UeWNT AZvQ== X-Forwarded-Encrypted: i=1; AJvYcCVPQXs7gaQ2m1OdZOQP1Gd6XuVybD4uOUTX7E5GkmJ3ne1sVySZYExjSat3nULfzU0X6m6G5Q4tCFMIKVDbKRLNh6M= X-Gm-Message-State: AOJu0Yzfsh///X8V6JoioQNuayUNi8ewtGtWDrTS5ULXnBRn1TvRbPfp tinFpFmVQeC/QaMNqeJWlrRLJvkwrHBW/PQQ7SqvzUbQC8hp77XvrpofyLGCPQwZurJTlkH8ApD J7obv63HAgXuUULxVQ3RyTTalV0JPJA2PtkRL X-Google-Smtp-Source: AGHT+IFYPUdRIGoJo2FyON4O7qgOmZLSFxrIYUi3aafzci4nIsE7insXex/Szzw+Amr7vCbEJYbG8jzOOcIngN/ttDs= X-Received: by 2002:a25:97c3:0:b0:de0:e7f2:a03d with SMTP id j3-20020a2597c3000000b00de0e7f2a03dmr359262ybo.3.1714500562637; Tue, 30 Apr 2024 11:09:22 -0700 (PDT) MIME-Version: 1.0 References: <20240430060612.2171650-1-shakeel.butt@linux.dev> <20240430060612.2171650-9-shakeel.butt@linux.dev> In-Reply-To: <20240430060612.2171650-9-shakeel.butt@linux.dev> From: "T.J. Mercier" Date: Tue, 30 Apr 2024 11:09:11 -0700 Message-ID: Subject: Re: [PATCH v3 8/8] memcg: use proper type for mod_memcg_state To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Yosry Ahmed , kernel-team@meta.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam01 X-Stat-Signature: euqabfnjhse6o7hcz7aqx9quyhzkroja X-Rspam-User: X-Rspamd-Queue-Id: B48FF80010 X-HE-Tag: 1714500563-731599 X-HE-Meta: U2FsdGVkX19juSfMvx2xSa2lxy0jfynngJUbhl1PjnQWpcYd4I3IUAgZNHEGRfHGMwrd/yD0WrgsD7vetvJF0kmCLDNN69ie2t+n6jAbOJBIDClyJR63UdmgIe5lxfwPiQgcjSwVz/ZzYphO1HKxDn+UHGkrectrf9RWliFud+5/pZOpPhB3fO5BqQNjTkvGJnC81jILVwDEVjtBUjOQiWE9arpSorszZLRZyE5l59VpEgLbeqrD6jY3etkSuMOxA/F9qsiEj7ivDh6w9gTNtkcJ1rsn1W4dx3ckI7c1uESFfWXReXi5NhsK26jT/GC04c/3iOTY9I4up+Oy+AaQVtOiZ9h7R1T93slLVRRKUGmpRNX4s20NnHWL19QxtBWTcDcDGJkimkTvaFr/eW5SLSR1PHMQpOjpyVHq7RCcSSFW6pPvXapaPdvemZocdyt7UifDox3AVSXH/YWq9RQh5Sh/aPVmYCayez3+mWG27NXhc7QbuCrywO2tkJZFQ1cG2GR0qhQVRJqFPgM2n7GghNanVskLifVlSPjeUQaXFdh6N1wmPhNXkeb7qA1a2qTiuS2hTd5Wt8GEryd9Q16i1MJ+7A+PmHQg9KzPkYp8OnYe2SQ4pRwrKCpVebqmhk98gK1oNIRkCM0nGdRBTsL3DxaXzHMLXcM54A4uLDqIR8R/KnuOacvtQ3nUrywAYLY7SqBDXj/THXzLkBdOJ8c0uEsC9Ep3FnHnvZ1++ancWmTBQymB4kYj2UF7CtZhXwl91fz+vY3F6yQu4Bih1DSRpUbpKimzuKoWAqEXufTUIlcH7Uzp93Z/Qj6Hzpox9ssa9+U1BuSyE7HJdJOYI0LU19Z7XBO09oJM5BE2fn8R20675TIQlWy4ScmSq/HXUssQUAjyQXrqzNOpVeXIM+QzExy+f+1vNx3KaMCGRuJkxco68VNs0wClO0iOGIRBH+iCkMDwhg86lilVGwFIs7V 6tN6SWjy cFCmVgDrLtKzP7ik26B+VsVzS0+/tp2elI1dn+07fvGeDL4+qLl9xjzR1mIcwpkVa6mIaCv2HEiYVPGBKUnjoFWfDFhId8yXAmhng5qm2lIfZShiTfwSuaQoOe947W+fVmYdG7p3uZ29Glw/S4u7VE6bNeuALqGHc3JwXkQ3/4Xqm+81QFK8PAC8DVaSFiCiptZG+EAybU/uBI1hUKsWQmos7cbpZzO1Mg6lbgTH8de1zZGm/rh0OFtkEUo5vnAnN6+Gsg+YCOz4sD3VDZsegAGj48mCf5J9Ookxqbq3qYaC2HFA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000111, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Apr 29, 2024 at 11:06=E2=80=AFPM Shakeel Butt wrote: > > The memcg stats update functions can take arbitrary integer but the > only input which make sense is enum memcg_stat_item and we don't > want these functions to be called with arbitrary integer, so replace > the parameter type with enum memcg_stat_item and compiler will be able > to warn if memcg stat update functions are called with incorrect index > value. > > Signed-off-by: Shakeel Butt Reviewed-by: T.J. Mercier