From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3498BC36002 for ; Wed, 9 Apr 2025 21:48:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 54D62280092; Wed, 9 Apr 2025 17:48:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4FBF0280091; Wed, 9 Apr 2025 17:48:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EA59280092; Wed, 9 Apr 2025 17:48:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 22A8E280091 for ; Wed, 9 Apr 2025 17:48:50 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F14D0161412 for ; Wed, 9 Apr 2025 21:48:50 +0000 (UTC) X-FDA: 83315845620.28.D59FC5C Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by imf28.hostedemail.com (Postfix) with ESMTP id 12715C0002 for ; Wed, 9 Apr 2025 21:48:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=G4fKM35P; spf=pass (imf28.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744235329; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XSZUSVRQuVJE6oT7DHje+0X9ex/HveKSS9KgUQ/ld4c=; b=HiSZ2BTZ2k9w1nIyQaz/e1nIYRZigqWvrALUZWrwcMXPOV1qEGLdI8Znt94xkta8xpm32c Vw1w5SfL9ZwxKIFncOURow4vS29gkPgHTaEw5Ao/1TjEPFkmWvl522FkpQp/YaNw70fdkd KBY4TQZiZwBiienJ7R8I/ERygtTTklo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=G4fKM35P; spf=pass (imf28.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.46 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744235329; a=rsa-sha256; cv=none; b=lyTobQenIlGW+l2vdCPbjlSOsQbBmd0HGIRrWiC+KvyLkt/qKo+tvra3+2SIpv4yk8nmsf NrEMY6lhsAMAWjGRUZ2MPDtm0iJ/bADLeZ+2IMxUaOuOLFTneIotDW8msrrSyNPaR3RzwA 3o6X9JN6swnZv0On3uqEnVBpfsq0vrc= Received: by mail-wm1-f46.google.com with SMTP id 5b1f17b1804b1-43ef83a6bfaso7255e9.1 for ; Wed, 09 Apr 2025 14:48:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1744235327; x=1744840127; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=XSZUSVRQuVJE6oT7DHje+0X9ex/HveKSS9KgUQ/ld4c=; b=G4fKM35PM3pccaWr2VodKkIe3zjjYV2G58CmfH+fkR7amWkFr4Vq44qEPgLMK5He7+ QvNz1P2wi9WTarJgMnlmwI4CU3fpcPuBjfBedYm+IcDAS6ZFiglOfrANx2cwAHCMlxow GJ7SNUwFQqVpkFsRpAJr8WNeoRuKdJGcMYSKRmS+Tb1Q5jGCV9X/de4f4M8tL2P7bl7r gYGRAw76qrITbHnrMY33lvfJs9keEZ+HVMBKbkCgmvHjZz0tBz6ZcuYrYcmhIMu09TJz pQ55oDGCzJvSNh7NCwmx8UGfWGUq7FhA/flwXAYdgWOK46LI+hZ4m4t8KM3MOa164AeM Pflg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744235327; x=1744840127; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XSZUSVRQuVJE6oT7DHje+0X9ex/HveKSS9KgUQ/ld4c=; b=gf+oQ3TDdkfU3y5EoEIhSadNj6L+TOLL/6vi3PzJF1u9ot/y0cJgBvFaE0Ivyb3r7Z nkW3LXehxR+6LboyMYAQApJXb5xyP988wqETXP+0CLxYtPfug2HEteErs03DxJKz5OBq ruOhc67aPrwSNYtW1FS57298FsW5cti+wErdQJbiBoPoIDMXBAAeRVH3xXJwji2aY7KB uGKIm4VS2kKhmMrET5uzJPXcCgv4A3hvmdf296ab5faLypeNxe3bKv1ZnP4VsF24ms0y Iiq/VPKpN4hb0+NaIMrj/bUJPLTZkqdtCFBMCpMe8bkAJDMvgsR80yXGe87xDDoCXdgQ IHew== X-Forwarded-Encrypted: i=1; AJvYcCUEtw8rBUn+6NbbGckSr4O85koO/rc1YcqMHC/7JkyNMAhL2rcmxJESo/JOepAz/qfzPer28hPrJw==@kvack.org X-Gm-Message-State: AOJu0Ywtyu5qG7JZWm0e7P6y1SsyWFB/2m6hj7zWAmQgGsycb6J5shDT 1uOZ6TccWzr1pET6oWCt0V4vfU8AaoaLpeoH7zzazl+QPUMVgijTm4g//fQ8M5SNVCVGQZtFtQM UzKiqneHCAhyQY+wv1Zfz1YD9ExkxCwS/PgPx X-Gm-Gg: ASbGncuvtKH8Pjvj+Nyf4vopI0yKdKNbOKJTRn15DXiN+UEzNT6Gnp1hSODir5rGqET RYkCTjfjBuLGuExx1mqIfE/axeSimgsy8AymXnWbjK+5GQSNWReDTEiDg1sxdPVfKrb+UZZ/7xH vBGS9KxSq5xvc/U5kxHnsEblqw3oIGHNeDB49V3Hqb6W+0YlPWG0g= X-Google-Smtp-Source: AGHT+IHauDDJIzs+TZDCe4t9OJqCREySb7P+GlE6U4isA5IyHuxlz/bfR3AmRWkzdtomjCItz44GjxJQLhlCRN4iUww= X-Received: by 2002:a05:600c:4f56:b0:439:961d:fc7d with SMTP id 5b1f17b1804b1-43f2df82974mr246255e9.6.1744235327095; Wed, 09 Apr 2025 14:48:47 -0700 (PDT) MIME-Version: 1.0 References: <20250409195448.3697351-1-tjmercier@google.com> <20250409140848.da67768ac1f5e79d7296de4d@linux-foundation.org> In-Reply-To: <20250409140848.da67768ac1f5e79d7296de4d@linux-foundation.org> From: "T.J. Mercier" Date: Wed, 9 Apr 2025 14:48:34 -0700 X-Gm-Features: ATxdqUGpvo0jH95e98fd0xcqWevB4Q2LDp6Ds-grTEovtf3LvjI1tSodk9DguP8 Message-ID: Subject: Re: [PATCH] alloc_tag: Handle incomplete bulk allocations in vm_module_tags_populate To: Andrew Morton Cc: Suren Baghdasaryan , Kent Overstreet , Janghyuck Kim , linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 12715C0002 X-Stat-Signature: xr4jz44xa6sazzqpu6ohaef8cmw1g1n6 X-HE-Tag: 1744235328-134291 X-HE-Meta: U2FsdGVkX19VuaHhmI/hLjj8Ae0e5/l6U2Utym67TQMxIGdE5eXpKEy1kVD/7fDrvmeJ/ZXOp7j86+JlAP6bjYvLwj1fy4gr6NAN33sBMQrOi0cltkraKOqHrmTd/yZOcBn0YRlL+VK82fsAhkbYihVn1Z+Hrv79mmTxB/9s5lTy5Oyxf/ILaiKfsX2xLjSvURGsXLrPH2TfeLJMkcAx3hsc8T6geZlRUvBRsCGXyQi24loBUaPjp0mZWNkNf6RfXJwH9Vqf0lU8pt/3lHWA89tdFvB7LAQd3+Y1W9SZxyF5UU2CgMXKfUs4v8Sr8awLFYwbuH/FC8sVCeQDc+IeZTRmeywDdJPftkT/RR3ZyWLOfI6Tn8CXNmz5qC6FH9LtTFhDiNU1H+NqwV9/guHtYWDJKcNsoho+8rd45oFz4TbzOYep2c+3bNNClf4FKuHirrSB22qsZskyAAJtNmompljqSTMJH6XV7XF/vIXR/pD3xXUd+6KPEqW3djpCSmE5w2DvSr6MFgsV3JEaF1oROK3hdR2I7xnlCapYsDW7mkFkRDHLi2cvjbsfVSGOfh5Q4H+HUHyJulZkDFXMi45M0MROOCEEPMH+QjVD2zhFyR0y7FGYG5ixYTP6RdVYcFY5xbEzHrdbRRatJ7r0G7/ryLhhxuTxy3s410Q4aRcWyLONgGyzOe2Cml5hpgs+TzuyP38Td+k2nww9Vvso9imhqPfBiB2hXgu+WJhVtGeYzWcmvSu/Mtw2qeDTqCdWoeXNEGXb9MuRa8MH50Ge8s6okACVVwmD596XkM4aShHlGTIgRKK4jW6gJMVQ+D/EQQQXOJkwHfp0M3yvsEPah/Zyu8bJOE2PmJfUaUgh4yiyqIV1TJ6/gsAA5ekOSJPRbM8J8TziA7ui3TiwbGxzlLQQ5HWaJxeK+R56ECDQtFR/Y8iKa1Lh2+swN/FhkGYSXeQq4D71JV9CaY6b4IpKovz oNQaDwIr axpSV0suNOWdhDFJRb3CY0NOhSOa8j8yEKM6NKTXWh6PY+BDRhjlgIV0eNVKaeVse2aK4z1p92xb+Yi83BzB4GTXZx646jhVc2QUB/F735qU2VseFCkVzVY83HQxrbgFTjG31UWFw2ZpuOOOkCPfhfJluXBUL99Pb7fJ9pJ8Jc6IcrYdZ6XrcOEOGmB1Scn85szwZEKPQfnILhKBLgdGWsABOIgF7GaLLQ3uEToPTf7IQUn5wCh+bzs5d9/YeSWVKlqk52Fw8y4r4TjbF4eMRLFwqBCDWMZoHFGBFQqod6mmbx68x+BvD5TVWJsv2Ju6xEBOP X-Bogosity: Ham, tests=bogofilter, spamicity=0.239934, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Apr 9, 2025 at 2:08=E2=80=AFPM Andrew Morton wrote: > > On Wed, 9 Apr 2025 19:54:47 +0000 "T.J. Mercier" = wrote: > > > alloc_pages_bulk_node may partially succeed and allocate fewer than the > > requested nr_pages. There are several conditions under which this can > > occur, but we have encountered the case where CONFIG_PAGE_OWNER is > > enabled causing all bulk allocations to always fallback to single page > > allocations due to commit 187ad460b841 ("mm/page_alloc: avoid page > > allocator recursion with pagesets.lock held"). > > > > Currently vm_module_tags_populate immediately fails when > > alloc_pages_bulk_node returns fewer than the requested number of pages. > > This patch causes vm_module_tags_populate to retry bulk allocations for > > the remaining memory instead. > > Please describe the userspace-visible runtime effects of this change. In= a way > which permits a user who is experiencing some problem can recognize that = this > patch will address that problem. The userspace visible effect is that memory allocation profiling will get disabled when the bulk allocation is incomplete, for example: [ 14.297583] [9: modprobe: 465] Failed to allocate memory for allocation tags in the module scsc_wlan. Memory allocation profiling is disabled! [ 14.299339] [9: modprobe: 465] modprobe: Failed to insmod '/vendor/lib/modules/scsc_wlan.ko' with args '': Out of memory