From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BDB2C3DA4A for ; Wed, 14 Aug 2024 20:59:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 18E8B6B007B; Wed, 14 Aug 2024 16:59:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 118AC6B00AC; Wed, 14 Aug 2024 16:59:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED6546B00B4; Wed, 14 Aug 2024 16:59:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id C67376B007B for ; Wed, 14 Aug 2024 16:59:30 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1D1B4811B9 for ; Wed, 14 Aug 2024 20:59:30 +0000 (UTC) X-FDA: 82452066900.29.9262660 Received: from mail-yb1-f169.google.com (mail-yb1-f169.google.com [209.85.219.169]) by imf27.hostedemail.com (Postfix) with ESMTP id 6292440007 for ; Wed, 14 Aug 2024 20:59:28 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Bnydy6Cj; spf=pass (imf27.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1723669155; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7KLTTn/hjmzFSkfe2zHJsLIOkpo44yYFx9b8AKrmGa4=; b=xvNo6kzv8B6qR7yvCglfNihG4EFW+tB2nlzelJZlGvwHjdw/DfkwWP6QwPyhXS0PKDXHhy oN+mSzvezd676DhnAJsf3t/2cHWlUhvqQc1nWdqloA+Z6TyanCCsZd9BhuQ5JnNJXtN3Gv TfJOsGf09gZz3yFPWst9nbuTbvddD8Y= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Bnydy6Cj; spf=pass (imf27.hostedemail.com: domain of tjmercier@google.com designates 209.85.219.169 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1723669155; a=rsa-sha256; cv=none; b=L9OxZop2j3GgRmqLwf9hQMAxHZdKSVV0k88g381iB3b9vVolPaK+2UbkiUsSg+mtU0lgFq UgMC63v1rWfn/he6edo2MVCqGDXNpzvBScxR2QRdR8BUCCaVP53Y1bXrD3sP0yVtSmqhSa MquEMPSTGjeOnGBJJDFXBAWAVpbblEA= Received: by mail-yb1-f169.google.com with SMTP id 3f1490d57ef6-e026a2238d8so391298276.0 for ; Wed, 14 Aug 2024 13:59:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1723669167; x=1724273967; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7KLTTn/hjmzFSkfe2zHJsLIOkpo44yYFx9b8AKrmGa4=; b=Bnydy6Cjd1lU7NkRplS7q3tIK2JSnsgmulcDxFuGKoJQdj6HDs0HDMmKMoNCbK/aOp auxcYHuOupfziw0kCSucQDsZVHRD7ZRgUoIsihWKV15/VbKbICVHfpPF9fsUZPp7bMvG V7xrfLamZ32HxEw9Jx2BRHCBUb6VOmFU+rmpH6gqdISXj/wxV11xdV93ITp6d/hHoleP bx1Iq5wsQSX0OAElGqX53C+oE83L0EzC2uOa2SREuQR0WV9KjY3Vh6SIsIPJnk2JJcoZ aU4e0AqXBrwx7ZA+tiP4b/Ds9P3zgbPYusc6tyItV3X0ZHYQYAWxe1Re88X4Ss0Q9i+u tc3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723669167; x=1724273967; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7KLTTn/hjmzFSkfe2zHJsLIOkpo44yYFx9b8AKrmGa4=; b=powqXUe5kmmJajI1qC9u1hbjzsa3zzfSl4R+YZ5wQsf+I2Tf06N4MQbCxVy1etueA8 1sAOUKefbOT1gnaN/WNo4uwMH4DDYn6Cv3J5sD7vl8fO1XECuEcY//sNaqb10H3s8wLI YoL2GLPpLkUgm8McGQ1V7B9J3/M0DetHvOBJ5pzyJY3ydbG8xzgXil/B2vq8cPsN4x15 MCnFDhIViN3/SRkMLHn34+IFoZrKfT7FyHCyjhrbhiqmgH9rPe0xmaWgv0XNlDYWnOVY /nEsN4AYvti8RGbVI72V9AwPLuGpchoStbj5EgF84hXprNscAY2RvjMaMMbUIIm58g6j vNLg== X-Forwarded-Encrypted: i=1; AJvYcCVleBmml+fJ1qR/k32hckXaVXcQwogz9XlksxMTz+R2lZBFu5rc1KL9YQpFFjshzqgps8ufSf43OXKOmlM/Fvv0YKA= X-Gm-Message-State: AOJu0YxhJ42Is4YxH4mIF6CWUTkZFTiMnxj8Dc/IvwQfcdNgKn6YEUNo LGNXfU6+ToVIdlo/5opgO5F0Vr6KCwT4/w/AQ5nqdwoPdTP7n0Zo7wZK6D3U3fA/GASgqxGkzA1 iqnko8V2xRQ3HyamiwjQz1lWYJl9Y3YlCuDL3 X-Google-Smtp-Source: AGHT+IG6u9xXVM5sR6V6akfNNtSjFrQtV99kTT+jKruHC8y3/HDjw2NnRNFY4ZhQmcIEGdS9c4P0PYvFzO2HxMdto5A= X-Received: by 2002:a05:6902:2804:b0:e0b:9412:328f with SMTP id 3f1490d57ef6-e1155bd1112mr3928570276.56.1723669167090; Wed, 14 Aug 2024 13:59:27 -0700 (PDT) MIME-Version: 1.0 References: <20240814202825.2694077-1-shakeel.butt@linux.dev> <20240814202825.2694077-2-shakeel.butt@linux.dev> In-Reply-To: <20240814202825.2694077-2-shakeel.butt@linux.dev> From: "T.J. Mercier" Date: Wed, 14 Aug 2024 13:59:15 -0700 Message-ID: Subject: Re: [PATCH 1/4] memcg: initiate deprecation of v1 tcp accounting To: Shakeel Butt Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Meta kernel team , cgroups@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 8gmn5prhekhrzceukcq4iquqdt5ug3rh X-Rspamd-Queue-Id: 6292440007 X-Rspamd-Server: rspam11 X-HE-Tag: 1723669168-110779 X-HE-Meta: U2FsdGVkX18qQXFlBMtXswjWei0ZogRPsRU0Z/1gxyt2gU0iTYO0Sdg06B2fBHyvDq1tmaoMIXfGQF/s4DwtG1w8qp5wGTTGMYRBP9zNpaV0kv33eNcA5IGl3zBXKt+xEqFSn843CZGlxHOaNxihtKF9n03K84ujs1OgQ7ssrS7U3ZhvpEChtMdKuXVMWmkeciiomDnnauHVnQx8tH7QhOSfvj2yVmAq8XYox14u0IQcsjf/sG8Y9xwyN4hCe5v1ASc4cmDaHO1PpnqLj8r+/I14g+S6w17NfZ2mVkvpkwpLe2ogMBFjjTqDDcO07MrF4Qqt08yc116IiRsKE3i728fMNENoUCH7iZakZT7pZyd+wVNHO3VKG5b1VY4V5eFffc0msd3sLeJ9DvcgC4b/rkko+cBa8YkNijnK/a1Ru2VyeBLjwPuPHfxJOmJ9YU8IdaFoSTORFAXHXsD37TveIkSgO52ez4qYCmVTIIXomaslHYje1J8KCkEkXo5ECrsUwuy9ltSU8Z67CQrWkQ9fWMd2p7ZulP/U7AUIN8ViSkAcuvJR/bV5gM5Oat+RvIGlMhOpFZkkNbTsVWzYE37ZF7bYht6bAxiPT2DOObjpuGKN/bcItlFOGzerHSH4kEzn+OuAoB9/kuO0GTMYHbeQ0H743eRvxbs6X+Ge0Kyxs3iuINVRMWqH75/saXlMuIxRNk2M+iUVneMmNKH1gwG3r2OVQLYYq9xiSuALum4vjiGeoWn0NQj28VomP1Ak/dW6VOesZmKpSO4R2iYSJSJDuLbiIRav4UGffoSSB66Rj21G8nzkLDUvylQ3H26rDkjZCNJaXSJ+1O0ylEZQIygTpGygpVNAeSsjzMhn5TaPb5at+SFWMXAj64+fuIg2AAtPPrGxl60upD6ekC9GiOSG58NsXmLHMGaoXFDma3PfC7LXuYHA3i533FZBUTXLce23anTQnQK2hMm1hhZCOet SLgSil5c MGXifZHsFwdQpESQPvOWD+BdxEEdFPYAZI9RBQHbq+qYB8n6LR1SDKxaLlGIY0kybedYljPZ5lXzneKOFVlmBqLsSZPhVkGGXrpsCrq2te7KuIGqViq1icX7IZ2/fhAc0H4lEIMBzENLDWDYkcwdwGhg7s4Eix4mKH/6zmDjsA5oBZvNLCzQ5EdSbbU6oHiIRq42+20JAwistAJmOseCZThvxsHRdIeBD26D6IfHRc87Yl2ssvUWyZuyoLs4CrFor3WSq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Aug 14, 2024 at 1:28=E2=80=AFPM Shakeel Butt wrote: > > Memcg v1 provides opt-in TCP memory accounting feature. However it is > mostly unused due to its performance impact on the network traffic. In > v2, the TCP memory is accounted in the regular memory usage and is > transparent to the users but they can observe the TCP memory usage > through memcg stats. > > Let's initiate the deprecation process of memcg v1's tcp accounting > functionality and add warnings to gather if there are any users and if > there are, collect how they are using it and plan to provide them better > alternative in v2. > > Signed-off-by: Shakeel Butt > --- > Documentation/admin-guide/cgroup-v1/memory.rst | 8 ++++++++ > mm/memcontrol-v1.c | 3 +++ > 2 files changed, 11 insertions(+) > > diff --git a/Documentation/admin-guide/cgroup-v1/memory.rst b/Documentati= on/admin-guide/cgroup-v1/memory.rst > index 9cde26d33843..fb6d3e2a6395 100644 > --- a/Documentation/admin-guide/cgroup-v1/memory.rst > +++ b/Documentation/admin-guide/cgroup-v1/memory.rst > @@ -105,10 +105,18 @@ Brief summary of control files. > memory.kmem.max_usage_in_bytes show max kernel memory usage record= ed > > memory.kmem.tcp.limit_in_bytes set/show hard limit for tcp buf mem= ory > + This knob is deprecated and shouldn= 't be > + used. > memory.kmem.tcp.usage_in_bytes show current tcp buf memory allocat= ion > + This knob is deprecated and shouldn= 't be > + used. > memory.kmem.tcp.failcnt show the number of tcp buf memory u= sage > + This knob is deprecated and shouldn= 't be > + used. > hits limits Looks like you split the description (that has weird grammar) here. > memory.kmem.tcp.max_usage_in_bytes show max tcp buf memory usage recor= ded > + This knob is deprecated and shouldn= 't be > + used. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > 1. History > diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c > index 9725c731fb21..b8e2ee454eaa 100644 > --- a/mm/memcontrol-v1.c > +++ b/mm/memcontrol-v1.c > @@ -2447,6 +2447,9 @@ static ssize_t mem_cgroup_write(struct kernfs_open_= file *of, > ret =3D 0; > break; > case _TCP: > + pr_warn_once("kmem.tcp.limit_in_bytes is deprecat= ed and will be removed. " > + "Please report your usecase to linux= -mm@kvack.org if you " > + "depend on this functionality.\n"); > ret =3D memcg_update_tcp_max(memcg, nr_pages); > break; > } > -- > 2.43.5 > Otherwise LGTM Reviewed-by: T.J. Mercier