From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 13FAFC48BF8 for ; Mon, 19 Feb 2024 16:39:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8D0946B007B; Mon, 19 Feb 2024 11:39:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 880876B007E; Mon, 19 Feb 2024 11:39:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 748326B0080; Mon, 19 Feb 2024 11:39:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 6313A6B007B for ; Mon, 19 Feb 2024 11:39:34 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 067C440165 for ; Mon, 19 Feb 2024 16:39:34 +0000 (UTC) X-FDA: 81809114268.04.69DD483 Received: from mail-yw1-f173.google.com (mail-yw1-f173.google.com [209.85.128.173]) by imf24.hostedemail.com (Postfix) with ESMTP id 66E3A180030 for ; Mon, 19 Feb 2024 16:39:32 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eeswc2ne; spf=pass (imf24.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708360772; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gk6WUuOUYilwjlmi9KvPeSBtjRyvxYITvt3eyTtNzcA=; b=b0R183OtAeRWD/pnDOVs4/NM+jTK9SGv6ujxFjvNF1vddFrWzRQqm7O4dm0wCT4MTqaz9B 2hWXVVL2LSx7aWncGhFEIbgzIqQFjvUPsZPJfLAqMQoIpMDk4bGu9xojFxOkhvcFIBegia c2w4yLbHkM0LNrFmjC62Ecv3xUewSdQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708360772; a=rsa-sha256; cv=none; b=3YkwmT+hBuPRaNUJUMAaoNYkhJl2Cv8nKaOQ84taKzTou8F+4IyA4JQicMIgqtljFAQXKQ U2SJ1YtddXb7UYBLwp6xBvg/jJo+cRppZ2hYlJuq2hkMOwZJLH5nu0x/vkzEh+R9mCiUT1 aPyyrHvycw8Ahi7/DlOp++uuX/n1QBM= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=eeswc2ne; spf=pass (imf24.hostedemail.com: domain of tjmercier@google.com designates 209.85.128.173 as permitted sender) smtp.mailfrom=tjmercier@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yw1-f173.google.com with SMTP id 00721157ae682-60837b7a8ddso12124867b3.3 for ; Mon, 19 Feb 2024 08:39:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708360771; x=1708965571; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=gk6WUuOUYilwjlmi9KvPeSBtjRyvxYITvt3eyTtNzcA=; b=eeswc2neB51Gn2TQ6gYHgVcYYD0h2yb3XVtxH9oZlOqDMBwVogAW8MbJ8QxBssHljI R0lFhZno1NsrgG5a+O9ywjnuVVc7Q6ZH3DoEMEkRONv0s+EHug9dWI+5KGX7GQabd8UL 2ffdjzbElTEtsqbt4/4zH5gTYAUIfTesh2+mX92U8jCKq3hKJ3ZA4CO6PlcaHptjs+Dj 0HFF33LFstJ+4SXeShPhC3qHohB76ujnIo7EnuEeP9sJwcihQ7fW1g0OmDjvFK7GQbDO HuVhO5y7zWOs+Hy7xJbtFbhnj05YnE6m19Asb4rQaENndXSfI6zFj/1kKzyyemPpRjIg SNxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708360771; x=1708965571; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gk6WUuOUYilwjlmi9KvPeSBtjRyvxYITvt3eyTtNzcA=; b=HpOqt6vI8k3KdCX6ff7rXTgjmr8WjMuqa/ApjzTtmKRBbVN/WwtZL6Ccd06+S66gtS T9/9IRzi7xCIyvb9a5Xp1Zd41vtUnzd3/gEqzSyLg9EBjcXyZvdfbGKe5mIn/s8buQDT TFS5FBldDirJPPGFwQkaTqb+rAs5TOWWRdkepgzKVhexJsUYkLqZ1xXzTbMz5CBsd1Gr am8eIQ8S1nQixhcUdcVo5LswPtPCpHpMminaYcDVt4upS2s32o/KvfBFheZEh18bf5Uj AccCO1vKJ6VTV80r8GAcMDVBtyxeiyUxWDK6J0QD8c5boSjeCSbJ3W3SUPy0R8uHDNJv RSFw== X-Forwarded-Encrypted: i=1; AJvYcCUQB224lrA50rLIJaRIaJXO67HkecCUIAbEUGYkqBPdHD3f2UOlqEcFKeEmcw2JpwhQnBq3VtvEt4dfK+UE05eXRWE= X-Gm-Message-State: AOJu0YzLcmSwrhPqZFz1QlUyjBok5vUWV8uU1IdBIDZ2CsVg5BMGejBb 79VBpXG8vbfZmdDPhcEFSvFjBpSMj6C3OWn1MCqPkmm6aOxJu5MWzUGvX9xDU5egVH9iI8ymRU0 1UzK094K4U7lEU7nd/f5yHy4qRdMrT99ek16J X-Google-Smtp-Source: AGHT+IHOf7zN6UTEUs94Io+Il570qu2MIlpkBfsEY64np8rj8rUeVxwrc0psYvm2LfbR2YZKvPVrXq7xPmkV6NuOIPU= X-Received: by 2002:a0d:db0a:0:b0:608:218b:5494 with SMTP id d10-20020a0ddb0a000000b00608218b5494mr4113497ywe.14.1708360771228; Mon, 19 Feb 2024 08:39:31 -0800 (PST) MIME-Version: 1.0 References: <20240202233855.1236422-1-tjmercier@google.com> In-Reply-To: From: "T.J. Mercier" Date: Mon, 19 Feb 2024 08:39:19 -0800 Message-ID: Subject: Re: [PATCH v3] mm: memcg: Use larger batches for proactive reclaim To: Michal Hocko Cc: Johannes Weiner , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Efly Young , android-mm@google.com, yuzhao@google.com, mkoutny@suse.com, Yosry Ahmed , cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: o7wz1n9kg11kew9mmeb5f43hpujoaoj6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 66E3A180030 X-Rspam-User: X-HE-Tag: 1708360772-378469 X-HE-Meta: U2FsdGVkX1/taHmjGxIV8J0ghtpVMn3/s6YggPgkIT1ATe1F3W2HoBrE7i3ESCMNCT+M/fxRnnDWWX0IxjUTkWT371BiBYv7wWsf/3Xk6jrqwv0m49CSxDe4UOIKanyH9fUc41rGRD/zdA57uaLNoIcfIBYV8N3OIPzr4+qWejV5YmY5KXQheGX6OyvlEUuBlUm748W90pl9gAfR2r0J8OudBYL+KEBeCaNoKq1ISmCsGYYz3DSRUscn4MEZy/cy5WziI24ZgxbJ69/ZvxhlSeRUMIs3dZW00I1rPUOqgAGjXIclQH3UBjW3h1fVquafLBYfn+ZOywMiqddK6SwZXtq45HzzDj9ZE6U/jeaqvtP5rUbFJMKQ3b8bjIWrJ3a4ms7DiPuY8uYKRYH3K5CYLneBfXWpO4bxufVAZPQ6zxjL95O2RyN1moXMfpwIG1EMz0OlF1518Rri1j27j4suKqSjtNgOa2BoAQOfvEcTd09MniR0EgN44qeVEjFqxuFV23wHwJbttgko5nMU7IjjlZDEnZdBrsZdNjpkIgDPiVTXMyzI+bYbQ8j4SV4bj1prszBt1ggLwSpPtFl4hoXO+lXVooacVGDL0SNIkGRdy/7ElyQooJWpYTnE3QNAyH1zYG8efYtX7BgfcMVtwuaCcyFnGnLz3yk6xQx6Wz26C5buS8KrYlFjYXJLItu+qeprbcZjxLqqluTDCu8efcmzeOjvNn2eCAQmbKu2duO6bSSh2iO5MhIBC8bT89dcHZifmLZWhg1z1X39NyTj3XxkefG2sj3jXSqZVvi+tmY4umVb7mj2c1Ru6FlPh7UyOj/zQVlI7cU/8pQoyZpa63ZUaC37mG9Cq//KIOiyMjFR/KSoHST0bcDFxeumEW6RqJgWKSiGlZ7SG1ZWc5XPOibgXVjAiT89vbgjB/hP7Y0022grbWFy7/paS/s50wRLFAES/PkK4pb2HlTcvSChvTz AIlDq5Ww Az8rM X-Bogosity: Ham, tests=bogofilter, spamicity=0.003271, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Feb 19, 2024 at 4:11=E2=80=AFAM Michal Hocko wrot= e: > > On Tue 06-02-24 09:58:41, Michal Hocko wrote: > > On Mon 05-02-24 20:01:40, T.J. Mercier wrote: > > > On Mon, Feb 5, 2024 at 1:16=E2=80=AFPM Michal Hocko = wrote: > > > > > > > > On Mon 05-02-24 12:47:47, T.J. Mercier wrote: > > > > > On Mon, Feb 5, 2024 at 12:36=E2=80=AFPM Michal Hocko wrote: > > > > [...] > > > > > > This of something like > > > > > > timeout $TIMEOUT echo $TARGET > $MEMCG_PATH/memory.reclaim > > > > > > where timeout acts as a stop gap if the reclaim cannot finish i= n > > > > > > TIMEOUT. > > > > > > > > > > Yeah I get the desired behavior, but using sc->nr_reclaimed to ac= hieve > > > > > it is what's bothering me. > > > > > > > > I am not really happy about this subtlety. If we have a better way = then > > > > let's do it. Better in its own patch, though. > > > > > > > > > It's already wired up that way though, so if you want to make thi= s > > > > > change now then I can try to test for the difference using really > > > > > large reclaim targets. > > > > > > > > Yes, please. If you want it a separate patch then no objection from= me > > > > of course. If you do no like the nr_to_reclaim bailout then maybe w= e can > > > > go with a simple break out flag in scan_control. > > > > > > > > Thanks! > > > > > > It's a bit difficult to test under the too_many_isolated check, so I > > > moved the fatal_signal_pending check outside and tried with that. > > > Performing full reclaim on the /uid_0 cgroup with a 250ms delay befor= e > > > SIGKILL, I got an average of 16ms better latency with > > > sc->nr_to_reclaim across 20 runs ignoring one 1s outlier with > > > SWAP_CLUSTER_MAX. > > > > This will obviously scale with the number of memcgs in the hierarchy bu= t > > you are right that too_many_isolated makes the whole fatal_signal_pendi= ng > > check rather inefficient. I haven't missed that. The reclaim path is > > rather convoluted so this will likely be more complex than I > > anticipated. I will think about that some more. > > > > In order to not delay your patch, please repost with suggested updates > > to the changelog. This needs addressing IMO but I do not think this is > > critical at this stage. > > Has there been a new version or a proposal to refine the changelog > posted? Hi Michal, I updated the commit message in V4 to include a sentence about restart cost, and added a line above each reclaim test to note the MGLRU config and whether the memcg LRU was used or not. https://lore.kernel.org/all/20240206175251.3364296-1-tjmercier@google.com/ > -- > Michal Hocko > SUSE Labs