From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F4D9C001DE for ; Tue, 25 Jul 2023 18:05:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F8BF6B0075; Tue, 25 Jul 2023 14:05:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A94C6B0078; Tue, 25 Jul 2023 14:05:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 771376B007B; Tue, 25 Jul 2023 14:05:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 68C026B0075 for ; Tue, 25 Jul 2023 14:05:49 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 2EB6340F56 for ; Tue, 25 Jul 2023 18:05:49 +0000 (UTC) X-FDA: 81050912418.29.1D4A50D Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) by imf23.hostedemail.com (Postfix) with ESMTP id BE8FC140015 for ; Tue, 25 Jul 2023 18:05:45 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=IR7MPLRN; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of emmir@google.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=emmir@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690308345; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3gBnT3Q9DJqSuXcP4CzN0zSoMTfKvs3KyiDNWzlI9V4=; b=Jq2v+Cdn8uF35UgFoFq0t1/18oK5WM+JWS6ZVw4Rot+epKKpgRhO13FgLO2yZl1tFurjF4 CpFBeOUapiT5VZmFlBhBVlulOVK0sxQD5zd4dEqm86vx3kg76p+7R8nQIjKWJQDxQco8Zp bfhTwpAhXHBp47Ee7Lp37GIsBZUrO1w= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=IR7MPLRN; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf23.hostedemail.com: domain of emmir@google.com designates 209.85.208.44 as permitted sender) smtp.mailfrom=emmir@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690308345; a=rsa-sha256; cv=none; b=mcJXcGrSS6ddtPzjTf3NcSZLaogRuTsr8QsAQhEbG4PZJeJzSDJLNZXKrbOdOTgqkDnnoM oNHvXGX4yfsKQvGHuXvIdbV9CMYd4H4JaDgkwZvRKQyBcjw5Cry3DWcZLaZEcsfomm7oVV f7ueD/GmbLNDzt6gBScCB1gyWVpRN0o= Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-5223910acf2so1825a12.0 for ; Tue, 25 Jul 2023 11:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1690308344; x=1690913144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=3gBnT3Q9DJqSuXcP4CzN0zSoMTfKvs3KyiDNWzlI9V4=; b=IR7MPLRNrwqnMA6Taco+EOZJ6KtwnxWYXAWsiIpvLEpZ8GqzUUtArAD7xEuCO+mZv3 aOiO+lW2JAnLZdb/Ck6lRn0BxAyt4qUSG4lQz26wvv5CawhHADRbfR8JdTkmZuqKWid3 tQ4sxPrTLguBe5mOxWPkRgp5C+jQLB/QhL1zPzTMaIbs+8YY+xGjT6uCSOiuP+ShH/yh bghhKsbg4+YtihSsav+R2zhvOZpDN1YaMGxBsWq+BgWfdppwO7aEJnEB/IB6oySvNTZv PZ+ebPFJ7IFs6PMAwkdsvH388TRo5wF31MrlTWn+ckwpC0JHlIN/H20Q8pM/lztUD7CY vZjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690308344; x=1690913144; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3gBnT3Q9DJqSuXcP4CzN0zSoMTfKvs3KyiDNWzlI9V4=; b=Wx7Je2BaC10VVEEuixq/sz7NYllAY3eFjD7dnH2ON1qeMJywFkxEqHP6FQLiBM5/4y 5GqQwKPrw+mn/00oDoGK5yZY7Jq9ErDnGMwLsPkvheXqy8DU8JyJ+JwrlR6hFAZZw8EF CrqSUgYtkLQ6xZ+DeiQG0w433zGcIYnga/u+5ZQZ7WYb5O1EzBfHJ82wL0OOkm+28PS+ jOUve9g2VbrZpnDiAtRY/VvRoEw7YxGXeFkeeATioNDu+2s2xaiSXnTFieg7I+nTr2// W5j4JOA0RIOlD8jOjvVTiZs9ruz3PQ2xGZSjAdJ1LdFg86PBQYmMx2OGFzY2D5YVFGr0 dKUw== X-Gm-Message-State: ABy/qLZwelmbhOVkR7Q7VDkOisZihNS9gBaHqckwt+3Z4Qw/DFRZ7r7v xmW/7uaRAjwMfJ7sGPlgTOXK6dSqpciHWnor/+Ztyw== X-Google-Smtp-Source: APBJJlFx5VS5SCJzOTClBE3oorb3CkqCx6mrIr5bXycpxVlMeBOxmxwx7XhBiLPrxEo29Ul0BYE36xYQQxmuCt7+gdA= X-Received: by 2002:a50:d6de:0:b0:522:4741:d992 with SMTP id l30-20020a50d6de000000b005224741d992mr146970edj.4.1690308343974; Tue, 25 Jul 2023 11:05:43 -0700 (PDT) MIME-Version: 1.0 References: <20230713101415.108875-6-usama.anjum@collabora.com> <7eedf953-7cf6-c342-8fa8-b7626d69ab63@collabora.com> <382f4435-2088-08ce-20e9-bc1a15050861@collabora.com> <44eddc7d-fd68-1595-7e4f-e196abe37311@collabora.com> <1afedab8-5929-61e5-b0da-9c70dc01c254@collabora.com> In-Reply-To: From: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Date: Tue, 25 Jul 2023 20:05:32 +0200 Message-ID: Subject: Re: [v3] fs/proc/task_mmu: Implement IOCTL for efficient page table scanning To: Muhammad Usama Anjum Cc: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Danylo Mocherniuk , Alex Sierra , Alexander Viro , Andrew Morton , Axel Rasmussen , Christian Brauner , Cyrill Gorcunov , Dan Williams , David Hildenbrand , Greg KH , "Gustavo A . R . Silva" , "Liam R . Howlett" , Matthew Wilcox , Mike Rapoport , Nadav Amit , Pasha Tatashin , Paul Gofman , Peter Xu , Shuah Khan , Suren Baghdasaryan , Vlastimil Babka , Yang Shi , Yun Zhou , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: BE8FC140015 X-Stat-Signature: k9p4gtscrz7qacsfp8gcbojw1ajpyk99 X-Rspam-User: X-HE-Tag: 1690308345-961692 X-HE-Meta: U2FsdGVkX19HWXAEtlp61GdZGiBls+ufWiHS09IbbBzQC4yBImBcSpINh2paQun6xyy5o3BpDZQs30tRkgHes8tMCC1zPYqLHaZEp8IdvKg0RG8cN/oXf+niotNBt+8lIRBwRkTsQ8eTIIlcgJ47aQcWbCQXPlM2+P6nqD3xA5lMJfMpMZx6nknjkSfDeCTNOAy8kBJcTWAKuIZUFN763d2Hev4qZ8QE4BLf6VfoLBKIYLVaDO39vGWGGDicvruR+Oj7GuhvFtP+JxvjXQw2QEn9gMkRQ48LoC05lg2r0NQ0+bTmlWR22imY+v+81Qh+7IrCf4dZ7CbrhmYmlb57cxop6cnj8bmiS9Mo+H3M8y/hmPHgi2yp0gu5/WTmKo3KHpS14qN104eXzz2r3Bv1RkKYpmtGVHaMSGCCc068BrzVFx/hY1Dwkhg8r88RKzLhZbTthlgVNBULMiDmt1cL7U1Mp/TE7g8vkUoGwHQEur8YAvcJ/7rU7Wf6QaaEUBEFuyGjRc8XAnfNEzP/94gzy+K+0ppFJj0HB+6i4XkCy4T2LkL0ty1GaZ13j/dhUmaiqH6JGVZuRpIQnKiGwoDTdE/0SDaFpxZQBGAnizA9cL7UKDy6gqx9BHbHMNd8mceK3bFdqEIoW0WJ0ZcDdvGut4l1anhEQNMPKDHUOUu51kPSwVl1lEdK/gHTgk086R845ol33nQxyFNfGeH7Md+500TxKQRcQaU0xAl7vELWNJIBhkuAIS9emXrWpbEApJ5BBZPuC3twRLvGC8dD6ADEE0L8lTgQeJi4E8pgP6e7xuKo2jvP4ZHDdjq9c9CyR0AzFwJ4u1Dbm3ZOjsJLLrOthYVc44RTeqGUAUYJlqOwuud2XtXxnSjRVz24VVrr6YanpxNBXTNEzIfOumRgCQGxX1XtE824SmkNBFedvtPZiwZksdu6WbQHsk55NjlKM3TB0AiNcPqydgyR6OVgPv4 tTlXK/3q 7SCWrskb0oalsACX6XcoZjZYdxXZOfqwOZ5gpRBM2zIXdzFgnRbmqwbHupzNXZxrwr7O/46hw+WpZTX2yULLQ5BDLoDRpz+8sVv8kehMxbDZYuSusE3rOTl/rjbtdxpyU2zx5eZqv6UOe0UpIvOdnOyTn4d/m0fUhgDBOJ9Po+SQXWXWB3V+EyrV4v6basd3LSwYlsfs73R9YvgySGzSaKPpeYZ1fKEEb0oxu0BATh58teH4WRrx5wx3OPqC34HI4vnzUDVPsofVvXZ9m/12Jgs4wAYCOn9/JNwZGCD2ihdUoJSK6bT9nQLSCI5xX1tszCjyb+va4xz2HUsLujxp+b3FetYef0o3FHvyHsh6vrQu2xKz9aixYoUOucoMMQa22/W/C4+3NU+x4Yos/ZYQd4m0n7Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 25 Jul 2023 at 11:11, Muhammad Usama Anjum wrote: > > ---- > Michal please post your thoughts before I post this as v26. > ---- [...] Looks ok - minor things below. 1. I'd change the _WPASYNC things to something better, if this can also work with "normal" UFFD WP. 2. For the address tagging part I'd prefer someone who knows how this is used take a look. We're ignoring the tag (but clear it on return in ->start) - so it doesn't matter for the ioctl() itself. 3. BTW, One of the uses is the GetWriteWatch and I wonder how it behaves on HugeTLB (MEM_LARGE_PAGES allocation)? Shouldn't it return a list of huge pages and write *lpdwGranularity =3D HPAGE_SIZE? 4. The docs and commit messages need some rewording due to the changes in the API. Other than that: Reviewed-by: Micha=C5=82 Miros=C5=82aw