From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98C45EB64D7 for ; Wed, 21 Jun 2023 13:42:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 37BAD8D0007; Wed, 21 Jun 2023 09:42:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3044A8D0003; Wed, 21 Jun 2023 09:42:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1F37E8D0007; Wed, 21 Jun 2023 09:42:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 108868D0003 for ; Wed, 21 Jun 2023 09:42:35 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id D6394140838 for ; Wed, 21 Jun 2023 13:42:34 +0000 (UTC) X-FDA: 80926869828.14.3177677 Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) by imf19.hostedemail.com (Postfix) with ESMTP id E03B51A000A for ; Wed, 21 Jun 2023 13:42:32 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=sIctj19+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of emmir@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=emmir@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687354953; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=acPAMDZruYemX8TV6cTFFhShCBAic/MFb6BfUxW/eJ8=; b=1thIf7A7jXFYPfmVpXEdhCQiq8RpPLR6OdtDqLu1Y9S0VKkcoTwBp/izY/SzoRVF8LVijj ybxd0VM02tBgcT3yqM9AVJF+EmAha8n7DwVcUjPpWqawmOSMBxjSrLexK50+ZVZ9c4hNQA +qeqfejPZSkNe2fP0FBCwXN/2u0oBPI= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=sIctj19+; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf19.hostedemail.com: domain of emmir@google.com designates 209.85.208.42 as permitted sender) smtp.mailfrom=emmir@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687354953; a=rsa-sha256; cv=none; b=DfN4eF35a1+Sg/PLCuTOd9fT7QTmejICmdOxBecea7sadzIYWQNSkqUQcoWpd+HZLJzD4s AQSvY3Ldt0e8U8LC44ZR3xR2unhXoyNnCgm2ivs+MmJ7lYSoNt1vDjz8ducuDdZpGEX0Fr yzpSotDjrm36g60tGlR+YM8xAtmvZP0= Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-516500163b2so3209a12.1 for ; Wed, 21 Jun 2023 06:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687354951; x=1689946951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=acPAMDZruYemX8TV6cTFFhShCBAic/MFb6BfUxW/eJ8=; b=sIctj19+4iS+N71smDAtyzFiXlzPZiOW+G6z39xane6Zv//qrUMsCz6nAa7J6rV7AC b9Jkx0V70uzOFA8gjwzskpQqkQ4Ukl3fYwTxBHAEaFMtCEOImHM7hEt+2d/UvfLorHs0 4E1pwirARjhBK//tyNLrThGOxKwhf8L7gVbhpGvtGoDCGkas9ROaw3nofqrra8OREG1m aC+ioXYVUWJA9heR/2mhaSbQMckdie99gPv4K3MUVGFZVhmZLWUa4UscoMWhoa08jzae PCAeOpYXF+j2zdZD0b/8Q/x7fn08yK7Tm3Q0H2oFC/DCBLrlrhJpxBsjUT9YlpgTarMt d/DQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687354951; x=1689946951; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=acPAMDZruYemX8TV6cTFFhShCBAic/MFb6BfUxW/eJ8=; b=TxucoD8q5AaOpmOS5GXu5uLdw/XTDmcnjjT01RruNDfinG/v6KE3g7yuUAQxeP58Wt Ru3OU6gMpQbRrpu8qUqLdOf9KF8dHt02B0Jo8AioKc6GeF9d8Z0ja3LTpMRcbF0BYtJ9 yPDrUJiMIkLY6bgWwUMKsrrlJbtsYEzsKKIXAFzJrkxTFspOlo4XVRcoOs4fHPbWRUww aj9PLQ7mbCPr2X77yXY0/5DeTSn9xHW/p61KU5e0Boo0pDqLbInc3p2cgH2JHuXW9Iys 65GseiW3OYAVLjWGHnrRQfKZN7BMVlQDxCUa3cwsm5xgu99FKhbAh8w0eqQ/kDoR867w yhkQ== X-Gm-Message-State: AC+VfDyDGG5KACoGeFM6cbeXkSyjbGWuBUr7knRbe1Rqy6LxRsOSwxLG GFkRuztf38s/0hiXGYVOosW/2LsDVrDUZb/wwgnXBw== X-Google-Smtp-Source: ACHHUZ5UHF11eJAlQXvvGM7fzyvA2yQYbNg05LXVZvb+ql5FzKqus823wT1co33vViD1konnn7jxrblfw3QsQIOgWL8= X-Received: by 2002:a50:d59a:0:b0:51a:1fd1:952f with SMTP id v26-20020a50d59a000000b0051a1fd1952fmr632263edi.1.1687354951319; Wed, 21 Jun 2023 06:42:31 -0700 (PDT) MIME-Version: 1.0 References: <20230621072404.2918101-1-usama.anjum@collabora.com> <20230621072404.2918101-3-usama.anjum@collabora.com> In-Reply-To: <20230621072404.2918101-3-usama.anjum@collabora.com> From: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Date: Wed, 21 Jun 2023 15:42:20 +0200 Message-ID: Subject: Re: [PATCH v20 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs To: Muhammad Usama Anjum Cc: Peter Xu , David Hildenbrand , Andrew Morton , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: 594dzgs6iu86gu6miid9dmrcera659ez X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E03B51A000A X-HE-Tag: 1687354952-478856 X-HE-Meta: U2FsdGVkX18bT/jEIqQLXc8hM4WXIgLva+ksL/sBvJDHMMsgkuntLvhYBH4wiZHx3ugPsj9LLxq0+fh//zqSeF42/J6KDJCp6unI7mh6XdqzPu3LEG2jJdI0RPb7WxuSuVmsQliX6BvKNf6DFs/oiP8cpxLDKornWaJAP/27jXaeO7A1KVCoAs26jxDTpSYMxB23dDLfXma7RG5bqSjX6KA1tAVJ3T/WBJhcwslNvN5tUKNq8N4yZxB6xI4xY38YTsC/HPUzOWsxSjlzj+suffeTE3QovzUsN1Z23DD1ZpC5HI6m1lyYWb6WMiobbxLK5Z4nSrBMH5P8vQBffPZk7j5A4yK2IT/AiAsyb0GgxGZoEANoOsMv5bXBYAwWt4/MEGz8RJQ9MK9U2DXRafncrEPHi5JQrvYsk4yZTBWUPcY8JCrvYewHX5Ys2OhNO9CTPSqth6NOUBXD88vRrKTPGyVdGlMmfx53vO54CQD1bm99GXIdJOcqGQ3VRvBrf54GUXXuuNy0gW0bSEZZSa7wa2XItg5AScOFjjzuWWcMPR15lP1tcwdeLvo4V2nDtEXdfbrPlsl2Iw70RKGzoO13WarDPxbcIFV3sI3j4e3zIwXBi/lCm/s+GZ3AGoAyt4z4pwRFB1Mz3411bZvGeAZ2/IKyqleJiwyfn8bXsyFkqwgIxTuWt7e69zjfZ9ePaz/tdkE3kIYBxJbmxQJf1zwKXYCrTyPusRpsw1lpSKzBWswI3jscv/3YxyHnuwXWdTQBMAyZo8PeNYf6NsEoldWuLjGm+zD8E4jCbOefbwl//m9AcsT8H/iz9zt3h7qwV31NEb52XpUB6b2J2Ec5KJImW7yo1H6TqfGnSo+tT7i34/tmsUVYxeJbZpt5D4erk7udXQ7W7HQv/XzAkiYJBAlhSm0lyEsxI7L9VB3eKNSfYkcZJXcMnpAaMaON5aDnE5yQV6meVsvlpURjwrrSJWO PhD6Umw4 aQU3J3ANXv4fg6B0Z9ulqbUw/ii2Nrke2DZ3vS3mn3ZfQ02aE6oT+pd/1LX7GeEjrIaBY7bznbSkJb+fbLOOk/QTeBJKDkGsVowNwviRI+hd+ljlAJUXCTkkJzdLbWigZI6ITo6tVsfV3ciuLvsfcNL2SUbXkYBcvO/WMzoaMFblAh0oX1DtF3+0Y/LEi3mU1ubid8wRPi9xfPvgxHNYEDqlrc8bF4vlVBf7Do+JsfjxvvmKW5ljDdPWYdqR/LgtStKO+6SthECMvQ56PNftZo9b5wJ9lDLAklObH0HbDXvTl8oisrjAzK1ov/cou3Zeys3s8iJKjBfG4556tj6JbdiprZJA+ymzJVYfPwqT8wxdN9ok= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 21 Jun 2023 at 09:24, Muhammad Usama Anjum wrote: [...] > +static int pagemap_scan_test_walk(unsigned long start, unsigned long end= , > + struct mm_walk *walk) > +{ > + struct pagemap_scan_private *p =3D walk->private; > + struct vm_area_struct *vma =3D walk->vma; > + > + if ((p->flags & PM_SCAN_REQUIRE_UFFD) && (!userfaultfd_wp_async(v= ma) || > + !userfaultfd_wp_use_markers(vma))) > + return -EPERM; > + > + if (vma->vm_flags & VM_PFNMAP) > + return 1; > + > + return 0; > +} This could actually short-circuit all vma flags (e.g. IS_FILE): if (required_mask & IS_FILE && vma is not file-backed) return 0; Best Regards Micha=C5=82 Miros=C5=82aw