From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A459EB64D8 for ; Wed, 21 Jun 2023 14:27:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1FAB8D0003; Wed, 21 Jun 2023 10:27:49 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CFC48D0002; Wed, 21 Jun 2023 10:27:49 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 898598D0003; Wed, 21 Jun 2023 10:27:49 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7826F8D0002 for ; Wed, 21 Jun 2023 10:27:49 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 38B51A07E4 for ; Wed, 21 Jun 2023 14:27:49 +0000 (UTC) X-FDA: 80926983858.24.F8DFAD1 Received: from mail-ed1-f49.google.com (mail-ed1-f49.google.com [209.85.208.49]) by imf13.hostedemail.com (Postfix) with ESMTP id 5139C2001E for ; Wed, 21 Jun 2023 14:27:47 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Zx7ZT6CD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of emmir@google.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=emmir@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1687357667; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Nx/8tkwi/QCBsZ8gmyeG8Rkuz2KMvUk7ydKIx+Um+wA=; b=E32msm4cHNRCwciwvl7FhEA20ESGbBb55B7uoO9KmKDc1gIO+5KrcpUIs96DJika0y60oK O6PRytZ9diZZhcWAG5/z2Zc3vJoC7EY4pKs2/NXKnc84ff3xV3U6bj+dSuBZAkVF8uhwHu fGuxkl0kT+clcjWvuh9OOvZQC19ecvQ= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=Zx7ZT6CD; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of emmir@google.com designates 209.85.208.49 as permitted sender) smtp.mailfrom=emmir@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1687357667; a=rsa-sha256; cv=none; b=UUBx0A8x8GZK46iCIXkhQa0yYrfP9rl5qIKNilDkLpZ3s+vWno7gfFR2tW7h5PMUBAoEmW xtub+za3+pjRC8wN24QiC8qeyQ0jXX8UlGGniuh07BWyvlivwwPAYuAL1MJdc2ijOL1kqr MRiYMJw+f+FSQNCCTVfou26ML3pj/Ac= Received: by mail-ed1-f49.google.com with SMTP id 4fb4d7f45d1cf-516500163b2so3682a12.1 for ; Wed, 21 Jun 2023 07:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1687357666; x=1689949666; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Nx/8tkwi/QCBsZ8gmyeG8Rkuz2KMvUk7ydKIx+Um+wA=; b=Zx7ZT6CDGiK06H867vY+sNm4wafZK+Kvmb8BqCHCD+RgK/A8TOsKrYm88ZeQ2SECqv S7fVo2jMZAWlKlfibVSF4+NdJIuFTIa0/hV9eZbzpGNs8NdeOq6Gf/hK1j41+VqJkX7f 0MdtnvEDcTvQ1qlxcyubtHy52SpsQWtzGcgMHO/beMlI2JAgE/lBuWgZO2ZNHA+12UAk 6xkAO2o6lOr6d4DjCP484PkPelet7gw71VpFO6zM1RaeJUU4GliVx6GQS/0Q1anV9/b0 1vlDsaqBmqIlvqPZnEthL85A7DkyTOobm6olApyMhJG0hLtOI5m8PH9wari0gbV3oEGX O3+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687357666; x=1689949666; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Nx/8tkwi/QCBsZ8gmyeG8Rkuz2KMvUk7ydKIx+Um+wA=; b=S0JpiaWMKM581SktjKqY4SCzfoJivOBBqJkdSz5XSkUbIqo42wm6IYX5lOIL3M88Mp SjIApj5/uPWKK3Xz1jz1ztkhdHpl6yAJKrib8eecDcbvRWsn9vxmdV9/46gfOl42jeE8 Tbq6Q18Zrl9SMflwDMPzxVtPVDmLBe/nraFCrdegqm0AIHZ3sHE93jvor58QrlRMo1hj I0MfStZOjp9yL1hE69DBoDb/otr5zNAdxssrwp9ykUDW5+Gnt+wEhPjxzWfAQeoL+73Q 7fRn/iOOsqPlQtjbgkWzVA3ceMDA6osAGWsFWZPT7UYm2/gp3c/pbW7zQpkV0xvZ/BlR qnJA== X-Gm-Message-State: AC+VfDzmWMT1wyHdoUeIJ7GoUInirT3gku0gp/dhqKetDB+D4YXXAn1y DeXwLJx5tSHP7SebrMpkd+KBpSkixyPmVtM+70eMTA== X-Google-Smtp-Source: ACHHUZ5b784EIfEpEvB4OmcZ87YYr3Ia27+LLB97tML2JkkHkDJzLWdV+C3hXWpgda3VhYBy/K3VCv+xK2nMSkOkpVY= X-Received: by 2002:a50:d79a:0:b0:506:b280:4993 with SMTP id w26-20020a50d79a000000b00506b2804993mr20647edi.2.1687357665556; Wed, 21 Jun 2023 07:27:45 -0700 (PDT) MIME-Version: 1.0 References: <20230621072404.2918101-1-usama.anjum@collabora.com> <20230621072404.2918101-3-usama.anjum@collabora.com> In-Reply-To: From: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Date: Wed, 21 Jun 2023 16:27:34 +0200 Message-ID: Subject: Re: [PATCH v20 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs To: Muhammad Usama Anjum Cc: Peter Xu , David Hildenbrand , Andrew Morton , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 5139C2001E X-Stat-Signature: ba7jxygkhy9boqjip9q76aaajabq83pw X-HE-Tag: 1687357667-737709 X-HE-Meta: U2FsdGVkX1/tVDsimO/NspIPG68uWzaNS5W0JlFgDAcv2+on8OVq8vU8RcDZo5ovz8BgSMcEMJhx2LAqoLlCXFr2A0ur8YT6kQalIQbOYJ+9ZpOxATwMc72fsYTS5u0rxBFIyCJFjTqjm8kmX+5TAmWiKEeDGOHlYKNMOyxNFFOt8+9mLUxGMhlOQ4slC3P1GCDhpUnt4uQWVh9mxCEpEAU1UiV+PhwCRxS7fsBp0arRn0U4oWLLGNcBOyaaHQ8K/qA78MeezHpWccdq9oUeifxHOj0hL9siErbwIa56CIWKVhkynKstaBhlLismUY1DYeM0IgMlPG8P38VbSiVGBRLxkEDjMbpt8mYEQpofpyunJH0d79wc6RR+3WIfUUWtwV4pQPLlLej52JxJMAa8r//tyGQrmTBteEuC7xSrscufnIEoGBzl0XnL689jbnjSSkTkeaX3YmUryzE/gOXCyp7YSsXoGSYY6PWk/a+pGN29jA+k5oaUxnoCtVCTjQvyQ3d+v7tlQQ5Nrc8lJpLacyaa91x7+MyC4xvfzRuy37IbYq0H4PQtxmMsoOC5lHajuJyjoUpbycWmXFIBbIIhMqcDQzZcASvUWb24Zs9DzeQEWSPzQQcP68PCgfKPXx1Jwh7lS6FUSoCV1S0DGijWejFERFkxlQyt9KnoEi0bZrgQwkfYW70ntKBhiIQMXsSrqqIMr861Ck6IMIijLYEloYEEUUF70+kVlAX0YuniNn0AZ8YnBEZ3mzi6gYz/sg4s8NfMD67CGOUtx1cFLA1L2DuyQo+t66TmsytvKo1NSh3IqwXENvl790ZgKO8rudYjzetw8i22cZx+a2YUmzihonBzRPjrH1UUdxS2Q8ee/nRJUqRisV0m+4du2ASVUPlACESUez05XtbM82AD1XoSbR05Dav9OFNODRHJz6UW9ARE5sjCHabYUSx/4iFG6RCjSr4yhpxeGuVyeAko10b geKTAcb6 /y22xu6Pf3zPxG3VY1Tfbo252xJizDMf3iCkNL2CaZCsxPoI29KlQ/R/1oXYT6yoNDYuOkEWzqUNc/c0Mx5ggaANyUT1oJC6rkGQj47A6+1EofYgF4zSXMKo8PY/pok4qaMRJ36i7u/pOnE/ArLzK/jNnUNWLfYN9VrkKKa4TgFNuuNCxLKhzFd/OD4bylSHZvSI9vruJnl06Zmsvp9N4cUxQbWdixhiws67Y8GgVpXyvq3zeBOAAIHQqe9L+5hCpz69yu01ZXreN992OSHbsMNGLCvuIEK7pYlBGmKYBApzKR6xy27cPYs/ohgjQxHGbE11Cx2axfni0eZcxoCiHUny9/4umeqXhh05dDXyXbwIdWD0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 21 Jun 2023 at 16:16, Muhammad Usama Anjum wrote: > On 6/21/23 6:42=E2=80=AFPM, Micha=C5=82 Miros=C5=82aw wrote: > > On Wed, 21 Jun 2023 at 09:24, Muhammad Usama Anjum > > wrote: > > [...] > >> +static int pagemap_scan_test_walk(unsigned long start, unsigned long = end, > >> + struct mm_walk *walk) > >> +{ > >> + struct pagemap_scan_private *p =3D walk->private; > >> + struct vm_area_struct *vma =3D walk->vma; > >> + > >> + if ((p->flags & PM_SCAN_REQUIRE_UFFD) && (!userfaultfd_wp_asyn= c(vma) || > >> + !userfaultfd_wp_use_markers(vma))) > >> + return -EPERM; > >> + > >> + if (vma->vm_flags & VM_PFNMAP) > >> + return 1; > >> + > >> + return 0; > >> +} > > > > This could actually short-circuit all vma flags (e.g. IS_FILE): if > > (required_mask & IS_FILE && vma is not file-backed) return 0; > Sorry, unable to understand you. Should we do something here? It seems I had an earlier version of the patch in my mind, where PAGE_IS_FILE was based on vma type. Sorry for the noise. Best Regards Micha=C5=82 Miros=C5=82aw > > > > > Best Regards > > Micha=C5=82 Miros=C5=82aw > > -- > BR, > Muhammad Usama Anjum