From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF839C76196 for ; Thu, 6 Apr 2023 20:12:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 489436B0071; Thu, 6 Apr 2023 16:12:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 439326B0074; Thu, 6 Apr 2023 16:12:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 327EE6B0075; Thu, 6 Apr 2023 16:12:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 246FE6B0071 for ; Thu, 6 Apr 2023 16:12:20 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id C3CCAACBB3 for ; Thu, 6 Apr 2023 20:12:19 +0000 (UTC) X-FDA: 80652063198.25.FA501B2 Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf12.hostedemail.com (Postfix) with ESMTP id E3D634000D for ; Thu, 6 Apr 2023 20:12:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=eLh2M2ox; spf=pass (imf12.hostedemail.com: domain of emmir@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=emmir@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1680811937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=hfXQEoCgBqadpu6FRThsZsy1nkY1OVsi1rMIvATBeoI=; b=IlZHLeFOh5xRB1+YGrkYRjCqNKe3ITN8mQV15KLcNeUSE+PKpiNx8MLToB1LNvwct5U62m pEugcUkqGVjPiRC1T0BdjIGjIRuxYeHkje12am42HFoU2gKsCnddC5HlEtfWxQrEoeo0zk YFmxMDWYKqFQe5x0CPj4fVVNrMIKL6o= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=eLh2M2ox; spf=pass (imf12.hostedemail.com: domain of emmir@google.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=emmir@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1680811937; a=rsa-sha256; cv=none; b=nev2jxKu/9EvZjdmiOKVT5VXk3a89OPZeBm16+d2jy0xZW9q79R9UsPemHBE0zocwNhccs 02vSBVhLdub/Ue9ck7nceySM9j2wcuOegwbv9gk5GT4WJi1eCRDpEhICr9k2AyihmiXCOx Zh8op7Ls6rD5qzpZQP2dhqylkfupZ/8= Received: by mail-ej1-f49.google.com with SMTP id l15so4121444ejq.10 for ; Thu, 06 Apr 2023 13:12:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; t=1680811935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=hfXQEoCgBqadpu6FRThsZsy1nkY1OVsi1rMIvATBeoI=; b=eLh2M2ox7ujSVvQ6g9xvjw/WemChY3P4HRSOdHrdgai9GlQKCSmP0BGwnq2lSAjYEP Fapb2AbNv5Gfj16ljxDNnlAMyzI5zF8Gopik9TnFJMJrPhvTMNEQSsUPsivu74u7bYBh PVi8jp/K5KOpIq2YvkU+sUAuMuZutnSno/fRPjRnq+3Znlb1v3jpvhteI4OL0vRVE4fX Of4a8TIzoVa5/AykJda6kyFA0VO9w3Wul3dP+No2oOAG+TUCa2d9G+ytndgPJ0y1Qqs6 bm09CvYM1UsyGT0YIHH82BvLeQ/dp5BFc+bZLy6J7hbPX/WK/sxIQoDiBcjt9kf3j8cf 1ijA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680811935; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hfXQEoCgBqadpu6FRThsZsy1nkY1OVsi1rMIvATBeoI=; b=k94IChXUO20muy3yTsAe8bFgeDVQjpjEvH1OrsDKHkFQqrJ9koxGckrZsmSSktY1Rd t0xo2ZFJNPiiJhYU7xCzY2ta9SEPwA/3JZz88I1zg/oXSCUtGn1YTwo9QhTNk7nRFcgS /LNpjQfaCa+lGCpvuFGxA9U9s14l7LlEwKxjH9ZyRjPydisJhAIx+7h99BJNzqXwCSo3 r5xCfjuLdvtdaiyaKM2jyoYgWtWrKkfW/49v2jdAtTXFebPxHR2iSQceFSEzN1i9qvhi aeYlUJ/VxVrTVyqIsny5EXwo7RW2V3iywAeDxR//t9o52BVSwTSxooCUrcR32EQh8mR0 Ov0w== X-Gm-Message-State: AAQBX9du3wgUxoPH4PeSr6V3lXr/MYQ6N4sDTTHkg7cNHTqGDUktvjwQ 7m2MVbgDg9SjpXN9bIhQUdDhv9apSvYi15O4Iic64A== X-Google-Smtp-Source: AKy350YWTiBKhF69rS3s7/XUdyc2hKHku2MPzilut5tCz5P9UctIFCxaz2a8OpRCWENJH0p1saUwx/M1YK9rBFquknE= X-Received: by 2002:a17:906:138c:b0:93e:186f:ea0d with SMTP id f12-20020a170906138c00b0093e186fea0dmr22597ejc.15.1680811935410; Thu, 06 Apr 2023 13:12:15 -0700 (PDT) MIME-Version: 1.0 References: <20230406074005.1784728-1-usama.anjum@collabora.com> <20230406074005.1784728-3-usama.anjum@collabora.com> In-Reply-To: <20230406074005.1784728-3-usama.anjum@collabora.com> From: =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= Date: Thu, 6 Apr 2023 22:12:03 +0200 Message-ID: Subject: Re: [PATCH v12 2/5] fs/proc/task_mmu: Implement IOCTL to get and optionally clear info about PTEs To: Muhammad Usama Anjum Cc: Peter Xu , David Hildenbrand , Andrew Morton , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov , Mike Rapoport , Nadav Amit , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Matthew Wilcox , Pasha Tatashin , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, Greg KH , kernel@collabora.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: sieftq8z3err65gqkrfxoige81m3kfug X-Rspam-User: X-Rspamd-Queue-Id: E3D634000D X-Rspamd-Server: rspam06 X-HE-Tag: 1680811936-481213 X-HE-Meta: U2FsdGVkX1/iHN+Vt7arzP7DOWmTlZR3J+8ZVYhedB1VuPB9wwBDXCwGDH6GyRMIJRAnWVQWQjnpIbNvxQcaU8/svX1f+oB1nKu80tDJegRAWHy5Xb54Wlfpiq+gZ5nL6QbNDKPder4xc10TmBGlvfkL2Vnher8qV7j+YJE68bflUzkmrHnyXTQBWzFGXvcjyxpEpIToA06xowY77wKBvjmZayEDW760Q2JrmENN2rowG1KXurL6uITSZAxApHy6IzSrQxlcrrAyWhEGHNB+I78RtOVUrA56KfEypDkBCsT4BrzBb3WjodzRWTHmCtBhxJf7s7lXgGyMHcJT+XWM2uwhvIUQQrlXunMNonudqjH086Jwj0gXD9SlaeTFlTJpCC84ZMDeSpfCnzIglpRZWJccl58G4ZGk4LPdbjK1omVYGwtSnlOO1Jv1Aoe/AjU1nfKexa8P1GStHT8YqNxRwGOk+/0a5OnO/2T7wztvC4s/0E0QoYsk05dtN7MJIXd6J5bC25rhJ/gR1qevjg4NghthuJ/eJzBeTuZaMeLN23gSg/N5kWAA6nzHWao85CQWCQrofftgSHZa6NWUGIXAJtj7GvRIVtjkN9WFyWdGLd36+t4FKEKNr4dHk9F9oMhBeHSNEvn2woZN4LK7F5Gq0dMz98AWXRZTMKgoRcB3rFYWZ8Nh74uPNsEMGM1q2QRmMhUu4Yas7e4nu5HZnSNxiKoOLqCpu/azv2NK6xeDVPvvQbjmxTWWDQ8vYeRAARRmXZblEzjlYD+q4wtGar6wsJGZEB6Eq1JtgZdizSDHj0k85yMDgSTJxoJBjoSNlBbqdj69d+aHrztw1xhYLGLl3EodWzBOWNE6ZhUPoRF3Ju0shzSEEUP5OS6Ia6jyzZGBJ1Tih0j1Dm86Lk16zEjkEKmvLle7jLwWdzPorgXcsKKN3ghT5DTSxC4nuksKksAs6/o+rTXtmfPmu4bcjVK fU0DtQay wNlUQAcbZaITcFOx8bXGnmBE/bKF/bVjHqW1U0xEgyu/zSq/XyC0baTGROZ02l7sMNuVwETbncDP2Zx2A8oIlhtVGhKEiSDYCNrHICF3VIrS8dCjVFMrv7AYo8v93aZWXdyDCL1yZjJLXCFWsBB3dQttsvXS6J80JnVdZhB1fr9IBOhqJQF9U9ph633y/o3fQnodnWl1Poy3LK4pfD3SSYf0is87Udojhh+p39FBpxmZtFmj4bfKXaWcGQZKn2oB+rnhT69Kjj0WbmnHoUXDXBxS15gbQX+lfKBUl4VMJwGOu1Jj5wPY/YusRZ+H5nuUQmczZxg0Z208USKwnGlIfRi28Eq/vIojnshVY7g4M42M50845EvUnBlXsJA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 6 Apr 2023 at 09:40, Muhammad Usama Anjum wrote: [...] > --- a/fs/proc/task_mmu.c > +++ b/fs/proc/task_mmu.c [...] > +static int pagemap_scan_pmd_entry(pmd_t *pmd, unsigned long start, > + unsigned long end, struct mm_walk *walk= ) > +{ > + struct pagemap_scan_private *p =3D walk->private; > + bool is_written, is_file, is_present, is_swap; > + struct vm_area_struct *vma =3D walk->vma; > + unsigned long addr =3D end; > + spinlock_t *ptl; > + int ret =3D 0; > + pte_t *pte; > + > +#ifdef CONFIG_TRANSPARENT_HUGEPAGE > + ptl =3D pmd_trans_huge_lock(pmd, vma); > + if (ptl) { [...] > + return ret; > + } > +process_smaller_pages: > + if (pmd_trans_unstable(pmd)) > + return 0; Why pmd_trans_unstable() is needed here and not only after split_huge_pmd()= ? Best regards Micha=C5=82 Miros=C5=82aw