From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A25BC433F5 for ; Mon, 14 Mar 2022 16:18:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19C5F6B0072; Mon, 14 Mar 2022 12:18:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 124AB8D0002; Mon, 14 Mar 2022 12:18:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE0808D0001; Mon, 14 Mar 2022 12:18:22 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id D8A736B0072 for ; Mon, 14 Mar 2022 12:18:22 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A5E0462006 for ; Mon, 14 Mar 2022 16:18:22 +0000 (UTC) X-FDA: 79243499244.13.BC6A72F Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by imf22.hostedemail.com (Postfix) with ESMTP id 04978C0014 for ; Mon, 14 Mar 2022 16:18:21 +0000 (UTC) Received: by mail-ej1-f48.google.com with SMTP id kt27so35304255ejb.0 for ; Mon, 14 Mar 2022 09:18:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=geh31JjmgNWx5ruklOlb9OcIoz6waTuVoRaSRs47BzU=; b=Enq2pfXD4718fUK1qGIYNzfxh6gLp6gYvWlpoOX+opsFjk4MlAM5woUkcazkOTCoah CkuadOpxvrqyp9o+WuSg21I7x88nHviuCrwrDEbwCJ5jjC4/77X42nYCyZb2NjmeI4Wd Goaugm3+OtW7+zdBF9p8swNUc4SiOmEJWItPcH6RptjIIlvoO2yeAQUppyY7H1+StldH wlTHvsBwCk9Z7SUCGWry29PDB9LBhFoLYUKkCeC4/87SEwJzf1erdLyqJQIny7BsMekI ivaonQQOwnez1vOaIeaYHYbEeaMLVUwUc1bSEf8eaufczMIecqDPqzs4yZUWtenZlmgf ByQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=geh31JjmgNWx5ruklOlb9OcIoz6waTuVoRaSRs47BzU=; b=AThHL4jUHq1unCjSFZ0IGUAs/yALl0zVEkSBqPW47fd3aYHAkjOpU36P4qUH1QKqIM G4K1JSiKG3ZqXNPptYEmZtR7KRf+lLtRIiSMjke/10VS9yQy5qxdkN902lrIArhjTBb5 Gz3PlXIYTA5LIwULV/kBfS+oGsb2XCrCUmjn2n0fV90BMEFot/pIVdIXJjJoqOd/BQHt ay/mx+IH0ttaWxvtusYlZQT9NFEhzw4ajuakCsLiBAgF4iQoTjH3WlxAJCBhokwTPNi5 KW0pZfKubNjQXh4ZrDqyk9f0koFAeEEYk2I6TxfSTdHIqGxCiF3mYQ1N+26qHt5gZ20U wFBw== X-Gm-Message-State: AOAM533tSgTlEOzfurI7pT8z8ZL8FJL2jJms20KerYqoYhc89GRGNKdP wOBl+dm1YxGYsS0LlIbJ5gVt8uW60wBpwrek5d5ElQ== X-Google-Smtp-Source: ABdhPJyJXWUIWeE0eLsn9QkFhL/gxlpQinKhevG1+ViqzjPGziTURcXeGN4fpJf9R/seHpCB5DB/xt8SuiOV4BG2dF4= X-Received: by 2002:a17:906:2811:b0:6ce:eacf:5210 with SMTP id r17-20020a170906281100b006ceeacf5210mr19888730ejc.618.1647274700471; Mon, 14 Mar 2022 09:18:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Guenter Roeck Date: Mon, 14 Mar 2022 09:18:08 -0700 Message-ID: Subject: Re: [PATCH v2] selftests, x86: fix how check_cc.sh is being invoked To: kernelci@groups.io, Guillaume Tucker Cc: Shuah Khan , Andrew Morton , Borislav Petkov , Dave Hansen , Collabora Kernel ML , Linux MM , linux-kselftest@vger.kernel.org, linux-kernel Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 04978C0014 X-Stat-Signature: fcgbyfs14ygjn6rdmprudx1mmdnmoj1z X-Rspam-User: Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=Enq2pfXD; spf=pass (imf22.hostedemail.com: domain of groeck@google.com designates 209.85.218.48 as permitted sender) smtp.mailfrom=groeck@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1647274701-997744 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 11, 2022 at 2:05 AM Guillaume Tucker wrote: > > The $(CC) variable used in Makefiles could contain several arguments > such as "ccache gcc". These need to be passed as a single string to > check_cc.sh, otherwise only the first argument will be used as the > compiler command. Without quotes, the $(CC) variable is passed as > distinct arguments which causes the script to fail to build trivial > programs. > > Fix this by adding quotes around $(CC) when calling check_cc.sh to > pass the whole string as a single argument to the script even if it > has several words such as "ccache gcc". > > Fixes: e9886ace222e ("selftests, x86: Rework x86 target architecture detection") > Tested-by: "kernelci.org bot" > Signed-off-by: Guillaume Tucker Reviewed-by: Guenter Roeck > --- > > Notes: > v2: rebase and drop changes in check_cc.sh > > tools/testing/selftests/vm/Makefile | 6 +++--- > tools/testing/selftests/x86/Makefile | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/vm/Makefile b/tools/testing/selftests/vm/Makefile > index fbccdda93629..213f6a57d7f6 100644 > --- a/tools/testing/selftests/vm/Makefile > +++ b/tools/testing/selftests/vm/Makefile > @@ -54,9 +54,9 @@ TEST_GEN_FILES += split_huge_page_test > TEST_GEN_FILES += ksm_tests > > ifeq ($(MACHINE),x86_64) > -CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_32bit_program.c -m32) > -CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_64bit_program.c) > -CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh $(CC) ../x86/trivial_program.c -no-pie) > +CAN_BUILD_I386 := $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_32bit_program.c -m32) > +CAN_BUILD_X86_64 := $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_64bit_program.c) > +CAN_BUILD_WITH_NOPIE := $(shell ./../x86/check_cc.sh "$(CC)" ../x86/trivial_program.c -no-pie) > > override TARGETS := protection_keys > BINARIES_32 := $(TARGETS:%=%_32) > diff --git a/tools/testing/selftests/x86/Makefile b/tools/testing/selftests/x86/Makefile > index 8a1f62ab3c8e..53df7d3893d3 100644 > --- a/tools/testing/selftests/x86/Makefile > +++ b/tools/testing/selftests/x86/Makefile > @@ -6,9 +6,9 @@ include ../lib.mk > .PHONY: all all_32 all_64 warn_32bit_failure clean > > UNAME_M := $(shell uname -m) > -CAN_BUILD_I386 := $(shell ./check_cc.sh $(CC) trivial_32bit_program.c -m32) > -CAN_BUILD_X86_64 := $(shell ./check_cc.sh $(CC) trivial_64bit_program.c) > -CAN_BUILD_WITH_NOPIE := $(shell ./check_cc.sh $(CC) trivial_program.c -no-pie) > +CAN_BUILD_I386 := $(shell ./check_cc.sh "$(CC)" trivial_32bit_program.c -m32) > +CAN_BUILD_X86_64 := $(shell ./check_cc.sh "$(CC)" trivial_64bit_program.c) > +CAN_BUILD_WITH_NOPIE := $(shell ./check_cc.sh "$(CC)" trivial_program.c -no-pie) > > TARGETS_C_BOTHBITS := single_step_syscall sysret_ss_attrs syscall_nt test_mremap_vdso \ > check_initial_reg_state sigreturn iopl ioperm \ > -- > 2.30.2 > > > > ------------ > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#1448): https://groups.io/g/kernelci/message/1448 > Mute This Topic: https://groups.io/mt/89707412/955378 > Group Owner: kernelci+owner@groups.io > Unsubscribe: https://groups.io/g/kernelci/unsub [groeck@google.com] > ------------ > >