From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD784CA0FF6 for ; Sat, 2 Sep 2023 09:52:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F36BB8D0012; Sat, 2 Sep 2023 05:52:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE77B8D0002; Sat, 2 Sep 2023 05:52:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DD5F08D0012; Sat, 2 Sep 2023 05:52:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CC5AD8D0002 for ; Sat, 2 Sep 2023 05:52:09 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 7EB071C9496 for ; Sat, 2 Sep 2023 09:52:09 +0000 (UTC) X-FDA: 81191191578.06.C750806 Received: from mail-qv1-f50.google.com (mail-qv1-f50.google.com [209.85.219.50]) by imf04.hostedemail.com (Postfix) with ESMTP id BDCE740004 for ; Sat, 2 Sep 2023 09:52:07 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=BhADYi7f; spf=pass (imf04.hostedemail.com: domain of mikhail.v.gavrilov@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=mikhail.v.gavrilov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693648327; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GjdWtHgsDTB4R4Jq1soVJcM9QWTddW8JRmrExPBXbIU=; b=gWPeVEO90ndlg5DhEZIy7T4Dy2H/kdyiBufeQoupdGYbTvkcniczllYW6M6MSZ6R1KjYv5 3MwbHaYnDRKcRgrKKIbwYuTW7uES/rfiCo5yw6HIeOahEyjKoCQgRddl0Q35O7QTI2/N3Y Wyuo9yI2dfEe9HvamGuqYjUwkn8cGTM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693648327; a=rsa-sha256; cv=none; b=i1XsbZKqxq5L2YrgZ9UUwGjyPOG29P6wtKCIEGI8yxkHRxqiGSTR3y2J661x2Q3wShJd5h w12eggJF0+f2SAjaov1BlKWGd1uKXIUuujpathFgObh0YRqU+gulWQ+ttDZXP8qkcMyyP0 Dno4x1KjRWc/YntsbxJWxtLBRtXZicw= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20221208 header.b=BhADYi7f; spf=pass (imf04.hostedemail.com: domain of mikhail.v.gavrilov@gmail.com designates 209.85.219.50 as permitted sender) smtp.mailfrom=mikhail.v.gavrilov@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-qv1-f50.google.com with SMTP id 6a1803df08f44-6515d4bd335so2129016d6.0 for ; Sat, 02 Sep 2023 02:52:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693648327; x=1694253127; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GjdWtHgsDTB4R4Jq1soVJcM9QWTddW8JRmrExPBXbIU=; b=BhADYi7fkwJh9VbKjImbBImxacr8tmvJ5qTQquHSCDAXIZkTsnLstUSd8MamesaKq7 gXLcEltyuAekQko+kxIUrlt4md6bAsorSbu87/UFNWvyaXOqr6+8QhlB6oorJIbJZXoR JcqhIYqqtf4YXs/0aoqCwsG8HjWWzZGzrzVWc9Dgo6kDW5G/x5K80G48l6IPWE/DIMz4 jEWbLH+CW5pjntxdjN2w58SNkfKr+YVinyiHamwejyJDzZmJhbmn6XkgbqHPrdBISwd5 AmhnFt4BXpqzcTj1kul9G0OWR/628vNw5fnXH4x7WarH5Woxo6JHxSemrwUPX6kWsXEG GhXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693648327; x=1694253127; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GjdWtHgsDTB4R4Jq1soVJcM9QWTddW8JRmrExPBXbIU=; b=dx/KJ2dypg5pIuS31aTaXqrrG3nq9E87k7kKE7ZbqGER9/Cwd+j0MCa4kLKTq53KHh zLmicUFcH+OE5Zylc14m3PWELiTdASlk5u0OoCn5/PdY5gF93+54fvyM+qD/owt64Sz4 qq0TGfHUrQfyUYvD6xJgKhksngOFlJO/ntK7xTzOqi+OPwUT2zN6/ucSoA9itFZcIx38 BzasgFcXBlj/sJOPKDWAtwCAF06An+UP3SNxzpbTCHr6ZLZUIICsxT8q+xcAa2KqGNI/ OFyru4pGLwH1bl70D7k19G9zyOC+Lw4mRxWEtHoW3oAkkYmX5y+htTsStm63PM7XknQA 8cyQ== X-Gm-Message-State: AOJu0YwDAwbqQy4paA257Ds3WOZx3OVQmzhUvXHCPJxb7TezsVwmivEZ TSKp0mG3gI63AXPvom7iwBnSaNN09sWIrbAs8DE= X-Google-Smtp-Source: AGHT+IE3L2Pns1+lhVfe9SzdXHBx2qDiPbdxS5Iukb3V4eViqvyqRuX63PI3CMe4Qyd/74RfpRpqlmOCsBaldezjBWU= X-Received: by 2002:a05:6214:f2e:b0:63c:7427:e7e9 with SMTP id iw14-20020a0562140f2e00b0063c7427e7e9mr5628283qvb.6.1693648326776; Sat, 02 Sep 2023 02:52:06 -0700 (PDT) MIME-Version: 1.0 References: <3548ca67-ce58-3bc6-fef5-348b98d7678b@google.com> <98eb1ba4-5bd3-ee7-1a88-47b054dc938@google.com> <5e4d50d4-978-ce54-e1ae-40f7117dbf3d@google.com> In-Reply-To: <5e4d50d4-978-ce54-e1ae-40f7117dbf3d@google.com> From: Mikhail Gavrilov Date: Sat, 2 Sep 2023 14:51:55 +0500 Message-ID: Subject: Re: 6.6/regression/bisected - after commit a349d72fd9efc87c8fd1d16d3164752d84a7275b system stopped booting To: Hugh Dickins Cc: Andrew Morton , Bagas Sanjaya , linux-kernel@vger.kernel.org, linux-mm@kvack.org, regressions@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Stat-Signature: ri6gt7oamcuzcb6cru7oee1jujqyccr6 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: BDCE740004 X-Rspam-User: X-HE-Tag: 1693648327-666889 X-HE-Meta: U2FsdGVkX19uIV7JFrujJysZ4yUszFtwMXXMTHy5PTZKCVB6Ig1WkRAvjh1+ARiH3KYJbwIdV/63DjTP32TKLcrAClYM4R96PzrnqWkYUaOGCvApoPKSZTpLlt7uO1W7YzpGXGRxe2nBX9T7hgVh19b6RH635i9zTRgfISdJsn0W7kxCBJdjHnJ7nZwyfXCGD713oUAIVobCb7iZsghxnhof0y60kHFkHrkmi0yE7Sz55yrSrKEDQUwywPbobiIv4JKnVUlwC4lmC6Zqk6TjJrtjWKeBUz62NLvFl3PmG1L3VITz8iZOCFvpJiBaeHT2A3HTE6/9x1QesVyf9ffGCEDY239Trq40P9h97m5IHelR97EnyGpas74viQ2HtTuSZG/e4TIIySgGf0/vTYC0IkPhVz7DA0rZLknbHBJVizZHexUcFR3unAreNhFXO63xThtzBbAk1+emCeaRu75eAIg7byqUmpyBOBFeRYM4T4X0qJXUUxBwK+JejTXZSrZ9iLJGd96YcTCCGNEpu1c3baRSqIXBQdbSghwGnWuBM6rkD49zdlbJenw97EXunGXQEsBMK83pppZp/PVQGX/QZdEPWSuAkWkW4X9ZVPzmNVj1qdZve08pnwtnXmxQd2jHorQUjvcLNdDHhEZHcluddLlNTPbNdFAPAHHg3zkZzFYkQVjwwoq81ankJprGSsvkZKOIqJUOmNWFw3dd5rnAI9xsKLN4uMG7b/Jt7mc/oWNMTqVbGk3UsAwuib+jxbUdKebbCXdriXTzYW95ZIvf0bF2E0dMbBHO/Bem9VfpyhrCDhs11xs5tLsKdJO/OxOUZihrAYO8oJWjbXqC9gsRCpDKb4mmttgAH3zaCnKT5jiSUbboZX8AUU1s/drcTQxwknPLACkXUVO0XtKUGpD4+mL1W22W28iSNWUqljEUt818jdb+ivXaJOArhFOwVAoc6HXJbAH1iZwroYXI7MF y4tOyE94 fKbq7IBupkU3oYbcdVgj4Bdmhc9CgUPSk2g0FH9tFoNXeAfzbdVfFTyYlS9B1+CcY5JNZ2heIf2ISmuiKmqVjFdDhR8oFzIuum66CrzbKVnl45QLxz7XU5gUgo2hKPmRvGTk2Z7vUtlYUI7zSuaNk0hx892OfUSoNmZou+CvSFMg6FzcBBIRyKlqHiwWh2tJEOP5fGVsTJMSqaeTrfC2rllgaWQ4aUBK+IbUzL7xNIy1tKpekTKoUfH+88Lqg2mqo5b5AxT3bQQ48+tdSPBZ260/y+mty51Mx05Y5v2NTwf8V2dnC61gkUC4JyT1NLN2FB+dweUwOQn91eKxV1XfE6709l0T8r6v5Z/3QLXqe4ZUci4JmE96wAGniZIlyrLgs2UV1dbORpx7M9dGqBn0GNOMa5M6cMraNMJgEdZdARUP/cuE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sat, Sep 2, 2023 at 3:48=E2=80=AFAM Hugh Dickins wrot= e: > That was very disappointing: I found it hard to explain, but was thinking > of sending you a similar patch, doing the same check on all your 32 CPUs = - > maybe the stall being on CPU 0 in your photo was accidental. > > But now I think I have the shameful answer (which studying your dmesg, > and the 82328 jiffies at 86 seconds in your photo, did help me towards). > > That mm/pagewalk fix I put into 6.5 has a grievous oversight (and a > video of your failing 6.6 bootup would likely have shown a WARN_ON_ONCE > from the underflow in __rcu_read_unlock()). > > Please revert the debug patch I sent yesterday (or earlier today), please > try booting with this one on top of a349d72fd9ef; and if that's successfu= l, > then please go back to your original Rawhide tree and apply this on top o= f > that, to confirm that boots to a working system too - thanks. > > With my apologies, > > [PATCH] mm/pagewalk: fix bootstopping regression from extra pte_unmap() > > [ Commit message yet to be written: it's actually something to go to > 6.5 stable, to correct i386 CONFIG_HIGHPTE there - though we know of > no case where it is actually hit. ] > > Signed-off-by: Hugh Dickins > --- > mm/pagewalk.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/pagewalk.c b/mm/pagewalk.c > index 2022333805d3..9e7d0276c38a 100644 > --- a/mm/pagewalk.c > +++ b/mm/pagewalk.c > @@ -58,7 +58,7 @@ static int walk_pte_range(pmd_t *pmd, unsigned long add= r, unsigned long end, > pte =3D pte_offset_map(pmd, addr); > if (pte) { > err =3D walk_pte_range_inner(pte, addr, end, walk= ); > - if (walk->mm !=3D &init_mm) > + if (walk->mm !=3D &init_mm && addr < TASK_SIZE) > pte_unmap(pte); > } > } else { > -- > 2.35.3 Great, this is the right patch. Both build a349d72fd9ef and latest in Rawhide (now it is 99d99825fc07) works fine after applying this patch. So thank you a lot. Tested-by: Mikhail Gavrilov --=20 Best Regards, Mike Gavrilov.