linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
To: Daniel Jordan <daniel.m.jordan@oracle.com>
Cc: linux-mm@kvack.org, mgorman@techsingularity.net, cai@lca.pw,
	 vbabka@suse.cz
Subject: Re: kernel BUG at include/linux/mm.h:1020!
Date: Thu, 21 Mar 2019 02:50:25 +0500	[thread overview]
Message-ID: <CABXGCsMcXb_W-w0AA4ZFJ5aKNvSMwFn8oAMaFV7AMHgsH_UB7g@mail.gmail.com> (raw)
In-Reply-To: <20190315205826.fgbelqkyuuayevun@ca-dmjordan1.us.oracle.com>

On Sat, 16 Mar 2019 at 01:59, Daniel Jordan <daniel.m.jordan@oracle.com> wrote:
>
> This is new code, from e332f741a8dd1 ("mm, compaction: be selective about what
> pageblocks to clear skip hints"), so I added some folks.
>
> Can you show
> $LINUX/scripts/faddr2line path/to/vmlinux __reset_isolation_pfn+0x244
> ?

$ /usr/src/kernels/`uname -r`/scripts/faddr2line
/lib/debug/lib/modules/`uname -r`/vmlinux __reset_isolation_pfn+0x244
__reset_isolation_pfn+0x244/0x2b0:
page_to_nid at include/linux/mm.h:1021
(inlined by) page_zone at include/linux/mm.h:1163
(inlined by) __reset_isolation_pfn at mm/compaction.c:250

It was not easy, but I completed just now kernel bisecting and see
that you right.
First bad commit is e332f741a8dd1

$ git bisect log
git bisect start
# good: [cd2a3bf02625ffad02a6b9f7df758ee36cf12769] Merge tag
'leds-for-5.1-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/j.anaszewski/linux-leds
git bisect good cd2a3bf02625ffad02a6b9f7df758ee36cf12769
# bad: [610cd4eadec4f97acd25d3108b0e50d1362b3319] Merge branch
'x86-uv-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad 610cd4eadec4f97acd25d3108b0e50d1362b3319
# good: [203b6609e0ede49eb0b97008b1150c69e9d2ffd3] Merge branch
'perf-core-for-linus' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect good 203b6609e0ede49eb0b97008b1150c69e9d2ffd3
# bad: [da2577fe63f865cd9dc785a42c29c0071f567a35] Merge tag
'sound-5.1-rc1' of
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
git bisect bad da2577fe63f865cd9dc785a42c29c0071f567a35
# good: [fb686ad25be0343a9dab23acff674d0cb84bb516] Merge tag
'armsoc-defconfig' of
git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
git bisect good fb686ad25be0343a9dab23acff674d0cb84bb516
# good: [70395a96bd882d8dba669f99b5cec0008690accd] Merge tag
'asoc-v5.1-2' of
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound into
for-next
git bisect good 70395a96bd882d8dba669f99b5cec0008690accd
# bad: [8dcd175bc3d50b78413c56d5b17d4bddd77412ef] Merge branch 'akpm'
(patches from Andrew)
git bisect bad 8dcd175bc3d50b78413c56d5b17d4bddd77412ef
# bad: [7f18825174203526a47c127c12a50f897ee0b511] powerpc/mm/iommu:
allow large IOMMU page size only for hugetlb backing
git bisect bad 7f18825174203526a47c127c12a50f897ee0b511
# good: [566e54e113eb2b669f9300db2c2df400cbb06646] mm, compaction:
remove last_migrated_pfn from compact_control
git bisect good 566e54e113eb2b669f9300db2c2df400cbb06646
# bad: [d9f7979c92f7b34469c1ca5d1f3add6681fd567c] mm: no need to check
return value of debugfs_create functions
git bisect bad d9f7979c92f7b34469c1ca5d1f3add6681fd567c
# good: [cb810ad294d3c3a454e51b12fbb483bbb7096b98] mm, compaction:
rework compact_should_abort as compact_check_resched
git bisect good cb810ad294d3c3a454e51b12fbb483bbb7096b98
# bad: [147e1a97c4a0bdd43f55a582a9416bb9092563a9] fs: kernfs: add poll
file operation
git bisect bad 147e1a97c4a0bdd43f55a582a9416bb9092563a9
# good: [dbe2d4e4f12e07c6a2215e3603a5f77056323081] mm, compaction:
round-robin the order while searching the free lists for a target
git bisect good dbe2d4e4f12e07c6a2215e3603a5f77056323081
# bad: [e332f741a8dd1ec9a6dc8aa997296ecbfe64323e] mm, compaction: be
selective about what pageblocks to clear skip hints
git bisect bad e332f741a8dd1ec9a6dc8aa997296ecbfe64323e
# good: [4fca9730c51d51f643f2a3f8f10ebd718349c80f] mm, compaction:
sample pageblocks for free pages
git bisect good 4fca9730c51d51f643f2a3f8f10ebd718349c80f
# first bad commit: [e332f741a8dd1ec9a6dc8aa997296ecbfe64323e] mm,
compaction: be selective about what pageblocks to clear skip hints

Also I see that two patches already proposed for fixing this issue.
[1] https://patchwork.kernel.org/patch/10862267/
[2] https://patchwork.kernel.org/patch/10862519/

If I understand correctly, it is enough to apply only the second patch [2].



--
Best Regards,
Mike Gavrilov.


  parent reply	other threads:[~2019-03-20 21:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 17:55 Mikhail Gavrilov
2019-03-15 20:58 ` Daniel Jordan
2019-03-15 21:34   ` Qian Cai
2019-03-17 15:22   ` Mel Gorman
2019-03-19 19:14     ` Qian Cai
2019-03-19 19:27       ` Pavel Tatashin
2019-03-19 19:35         ` Qian Cai
2019-03-19 23:13           ` Pavel Tatashin
2019-03-19 23:26             ` Qian Cai
2019-03-20 14:20       ` Mel Gorman
2019-03-20 21:50   ` Mikhail Gavrilov [this message]
2019-03-21  5:39     ` Mikhail Gavrilov
2019-03-21 13:21       ` Qian Cai
2019-03-21 15:08         ` Mikhail Gavrilov
2019-03-21 15:48           ` Qian Cai
2019-03-21 18:57             ` Mikhail Gavrilov
2019-03-21 19:14               ` Qian Cai
2019-03-22  3:41                 ` Mikhail Gavrilov
2019-03-22 13:43                   ` Qian Cai
2019-03-22 11:15       ` Mel Gorman
2019-03-23  4:40         ` Mikhail Gavrilov
2019-03-25 10:58           ` Mel Gorman
2019-03-25 16:06             ` Mikhail Gavrilov
2019-03-25 20:31               ` Mel Gorman
2019-03-26  4:03                 ` Mikhail Gavrilov
2019-03-26 12:03                   ` Mel Gorman
2019-03-27  3:57                     ` Mikhail Gavrilov
2019-03-27  8:54                       ` Mel Gorman
2019-03-22  7:39 ` Oscar Salvador
2019-03-22  7:54   ` Mikhail Gavrilov
2019-03-22  8:55     ` Oscar Salvador
2019-03-22  8:56       ` Oscar Salvador
2019-03-22 17:49         ` Mikhail Gavrilov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABXGCsMcXb_W-w0AA4ZFJ5aKNvSMwFn8oAMaFV7AMHgsH_UB7g@mail.gmail.com \
    --to=mikhail.v.gavrilov@gmail.com \
    --cc=cai@lca.pw \
    --cc=daniel.m.jordan@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox