linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mikhail Gavrilov <mikhail.v.gavrilov@gmail.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Daniel Jordan <daniel.m.jordan@oracle.com>, Qian Cai <cai@lca.pw>,
	linux-mm@kvack.org,  vbabka@suse.cz
Subject: Re: kernel BUG at include/linux/mm.h:1020!
Date: Sat, 23 Mar 2019 09:40:04 +0500	[thread overview]
Message-ID: <CABXGCsMG+oCTxiEv1vmiK0P+fvr7ZiuOsbX-GCE13gapcRi5-Q@mail.gmail.com> (raw)
In-Reply-To: <20190322111527.GG3189@techsingularity.net>

On Fri, 22 Mar 2019 at 16:15, Mel Gorman <mgorman@techsingularity.net> wrote:
>
> Build-tested only but can you try this?
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index f171a83707ce..ba3afcc00d50 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -242,6 +242,7 @@ __reset_isolation_pfn(struct zone *zone, unsigned long pfn, bool check_source,
>                                                         bool check_target)
>  {
>         struct page *page = pfn_to_online_page(pfn);
> +       struct page *block_page;
>         struct page *end_page;
>         unsigned long block_pfn;
>
> @@ -267,20 +268,26 @@ __reset_isolation_pfn(struct zone *zone, unsigned long pfn, bool check_source,
>             get_pageblock_migratetype(page) != MIGRATE_MOVABLE)
>                 return false;
>
> +       /* Ensure the start of the pageblock or zone is online and valid */
> +       block_pfn = pageblock_start_pfn(pfn);
> +       block_page = pfn_to_online_page(max(block_pfn, zone->zone_start_pfn));
> +       if (block_page) {
> +               page = block_page;
> +               pfn = block_pfn;
> +       }
> +
> +       /* Ensure the end of the pageblock or zone is online and valid */
> +       block_pfn += pageblock_nr_pages;
> +       block_pfn = min(block_pfn, zone_end_pfn(zone));
> +       end_page = pfn_to_online_page(block_pfn);
> +       if (!end_page)
> +               return false;
> +
>         /*
>          * Only clear the hint if a sample indicates there is either a
>          * free page or an LRU page in the block. One or other condition
>          * is necessary for the block to be a migration source/target.
>          */
> -       block_pfn = pageblock_start_pfn(pfn);
> -       pfn = max(block_pfn, zone->zone_start_pfn);
> -       page = pfn_to_page(pfn);
> -       if (zone != page_zone(page))
> -               return false;
> -       pfn = block_pfn + pageblock_nr_pages;
> -       pfn = min(pfn, zone_end_pfn(zone));
> -       end_page = pfn_to_page(pfn);
> -
>         do {
>                 if (pfn_valid_within(pfn)) {
>                         if (check_source && PageLRU(page)) {

Unfortunately this patch didn't helps too.

kernel log: https://pastebin.com/RHhmXPM2

--
Best Regards,
Mike Gavrilov.


  reply	other threads:[~2019-03-23  4:40 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 17:55 Mikhail Gavrilov
2019-03-15 20:58 ` Daniel Jordan
2019-03-15 21:34   ` Qian Cai
2019-03-17 15:22   ` Mel Gorman
2019-03-19 19:14     ` Qian Cai
2019-03-19 19:27       ` Pavel Tatashin
2019-03-19 19:35         ` Qian Cai
2019-03-19 23:13           ` Pavel Tatashin
2019-03-19 23:26             ` Qian Cai
2019-03-20 14:20       ` Mel Gorman
2019-03-20 21:50   ` Mikhail Gavrilov
2019-03-21  5:39     ` Mikhail Gavrilov
2019-03-21 13:21       ` Qian Cai
2019-03-21 15:08         ` Mikhail Gavrilov
2019-03-21 15:48           ` Qian Cai
2019-03-21 18:57             ` Mikhail Gavrilov
2019-03-21 19:14               ` Qian Cai
2019-03-22  3:41                 ` Mikhail Gavrilov
2019-03-22 13:43                   ` Qian Cai
2019-03-22 11:15       ` Mel Gorman
2019-03-23  4:40         ` Mikhail Gavrilov [this message]
2019-03-25 10:58           ` Mel Gorman
2019-03-25 16:06             ` Mikhail Gavrilov
2019-03-25 20:31               ` Mel Gorman
2019-03-26  4:03                 ` Mikhail Gavrilov
2019-03-26 12:03                   ` Mel Gorman
2019-03-27  3:57                     ` Mikhail Gavrilov
2019-03-27  8:54                       ` Mel Gorman
2019-03-22  7:39 ` Oscar Salvador
2019-03-22  7:54   ` Mikhail Gavrilov
2019-03-22  8:55     ` Oscar Salvador
2019-03-22  8:56       ` Oscar Salvador
2019-03-22 17:49         ` Mikhail Gavrilov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABXGCsMG+oCTxiEv1vmiK0P+fvr7ZiuOsbX-GCE13gapcRi5-Q@mail.gmail.com \
    --to=mikhail.v.gavrilov@gmail.com \
    --cc=cai@lca.pw \
    --cc=daniel.m.jordan@oracle.com \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=vbabka@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox