From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38200C4332F for ; Tue, 22 Nov 2022 19:05:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 966ED6B0071; Tue, 22 Nov 2022 14:05:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 916F46B0073; Tue, 22 Nov 2022 14:05:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 806146B0074; Tue, 22 Nov 2022 14:05:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 71A306B0071 for ; Tue, 22 Nov 2022 14:05:58 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 2A675120726 for ; Tue, 22 Nov 2022 19:05:58 +0000 (UTC) X-FDA: 80162007996.18.3336450 Received: from mail-yb1-f181.google.com (mail-yb1-f181.google.com [209.85.219.181]) by imf06.hostedemail.com (Postfix) with ESMTP id C6537180004 for ; Tue, 22 Nov 2022 19:05:57 +0000 (UTC) Received: by mail-yb1-f181.google.com with SMTP id b131so18402153yba.11 for ; Tue, 22 Nov 2022 11:05:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=UH8CULqws8EURCcGLdD3MqO4szk6ZDfTwbWJ1BRasAg=; b=aHU/4rTLIP2Roaj3oaDqTP6BsSgt/v+o233yVnztvkFamUnTqO8lqNGVxX/atHUwpT 0pwGoQ2WKh6tm6+rl6WR91tXJ/1tcpEPv3HIXZCPN6kJbNQzq6rIT91BX3dv+tQCuXjy BMucSc5zV6VYfU/4Qe5UZ0aJpEz7PT7LlfCmc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=UH8CULqws8EURCcGLdD3MqO4szk6ZDfTwbWJ1BRasAg=; b=ETWFHqsj2WfPF4jqHayXWhWFaqVcGn3jM8AEFgQPiBEfo9xLx3U6UsV66BEp67pIbl 2dLjq09/spCRdvoXoWBbA4imU0y0olqcJN8uGz0KCUb+c5HmUHOPWRlWxN00KGW+bGYj 3ZQp83Nmp0C1FL8e65VE6rtICOv/AaiiXQNVdorjegQz15u9O3PQItK8s6WNAcOfN8Yp dol8aaKWtYbf9+oPuMWMfRtV4BFhsxnD9DNRhqT8LustN0tb5fDLDE0xoZ+hGO9iPpup qVK1U+vu1VfaHJYDeNVeH8cZMLOYDWG5DF/RQNqJN4qK6HdFKeXkW5QnkDR7pp1F0gzH dWlA== X-Gm-Message-State: ANoB5pmwLG7uGeFTAkAoy8pg/ktecNpDCbu/DO6KehQ7JEQzSoxtggM4 Jvbr6ICnFTJh14B723+AbNooEvgXu8HeOtYnVaNR7A== X-Google-Smtp-Source: AA0mqf7/yUBMx4gWYxYMHUbZsapsTGO89vB5gRJDkAiIq8XymkZLdq2rSWqnQyXHdKsRkb9Mz4W6p0JLVWhoWo9hIQk= X-Received: by 2002:a25:1a57:0:b0:6ca:468d:18fe with SMTP id a84-20020a251a57000000b006ca468d18femr5482863yba.224.1669143956921; Tue, 22 Nov 2022 11:05:56 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Ivan Babrou Date: Tue, 22 Nov 2022 11:05:46 -0800 Message-ID: Subject: Re: Low TCP throughput due to vmpressure with swap enabled To: Yu Zhao Cc: Linux MM , Linux Kernel Network Developers , linux-kernel , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Andrew Morton , Eric Dumazet , "David S. Miller" , Hideaki YOSHIFUJI , David Ahern , Jakub Kicinski , Paolo Abeni , cgroups@vger.kernel.org, kernel-team Content-Type: text/plain; charset="UTF-8" ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=cloudflare.com header.s=google header.b="aHU/4rTL"; spf=pass (imf06.hostedemail.com: domain of ivan@cloudflare.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=ivan@cloudflare.com; dmarc=pass (policy=reject) header.from=cloudflare.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1669143957; a=rsa-sha256; cv=none; b=EteTdLZi71MO7zscYcrw4xgaDK7iJ/wboodKuUnsaHfp4VcL0awkXrCBuygU7UB594gz4Y qxh/Or4AIUZSKul1GvibzYoBBcDSxn7/qolKNGDRK0pfh/t2D+MQTqsGcfg78cwP8KQ1D4 GqZcjjBV2D0tp0ymgsgjtYxJioYNMo8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1669143957; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UH8CULqws8EURCcGLdD3MqO4szk6ZDfTwbWJ1BRasAg=; b=i85ArINLqvV1QfDwQ+U84pmoFAfeyU251r+rQo0Wfao08vzylNNMnH0Qjw/bk9JaPJle3w ENBLX45mEgG5yrHysQ278Zu14eqPZgU+5aSvOXa95QYNo+t8JY+Lnm7rU8eXnKGB6TT9BT 2tQx+ldwMyMH2VxDuQTSqUnaKen+JhY= X-Stat-Signature: duofts9rooz9baahnzj5nwsrwtaax8tf X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: C6537180004 Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=cloudflare.com header.s=google header.b="aHU/4rTL"; spf=pass (imf06.hostedemail.com: domain of ivan@cloudflare.com designates 209.85.219.181 as permitted sender) smtp.mailfrom=ivan@cloudflare.com; dmarc=pass (policy=reject) header.from=cloudflare.com X-Rspam-User: X-HE-Tag: 1669143957-213002 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Nov 22, 2022 at 10:59 AM Yu Zhao wrote: > > On Mon, Nov 21, 2022 at 5:53 PM Ivan Babrou wrote: > > > > Hello, > > > > We have observed a negative TCP throughput behavior from the following commit: > > > > * 8e8ae645249b mm: memcontrol: hook up vmpressure to socket pressure > > > > It landed back in 2016 in v4.5, so it's not exactly a new issue. > > > > The crux of the issue is that in some cases with swap present the > > workload can be unfairly throttled in terms of TCP throughput. > > > > I am able to reproduce this issue in a VM locally on v6.1-rc6 with 8 > > GiB of RAM with zram enabled. > > Hi Ivan, > > If it's not too much trouble, could you try again with the following? > CONFIG_LRU_GEN=y > CONFIG_LRU_GEN_ENABLED=y > > I haven't tried it myself. But I'll fix whatever doesn't work for you, > since your team is on the top of my customer list :) We don't have it in production, since there we have 5.15 LTS (our kernel team is testing v6.1). I do have it enabled in my VM running v6.1-rc6 where I was able to replicate this, so it doesn't seem to help.