From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F5BFC433EF for ; Fri, 18 Mar 2022 16:30:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A88228D0002; Fri, 18 Mar 2022 12:30:21 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A37328D0001; Fri, 18 Mar 2022 12:30:21 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8FD8A8D0002; Fri, 18 Mar 2022 12:30:21 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0251.hostedemail.com [216.40.44.251]) by kanga.kvack.org (Postfix) with ESMTP id 823208D0001 for ; Fri, 18 Mar 2022 12:30:21 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 3F3B91827C16E for ; Fri, 18 Mar 2022 16:30:21 +0000 (UTC) X-FDA: 79258044642.30.70BBE31 Received: from mail-yw1-f176.google.com (mail-yw1-f176.google.com [209.85.128.176]) by imf19.hostedemail.com (Postfix) with ESMTP id B145A1A002A for ; Fri, 18 Mar 2022 16:30:20 +0000 (UTC) Received: by mail-yw1-f176.google.com with SMTP id 00721157ae682-2e592e700acso96530627b3.5 for ; Fri, 18 Mar 2022 09:30:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kAE3uuJYaI6bZvK1JirdmvyIyu+ZeP4A7IF2vH7oYhI=; b=mOYCnnUxwb1osdLgXKMQa4A9q4QPWM9rhR+WhIZaDXV9nNkbEQeKnyjoT4a99+aSuN eF3SZaDvHbMGMLFbwS5OYwy0MsweHwpZZw5JzmfyW7ivcIWJ6uf0ZgB9B0CW5MC6OAdp W0TeQxoZCujax5Mn72w3oTLaCYhWpd3zCAEZ0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kAE3uuJYaI6bZvK1JirdmvyIyu+ZeP4A7IF2vH7oYhI=; b=m7/N28D1iGkH6RcBbRH8oXAwrXPVpAz4kcECZRlqjcY2wJ0D+3pJcdhs4wmZFtoLEr kPCrBQoeD46Zcga9Izr67r6aYP7xNql+YTia8vwaGGsaEwKNDIvOD78FQypLk9kwMKcp cvdIlWGGFi+00irwuh/896t9Fkd5qujYhPCZ/4frUzlp7SkXjl8cNy0yXQ0rw/xW3EBX 4Tz24VsE1HS2z4umjDiON7goNKGB9T4ip8+60h2CFFwIz96F9/J17W+PdYi2EHWzlCkU 2RfqDWjk/+PvYSPlahRkUtSZlD7R5tzyfLVQ+I+3kfO0UuWAU1DvCqbURapnMq/W0lhm gvjQ== X-Gm-Message-State: AOAM530LWORNTo8bOGu1na+E7n/iHTm7tR+vr8IMhfqCBXbcjbNFuj8P jU2AnH1QfyiG9CZWfJMwMOn1ARkMwCCA94IM8GhNyQ== X-Google-Smtp-Source: ABdhPJzl1HaVxL6M7wATA0aA7ue2teOSdQFdYnb3ZCTBjjtSXetDYzZ2exTvmluualwMq/4vLF3w3ZbC725ewFt67Vo= X-Received: by 2002:a81:a842:0:b0:2db:562a:3f13 with SMTP id f63-20020a81a842000000b002db562a3f13mr11684645ywh.322.1647621020015; Fri, 18 Mar 2022 09:30:20 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ivan Babrou Date: Fri, 18 Mar 2022 09:30:09 -0700 Message-ID: Subject: Re: zram corruption due to uninitialized do_swap_page fault To: Minchan Kim Cc: Linux MM , linux-kernel , Andrew Morton , Nitin Gupta , Sergey Senozhatsky , Jens Axboe , linux-block@vger.kernel.org, kernel-team Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Queue-Id: B145A1A002A X-Stat-Signature: 8ifjanohkzxjpsqx5hntchkou57iqji9 Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cloudflare.com header.s=google header.b=mOYCnnUx; dmarc=pass (policy=reject) header.from=cloudflare.com; spf=none (imf19.hostedemail.com: domain of ivan@cloudflare.com has no SPF policy when checking 209.85.128.176) smtp.mailfrom=ivan@cloudflare.com X-Rspamd-Server: rspam03 X-HE-Tag: 1647621020-132451 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Mar 16, 2022 at 11:26 AM Ivan Babrou wrote: > I'm making an internal build and will push it to some location to see > how it behaves, but it might take a few days to get any sort of > confidence in the results (unless it breaks immediately). > > I've also pushed my patch that disables SWP_SYNCHRONOUS_IO to a few > locations yesterday to see how it fares. I have some updates before the weekend. There are two experimental groups: * My patch that removes the SWP_SYNCHRONOUS_IO flag. There are 704 machines in this group across 5 datacenters with cumulative uptime of 916 days. * Minchan's patch to remove swap_slot_free_notify. There are 376 machines in this group across 3 datacenters with cumulative uptime of 240 days. Our machines take a couple of hours to start swapping anything after boot, and I discounted these two hours from the cumulative uptime. Neither of these two groups experienced unexpected coredumps or rocksdb corruptions. I think at this point it's reasonable to proceed with Minchan's patch (including a backport).