From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD14FC433F5 for ; Tue, 15 Mar 2022 04:54:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 217CF8D0002; Tue, 15 Mar 2022 00:54:19 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C7788D0001; Tue, 15 Mar 2022 00:54:19 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B5DB8D0002; Tue, 15 Mar 2022 00:54:19 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0118.hostedemail.com [216.40.44.118]) by kanga.kvack.org (Postfix) with ESMTP id EFD8A8D0001 for ; Tue, 15 Mar 2022 00:54:18 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A3098A15EF for ; Tue, 15 Mar 2022 04:54:18 +0000 (UTC) X-FDA: 79245404196.29.C725C3B Received: from mail-yw1-f175.google.com (mail-yw1-f175.google.com [209.85.128.175]) by imf19.hostedemail.com (Postfix) with ESMTP id 0C2761A0009 for ; Tue, 15 Mar 2022 04:54:17 +0000 (UTC) Received: by mail-yw1-f175.google.com with SMTP id 00721157ae682-2dc242a79beso188238367b3.8 for ; Mon, 14 Mar 2022 21:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kXJSsqX5oGMRLxCD3m0yp+eu9UGao+wbB29wVMzrfDc=; b=EA6b8UuoTWXdRSlRV5mh8W1fHVA4d42jxkR8q1H9pK86FIFRXOeITtTRgQKWy4ZO/b BwkQBRbpqjpc+7u6hJUWkF+cIa+5Qdz3J45ZD0aqtcnz1NBbdVmraFAoSSygX9ZRgfTA cS0LHPehSfXi+Gin/xJJeX+mnxPkeQHs5q8Gs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kXJSsqX5oGMRLxCD3m0yp+eu9UGao+wbB29wVMzrfDc=; b=KePvLlDLNbbZJVFBg+r49PeUcoXQtuGDEAxhO8LOdjCxwC50J/Ts4ZKVETgwV8JD3j d+qXd0aOQlDTyZgBx0ghYPky85MVPs+zXFNegpHuP5m0wb3dazwOTsGRi7UxXdmkMmrr 9sQhoDEf4NElPq3/ssY/SVpNWHwZdtlHjnkOOHS2+0aKficm1tfT3I8GCN+RzblHnkcm NEc0+gBKBSCCTpekFtpJj6e4rSqlRW7UGMu7eWwhdKXM4CQU30s/fIpOhULuTuOX8pxt Zyyt5l0oiWn6MhBrcn4ghZxdcsN2AT6SVzsWjg9p6LsuwiDAwgtzKpbr5ZMCcXSjQ3YF y2xw== X-Gm-Message-State: AOAM5319MBAfrS4gDFArinvTAw0POoQ8SDlcAomhF7nxKqLWDB79yCUZ iNcc8MFTC/TyR4KjuwH+eHN5SxnndNzk7fyfHIh9yikrfpviIA== X-Google-Smtp-Source: ABdhPJz2SgRn+t7pTNQk1P53uQ6Gw/tiRpztmikitCBJr10puSNwrdsCdzGbvIo6hORFxP0civv3NJ7ivrsybtlxJ70= X-Received: by 2002:a81:1404:0:b0:2dc:c5:c540 with SMTP id 4-20020a811404000000b002dc00c5c540mr21532780ywu.379.1647320057450; Mon, 14 Mar 2022 21:54:17 -0700 (PDT) MIME-Version: 1.0 References: <20220315043422.1846-1-hdanton@sina.com> In-Reply-To: <20220315043422.1846-1-hdanton@sina.com> From: Ivan Babrou Date: Mon, 14 Mar 2022 21:54:06 -0700 Message-ID: Subject: Re: zram corruption due to uninitialized do_swap_page fault To: Hillf Danton Cc: Minchan Kim , Linux MM , linux-kernel Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0C2761A0009 X-Stat-Signature: 475x3k1oaxb8imhh1e5mdgjwj7ibd8gs X-Rspam-User: Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=cloudflare.com header.s=google header.b=EA6b8Uuo; dmarc=pass (policy=reject) header.from=cloudflare.com; spf=none (imf19.hostedemail.com: domain of ivan@cloudflare.com has no SPF policy when checking 209.85.128.175) smtp.mailfrom=ivan@cloudflare.com X-Rspamd-Server: rspam02 X-HE-Tag: 1647320057-527129 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000011, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 14, 2022 at 9:34 PM Hillf Danton wrote: > Can you test if the race comes from the diff below wrt zram_free_page? > > Hillf > > --- upstream/mm/page_io.c > +++ b/mm/page_io.c > @@ -392,11 +392,6 @@ int swap_readpage(struct page *page, boo > if (sis->flags & SWP_SYNCHRONOUS_IO) { > ret = bdev_read_page(sis->bdev, swap_page_sector(page), page); > if (!ret) { > - if (trylock_page(page)) { > - swap_slot_free_notify(page); > - unlock_page(page); > - } > - > count_vm_event(PSWPIN); > goto out; > } I tried it without the previous patch (the one commenting out swap_slot_free_notify in end_swap_bio_read) and it still fails.