From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55298C433F5 for ; Fri, 25 Mar 2022 02:10:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B87B26B0071; Thu, 24 Mar 2022 22:10:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B0FD76B0073; Thu, 24 Mar 2022 22:10:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 963686B0074; Thu, 24 Mar 2022 22:10:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0173.hostedemail.com [216.40.44.173]) by kanga.kvack.org (Postfix) with ESMTP id 7F3516B0071 for ; Thu, 24 Mar 2022 22:10:26 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 2E3198249980 for ; Fri, 25 Mar 2022 02:10:26 +0000 (UTC) X-FDA: 79281279252.19.FDD5F78 Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) by imf25.hostedemail.com (Postfix) with ESMTP id B0F0FA0035 for ; Fri, 25 Mar 2022 02:10:25 +0000 (UTC) Received: by mail-yb1-f171.google.com with SMTP id t11so11687505ybi.6 for ; Thu, 24 Mar 2022 19:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloudflare.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=IKwNBEs3tASJWL7vN74tIrUm9dV+sBlNlNaJ5KwKgTs=; b=cbc3BGe5+zL07UFEV9pbFjATQyTFfHkL8NRVARYGOxWmh0lxE1dNlskSSeW2JkMs2k sFZgeI9XI06R2An17rGJRCrVBd+4KlMmefFE0nM82JlLERTRrgyL+1O3jRbO/hSqr9ZS Pvf+cXGQaP182cb0VU8dTVUGy9z7Ic0Nmx+vQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IKwNBEs3tASJWL7vN74tIrUm9dV+sBlNlNaJ5KwKgTs=; b=3InVUJxiWXhA9vIsCUw53P656JUBFXIbv7LyoTFh5lZ1BqE1YXtT+gMJ8LmHLIO5WN a2Vo+YtErbvxQ/X5RFWpCsTRjIr2y6+yZbKsoM9dWCVFLiKAgHQMnFCt7KqMQj9UHhJc 2ZHpZyVw45SKE+Bn7xq8t2M4Au2hZrIyT4nVTo+qUW8DNn5grAiio2+pnVmUumEXv1Bq 88WmMA+BJg2mFx7TSBm/fgJb5GIsMzB4Z+mg07vGFxH6VZuWYyzD4HEYtfNw4Cac8+t1 QCQCh10mlYhcIThjjXtDk8Fs0ZdfR/LS2Lq7uzlW4I0f6pvZySvw/xOo+5ztUsQEJo1w 3Qwg== X-Gm-Message-State: AOAM5337tMz+aZddOY14LMcOi19XNyfYQMcl/+Uk67/AjEhqrrcsvQF8 npobOTk5en3bhUQ4BXdYxeEG7LVqJ/KVCGaG2pWGrQ== X-Google-Smtp-Source: ABdhPJz3y4TlNL1JF4KJF+1yuPmc8LbezhlJz2o/4Jb79VASFUj+QoEgLFnQxvm0LwiSP+zSpCA553HDqMC/wZi0OFI= X-Received: by 2002:a25:3f43:0:b0:633:bdd8:4ae6 with SMTP id m64-20020a253f43000000b00633bdd84ae6mr7423462yba.134.1648174224922; Thu, 24 Mar 2022 19:10:24 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ivan Babrou Date: Thu, 24 Mar 2022 19:10:14 -0700 Message-ID: Subject: Re: zram corruption due to uninitialized do_swap_page fault To: Minchan Kim Cc: Andrew Morton , Linux MM , linux-kernel , Nitin Gupta , Sergey Senozhatsky , Jens Axboe , linux-block@vger.kernel.org, kernel-team Content-Type: text/plain; charset="UTF-8" Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=cloudflare.com header.s=google header.b=cbc3BGe5; spf=none (imf25.hostedemail.com: domain of ivan@cloudflare.com has no SPF policy when checking 209.85.219.171) smtp.mailfrom=ivan@cloudflare.com; dmarc=pass (policy=reject) header.from=cloudflare.com X-Rspam-User: X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: B0F0FA0035 X-Stat-Signature: qyefdrcum613sq33kbgqgt7fh1xsgwxj X-HE-Tag: 1648174225-359041 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Mar 18, 2022 at 11:54 AM Minchan Kim wrote: > > On Fri, Mar 18, 2022 at 10:32:07AM -0700, Minchan Kim wrote: > > On Fri, Mar 18, 2022 at 09:30:09AM -0700, Ivan Babrou wrote: > > > On Wed, Mar 16, 2022 at 11:26 AM Ivan Babrou wrote: > > > > I'm making an internal build and will push it to some location to see > > > > how it behaves, but it might take a few days to get any sort of > > > > confidence in the results (unless it breaks immediately). > > > > > > > > I've also pushed my patch that disables SWP_SYNCHRONOUS_IO to a few > > > > locations yesterday to see how it fares. > > > > > > I have some updates before the weekend. There are two experimental groups: > > > > > > * My patch that removes the SWP_SYNCHRONOUS_IO flag. There are 704 > > > machines in this group across 5 datacenters with cumulative uptime of > > > 916 days. > > > * Minchan's patch to remove swap_slot_free_notify. There are 376 > > > machines in this group across 3 datacenters with cumulative uptime of > > > 240 days. > > > > > > Our machines take a couple of hours to start swapping anything after > > > boot, and I discounted these two hours from the cumulative uptime. > > > > > > Neither of these two groups experienced unexpected coredumps or > > > rocksdb corruptions. > > > > > > I think at this point it's reasonable to proceed with Minchan's patch > > > (including a backport). > > > > Let me cook the patch and then will post it. > > > > Thanks for the testing as well as reporting, Ivan! > > From 1ede54d46f0b1958bfc624f17fe709637ef8f12a Mon Sep 17 00:00:00 2001 > From: Minchan Kim > Date: Tue, 15 Mar 2022 14:14:23 -0700 > Subject: [PATCH] mm: fix unexpected zeroed page mapping with zram swap Is there any action needed from me to make sure that this lands into the mm tree and eventually into stable releases?