From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CCA2D6D247 for ; Wed, 27 Nov 2024 23:15:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 773E86B0082; Wed, 27 Nov 2024 18:15:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7235D6B0083; Wed, 27 Nov 2024 18:15:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C4336B0085; Wed, 27 Nov 2024 18:15:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3C3496B0082 for ; Wed, 27 Nov 2024 18:15:24 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id D7FDBA13BD for ; Wed, 27 Nov 2024 23:15:23 +0000 (UTC) X-FDA: 82833433116.06.EF54DC2 Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by imf29.hostedemail.com (Postfix) with ESMTP id AE055120004 for ; Wed, 27 Nov 2024 23:15:12 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VAF95CBf; spf=pass (imf29.hostedemail.com: domain of dverkamp@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=dverkamp@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732749317; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GYut6aU/zn0xLVmf0unpLL5mLReSDppc7n+P3njEiRE=; b=TrEUY4fVgkpRTzzElek+YmtVPc9Hqsetqjz8YtgyKJLkEyU5O/A1XYjZJFCP6mS/UAtqbj pa+2b858JLWrue5J7baSqea9Q87/sOWAJDidVStzZAN07O5gvXuKJt8H2TMvkBDdTzTIel XL2r+bhcTuWR09CqmXbfez7m0wZRznQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=VAF95CBf; spf=pass (imf29.hostedemail.com: domain of dverkamp@chromium.org designates 209.85.210.170 as permitted sender) smtp.mailfrom=dverkamp@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732749317; a=rsa-sha256; cv=none; b=NKqy7lOqibaRlFASBayCo9lg9uhtv9TO5ej8X2yT2koitX7GfkHD5HvUyncuR8EzIilMfD uYh2namVifDLg2Vfb9r2ygXrQjHhxepCMU1cb008ckn9oTCuia4XpiwxII9pLg9/MFdoNh AkcBefKsjaz1kjeYBRnOZYZt7Bi71SA= Received: by mail-pf1-f170.google.com with SMTP id d2e1a72fcca58-724e3e4accdso54553b3a.0 for ; Wed, 27 Nov 2024 15:15:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1732749320; x=1733354120; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=GYut6aU/zn0xLVmf0unpLL5mLReSDppc7n+P3njEiRE=; b=VAF95CBfAF9Edyjx5KBcdRnVYUixu7G3IK5ocPt+cD7/gly46BV+FTmzFpbURIXDhf I2zWZb/pHp5dhnmymTUvEtK0/6+p29Yv5wNAaz7Xk9+zU+GSB0ca2OLsiWbp3ufNc8uc 5A1rtI0+jORfkMqk35alVb6WKBeEmgd4tT380= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732749320; x=1733354120; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GYut6aU/zn0xLVmf0unpLL5mLReSDppc7n+P3njEiRE=; b=r7uq9z2w3SA4/215W0ws4bWaIjeKm9hwBf9a0+xpZSJ228H3EN9SaE2iCReICDCtES KM92hebMbL9ia7+eLpSRCeE2OOOXD9BU8NGEx9M+1A1wRXgsvXJnzVrATThenH8piXsf jUEs1mdRWEWwjK+gzGySiVEqUFIRxtQnl2HrATf4EHMoS8G2DFnmZChAqOGOn6l8dXix cv2j8ixnhXfh6ptWxXuJViG2cbbbnxD5je6HCpqBIVpyfjMm8lcWqZ3D/7LqyBgfBLND COnuXG4wMsRRVcF0MoS7D2NknTKTw+bJcgsZqJqkmPd1Tcy2iPBvSgOW9cxKPOtQUXVu /mvA== X-Forwarded-Encrypted: i=1; AJvYcCWCP0fGa+/957FGL2rFxUsthpCwCL2RQJw5aY5VH++eP2m6dNjcaf96iZ2U2xYKnxje0uDg0DeBXg==@kvack.org X-Gm-Message-State: AOJu0YygyCuUt4AKVWPvkZNv46bh9Vv5ElKJJGmO4MKyiXhnMy6dqjxa IEUsGkq7UyFDLJe8Kr8fRDC8WvrCvVDXYKyNSORDgIAu0v3fxKmQyQUhGZXwO73fJif12UsKCbK j+l7I X-Gm-Gg: ASbGncvvFb3/HM8lWycBCb6biWdxfWIWCH/PBwtg25KFGgJ2nkA1qJvd/M/bpKa8vBw WIxQfa8MIANMq9MQpyDShW3kgW8fvrNewyB3Ib4V50N9U8DKXV4NnsOCvvJuxY3EVSPwhmZ+H7O n1QgJBevtlV63n9oX6iSOmakh1sLjcfoXhVlTLLB1rRjfXwKJ1kYKOT8FxlRQmCQBhEO4O5bUhN Nz7FasjUsdEzFPuhs7yE5rZG4bjOTjUfyjM+OEetU6dPAfbMpebHWylpNE/BI9guVgfAER+6nwo BdcuB4ta9ebcVaSgNw== X-Google-Smtp-Source: AGHT+IG3bPsTyhFCY6hoINPDzmhUD0TPkHi/efVkKl2Lw9wguPLrA9zHaayJswyzq6H20wCRt283nA== X-Received: by 2002:a17:902:d4c1:b0:20c:e169:eb6a with SMTP id d9443c01a7336-21501c5d7damr26426225ad.10.1732749320227; Wed, 27 Nov 2024 15:15:20 -0800 (PST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com. [209.85.214.174]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-215219081b3sm1003685ad.85.2024.11.27.15.15.18 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2024 15:15:18 -0800 (PST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-212776d6449so2044685ad.1 for ; Wed, 27 Nov 2024 15:15:18 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCUxw/Cvwtazxtvo6Y8a49CxMlAOuwoC3+6RZlGNRtnmIUvSgyq6emdaJZEE5V21VG9sVkKl/c+I/A==@kvack.org X-Received: by 2002:a17:902:f382:b0:212:655c:caf with SMTP id d9443c01a7336-21501e5af92mr39560115ad.55.1732749318060; Wed, 27 Nov 2024 15:15:18 -0800 (PST) MIME-Version: 1.0 References: <20241127025728.3689245-1-yuanchu@google.com> <20241127025728.3689245-10-yuanchu@google.com> In-Reply-To: <20241127025728.3689245-10-yuanchu@google.com> From: Daniel Verkamp Date: Wed, 27 Nov 2024 15:14:52 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v4 9/9] virtio-balloon: add workingset reporting To: Yuanchu Xie Cc: Andrew Morton , David Hildenbrand , "Aneesh Kumar K.V" , Khalid Aziz , Henry Huang , Yu Zhao , Dan Williams , Gregory Price , Huang Ying , Lance Yang , Randy Dunlap , Muhammad Usama Anjum , Tejun Heo , Johannes Weiner , =?UTF-8?Q?Michal_Koutn=C3=BD?= , Jonathan Corbet , Greg Kroah-Hartman , "Rafael J. Wysocki" , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Mike Rapoport , Shuah Khan , Christian Brauner , Daniel Watson , cgroups@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, virtualization@lists.linux.dev, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: AE055120004 X-Rspamd-Server: rspam12 X-Stat-Signature: qobccqhj9kd7tt5n56xn97rimzm83ycy X-Rspam-User: X-HE-Tag: 1732749312-82288 X-HE-Meta: U2FsdGVkX1/SkTMm9mUlEh78QRmggShTniQjxUTmoFG5CHwaoTH9qivF2Sx9dc1WK2VoDKlzfpUPH+yBx68ZMG+ojELU91ZhomoWmR5mHf7d3iWJiDJ5MhneRl071v4IojowsN4zhgRrxE088Do2RMFcjwzw1w+nfZrY+EGf7CnYKQQkipTFuGAfgKZahq8fpSRu5rkKUK1C0J7HZsNGQt7kgJmoZc9Vp8/fnvfhMA8eEUbx3/VV8wHecAkQUR6QbcQJ932v9xIL9nBPE31mSDSj7HdMLxF6wNFtA4zsttmGLon16d9CDbAxJRUuFSowJdkZyHrd2WLn7onuhoU7Iq2Cz4u6trwP7oH4i+4y7lPxpts2S0EamNiRSgG8OkCxI7BI2mULv7L+yktYYXtpW2uRBwmDIjG0MN9monYp6V6YjrFV+KlM0VIfwMwZ+6WYnEBpdKLEg5F1H8lYcRmYMs2+rtw6DLshDmltthWSGuxUrzRE6Rxn88vxWU8Zi5hwncc61eyNuAxHV3CdMMHFNvipIkRmfX7L4OxPGb7pNt98HhSWc83pVT/96EBV1oeGQS+50sC7mWUOAA58wamWD7l+LD/HRQN4S2NLr21GrM60Wsiph2efqF0MzclR1TQKYw/riXPcRKtd9mSEtD2iK2lvwjHv3soTmpCQJApFBpu+jRFs4ScO82s4r+zjEtpY3wyFAh/1Y7k2lR0XMk9+G2Vl/jPgfyghcvaLKP3cmMoy6AZ5IaVWPO9FEiqQ7DBXHVgFDTcs3VHP47xo1rR1sXIW9784BFxQMsg2pXTw5/SMzrUZrb8GClW90ry65kwb7yQ+zYnULttsq/be6TlYpQ96CPCkxCh5UewDwmE8BYLLdFSPzHHWUqJ6IBZp2TfUcmBJ7nlI4qIfZSr+os7VqL9jcr2l03NpP3fH2lxiNhYo4vphea78g2grTatYEGRd0Oq65lRx+bTZCwI4Czx ocdkvUrU Rq3zPzSYQhFQ5OhVe136w+BzyUD4DMvjIx5eg+2BGQSKIldxXuAuqj5HVfQEVRzGZr7IURawwv1mX2KvN/UxCTypjpHz/w/QQOeaSRLG3nJsdZVqmZHFY3PjJdaSMmyvljstYcB0qQKRBjbnow6xa8wjh0kpSTUnj1LbzSM2NJ6hV+QJMsO9tzDIAm/yGLs2jlDiskf7vQXohKPO/bfIBsjO80sMW1+XVUsY80LpTQ+b7U6ubfxD3HCKWmVwIPl5bG3iLOHOzRsjOtxKTn81LCdKmy2SXm5Kqav0Xj5FW3TvWhH+ao0n2e6yoMJn+p7Ceq8pcIsRpwPMpTSjLHqsMe1opWAz8QHOiO8voalwChjG4FEz+urx+4BB9rQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 26, 2024 at 7:00=E2=80=AFPM Yuanchu Xie wr= ote: [...] > diff --git a/include/linux/workingset_report.h b/include/linux/workingset= _report.h > index f6bbde2a04c3..1074b89035e9 100644 > --- a/include/linux/workingset_report.h > +++ b/include/linux/workingset_report.h [...] > diff --git a/include/uapi/linux/virtio_balloon.h b/include/uapi/linux/vir= tio_balloon.h > index ee35a372805d..668eaa39c85b 100644 > --- a/include/uapi/linux/virtio_balloon.h > +++ b/include/uapi/linux/virtio_balloon.h > @@ -25,6 +25,7 @@ > * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY= WAY > * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY O= F > * SUCH DAMAGE. */ > +#include "linux/workingset_report.h" > #include > #include > #include This seems to be including a non-uapi header (include/linux/workingset_report.h) from a uapi header (include/uapi/linux/virtio_balloon.h), which won't compile outside the kernel. Does anything in the uapi actually need declarations from workingset_report.h? > @@ -37,6 +38,7 @@ > #define VIRTIO_BALLOON_F_FREE_PAGE_HINT 3 /* VQ to report free pa= ges */ > #define VIRTIO_BALLOON_F_PAGE_POISON 4 /* Guest is using page poisonin= g */ > #define VIRTIO_BALLOON_F_REPORTING 5 /* Page reporting virtqueue */ > +#define VIRTIO_BALLOON_F_WS_REPORTING 6 /* Working Set Size reporting *= / > > /* Size of a PFN in the balloon interface. */ > #define VIRTIO_BALLOON_PFN_SHIFT 12 > @@ -128,4 +130,32 @@ struct virtio_balloon_stat { > __virtio64 val; > } __attribute__((packed)); > > +/* Operations from the device */ > +#define VIRTIO_BALLOON_WS_OP_REQUEST 1 > +#define VIRTIO_BALLOON_WS_OP_CONFIG 2 > + > +struct virtio_balloon_working_set_notify { > + /* REQUEST or CONFIG */ > + __le16 op; > + __le16 node_id; > + /* the following fields valid iff op=3DCONFIG */ > + __le32 report_threshold; > + __le32 refresh_interval; > + __le32 idle_age[WORKINGSET_REPORT_MAX_NR_BINS]; > +}; > + > +struct virtio_balloon_working_set_report_bin { > + __le64 idle_age; > + /* bytes in this bucket for anon and file */ > + __le64 anon_bytes; > + __le64 file_bytes; > +}; > + > +struct virtio_balloon_working_set_report { > + __le32 error; > + __le32 node_id; > + struct virtio_balloon_working_set_report_bin > + bins[WORKINGSET_REPORT_MAX_NR_BINS]; > +}; > + > #endif /* _LINUX_VIRTIO_BALLOON_H */ Have the spec changes been discussed in the virtio TC? Thanks, -- Daniel