From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F441C3DA49 for ; Thu, 18 Jul 2024 06:04:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F0526B0089; Thu, 18 Jul 2024 02:04:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A0776B008C; Thu, 18 Jul 2024 02:04:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 168166B0092; Thu, 18 Jul 2024 02:04:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id E71486B0089 for ; Thu, 18 Jul 2024 02:04:30 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 97837A4088 for ; Thu, 18 Jul 2024 06:04:30 +0000 (UTC) X-FDA: 82351833900.05.BEE0FF2 Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by imf23.hostedemail.com (Postfix) with ESMTP id D7838140019 for ; Thu, 18 Jul 2024 06:04:28 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EHzplttK; spf=pass (imf23.hostedemail.com: domain of davidgow@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=davidgow@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1721282628; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E8scQbL3ojunFA2vu6Mm/M82C9xFWuPlbVxUojeYRbc=; b=WBSzgnIVI6yYVDQjWGf3I+Rx4lXYGaK36xn+ygN4KgvWIhyF4GyNN25AFeUUPhIuFNe+QG +OpZY2LrNVG9SJBQzZbP6YV29ARnBVgen5m1rAoZ0ZqwfbilX/hIyWTWySmJEuqqnk6jYr a+xoNIfgo9b1A+5kcPA0sNwiUalEVgQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1721282628; a=rsa-sha256; cv=none; b=uX72O4md/vrPU2R/sL1yhURyBO6i1vAyyRkGmzwqvv0/JWjMwyGcZlszLw9s3ehKVMfbMi m/gQWjmPvGbGbPYvPS/rdZOln2oN6iFXjUA2XFUktolAT19bAjTVX3VWffgnQnCzqXQ86N x8I0Ve50DBrkG4zZZK34eOPkeYlTOw4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=EHzplttK; spf=pass (imf23.hostedemail.com: domain of davidgow@google.com designates 209.85.160.170 as permitted sender) smtp.mailfrom=davidgow@google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-447df43324fso123051cf.1 for ; Wed, 17 Jul 2024 23:04:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1721282668; x=1721887468; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=E8scQbL3ojunFA2vu6Mm/M82C9xFWuPlbVxUojeYRbc=; b=EHzplttKMXgsS5jQaGBGta62eSV5nAxdzPQCH6A8D9lNkmULilTOQ1JAGZhg51kDbc ZFbNQt6u9q7wAAxEJGEHcQrAxAf0PGw/U4cHE3y0pCJR2SANaqN9zRb1ovnTb8SNeYyv 35Fay8W1ipKL79BFuYWuGU9akS+E7nTlMPMGNQLzU7qcSZn1byyXQHDwEQm4TF5twJ6W s3L+s2t4DZFXVKle/tQP7nxUlwd4NdOKPlpkI4BY63OnXsgFjJ+uOnp7msoWFfNGSEs1 q8O4ixYoVWESpM/r40tvP3E8qW/ET173nESTV6f7JNk41Mzdrkz1PNya+gRb77ENUxmn EhSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721282668; x=1721887468; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=E8scQbL3ojunFA2vu6Mm/M82C9xFWuPlbVxUojeYRbc=; b=foJpScfY6dJwWq6aBEOQCbCcri9aJStNFSu9gZIbPcHnKRfQXVSqfYwOsqzFh10Yiw k7B3sN+33q1InVN8EZ1xU+tcavOjB008CMbJTR28q3zIpexC4FyqprYgluef98leXg+9 WLwLkQIqJHAXs9sdwsmUSR0PKZ3sEcMLntUC9k7ILqu35gkKJ2KeUIfa4poK+LEdkorm rLfrQyrFkrXnh+qg+MWATY+nJPq+oSgTZIm9n1yVIRVCewpMjCSOnMz/cAm/qRjjjyt/ cshYOAMRwfDpFqCiGCAvLCDAnewKdIUwXwh/m33P+FMGxb+5bkmTPqfCITQsDB1cEaiG ualA== X-Forwarded-Encrypted: i=1; AJvYcCWCVEqYciJn7E+8OrRzs+8FynwkIKDv7aEKd9rAAIxuxPduY27iLnCAktE2yHJEB1oCJWxWau2gy4pHtiY/3FTjikA= X-Gm-Message-State: AOJu0Yy1Hl8DIgy1Cjk0OaeNTbQ52Qf44v4PzEtR6bTUI+KeU+oSpzo5 e/Waq+0IXkguUUsB2sTVxmXcCSE2Iccqqyx8mJmLFOEFwqWVoFFqpCRpvnHjDjbgwCRygV6aMao /bsT2uCEXofLerGOMkKO/XpwgmIDFBmXC/kC0 X-Google-Smtp-Source: AGHT+IFWiSFqWtqZYfC0jy++zn1iek0Vig5wz8pSEdHMvDV8US/DapjvjgpSBDodO3pWivnkdS9LQpK1eVFmUnjjxIc= X-Received: by 2002:a05:622a:4297:b0:447:d78d:773b with SMTP id d75a77b69052e-44f919d5b5emr1331311cf.6.1721282667643; Wed, 17 Jul 2024 23:04:27 -0700 (PDT) MIME-Version: 1.0 References: <20240717212230.work.346-kees@kernel.org> In-Reply-To: <20240717212230.work.346-kees@kernel.org> From: David Gow Date: Thu, 18 Jul 2024 14:04:14 +0800 Message-ID: Subject: Re: [PATCH] execve: Move KUnit tests to tests/ subdirectory To: Kees Cook Cc: Al Viro , Christian Brauner , Jan Kara , Eric Biederman , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D7838140019 X-Stat-Signature: eu9afixjm996kmfjix1a8ucjitjbg1uz X-HE-Tag: 1721282668-792837 X-HE-Meta: U2FsdGVkX1+LI1IBnjsr/j16sxL2IJrCjrfAW6i500Df8Ok6jERxDLYQlSO4J7xzqVI9DFnvL3MH/5QbFdQm+Iq+WSHS//J3yJ4YSuNO9Awi4u3ouQravRZibc4TMPiwhu778at5ZreSRix3PKqeODsOYBa3ygcRlv6yo5xFgRPOa1lNyWOm3JxGidgwv08gUd8/flOTCmXxSk5AsoTZl1cUwihgRgza3S00HYBXi5wOXCxzUxZpOqohpJeB73lA6lvSpJ1bSLltKhfV7CaFayZlODozkH6nSQh3hzQfx+4jTYMtzBTJTTqaKGXE/7Ii1V5Dx/PmY6W4Xyv4LM8Eyjn0IseRKFDMHrpimpkLcO0bYEb4QGzwiR1ZYMWjNv6a20YDYZ9Jlmg1XHdvYuE3wk3LOQJFCKV3O7CLynRcNWQTZXN/ab7U1bTeXyB1l0v2BnINHfDGfpoMz3XMhaj6FlUGcQKQkb3bFN1QIE7FoGaEbQkal6QidzwNKM6VL6ZpjoF5fzQG12rVfddiX6Rh10G8OeB4yKIoWtpk5C9T74tfUmsQL7AScXeN38qKLpSiv+26c7siurMhL+Epd1oROQw71xiXvhNuA/3XSjYoQe+iRXHaHW/RL3eAYdv4/N0oYFX8o+SFzB3xyS32/6phdPhhFiiULWgRZB72g8QmT6nWO1RuwCvqztRIoAHaIB8SQwn0NPzNVbFOt5LXoHY22eIb6FcfRUToUqbX4glyWofyFrb1xBGVh7s3LUMbcjDeYRf32D8hbI3iAtaK9/q+0qqzA0Nxa6lVqa+CN1mvM4TcLanBKoww9SF4mvBzUSwD/tMVaIoMFML5EEMjHduvzdNMIYTDFQIYGX1yofYpsAaLF7M8y4LshLkiH3LNNrWNLNk/5osF0dg9jzHWQw49mt2C810FEg1PkMl6LcXSUjRdIDs9oXwm61YGR6+SREg+hLjqDhnBtze1m5Zp/bs JQCWYajv /eH0nE1PBGPBvP3dNlTnKjNrxUbiS/RAQb3QU3oA+/AtZlQf6kN8YpHgZZEavpIhfYkA0ukJ6p5ldF42AY/TudG/zntB/XwmX+R/zCi13iXo2HknTVS9AIJuLJC0ZSORq8zimRVis8p2QFnyr6GroDQTlEtnr6TTa9dChjqTo03TE9UeuyN2roY9bnbl7ulVF3EJ0B02M4K276S5FwukD6LVbYIcZKbcVosfFDfBjCU+hhRb8DI+4DEgTtZ2SqzmDcJee6EzRxRiSrjj+Dultr3IDLstNOKcxNshChs8PIJCPJc/hVE1e0gN9bJEipCDTQ3WP/coontBwHRfhRG+oPyQC1rS5CGlKtv9thyBzKaBpFNQWqbAnkVjjrvvctS5VTW02pT9+PO6zHPdYWF4Ctvb+rMzsdiYatPwsOmfhgmITlZb/PURk8hbE7x26rZmB+zp5lem9co2P/SVVi49jHYK92ooiQE+dWvPyj4gaq7moxm3+OYK/4+Z1a7BMEmrFmbctRGnRbBAIohsEidBPTHfd7Fquvj7HZ5zp8KhNqS7U7pw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 18 Jul 2024 at 05:22, Kees Cook wrote: > > Move the exec KUnit tests into a separate directory to avoid polluting > the local directory namespace. Additionally update MAINTAINERS for the > new files and mark myself as Maintainer. > > Signed-off-by: Kees Cook > --- > I'll toss this into -next and send it to Linus before -rc1 closes. > --- With s/_test/_kunit (once the docs changes are sorted), this looks good. Reviewed-by: David Gow Cheers, -- David > Cc: Alexander Viro > Cc: Christian Brauner > Cc: Jan Kara > Cc: Eric Biederman > Cc: David Gow > Cc: Linus Torvalds > Cc: linux-fsdevel@vger.kernel.org > Cc: linux-mm@kvack.org > --- > MAINTAINERS | 5 +++-- > fs/binfmt_elf.c | 2 +- > fs/exec.c | 2 +- > fs/{ => tests}/binfmt_elf_test.c | 0 > fs/{ => tests}/exec_test.c | 0 > 5 files changed, 5 insertions(+), 4 deletions(-) > rename fs/{ => tests}/binfmt_elf_test.c (100%) > rename fs/{ => tests}/exec_test.c (100%) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 8dfbe998f175..35474718c05b 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -8211,8 +8211,8 @@ S: Maintained > F: rust/kernel/net/phy.rs > > EXEC & BINFMT API, ELF > +M: Kees Cook > R: Eric Biederman > -R: Kees Cook > L: linux-mm@kvack.org > S: Supported > T: git git://git.kernel.org/pub/scm/linux/kernel/git/kees/linux.git for-next/execve > @@ -8220,7 +8220,8 @@ F: Documentation/userspace-api/ELF.rst > F: fs/*binfmt_*.c > F: fs/Kconfig.binfmt > F: fs/exec.c > -F: fs/exec_test.c > +F: fs/tests/binfmt_*_test.c > +F: fs/tests/exec_test.c > F: include/linux/binfmts.h > F: include/linux/elf.h > F: include/uapi/linux/binfmts.h > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c > index 40111451aa95..1a032811b304 100644 > --- a/fs/binfmt_elf.c > +++ b/fs/binfmt_elf.c > @@ -2152,5 +2152,5 @@ core_initcall(init_elf_binfmt); > module_exit(exit_elf_binfmt); > > #ifdef CONFIG_BINFMT_ELF_KUNIT_TEST > -#include "binfmt_elf_test.c" > +#include "tests/binfmt_elf_test.c" > #endif > diff --git a/fs/exec.c b/fs/exec.c > index 5b580ff8d955..5a59063c50b1 100644 > --- a/fs/exec.c > +++ b/fs/exec.c > @@ -2244,5 +2244,5 @@ fs_initcall(init_fs_exec_sysctls); > #endif /* CONFIG_SYSCTL */ > > #ifdef CONFIG_EXEC_KUNIT_TEST > -#include "exec_test.c" > +#include "tests/exec_test.c" > #endif > diff --git a/fs/binfmt_elf_test.c b/fs/tests/binfmt_elf_test.c > similarity index 100% > rename from fs/binfmt_elf_test.c > rename to fs/tests/binfmt_elf_test.c > diff --git a/fs/exec_test.c b/fs/tests/exec_test.c > similarity index 100% > rename from fs/exec_test.c > rename to fs/tests/exec_test.c > -- > 2.34.1 >