From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90C86C433EF for ; Fri, 4 Mar 2022 07:52:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 177488D0002; Fri, 4 Mar 2022 02:52:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 127A08D0001; Fri, 4 Mar 2022 02:52:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 015DD8D0002; Fri, 4 Mar 2022 02:52:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0195.hostedemail.com [216.40.44.195]) by kanga.kvack.org (Postfix) with ESMTP id E7A1F8D0001 for ; Fri, 4 Mar 2022 02:52:18 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A8900987B7 for ; Fri, 4 Mar 2022 07:52:18 +0000 (UTC) X-FDA: 79205935956.19.B0BF886 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by imf31.hostedemail.com (Postfix) with ESMTP id 4D3412000B for ; Fri, 4 Mar 2022 07:52:18 +0000 (UTC) Received: by mail-wm1-f42.google.com with SMTP id 19so4234175wmy.3 for ; Thu, 03 Mar 2022 23:52:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qV2WgWfmy025B2yizHj5cEsy8QBqW+3p0W5gPgrOAks=; b=MHV5AYLQOFfjKXxLFA8RLSSli+MKWBjwzrjEG6CVgtspLqtfMs+sTR5fn6ZPCAf+d8 Deo4ox8hoNiGm9G39jdV+3erDuXzLOeMKlfkrU5IduIwfQp+GWmz1Umr1utxZ50GHRy+ bs87f3tWeJuBPuc5MFO3iEk4+ZxesB6MLNyyNcq4iDeO27LapWaDh6dL7sL7Kt3Rz5Ji Ix34IoAo/Yww0cKbWDUNmunXcwaFp/15g+yn2eFmZMvBjeY4dmIVJ7FQm/oZtSSScs7b aGjLSiVnbhrLkDlYo6PYyH/fov5Q8PZ95fT4ELx+8bcCp8CVOo7BOs15SV3HIwaESNk4 b++w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qV2WgWfmy025B2yizHj5cEsy8QBqW+3p0W5gPgrOAks=; b=phtYPntGPYvuxvkREhYRvXPvEnsU7ASeBfh4wJKhI42jtV2q2Ukkij9Uk3kTCcOoM2 qixjlFDj4asrITceM9IpVUZk0GR/1kV2VN59XOW//DwvLffesY2nagMPjGyDX5anVmYe skdnMbIwBjPvTwji79ZGIkXArLFrb8f3ca3qzskU8XUGXHXWWWF1MMB7fxNMlssA6Wj8 fc5gVf8APRjgPF/mm/gi3qTwAJFCSa3nK6OVG8cfDNMFSnFMBGhQWls5wrITYl81KXtt OgV+cFr6nLgmk1ijZrUFFCdlo9Cx62x89+iSYo2NxjCvdmY//7eCoZQcyYcF2EPoUwDK YBrg== X-Gm-Message-State: AOAM530N1PPjUlx/ada8PlHIFIL33l/AwHWHsH9un1cBnSt9/y95LSYe W4N4ropbAZiYi5Q0KDnP4BUnfmy2eJvGiONG/wI07A== X-Google-Smtp-Source: ABdhPJxIPfDXvtH+FUsLdt+mQruAYm8bX4xhBQYNp//ry3REN+e7uBKdH22pPJ1wNIYTM2Yhk8PJIKciXziFQf4SpZA= X-Received: by 2002:a05:600c:4fd0:b0:382:716a:c5fc with SMTP id o16-20020a05600c4fd000b00382716ac5fcmr6621968wmq.81.1646380336841; Thu, 03 Mar 2022 23:52:16 -0800 (PST) MIME-Version: 1.0 References: <20220304044831.962450-1-keescook@chromium.org> In-Reply-To: <20220304044831.962450-1-keescook@chromium.org> From: David Gow Date: Fri, 4 Mar 2022 15:52:05 +0800 Message-ID: Subject: Re: [PATCH v2] binfmt_elf: Introduce KUnit test To: Kees Cook Cc: Eric Biederman , Daniel Latypov , Alexey Dobriyan , =?UTF-8?B?TWFnbnVzIEdyb8Of?= , Alexander Viro , Linux Kernel Mailing List , KUnit Development , linux-fsdevel@vger.kernel.org, Linux Memory Management List , linux-hardening@vger.kernel.org Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000002a0e8205d95fcb49" X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 4D3412000B X-Stat-Signature: n89ffh9ise8u5wun7sacun4dgu5p6pp1 Authentication-Results: imf31.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=MHV5AYLQ; spf=pass (imf31.hostedemail.com: domain of davidgow@google.com designates 209.85.128.42 as permitted sender) smtp.mailfrom=davidgow@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1646380338-742595 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --0000000000002a0e8205d95fcb49 Content-Type: text/plain; charset="UTF-8" On Fri, Mar 4, 2022 at 12:48 PM Kees Cook wrote: > > Adds simple KUnit test for some binfmt_elf internals: specifically a > regression test for the problem fixed by commit 8904d9cd90ee ("ELF: > fix overflow in total mapping size calculation"). > > $ ./tools/testing/kunit/kunit.py run --arch x86_64 \ > --kconfig_add CONFIG_IA32_EMULATION=y '*binfmt_elf' > ... > [19:41:08] ================== binfmt_elf (1 subtest) ================== > [19:41:08] [PASSED] total_mapping_size_test > [19:41:08] =================== [PASSED] binfmt_elf ==================== > [19:41:08] ============== compat_binfmt_elf (1 subtest) =============== > [19:41:08] [PASSED] total_mapping_size_test > [19:41:08] ================ [PASSED] compat_binfmt_elf ================ > [19:41:08] ============================================================ > [19:41:08] Testing complete. Passed: 2, Failed: 0, Crashed: 0, Skipped: 0, Errors: 0 > > Cc: Eric Biederman > Signed-off-by: Kees Cook > --- > This is now at the top of my for-next/execve tree > v1: https://lore.kernel.org/lkml/20220224054332.1852813-1-keescook@chromium.org > v2: > - improve commit log > - fix comment URL (Daniel) > - drop redundant KUnit Kconfig help info (Daniel) > - note in Kconfig help that COMPAT builds add a compat test (David) > --- This looks good to me, and works fine with those two prerequisite patches from your tree: - ELF: Properly redefine PT_GNU_* in terms of PT_LOOS - ELF: fix overflow in total mapping size calculation (I even played a few of the games which triggered the ELF bug to make sure it was fixed, too. :-) ) Reviewed-by: David Gow Cheers, -- David --0000000000002a0e8205d95fcb49 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIPnwYJKoZIhvcNAQcCoIIPkDCCD4wCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg ggz5MIIEtjCCA56gAwIBAgIQeAMYYHb81ngUVR0WyMTzqzANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA3MjgwMDAwMDBaFw0yOTAzMTgwMDAwMDBaMFQxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMSowKAYDVQQDEyFHbG9iYWxTaWduIEF0bGFz IFIzIFNNSU1FIENBIDIwMjAwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQCvLe9xPU9W dpiHLAvX7kFnaFZPuJLey7LYaMO8P/xSngB9IN73mVc7YiLov12Fekdtn5kL8PjmDBEvTYmWsuQS 6VBo3vdlqqXZ0M9eMkjcKqijrmDRleudEoPDzTumwQ18VB/3I+vbN039HIaRQ5x+NHGiPHVfk6Rx c6KAbYceyeqqfuJEcq23vhTdium/Bf5hHqYUhuJwnBQ+dAUcFndUKMJrth6lHeoifkbw2bv81zxJ I9cvIy516+oUekqiSFGfzAqByv41OrgLV4fLGCDH3yRh1tj7EtV3l2TngqtrDLUs5R+sWIItPa/4 AJXB1Q3nGNl2tNjVpcSn0uJ7aFPbAgMBAAGjggGKMIIBhjAOBgNVHQ8BAf8EBAMCAYYwHQYDVR0l BBYwFAYIKwYBBQUHAwIGCCsGAQUFBwMEMBIGA1UdEwEB/wQIMAYBAf8CAQAwHQYDVR0OBBYEFHzM CmjXouseLHIb0c1dlW+N+/JjMB8GA1UdIwQYMBaAFI/wS3+oLkUkrk1Q+mOai97i3Ru8MHsGCCsG AQUFBwEBBG8wbTAuBggrBgEFBQcwAYYiaHR0cDovL29jc3AyLmdsb2JhbHNpZ24uY29tL3Jvb3Ry MzA7BggrBgEFBQcwAoYvaHR0cDovL3NlY3VyZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvcm9vdC1y My5jcnQwNgYDVR0fBC8wLTAroCmgJ4YlaHR0cDovL2NybC5nbG9iYWxzaWduLmNvbS9yb290LXIz LmNybDBMBgNVHSAERTBDMEEGCSsGAQQBoDIBKDA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5n bG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzANBgkqhkiG9w0BAQsFAAOCAQEANyYcO+9JZYyqQt41 TMwvFWAw3vLoLOQIfIn48/yea/ekOcParTb0mbhsvVSZ6sGn+txYAZb33wIb1f4wK4xQ7+RUYBfI TuTPL7olF9hDpojC2F6Eu8nuEf1XD9qNI8zFd4kfjg4rb+AME0L81WaCL/WhP2kDCnRU4jm6TryB CHhZqtxkIvXGPGHjwJJazJBnX5NayIce4fGuUEJ7HkuCthVZ3Rws0UyHSAXesT/0tXATND4mNr1X El6adiSQy619ybVERnRi5aDe1PTwE+qNiotEEaeujz1a/+yYaaTY+k+qJcVxi7tbyQ0hi0UB3myM A/z2HmGEwO8hx7hDjKmKbDCCA18wggJHoAMCAQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUA MEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9vdCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWdu MRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEg MB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENBIC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzAR BgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4 Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0EXyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuu l9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+JJ5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJ pij2aTv2y8gokeWdimFXN6x0FNx04Druci8unPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh 6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTvriBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti +w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGjQjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8E BTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5NUPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEA S0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigHM8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9u bG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmUY/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaM ld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88 q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcya5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/f hO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/XzCCBNgwggPAoAMCAQICEAFB5XJs46lHhs45dlgv lPcwDQYJKoZIhvcNAQELBQAwVDELMAkGA1UEBhMCQkUxGTAXBgNVBAoTEEdsb2JhbFNpZ24gbnYt c2ExKjAoBgNVBAMTIUdsb2JhbFNpZ24gQXRsYXMgUjMgU01JTUUgQ0EgMjAyMDAeFw0yMjAyMDcy MDA0MDZaFw0yMjA4MDYyMDA0MDZaMCQxIjAgBgkqhkiG9w0BCQEWE2RhdmlkZ293QGdvb2dsZS5j b20wggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC0RBy/38QAswohnM4+BbSvCjgfqx6l RZ05OpnPrwqbR8foYkoeQ8fvsoU+MkOAQlzaA5IaeOc6NZYDYl7PyNLLSdnRwaXUkHOJIn09IeqE 9aKAoxWV8wiieIh3izFAHR+qm0hdG+Uet3mU85dzScP5UtFgctSEIH6Ay6pa5E2gdPEtO5frCOq2 PpOgBNfXVa5nZZzgWOqtL44txbQw/IsOJ9VEC8Y+4+HtMIsnAtHem5wcQJ+MqKWZ0okg/wYl/PUj uaq2nM/5+Waq7BlBh+Wh4NoHIJbHHeGzAxeBcOU/2zPbSHpAcZ4WtpAKGvp67PlRYKSFXZvbORQz LdciYl8fAgMBAAGjggHUMIIB0DAeBgNVHREEFzAVgRNkYXZpZGdvd0Bnb29nbGUuY29tMA4GA1Ud DwEB/wQEAwIFoDAdBgNVHSUEFjAUBggrBgEFBQcDBAYIKwYBBQUHAwIwHQYDVR0OBBYEFKbSiBVQ G7p3AiuB2sgfq6cOpbO5MEwGA1UdIARFMEMwQQYJKwYBBAGgMgEoMDQwMgYIKwYBBQUHAgEWJmh0 dHBzOi8vd3d3Lmdsb2JhbHNpZ24uY29tL3JlcG9zaXRvcnkvMAwGA1UdEwEB/wQCMAAwgZoGCCsG AQUFBwEBBIGNMIGKMD4GCCsGAQUFBzABhjJodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9jYS9n c2F0bGFzcjNzbWltZWNhMjAyMDBIBggrBgEFBQcwAoY8aHR0cDovL3NlY3VyZS5nbG9iYWxzaWdu LmNvbS9jYWNlcnQvZ3NhdGxhc3Izc21pbWVjYTIwMjAuY3J0MB8GA1UdIwQYMBaAFHzMCmjXouse LHIb0c1dlW+N+/JjMEYGA1UdHwQ/MD0wO6A5oDeGNWh0dHA6Ly9jcmwuZ2xvYmFsc2lnbi5jb20v Y2EvZ3NhdGxhc3Izc21pbWVjYTIwMjAuY3JsMA0GCSqGSIb3DQEBCwUAA4IBAQBsL34EJkCtu9Nu 2+R6l1Qzno5Gl+N2Cm6/YLujukDGYa1JW27txXiilR9dGP7yl60HYyG2Exd5i6fiLDlaNEw0SqzE dw9ZSIak3Qvm2UybR8zcnB0deCUiwahqh7ZncEPlhnPpB08ETEUtwBEqCEnndNEkIN67yz4kniCZ jZstNF/BUnI3864fATiXSbnNqBwlJS3YkoaCTpbI9qNTrf5VIvnbryT69xJ6f25yfmxrXNJJe5OG ncB34Cwnb7xQyk+uRLZ465yUBkbjk9pC/yamL0O7SOGYUclrQl2c5zzGuVBD84YcQGDOK6gSPj6w QuBfOooZPOyZZZ8AMih7J980MYICajCCAmYCAQEwaDBUMQswCQYDVQQGEwJCRTEZMBcGA1UEChMQ R2xvYmFsU2lnbiBudi1zYTEqMCgGA1UEAxMhR2xvYmFsU2lnbiBBdGxhcyBSMyBTTUlNRSBDQSAy MDIwAhABQeVybOOpR4bOOXZYL5T3MA0GCWCGSAFlAwQCAQUAoIHUMC8GCSqGSIb3DQEJBDEiBCCV FrtjW1B6FpmKliW4uhUI+lIfowUo7bSWeSjsXcKpXTAYBgkqhkiG9w0BCQMxCwYJKoZIhvcNAQcB MBwGCSqGSIb3DQEJBTEPFw0yMjAzMDQwNzUyMTdaMGkGCSqGSIb3DQEJDzFcMFowCwYJYIZIAWUD BAEqMAsGCWCGSAFlAwQBFjALBglghkgBZQMEAQIwCgYIKoZIhvcNAwcwCwYJKoZIhvcNAQEKMAsG CSqGSIb3DQEBBzALBglghkgBZQMEAgEwDQYJKoZIhvcNAQEBBQAEggEAL2sYhi6qF+P3ASYQL3fi 2xMTSw82DtAFCyKxLATmRSJVQo1g3wuaiehNaIaWue5Q8ZXRnb+C9kGW58X0al07058td0d1u/mn stbGdewvgwWvjY5X66BeaxSBd928y9NKpD42LuthBoZO0nYUJ21q+p3r8kYg1/rx3YkL7JryMwWv YzF1VJF6lDfVR5uq3+iDe97GLz3xD+vjl2FjUheXaIepNXKkBUqOb8wh2R3jdiXo/DemM2qjPaj3 Gt6VpRRxG3S5rsELdaGrGwgBVs4govBSUAU38Lpz7ZZuGbTm5xSp3U9meOdLOuuC6zRgskWOve6k 7deTjsMkA0KWb+4i6g== --0000000000002a0e8205d95fcb49--