From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 092FDC83F12 for ; Mon, 28 Aug 2023 14:46:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6595628001A; Mon, 28 Aug 2023 10:46:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 609CC8E000E; Mon, 28 Aug 2023 10:46:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4AA5028001A; Mon, 28 Aug 2023 10:46:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2CB528E000E for ; Mon, 28 Aug 2023 10:46:54 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id F39111A0290 for ; Mon, 28 Aug 2023 14:46:53 +0000 (UTC) X-FDA: 81173790306.04.F1A759B Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf14.hostedemail.com (Postfix) with ESMTP id 3A5DC100041 for ; Mon, 28 Aug 2023 14:46:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ZlMeB4Jg; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of revest@chromium.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=revest@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1693234012; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uEYtr8V/fktSZTifRUB9ASx/4sFKcy6buk58qRmPz38=; b=E0XwKl7S7q4ypazgSs4UPBDUrSR0ORzv5j2tCPzoOA2QFW9arBzNP9GLgPVdBGLtSW+hng NcYjazXiUmnGhi7WhbPghLjqHAVhNcRvKrVGMVR/RiYj2ewam8LjmvXmjnW9Cpv32LTzIh nVKUskInnhNwux+415PPEbzStxvyIs8= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ZlMeB4Jg; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of revest@chromium.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=revest@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1693234012; a=rsa-sha256; cv=none; b=p28do1eLX4X20EVJNGlUZddaWjf346r4tT3HjxVbh45Vv79laF49rAMgdKkxTm7psCJiHv pCqvUNT3bhkfzLhS4qW5x6eR7mcyHSNOwdifNPbzmh2H0vGbgqSsarEaLnGJL9SLdpYNsn juqcjmZUWkU51w4RhjimkpJEKAp47n4= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1bdbf10333bso25696135ad.1 for ; Mon, 28 Aug 2023 07:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1693234010; x=1693838810; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=uEYtr8V/fktSZTifRUB9ASx/4sFKcy6buk58qRmPz38=; b=ZlMeB4JgOYuCVRgsXeqFonPY8IbqVcg0WlOyM2FEn8psyI4ZndgkyeFdJUIcLX4sxi 1EipQxeAbgjbhGie+/5gTPm9hASTTvC29zUd5U1pm1wvvwVwB6E4Zws9foVRayNuPBdt dPpM7CMLQ9CNARZAfT5hRjaBF+ETLnKdqMtHw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693234010; x=1693838810; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uEYtr8V/fktSZTifRUB9ASx/4sFKcy6buk58qRmPz38=; b=P0kGexlN1Ed8nzl5Q3TwgEsl/VoM6cDO5OeqjYAFsTOakxXrdUSov7Ngb8eCf58Dhg FTbmDGbujExLDo3hi+Ny390ozLBm6zE/GcrbniGGkyXwEEsglX+LyLXDp0zmumKaR5HG BR8Q42XbbVYVW6hdYYt7OiHmdRW8JJrhw2irRd/E8yHBLf55c2NRmZsYzVXAjScQPTyu ySPtfcTQtoTygCr9JjqaFp1NXa0vnOjzpYz8KyRYjRA8NG+4n139iF98C/R0zC4PNI22 zNX0UHaVoCb8byGnRiOycP6g/rgM2s7oH4FsCEyGJCDsV29L+MDzIYG3uKtlR4zY2uN4 0LVw== X-Gm-Message-State: AOJu0YwfnnrcpSFuM4UesEncsWfEWkbufNUGomNn9GoOogHo6XUFjOT7 aODLlR+TpSXaoJLio5qpBDh7kQnvLD+gWmLTH9JzRg== X-Google-Smtp-Source: AGHT+IG4zpabqadmwypRX1FvyZoPXaUiVEvAlDzyWO2H5OwtbLF1xQRBmEVyynF11+a3Cx9U5SYwazsp0+Fwwqol9NM= X-Received: by 2002:a17:90b:2348:b0:268:e43a:dbfd with SMTP id ms8-20020a17090b234800b00268e43adbfdmr24068342pjb.1.1693234010758; Mon, 28 Aug 2023 07:46:50 -0700 (PDT) MIME-Version: 1.0 References: <20230704153630.1591122-1-revest@chromium.org> <20230704153630.1591122-5-revest@chromium.org> In-Reply-To: From: Florent Revest Date: Mon, 28 Aug 2023 16:46:39 +0200 Message-ID: Subject: Re: [PATCH v3 4/5] mm: Add a NO_INHERIT flag to the PR_SET_MDWE prctl To: Catalin Marinas Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 3A5DC100041 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: hkm871h6qudw8g6986go5hfpe79krhwb X-HE-Tag: 1693234011-620757 X-HE-Meta: U2FsdGVkX1/LhsnAQlhxKJzB520m9opxGIe1WI24YUjaprqN33fKrBJAqbUPpXFMs7Gu6ad2RMSIBAIPVqTc/Iqs0zbQ4aEnwAhI4cbaUaOshNDGmFEj4mphxnIZeznouH2PpVb6+1F9YBo5s56IXbCTS4DQrb8MSD0LL+EbMJztlb28uutz2HEEYKqee/oLk0MIhaxvEKpdtKr78spQzA4fUBndRmzj0w35GvBEmqao4zjKtUn0HZQ3iAGXERDf8Tkp33v5oQsOetsVAHGAap8wGRaVyxSmv/vHrsH9oNlBy2TT5PzeCrcETeOFg7/obo1sOY4RpAXurQlD9GSMeA571YqpHsskrbWcSDLysFqTGXxiX72Iiuy9I7AaOTcCTgx/oODmbMmzcx0honVEuASVhWdilHloUbs+FgIBvVtIDwIsQfxdF2CGE57PxsiR456QQxsKPWJ2ZY0YU0s8z9wEOX1Lj4xFciQVJ8NuMnU02W/Lp25aT4WaGoxaSiWC8eRq1fxaqzPmRYYELS9kPGgZ5kKWI42iUP+xFp7qO2kVJbc5wCuMGRdqhsL3zkxFN+dwl6Z1bzoIV0LXSdwq0yDETSddevscC3ClJPv3HO9tY+t9xpuIrgJKhI37/0uduUKqSU+QQJH23RTsELjuKbLAFbOqPaHmFon6DKeribuBqRVp/yCpX/0G2flaCRVDeC2VJ0jIJfPwOqQrFzWw45tGYjAOjEU+wP9fj2URQWy52SCLJaqs14e1UBbypgtSjho3vHMji2m5igI3dMTM5PzCp1hue3ACyIUWlRZwXEebYd+3zajienTvlo8NV0MQ/F61/Sfz8G7aemVXIR0uKD9dtuTLWefig6AMjpMmFVPW1Sg/KbIFWjNMWGzwupUMN4dHwaXVqa4+LcnGvNMO6VXJTJ3g+MvfZ0B8qNhPBuy3/bp7Fhkdrwbzm/8SHg3cjKxZCHmfxMetlS38tNp pQuQB3+e NvN6T42kJ0rfj2LVRumMC1A/GRntn3ub+OgryUueuamR5kODthWITBDFMEXPj9huVEk2ooCzKdAyNNx6MrZ2a1qEqkebyg1dKe2CwO8CGk4NAUx3tEYc92iTwGHviUihNompPKiM4ltGEAvgAw4gFuQFd90zkhWXCkja+finvr7DtCmeqpttebwrFt+9mecMSKb3+gSUqSPgdNwIonDQDKYFRpjJn4D6uSVXRRVm7TqcKV+YAO17RPS0/r0BRKDtCM2D64laVDtJMrt1s20hNgMTu1D9eX3y8nb8Vn1K6TIruF51YUcvt3YAC2q7seQmIFTlV/e6w7/I0NiJfM/5QpTfZvw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Aug 27, 2023 at 3:10=E2=80=AFPM Catalin Marinas wrote: > > On Tue, Jul 04, 2023 at 05:36:28PM +0200, Florent Revest wrote: > > @@ -2384,9 +2406,7 @@ static inline int prctl_get_mdwe(unsigned long ar= g2, unsigned long arg3, > > { > > if (arg2 || arg3 || arg4 || arg5) > > return -EINVAL; > > - > > - return test_bit(MMF_HAS_MDWE, ¤t->mm->flags) ? > > - PR_MDWE_REFUSE_EXEC_GAIN : 0; > > + return (int)get_current_mdwe(); > > Nitpick: the type conversion should be handled by the compiler as > prctl_get_mdwe() returns an int already. Ah yes. Not sure why I added this one... :) thank you!