From: Florent Revest <revest@chromium.org>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
akpm@linux-foundation.org, anshuman.khandual@arm.com,
joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org,
david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru,
broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org,
gthelen@google.com, toiwoton@gmail.com
Subject: Re: [PATCH v3 4/5] mm: Add a NO_INHERIT flag to the PR_SET_MDWE prctl
Date: Mon, 28 Aug 2023 16:46:39 +0200 [thread overview]
Message-ID: <CABRcYmLYiwDBK-sMQMcpjZEcLicoj2PyRmJrs5hB0EaTHzX1Vg@mail.gmail.com> (raw)
In-Reply-To: <ZOtLWxokPxBCg0ao@arm.com>
On Sun, Aug 27, 2023 at 3:10 PM Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> On Tue, Jul 04, 2023 at 05:36:28PM +0200, Florent Revest wrote:
> > @@ -2384,9 +2406,7 @@ static inline int prctl_get_mdwe(unsigned long arg2, unsigned long arg3,
> > {
> > if (arg2 || arg3 || arg4 || arg5)
> > return -EINVAL;
> > -
> > - return test_bit(MMF_HAS_MDWE, ¤t->mm->flags) ?
> > - PR_MDWE_REFUSE_EXEC_GAIN : 0;
> > + return (int)get_current_mdwe();
>
> Nitpick: the type conversion should be handled by the compiler as
> prctl_get_mdwe() returns an int already.
Ah yes. Not sure why I added this one... :) thank you!
next prev parent reply other threads:[~2023-08-28 14:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-04 15:36 [PATCH v3 0/5] MDWE without inheritance Florent Revest
2023-07-04 15:36 ` [PATCH v3 1/5] kselftest: vm: Fix tabs/spaces inconsistency in the mdwe test Florent Revest
2023-08-25 22:23 ` Kees Cook
2023-08-27 13:09 ` Catalin Marinas
2023-08-28 14:45 ` Florent Revest
2023-07-04 15:36 ` [PATCH v3 2/5] kselftest: vm: Fix mdwe's mmap_FIXED test case Florent Revest
2023-07-13 7:13 ` Ryan Roberts
2023-08-25 4:37 ` Jain, Ayush
2023-08-25 22:28 ` Kees Cook
2023-08-28 14:46 ` Florent Revest
2023-08-27 13:09 ` Catalin Marinas
2023-07-04 15:36 ` [PATCH v3 3/5] mm: Make PR_MDWE_REFUSE_EXEC_GAIN an unsigned long Florent Revest
2023-07-04 15:45 ` Florent Revest
2023-08-25 22:29 ` Kees Cook
2023-07-04 15:36 ` [PATCH v3 4/5] mm: Add a NO_INHERIT flag to the PR_SET_MDWE prctl Florent Revest
2023-08-25 22:38 ` Kees Cook
2023-08-27 13:09 ` Catalin Marinas
2023-08-28 14:46 ` Florent Revest
2023-08-27 13:10 ` Catalin Marinas
2023-08-28 14:46 ` Florent Revest [this message]
2023-07-04 15:36 ` [PATCH v3 5/5] kselftest: vm: Add tests for no-inherit memory-deny-write-execute Florent Revest
2023-08-25 22:45 ` Kees Cook
2023-08-28 14:47 ` Florent Revest
2023-08-27 13:11 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABRcYmLYiwDBK-sMQMcpjZEcLicoj2PyRmJrs5hB0EaTHzX1Vg@mail.gmail.com \
--to=revest@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=gthelen@google.com \
--cc=izbyshev@ispras.ru \
--cc=joey.gouly@arm.com \
--cc=keescook@chromium.org \
--cc=kpsingh@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=peterx@redhat.com \
--cc=szabolcs.nagy@arm.com \
--cc=toiwoton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox