From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 176EFEB64D9 for ; Tue, 4 Jul 2023 15:46:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6B220280091; Tue, 4 Jul 2023 11:46:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 661DC280076; Tue, 4 Jul 2023 11:46:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 502FF280091; Tue, 4 Jul 2023 11:46:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 31C01280076 for ; Tue, 4 Jul 2023 11:46:08 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 013ED1C889E for ; Tue, 4 Jul 2023 15:46:07 +0000 (UTC) X-FDA: 80974355616.28.B1F77F0 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) by imf14.hostedemail.com (Postfix) with ESMTP id 154EA100014 for ; Tue, 4 Jul 2023 15:46:05 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="O5QUE2/e"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of revest@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=revest@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688485566; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ut9W76FKV+Lg/Nk3Q8fpYQfXZYC0YQoH73u8akKRiCM=; b=x/ySY7d/rD+maemwlel1dmrJLvucCN537QFeURuCWmGQO0zO6xThnC77dSaLW7sbLoWRko eTXkYzBSWNiSNJPSu+kcwmyMfXqTuo6G0h9TrdAKWv1k4latuRrB0FjCIpmLpQcSz4ukud wsp08g2FW3T46sqShRSeRyVcqKsU04A= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b="O5QUE2/e"; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf14.hostedemail.com: domain of revest@chromium.org designates 209.85.215.180 as permitted sender) smtp.mailfrom=revest@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688485566; a=rsa-sha256; cv=none; b=WkVr0Xibm892IRoXJ2ELmaENMo1pSLtQaBEx6peo5g7PO6WESQ+XifUjKpuYmEjp+OAncZ 7Z6YWAv5gdELYKdgvpG8sWzzDnP0mJCzImajOUe8Z9zTVpK/E8un/UhJjhT5ZHKBmGgJyk WUQTFxsKet1Z/zHIRALAc0Mx+H1TAKE= Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-55b12286476so2788708a12.1 for ; Tue, 04 Jul 2023 08:46:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1688485565; x=1691077565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Ut9W76FKV+Lg/Nk3Q8fpYQfXZYC0YQoH73u8akKRiCM=; b=O5QUE2/eaB2IalpuzNuEpk0Q2Vk7hSTHA+TLIf5LYyCw25zZd1uqEQdOa/qc4kuMsV tXcVLpWfGB6sAdnXlI2kWez7aOgTSOQ68YEtOPTI3xSA5+rU6uJiIwJVvPB8oej3RCfG M5wc2BU0P2AOW3N/ybsxWt25Z/tFG1TEZVjkg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688485565; x=1691077565; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ut9W76FKV+Lg/Nk3Q8fpYQfXZYC0YQoH73u8akKRiCM=; b=RXF6XJYoCLbIZI/jOgFvgeLiHjE7cmZzH0RDr/AAn3rX5P6fF4TQttIpHV7L7DqHVn MEof+RlTagC2Ccn0WswJF2+yIB8zU+5L8hJIwvf58g7B7l6YlGHygQBgYP2VAulCEuzh V00nuDs9fOjwCTQ2mTKorugJHkjMLI7Lisr1zyg4uxsS66Fx1ZYTv0V9mrAlH7ZyjLAB gI8HPaiyaXBxnpzfQAeDuy1p0FDZGvc6ofrObFhzUoqi/b1tPJUraMyvVqUKBLOETkKB 6lr3F+hyBycHNdH684ZXbDRBc138RtqTxpw2AFh+WIo620RJk3Er7GpORzp4w/Rvy0Ct /8XQ== X-Gm-Message-State: ABy/qLbgFfNkiSrknhAQ8ST2Kyf4bet9N4d9NU0wttwBO0tTDFOC/elt WDV8jIdFyk7Fl+oDcs7VXKnMJxGz/oO8vsLfLfwXMnRrW6D0INEE X-Google-Smtp-Source: APBJJlHNiEz/TsF8ZoZpcG3iC5rBPXBsnfzkr9aqCwymLema2t/+jBNd7zG2QXsm7C2ggFkH+uvDVgtCWhKoEudf6iQ= X-Received: by 2002:a05:6a20:3d1c:b0:10f:52e2:49ec with SMTP id y28-20020a056a203d1c00b0010f52e249ecmr13107156pzi.53.1688485564792; Tue, 04 Jul 2023 08:46:04 -0700 (PDT) MIME-Version: 1.0 References: <20230704153630.1591122-1-revest@chromium.org> <20230704153630.1591122-4-revest@chromium.org> In-Reply-To: <20230704153630.1591122-4-revest@chromium.org> From: Florent Revest Date: Tue, 4 Jul 2023 17:45:53 +0200 Message-ID: Subject: Re: [PATCH v3 3/5] mm: Make PR_MDWE_REFUSE_EXEC_GAIN an unsigned long To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com, linux-stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 154EA100014 X-Stat-Signature: afd98gtxdq7bzuusbptg9ueayhkbh75y X-Rspam-User: X-HE-Tag: 1688485565-566109 X-HE-Meta: U2FsdGVkX19PYUxrn7LvsUSHfqiZ+9WAvfJY51Pco5tYadGdMjgzOPAE/sShttkWqAfUaNXGH0n+IFsFiS0Fvq9EDI6ClB4jelhdKHduuCYx12gk2y89iAQCeGLmOTYa5zoyFTjrFLxw0mp9e4FSJxhIbY+Jfji/XxuLCnWVhUCVzVzYTT0wUdQx+XQe+9SrZS8DqViLirMxcYUTYWc2B3WLVkH7bjISwLLGmKeCdrUUtqPosahZXzDWVc1341+erYYNHlfQlla0zSnO0N8L2kBRK/xeFYYnU1yIu7BAO9Ofsmlnk5EdkJFNY2suc22ckRLX5UWI7tMFj1Dj9p0B4N9uJuTovUweTfTLOziOpxwPl0gvyhXwCFRLOERaVAUc9qRBkQsBPZgsGSF98zuxdOTap/+BVkE4ubcvgFz7GdBx0LT5CQzu+4iosvlCABCdF1tdDC0kyqJ4H37bYT9G45joejO4ajExU1IBRO8+wFKyQjMA6aB1QAhEo4jTOhSo2Vo6xeYYliKbsohaxTnKnqNzu2a5T+1yw0lvQTPZsm1RClpayLZ2A1LfFM6paYhvo3LhSwj6/HejmdnWldQdXJi2V3qp+/zgIlqtVVOMP9K0mIEt7OHbni72N8FeqHDRw6wQX3toNGLeJQZpnjzIU4wI/Y4tqQyetlNMyDoqixnXY+OraZ7EmeSPI4Ke5Sti1gd9AdCXSkQ3Ej+Rr3i05kvZQL6CVl2/8N3b+cGqTLy1z5fjjnZDpbayRSRHRYA+zid/M5S6ieOk8o3PfrLcKJWaMNqxFleCF7k3LzuLzAuNJWSiF2XrwfFEpNY2E4kB/lRhxHQEwTdpldArdbQuYS0eGafckx1Y1b+xVR0zM9uKTjgUr8ZdqC9prgEcsy633EzgmpMKZv4WLSRVuyj9/FmM6NSq3jihEC80O8odPo1v4iXF4MTYnLYH3rP3xSU/I1HYwL9ri95iIrv3g1L Klogkomy VXPEAP89n3RFf4Zc6soEz8ruovynHB5pOsjUxan8OsjlVV2oWyRlBWLQMeg0eymQJSByh8sk7IAclivWWn5GRAU7GyeySgG7gZ/6XjHkAzzEMCexvPq7cd95bg9pHW4O9sKKfeunAFofVLwL6EE7VoRaHq69qLzgHPVP90c08HhNOzu9c/R2qcxCFJ2JV1MNhmNl1vFcLfCv+C0/yyC0iQKiukWtxc3PaNn1Gsru4nQVoDRMG1Tv4BKsrNgtE/OtvzOy8EvW4rlpR2mW+Bp/HFKc/0PbdSrADJ+OxXTFZm6UfB9LGfn6GPPZIU+8WxruoG/aIcEUjYFaNQkJT7x8Yu3U5mKJjQx39TYjqkW9idZDGO18/TpJnOLJQwNpnX8ZZttngQrR7o4oD3p5bIVBvKMe/iFBlgnIvo6W0CrRSEBVWMCw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jul 4, 2023 at 5:37=E2=80=AFPM Florent Revest = wrote: > > Defining a prctl flag as an int is a footgun because on a 64 bit machine > and with a variadic implementation of prctl (like in musl and glibc), > when used directly as a prctl argument, it can get casted to long with > garbage upper bits which would result in unexpected behaviors. > > This patch changes the constant to an unsigned long to eliminate that > possibilities. This does not break UAPI. > > Fixes: b507808ebce2 ("mm: implement memory-deny-write-execute as a prctl"= ) > Cc: linux-stable@vger.kernel.org Oops, this was supposed to be stable@vger.kernel.org... I'll fix that tag as part of v4.