From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE44C77B7A for ; Fri, 26 May 2023 19:05:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0F4D900004; Fri, 26 May 2023 15:05:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BBFC6900002; Fri, 26 May 2023 15:05:05 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A870F900004; Fri, 26 May 2023 15:05:05 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 94B52900002 for ; Fri, 26 May 2023 15:05:05 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6BF7F120F22 for ; Fri, 26 May 2023 19:05:05 +0000 (UTC) X-FDA: 80833333770.10.2F0B9AF Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by imf09.hostedemail.com (Postfix) with ESMTP id 7DDC1140019 for ; Fri, 26 May 2023 19:05:03 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=AVVFpfyu; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of revest@chromium.org designates 209.85.210.175 as permitted sender) smtp.mailfrom=revest@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1685127903; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0SAeQ2xMzsERoeM9PeVs0BB2mFGDfR2b9upLxc7DKkI=; b=q2A5NY1Fuf9RcMEAjaV7OubUSwMT30w6gR9M2V0Z2ghwXdqZ01MuktDv4TFQbKDhU/EhhE 9I++Z3eII0j1tVHVXSevS6r8X2o78ZdiG/ZMEk+ItNkVxGPGKeRoYGtikhHXHL/yZjK16Q ZgeYLpV9FEnW6VFaoz/y4pU4vO+Y9Z8= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=AVVFpfyu; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf09.hostedemail.com: domain of revest@chromium.org designates 209.85.210.175 as permitted sender) smtp.mailfrom=revest@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1685127903; a=rsa-sha256; cv=none; b=Ak8iVuTrqWt2BeFosEp7MQ0NQPUeUS8EOs7VZOQV9x2UxZMw2dhij6Z0C19+tMFdMHKM24 s4ElRWo6M8IYmXvUGfXz8CXCCbgXwETPMSxwrbBUroAHjG8kQ8qQDuuOR1HI5QEupPdpsA MumKBRNA/oF7K+jHPgcHQAvWhaBm33k= Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-64d3491609fso1014278b3a.3 for ; Fri, 26 May 2023 12:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1685127902; x=1687719902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=0SAeQ2xMzsERoeM9PeVs0BB2mFGDfR2b9upLxc7DKkI=; b=AVVFpfyumrAcUAFk2l9Ratbv9bsaw11PAYDGo6T3IZvy3cYQrAwoQT01W1qnrApGOK oABFsf7K+o87TdmzTYPQgTYedlOWmW3p2s+2H+2XuKTFD9MUK0v6UxwH/z7PcuqMjNeO Mi+g8XRtj05iJjOqgqN+fHct+fTVCbzw17Bso= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685127902; x=1687719902; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0SAeQ2xMzsERoeM9PeVs0BB2mFGDfR2b9upLxc7DKkI=; b=kksJ7zRERy2+twdNF7asQcvIUF5lvX5lxckusqrdKr29GBTn+dTrvoElMNrQoneYyw s+qEXFz4nD//11XJlNJ+aVzWrTUxC4DHDAfx3HNSNBwMsK+CK+EVgCxLdoC+zK2OJTnD aVdd9VyKD+z56jrGCKoe0vHnO6rnOZNMgAwgdxbfF68aEZC72EFByAwN0I0YLNU1O6yD +HSL/42vdHN9/oZ+uUTpHd0XN4MucDxsl0Y8pRU9TG83jRAnA1jeNK3KKMVnB4lr6aG1 v/2I6XHXt0S8GExW2sYRMJjO0iVR2KYrrfK1Ct+dQdxmPpTvZc7ToAjAO8BaPDxJySkI CKIQ== X-Gm-Message-State: AC+VfDyvaySFQAz4tJfVM/3rQ+wHhJOPbiiVR4aKfX7Iv94cNgO/TZ9V zkd7C+sbivifxoWOUNno1aEOcAy3mOAF7MDaFzj8+w== X-Google-Smtp-Source: ACHHUZ7hETaDyIP/AquuzMzsvZqXmXkcXAMHkRrdZ9WMX6jPPnI13s0UvIqhbe5ejE8JxL34iakcftJhPiaZy/8pZoo= X-Received: by 2002:a05:6a20:938e:b0:104:d82a:63c5 with SMTP id x14-20020a056a20938e00b00104d82a63c5mr302697pzh.53.1685127902268; Fri, 26 May 2023 12:05:02 -0700 (PDT) MIME-Version: 1.0 References: <20230517150321.2890206-1-revest@chromium.org> <20230517150321.2890206-4-revest@chromium.org> <884d131bbc28ebfa0b729176e6415269@ispras.ru> <3c2e210b75bd56909322e8a3e5086d91@ispras.ru> <7c572622c0d8e283fc880fe3f4ffac27@ispras.ru> In-Reply-To: From: Florent Revest Date: Fri, 26 May 2023 21:04:51 +0200 Message-ID: Subject: Re: [PATCH v2 3/5] mm: Make PR_MDWE_REFUSE_EXEC_GAIN an unsigned long To: David Hildenbrand Cc: Alexey Izbyshev , linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, peterx@redhat.com, broonie@kernel.org, szabolcs.nagy@arm.com, kpsingh@kernel.org, gthelen@google.com, toiwoton@gmail.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Stat-Signature: gxnjwa47cy53ifszxbj71jpce644b7h4 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7DDC1140019 X-HE-Tag: 1685127903-978272 X-HE-Meta: U2FsdGVkX1+7xjoCAwOlBgWBTmtmPCZ25M6F1UJMUDjk8MulsasNxH91BaTZ5lYP7sXkDRe+H62ZBIrX48XjrjalJhBaDDj/rpX7Ft19uONoAYj6yC8BT59Bg5qj57pUi1r+A0Db9DVAEirRJg0LrX4NEUWylwT4RYyleUxf2Nl7IZ/AiuLlUwEXkQ0FHrO9FE0zWhJMMU0eowiR7kqdDnvZBXAiz1Ag2VTaXM7LxBSKjWA9A9HMU57orNcRHPkDOeC/3dd1Oct/EHUshkCSFB9wT49zEyCU0Bw5OFuQteN7o9Dsn6qtxRYhF/vroMCQL9kOcGgBZvhrSJXApRYTW5CnngN85wptRPJ06B4rnpAZyAfc/d87U2CSvmHWeDVZ3nxZHKCkg8lkzT0gXR5f2l+55KhlkLNsYYd8obA/T2OPNVMa3xOWKiC/84rKqaDalynHM2GakiZ5k0Kang/tkOIKp1kQxbpy7Yvg7i5u6MZq0ENTKMrNltn9vjSFcRAYGf07zMXARfUm8tI8sbfUuUsYA/OHU3C6yVB9UQzOmKHw+9EdwZUVE/HXgx4PyN4n1RDPS0RqUXOB0CXUjpKUUcHWZvkudBCTMMIwbhrThmRINMSAhx+0VXs3WNIRDFPzBz89wBtGwUj7UrCm5Cc4YHlGUPepwh0kJiKUva61Dt+H/uPGjs2x/GX7QCL5ysYWH81UzW1BhaROKKTz+QqjU7U/9DeOkvSYW1VhwsKiDWCJOVhxH25P3ece23YrVdER0ZI5wnrQfBv8XWgjJJOAFqHQPJIjkWgA7cqoXpEW/HGjnX8b2ot/OD74M82Kbudv72FBywoTuJwthX+VEn/A8BY9M7cVCo2w7aUAgTuqovJoOl8r0UR4ODmbVZ5Pm8YP1ME2ivEmTWQF6AJvUJvyZ6U0RbEkuWkGAyoQAzma8dSoWM3AWwLGJIetZlzvvi3QZY4+qc4Xh+AAZ1gzWjn 4JhLk0es UIQoE2ivEkeKAHzqIVjSQYaz6ubKug9MrfWOV9HXoP+AIVlyjCpPE4sOMC/tl5E9ibkMb1ScgVK00B7SOt+XWz9xVv3TGoaapZq/ebftNWsuaRQERApfWioAvUyQsTdsTRt+82owaOw2Scn1fpB6tqG3RLPOa/8Ed6aTrOO5sewcPA/62qKeQPYSPtGnTibuh0ycPASAF2C6cwI3+d5vScPIHLPwWC7ApvKLZYSY5jnzJ7D4gHq87RYjIY5nRM0eCKHKUxJmiKM+ZMFTJ7cnOaU3P0snD0NrN5bo9Qvx3L6jQWXU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 23, 2023 at 4:10=E2=80=AFPM David Hildenbrand wrote: > > >> I'm easily confused by such (va_args) things, so sorry for the dummy > >> questions. > > > > This stuff *is* confusing, and note that Linux man pages don't even tel= l > > that prctl() is actually declared as a variadic function (and for > > ptrace() this is mentioned only in the notes, but not in its signature)= . > > Agreed, that's easy to miss (and probably many people missed it). > > > Anyhow, for this patch as is (although it feels like drops in the ocean > after our discussion) > > Reviewed-by: David Hildenbrand Thanks everyone for the review and the exchange ! :)