From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9E7FC7EE21 for ; Thu, 4 May 2023 17:13:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 451D5900002; Thu, 4 May 2023 13:13:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 401E96B0081; Thu, 4 May 2023 13:13:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F0D5900002; Thu, 4 May 2023 13:13:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by kanga.kvack.org (Postfix) with ESMTP id 04D756B0080 for ; Thu, 4 May 2023 13:13:16 -0400 (EDT) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1a5197f00e9so5485485ad.1 for ; Thu, 04 May 2023 10:13:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1683220395; x=1685812395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eZZBXQcPWAT9VDLt86aSAOWK05En/ty3UkgMboGhsYM=; b=Y6RrftnbHlFXWZfdktclhOS3xsNtKMCtPqaw6Bz0iS1KQSQ5IsL7JDVum1rdeO7iXS CJiazY/eAQH3lVi1WNp+q3fc9HrISL9mLcI4rULQZONA4r3tAmkcOGsk0U9vi+DxTi4B ckewujMTJyGglHEzQDx0Rx9DjsyR1ysHjgfxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683220395; x=1685812395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eZZBXQcPWAT9VDLt86aSAOWK05En/ty3UkgMboGhsYM=; b=E+5Tw5VE7RldFNT9EW9nz+M0bRMch27fj48LnE5dTHqFeWVnOLu0a+gbJoMRd+xOdk 9QwTAQuu/rhcUuHORqWMFZnjp1Xamo+Q4AGjVdod9Mg6xRuytPgZRqVJ3ovl37/IFRB6 yAlkzMMAjKh/OraX4NYzmvkS5DfwDTlHIRjNtuWl3ruvHYMy8mIU/TVNy5w0aRTlT/W8 TiuT5GYDEbTlTARrciuIahz/Qml5nuVg9m1vvAcoyVROQGInExww30v3cbpWOZlhNFsQ 5vSWFE2k/ih4TgstRIDY2RZfNA07pzl9gTw1xmJ4vJPnqTV3QU+Tv+ztHH1hVs86QEdD rJMw== X-Gm-Message-State: AC+VfDyGfkAVYC/e4vAajtkSvMeWzBDJGlgA3eOX1wxJQrsv6uSftxsr nJpfNnOwuGPMzHw6o3Whe2YLHx2QzHWREi1MeGiwgA== X-Google-Smtp-Source: ACHHUZ7Ca2tNfQ+7SUqYOkauIBnweRX6s9q7AJxcxYU16KAxS+pX0Akt30c+9l9/3CqaXjOE2xdxpXWanD3up6AcG7w= X-Received: by 2002:a17:903:24e:b0:1a6:37a6:f41a with SMTP id j14-20020a170903024e00b001a637a6f41amr4858676plh.45.1683220395059; Thu, 04 May 2023 10:13:15 -0700 (PDT) MIME-Version: 1.0 References: <20230504170942.822147-1-revest@chromium.org> <20230504170942.822147-3-revest@chromium.org> In-Reply-To: <20230504170942.822147-3-revest@chromium.org> From: Florent Revest Date: Thu, 4 May 2023 19:13:04 +0200 Message-ID: Subject: Re: [PATCH 2/4] kselftest: vm: Fix mdwe's mmap_FIXED test case To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: akpm@linux-foundation.org, catalin.marinas@arm.com, anshuman.khandual@arm.com, joey.gouly@arm.com, mhocko@suse.com, keescook@chromium.org, david@redhat.com, peterx@redhat.com, izbyshev@ispras.ru, nd@arm.com, broonie@kernel.org, szabolcs.nagy@arm.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 4, 2023 at 7:10=E2=80=AFPM Florent Revest = wrote: > > I checked with the original author, the mmap_FIXED test case wasn't > properly tested and fails. Currently, it maps two consecutive (non > overlapping) pages and expects the second mapping to be denied by MDWE > but these two pages have nothing to do with each other so MDWE is > actually out of the picture here. > > What the test actually intended to do was to remap a virtual address > using MAP_FIXED. However, this operation unmaps the existing mapping and > creates a new one so the va is backed by a new page and MDWE is again > out of the picture, all remappings should succeed. > > This patch keeps the test case to make it clear that this situation is > expected to work. > > Signed-off-by: Florent Revest Ah, snap, I hit send to fast and forgot to add: Fixes: 4cf1fe34fd18 ("kselftest: vm: add tests for memory-deny-write-execut= e") I will do it in the next iteration (surely there'll be other things to fix... :))